Gary Pendergast
9528294613
Unit Tests: The `test_set_allowed_incompatible_sql_mode()` test tries to set the `NO_ZERO_DATE` sql mode, which was removed in MySQL 5.7. This causes the test to incorrectly fail when run against MySQL 5.7.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@30704 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 05:11:49 +00:00
Drew Jaynes (DrewAPicture)
18f101b4bf
Using let's properly in inline comments lets us move on to more pressing matters of inline documentation.
...
Props trepmal.
Fixes #30570 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30703 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 04:42:17 +00:00
John Blackbourn
5cda7d6aed
Update the tests for `get_metadata()` to reflect the revert in r30701.
...
See #15030
git-svn-id: https://develop.svn.wordpress.org/trunk@30702 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 03:43:17 +00:00
John Blackbourn
294b608879
Revert r30115 which was a breaking change for code which interacts with the return value of `get_metadata()` when no meta key is specified.
...
See #15030
git-svn-id: https://develop.svn.wordpress.org/trunk@30701 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 03:34:13 +00:00
John Blackbourn
b510780a53
Correct the width of the background vignette in the plugin info modal.
...
Fixes #28229
git-svn-id: https://develop.svn.wordpress.org/trunk@30700 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 03:19:00 +00:00
Gary Pendergast
34f8e4d433
WPDB: When looking up the character set for a table or column, make sure we send the table name to MySQL in the correct case, as MySQL can be configured with case sensitive table names.
...
Fixes #30538 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30699 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 02:59:36 +00:00
Helen Hou-Sandi
5539cf7511
Don't over-target buttons in the publish meta box.
...
This selector caused breakage for any custom buttons added.
props ericlewis.
fixes #30035 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30698 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 02:34:32 +00:00
John Blackbourn
16ec77cd70
Prevent the deletion of a theme while it has an active child theme.
...
Fixes #29580
Props karpstrucking, jesin
git-svn-id: https://develop.svn.wordpress.org/trunk@30697 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 02:20:14 +00:00
John Blackbourn
0216b01a69
Ensure the theme and plugin update checks are always in sync with the current theme and plugin versions before fetching cached update data. This change only triggers a request to the update API when necessary.
...
Fixes #13071
Props bswatson
git-svn-id: https://develop.svn.wordpress.org/trunk@30696 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 01:51:10 +00:00
Drew Jaynes (DrewAPicture)
205a43ed05
Correctly capitalize JavaScript throughout core docs.
...
Fixes #30569 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30695 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 00:30:59 +00:00
Andrew Ozz
4eb3c5960f
TinyMCE: update the wpView toolbar to look the same as the new image toolbar.
...
Fixes #30561 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30694 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 00:25:15 +00:00
Andrew Ozz
eb2f29f1c3
Editor DFW v2: do not fade out on using keyboard shortcuts in TinyMCE (Alt+Shift+letter).
...
Fixes #30539 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30693 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 22:52:46 +00:00
Ian Stewart
4a3bceaea9
Twenty Fifteen: correct stylesheet dependencies.
...
Props ocean90, fixes #30532 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30692 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 19:40:12 +00:00
Drew Jaynes (DrewAPicture)
2f64100369
Improve inline documentation for four methods in `WP_Widget`: `get_field_id()`, `display_callback()`, `update_callback()`, and `form_callback()`.
...
Props jazzs3quence for the initial patch.
See #30315 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30691 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 19:34:25 +00:00
Ian Stewart
e8ac9b21df
Twenty Fifteen: broader selection of avatars that should catch any plugins adding avatars that use the avatar class.
...
Props iamtakashi, fixes #30541 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30690 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 19:33:19 +00:00
Ian Stewart
4598e80675
Twenty Fifteen: correct list indentation inside blockquotes.
...
Props iamtakashi, fixes #30543 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30689 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 19:30:56 +00:00
Boone Gorges
50386cafd5
Use `assertEqualSetsWithIndex()` as appropriate in `get_terms()` tests.
...
See #30522 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30688 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 14:24:43 +00:00
Gary Pendergast
897b1645bb
Unit Tests: The `assertEqualSets()` helper was returning true for some sets that were not equal. `assertEqualSets()` now behaves correctly, and the new `assertEqualSetsWithIndex()` helper also checks that the array indexes are the same.
...
Fixes #30522 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30687 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 05:01:29 +00:00
John Blackbourn
fe4b0c7f14
Remove the sortable functionality from the selection editing toolbar at the bottom of the media manager.
...
Fixes #29934
See #24352
Props jessepollak
git-svn-id: https://develop.svn.wordpress.org/trunk@30686 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 04:17:53 +00:00
John Blackbourn
d8dd2e4a77
Clarify the text for the 'Edit Selection' link when multiple media items are selected in the media manager.
...
Props adamsilverstein
See #24325
git-svn-id: https://develop.svn.wordpress.org/trunk@30685 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 04:14:06 +00:00
John Blackbourn
cedecf8033
Allow brackets in a URL when it's sanitised for a redirect. Brackets are valid in query parameters.
...
Fixes #30308
Props voldemortensen
git-svn-id: https://develop.svn.wordpress.org/trunk@30684 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 03:20:13 +00:00
John Blackbourn
b57c4ae165
Allow square brackets in a URL when it's sanitised for a redirect. Square brackets are valid in query parameters and IPv6 addresses.
...
Fixes #17052
Props voldemortensen
git-svn-id: https://develop.svn.wordpress.org/trunk@30683 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 03:15:24 +00:00
Scott Taylor
095bfabfa9
Improve various `@param` docs.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30682 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 02:16:36 +00:00
Scott Taylor
4d46475b3d
Improve various `@param` docs for `src/wp-includes/*`.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30681 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 01:33:34 +00:00
Scott Taylor
8a4fa5662b
Improve various `@param` docs for `src/wp-admin/*`.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30680 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:59:43 +00:00
Scott Taylor
c0045bda84
Improve various `@param` docs for List Tables.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30679 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:32:19 +00:00
Scott Taylor
7a7bb0d6b4
Improve various `@param` docs for `src/wp-admin/includes/class-wp-filesystem-*.php`.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30678 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:12:05 +00:00
Gary Pendergast
6eebbc5750
WPDB: Before fetching results, make sure we have a valid result resource to fetch them from.
...
Fixes #27982 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30677 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:02:55 +00:00
Scott Taylor
5817aa262d
Improve various `@param` docs for `src/wp-includes/class-wp-customize*.php`.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30676 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 23:32:31 +00:00
Andrew Ozz
45f4403dd0
TinyMCE: update to 4.1.7, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt . Fixes #30560 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@30675 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 23:27:23 +00:00
Scott Taylor
0632a3de68
Improve various `@param` docs.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30674 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 23:23:37 +00:00
Scott Taylor
ee388b9852
Improve various `@param` docs.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30673 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 22:55:08 +00:00
Scott Taylor
6bb2a4ce36
Improve the `@param` docs for `src/includes/theme.php` and `src/includes/update.php`.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30672 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 22:43:27 +00:00
Scott Taylor
4de850c8ff
Improve the `@param` docs for `src/wp-includes/post*.php`.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30671 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 22:37:00 +00:00
Andrew Ozz
3c558b7436
TinyMCE: update translatable strings, see #30560 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@30670 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 22:26:56 +00:00
Scott Taylor
43885a303e
Improve the `@param` docs for `src/includes/rewrite.php`.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30669 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 22:24:49 +00:00
Scott Taylor
3008fe1060
Improve the `@param` docs for `src/wp-admin/includes/plugin.php`.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30668 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 22:22:33 +00:00
Scott Taylor
4bf6ad11fb
Improve the `@param` docs for `src/wp-includes/pluggable*`.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30667 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 22:18:33 +00:00
Scott Taylor
c7ce0a4d55
Improve the `@param` docs for `src/wp-includes/user.php`.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30666 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 22:10:12 +00:00
Scott Taylor
9e6096c89a
Improve the `@param` docs for `src/wp-includes/widgets.php`.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30665 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 22:04:23 +00:00
Scott Taylor
35358b0e26
Improve the `@param` docs for `src/wp-includes/wp-db.php`.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30664 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 21:54:08 +00:00
Scott Taylor
2bf092065a
Add missing `@param`s to `src/wp-includes/pomo` files.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30663 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 21:40:53 +00:00
Scott Taylor
1da6be4868
Improve the `@param` docs for `trackback_response()` and `validate_another_blog_signup()`.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30662 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 21:22:07 +00:00
Scott Taylor
9c95e2bb81
Use `sanitize_mime_type()` instead of `urlencode()` when string-building `<option>` values in `->get_views()` for media list tables.
...
`urlencode()` was introduced in [28553] via _duck and yours truly.
Got weirder after [29625].
Props birgire.
Fixes #30123 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30661 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 20:22:23 +00:00
Scott Taylor
35708f61f8
Use `round()` instead of `floor()` when resizing image dimensions.
...
Updates unit tests.
Props SergeyBiryukov, kitchin.
Fixes #18532 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30660 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 19:53:18 +00:00
Scott Taylor
dad44082a7
The menu items for `users.php` and `profile.php` that require the `promote_users` cap should be wrapped in an `is_multisite()` conditional a la `user-new.php`.
...
Props SergeyBiryukov.
Fixes #30526 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30659 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 19:17:44 +00:00
Scott Taylor
653485e87f
`wp_upload_dir()` has a (little-known?) side effect: if you call it, it will attempt to create an uploads directory for the current month. As such, `tearDown()` and cleanup routines have to be in sync with this behavior when deleting bogus directories used in unit tests.
...
Examples: if you clean up directories in a test, or a test fails before the directories are cleaned, or a test fails before the `'upload_path'` option is reset, the next call to `wp_upload_dir()` will recreate the directories you just tried to delete.
These changes ensure that `src/foo` and `/tmp/wp-unit-test` directories are deleted immediately after `wp_upload_dir()` is fired in the tests.
Fixes #30513 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30658 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 19:05:52 +00:00
Dominik Schilling (ocean90)
2f3fed5a52
Make notices added in [30459] less ugly.
...
see #25569 , #25571 , [30505].
git-svn-id: https://develop.svn.wordpress.org/trunk@30657 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 12:20:04 +00:00
Drew Jaynes (DrewAPicture)
e587324180
Docs Formatting: Backtick-escape inline code for all remaining dynamic hook docs in wp-includes/*.
...
Affects DocBlocks for the following hooks:
* `auth_post_meta_{$meta_key}`
* `term_links-$taxonomy`
* `customize_render_control_ . $this->id`
* `customize_render_panel_{$this->id}`
* `customize_render_section_{$this->id}`
* `customize_preview_{$this->id}`
* `customize_save_ . $this->id_data[ 'base' ]`
* `customize_update_ . $this->type`
* `customize_value_ . $this->id_data[ 'base' ]`
* `customize_sanitize_js_{$this->id}`
* `comment_form_field_{$name}`
* `comment_{$old_status}_to_{$new_status}`
* `comment_{$new_status}_{$comment->comment_type}`
* `extra_{$context}_headers`
* `get_template_part_{$slug}`
* `get_the_generator_{$type}`
* `get_{$adjacent}_post_join`
* `get_{$adjacent}_post_where`
* `get_{$adjacent}_post_sort`
* `{$adjacent}_post_rel_link`
* `{$adjacent}_post_link`
* `{$adjacent}_image_link`
* `blog_option_{$option}`
* `$permastructname . _rewrite_rules`
* `{$type}_template`
* `theme_mod_{$name}`
* `pre_set_theme_mod_$name`
* `current_theme_supports-{$feature}`
* `get_user_option_{$option}`
* `edit_user_{$field}`
* `pre_user_{$field}`
* `user_{$field}`
See #30552 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30656 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 12:09:56 +00:00
Drew Jaynes (DrewAPicture)
e8bc58459e
Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-includes/meta.php.
...
Affects DocBlocks for the following hooks:
* `add_{$meta_type}_metadata`
* `add_{$meta_type}_meta`
* `added_{$meta_type}_meta`
* `update_{$meta_type}_metadata`
* `update_{$meta_type}_meta`
* `updated_{$meta_type}_meta`
* `delete_{$meta_type}_metadata`
* `delete_{$meta_type}_meta`
* `deleted_{$meta_type}_meta`
* `get_{$meta_type}_metadata`
* `delete_{$meta_type}meta`
* `deleted_{$meta_type}meta`
* `sanitize_{$meta_type}_meta_{$meta_key}`
See #30552 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30655 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 12:02:44 +00:00