Commit Graph

30932 Commits

Author SHA1 Message Date
Helen Hou-Sandi
3b1e1f0376 List tables: Yet more primary column fallbacks.
Some custom list tables override enough methods for the column definition fallback to never kick in, so let's ensure that toggling columns only applies when a primary column is defined in some way. We also need to show a toggle button when we can when there are no row actions.

props Chouby, obenland, ocean90.
fixes #33313.


git-svn-id: https://develop.svn.wordpress.org/trunk@33623 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 15:37:03 +00:00
Konstantin Obenland
eea1678cd3 Editor: Exclude shift from modifier keys when handling spacebar shortcuts.
Patterns that activate on enter are still canceled with any modifier active.

Props azaozz.
Fixes #33382.



git-svn-id: https://develop.svn.wordpress.org/trunk@33622 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 14:50:42 +00:00
Boone Gorges
e33ff607e6 Don't run term-splitting routine on new installations.
Props pento.
Fixes #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33621 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 14:28:03 +00:00
Konstantin Obenland
e7a203cdf2 Passwords: Restore second parameter for wp_new_user_notification().
After [33023] users would always be notified, this restores previous behavior.

Props markjaquith, ocean90.
Fixes #33358.



git-svn-id: https://develop.svn.wordpress.org/trunk@33620 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 14:24:43 +00:00
Boone Gorges
9c70cea98f Don't suspend cache invalidation when running term splitting batch routine.
`wp_suspend_cache_invalidation()` was originally added to increase performance,
but the switch to batch processing in [33615] mitigates serious performance
concerns.

As a precaution against timeouts, the batch size has been reduced from 20 to 10.

Props Chouby.
See #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33619 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-15 19:24:42 +00:00
Helen Hou-Sandi
7abf08a52c Menu customizer: Ensure the search results section is full height.
fixes #33375.


git-svn-id: https://develop.svn.wordpress.org/trunk@33618 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-14 21:31:23 +00:00
Weston Ruter
a4bbc4454c Customize: Fix keyboard accessibility for toggling screen options and contextual help.
Also fix layout of search results in mobile.

Props valendesigns, afercia, adamsilverstein.
Fixes #33184.


git-svn-id: https://develop.svn.wordpress.org/trunk@33617 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-14 21:22:57 +00:00
Boone Gorges
6d5da327f5 Remove unit test related to pre-4.1 term splitting during wp_update_term().
After [33615], `wp_update_term()` no longer checks `$wp_db_version` before
attempting a split. This is because pre-4.1 versions of WordPress must be
allowed to update to 4.3+.

See #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33616 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-14 04:15:34 +00:00
Boone Gorges
f18355e66e Term splitting routine should be run in a separate process, triggered via wp-cron.
[32814] introduced a routine to split shared terms, which was run during the
regular WP database upgrade. This turned out to be problematic because plugins
are not loaded during the db upgrade (due to `WP_INSTALLING`), with the result
that plugins were not able to hook into the 'split_shared_term' action during
the bulk split. We work around this limitation by moving the term splitting
routine to a separate process, triggered by a wp-cron hook.

Props boonebgorges, Chouby, peterwilsoncc, pento, dd32.
Fixes #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33615 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-14 03:58:41 +00:00
Dominik Schilling (ocean90)
23eaa36145 Capabilities: Fall back to the edit_posts capability for orphaned comments.
Also avoid PHP notices because of orphaned comments in the comments list table.
Includes unit test.

props pento, dd32.
fixes #33154.

git-svn-id: https://develop.svn.wordpress.org/trunk@33614 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-13 22:30:26 +00:00
Konstantin Obenland
ce531d8723 About: Third pass at 4.3 about page:
* Improves some of the feature descriptions.
* Uses .org CDN for images and feature video.
* Fixes an overzealous Jetpack style that adds unwanted padding.
* Uses more specific `WP_List_Table` header.
* Adds 4.3 tagline to freedoms and credit page.
* Adds infrastructure for 4.3 about video. Only the ID needs to be updated.
* Makes all strings translatable.

Props siobhan, adamsilverstein, melchoyce, ocean90, markjaquith, helen, obenland.
Fixes #32929.



git-svn-id: https://develop.svn.wordpress.org/trunk@33613 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-13 22:10:06 +00:00
Scott Taylor
df480edb24 After [33325], supply a missing post_type in ->mw_editPost().
Add unit test.

Props ocean90.
Fixes #20662.


git-svn-id: https://develop.svn.wordpress.org/trunk@33612 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-13 15:27:57 +00:00
Boone Gorges
ee67bd08f9 When splitting a shared 'nav_menu' term, ensure that nav items and theme locations are retained.
Props boonebgorges, dd32.
Fixes #33187.

git-svn-id: https://develop.svn.wordpress.org/trunk@33611 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-12 14:06:21 +00:00
Weston Ruter
80bc70fc4b Customize: Fix layout issues in panels and sections when resizing and autofocusing.
Also reverts [33157] which is no longer needed.

Props valendesigns, mattwiebe, westonruter, ocean90.
Fixes #33220.


git-svn-id: https://develop.svn.wordpress.org/trunk@33610 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-11 23:55:40 +00:00
Andrew Ozz
e509984261 Fix paste typos in upgrade.php.
Props tellyworth. Fixes #33206.

git-svn-id: https://develop.svn.wordpress.org/trunk@33609 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-11 23:43:29 +00:00
Konstantin Obenland
14b7ed65bb After [32948]: Account for the use of paginate_links() with table navigation markup.
Props afercia.
Fixes #32253.



git-svn-id: https://develop.svn.wordpress.org/trunk@33608 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-11 20:42:18 +00:00
Konstantin Obenland
018cd0819e Tests: Update Site Icon tests to account for changes in [33605].
H/t jorbin.

Fixes #33325.



git-svn-id: https://develop.svn.wordpress.org/trunk@33607 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-11 18:41:01 +00:00
Konstantin Obenland
8f37374c3d Site Icon: Improvements to Site Icon API.
* Only call `get_blog_option()` when there is a blog id and we're in Mulitsite. If there is no blog id the request is for the current blog.
* Check return value of `wp_get_attachment_image_src()` before getting the URL since it could be `false`.
* Use `{bool}` rather than `!!` to return a boolean value.

Props MikeHansenMe, obenland.
Fixes #33326.



git-svn-id: https://develop.svn.wordpress.org/trunk@33606 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-11 16:24:07 +00:00
Helen Hou-Sandi
b9dd879f42 Site icon: Rearrange function parameters to avoid frequently passing empty values.
props obenland.
fixes #33325.


git-svn-id: https://develop.svn.wordpress.org/trunk@33605 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-10 20:14:35 +00:00
Konstantin Obenland
a367a1b67b Customize: Limit styles for menu's reorder button to the nav_menu control.
This prevents it from bleeding into other controls, misaligning their buttons.
Selectors use a class now too, which is preferable over ids.

Fixes #33260.



git-svn-id: https://develop.svn.wordpress.org/trunk@33604 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-10 19:35:57 +00:00
Helen Hou-Sandi
19f9dd3b72 Network admin: Internationalize some existing strings that were missed in [33186].
Also adds the trailing slash to the `get_home_url()` calls.

props johnbillion.
fixes #33317.


git-svn-id: https://develop.svn.wordpress.org/trunk@33603 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-10 18:10:11 +00:00
Helen Hou-Sandi
0999b0182b Customizer: Rename WP_New_Menu_Customize_Control to WP_Customize_New_Menu_Control for consistency.
props DrewAPicture.
fixes #33324.


git-svn-id: https://develop.svn.wordpress.org/trunk@33602 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-10 18:06:01 +00:00
dd32
0c29101892 Function documentation: Fix a broken docbock introduced with [32642].
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@33601 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-10 10:49:02 +00:00
ocean90
239759914f Shortcodes: Trim whitespace after sanitizing the shortcode output.
props Ankit K Gupta, obenland, miqrogroove.
fixes #33259.

git-svn-id: https://develop.svn.wordpress.org/trunk@33600 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-09 20:48:02 +00:00
Dominik Schilling (ocean90)
3f7b1ca2ff Customizer: Remove obsolete .control-panel-back and .customize-overlay-close buttons.
props afercia, ocean90.
see #31336.
fixes #33229.

git-svn-id: https://develop.svn.wordpress.org/trunk@33599 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-09 18:59:34 +00:00
Dominik Schilling (ocean90)
6741897dd0 List tables: Adjust width of Quick Edit labels for longer translations.
props Clorith, SergeyBiryukov, ocean90.
fixes #33212.

git-svn-id: https://develop.svn.wordpress.org/trunk@33598 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-09 18:54:37 +00:00
Dion Hulse
7ef82c235a Upgrade: Skip the sitecategories table when it doesn't exist (Global Terms is disabled).
Props nofearinc, obenland, SergeyBiryukov, and pento.
Fixes #33206


git-svn-id: https://develop.svn.wordpress.org/trunk@33597 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-09 02:21:11 +00:00
Dominik Schilling (ocean90)
2d6c10b842 Customizer: Restore Shift + Clicking on widgets to open the widgets panel.
Includes an alternative for jQuery UI's `:focusable` selector because it has an ancestor visibility requirement, see https://github.com/jquery/jquery-ui/pull/1583.

props westonruter.
fixes #33258.

git-svn-id: https://develop.svn.wordpress.org/trunk@33596 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-08 09:36:55 +00:00
Konstantin Obenland
c03388bd9d Install: Adjust th padding to align with tds.
Props Ankit K Gupta for initial patch.
Fixes #33280.



git-svn-id: https://develop.svn.wordpress.org/trunk@33595 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-07 22:09:41 +00:00
Dion Hulse
7a35bff916 Fix do_shortcode('<[shortcode]') edge case.
Props miqrogroove.
Merges [33499] trunk.
See #33116.


git-svn-id: https://develop.svn.wordpress.org/trunk@33594 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-07 02:49:31 +00:00
John Blackbourn
1939742e32 Remove all existing internal feature pointers.
Fixes #33289
Props obenland, ocean90, SergeyBiryukov


git-svn-id: https://develop.svn.wordpress.org/trunk@33593 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-07 00:58:10 +00:00
Ella Iseulde Van Dorpe
994b1d9a5b TinyMCE: fix inline toolbar repositioning for inline editors
Fixes #33286.


git-svn-id: https://develop.svn.wordpress.org/trunk@33592 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-06 21:34:16 +00:00
Mark Jaquith
7e4a72b9bc Only use a bare URL when the link text field is used.
Fixes bug that would remove images on edit, in some circumstances.

fixes #33293
props azaozz

git-svn-id: https://develop.svn.wordpress.org/trunk@33591 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-06 20:57:31 +00:00
Mark Jaquith
3d15757198 Move media hooks out of admin-filters.php as sometimes editors are used on the front end.
fixes #33257
props wonderboymusic

git-svn-id: https://develop.svn.wordpress.org/trunk@33590 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-06 20:39:35 +00:00
Dominik Schilling (ocean90)
f29b25e104 Comments: Update help text for new comment bubbles.
props kraftbj.
fixes #33256.

git-svn-id: https://develop.svn.wordpress.org/trunk@33589 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-06 08:02:53 +00:00
Sergey Biryukov
1dcb93b541 wpLink: Make sure the link wrapper is the last element in the body, otherwise the inline editor toolbar may show up above the backdrop.
props azaozz.
fixes #33268.

git-svn-id: https://develop.svn.wordpress.org/trunk@33588 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-06 02:16:54 +00:00
Jeremy Felt
1872e759ea Multisite: Use single URL input when editing sites in a subdirectory configuration
In [32759], we adjusted `site-info.php` to display a single input for a site's full URL if the network was configured for subdomains. We also enforced path only editing for non-subdomain networks, which is a regression in expected behavior.

The full URL of a site can now be edited in both subdomain and subdirectory configurations.

Props @michaelryanmcneill.
Fixes #22383.


git-svn-id: https://develop.svn.wordpress.org/trunk@33586 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-05 03:33:53 +00:00
Weston Ruter
fb62349c77 Customizer: Restore default fallback_cb arg for wp_nav_menu() calls in customizer preview.
Props ocean90, westonruter.
Fixes #33218.


git-svn-id: https://develop.svn.wordpress.org/trunk@33585 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-04 21:56:57 +00:00
Ella Iseulde Van Dorpe
3d88983860 TinyMCE: wplink: fix WPLinkPreview for multiple editors
Fixes #33264.


git-svn-id: https://develop.svn.wordpress.org/trunk@33584 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-04 21:41:34 +00:00
Dominik Schilling (ocean90)
e8b5345004 WordPress 4.3-RC2-33572.
git-svn-id: https://develop.svn.wordpress.org/trunk@33572 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-04 11:47:49 +00:00
Dominik Schilling (ocean90)
7fc5d6e2a4 WordPress 4.3-RC2.
git-svn-id: https://develop.svn.wordpress.org/trunk@33571 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-04 11:43:07 +00:00
Dominik Schilling (ocean90)
9f3217c8eb Multisite mails: Initialize $current_user before accessing $current_user->user_login.
props Toro_Unit.
see #31217.
fixes #33254.

git-svn-id: https://develop.svn.wordpress.org/trunk@33569 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-04 11:38:52 +00:00
Ella Iseulde Van Dorpe
aaf15cdde8 TinyMCE: wptextpattern: trim whitespace
Props iseulde and azaozz.
Fixes #33246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33563 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-03 22:06:25 +00:00
Ella Iseulde Van Dorpe
e30bd2f439 JSHint for [33528]: remove logging
See #32688.


git-svn-id: https://develop.svn.wordpress.org/trunk@33562 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-03 21:57:04 +00:00
Dominik Schilling (ocean90)
9d8768f442 Comments: IDs are integers.
git-svn-id: https://develop.svn.wordpress.org/trunk@33555 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-03 21:37:26 +00:00
Dominik Schilling (ocean90)
ad74207fa7 Heartbeat: Ensure post locks are released.
git-svn-id: https://develop.svn.wordpress.org/trunk@33542 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-03 21:11:35 +00:00
Dominik Schilling (ocean90)
d834719f34 Nav menus: Adjust redundant titles in accessibility helpers.
git-svn-id: https://develop.svn.wordpress.org/trunk@33540 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-03 21:03:59 +00:00
Dominik Schilling (ocean90)
dd5471dab2 Customizer: Use hash_equals() for widgets.
git-svn-id: https://develop.svn.wordpress.org/trunk@33535 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-03 20:56:56 +00:00
Weston Ruter
7857be9cf0 Customizer: Add QUnit tests for menus.
Props adamsilverstein, westonruter, jorbin.
Fixes #32688.


git-svn-id: https://develop.svn.wordpress.org/trunk@33528 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-03 19:27:27 +00:00
Andrew Ozz
86e10358fd TinyMCE: fix initializing the editor on switching Text => Visual when the Text editor is loaded first.
Props stuartshields, peterwilsoncc, netweb, azaozz. Fixes #33192.

git-svn-id: https://develop.svn.wordpress.org/trunk@33527 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-02 20:00:56 +00:00