Commit Graph

37690 Commits

Author SHA1 Message Date
Gary Pendergast
5233a95355 Updates: Add the core_version_check_query_args filter.
This filter allows the data being sent for core update checks to be controlled for privacy concerns.

Props toscho, MattyRob, swissspidy, pento.
Fixes #16778.



git-svn-id: https://develop.svn.wordpress.org/trunk@41962 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-21 11:54:47 +00:00
Weston Ruter
dbfb9f0f0b Customize: Improve back-compat for wp.customize.Control subclasses that expect options.params to be present for direct manipulation before calling parent initialize method.
Fixes known incompatibility with Make theme.

Amends [41726].
See #30741.


git-svn-id: https://develop.svn.wordpress.org/trunk@41961 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-21 08:50:43 +00:00
Weston Ruter
931bcb0f7d Customize: Allow control subclasses to add to the deferred object before the base class initializes.
Update the `CodeEditorControl`'s `codemirror` deferred to be set before calling the parent class's `initialize` method. Since the `ready` method may be called directly by `initialize` it may be too late to add a new `Deferred` to the control's `deferred` property after calling the base control class's `initialize`.

Amends [41958].
See #41897.


git-svn-id: https://develop.svn.wordpress.org/trunk@41960 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-21 08:43:36 +00:00
Sergey Biryukov
1a8b08418b Docs: Document $wp_version global in wp_initial_constants().
Props mt8.biz.
Fixes #42259.

git-svn-id: https://develop.svn.wordpress.org/trunk@41959 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-20 22:03:59 +00:00
Weston Ruter
c8c16b9f70 Customize: Add codemirror deferred object to CodeEditorControl which is resolved when CodeMirror is initialized.
CodeMirror gets initialized once the control's containing section is expanded. The deferred will be rejected if user preference for syntax highlighting is disabled.
Also move jsdoc from `wp.customize.Control` to intended `wp.customize.Control#initialize()`.

See #41897, #12423.


git-svn-id: https://develop.svn.wordpress.org/trunk@41958 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-20 21:47:13 +00:00
Weston Ruter
f5534ec8d5 Code Editor: Improve ability to create Customizer CodeEditorControl instances in JS, lessening PHP dependencies.
Allow `CodeEditorControl` to be instantiated with a `editor_settings` param which is merged with `wp.codeEditor.defaultSettings`.

Also:

* Turn redundant "CSS Code" control label into screen reader text for Additional CSS.
* Remove `code-editor` as script dependency for `custom-html-widgets` since enqueueing is determined by `wp_enqueue_code_editor()`.
* Remove useless exporting of `code_type` param to JS in `WP_Customize_Code_Editor_Control`.
* Add `disabled` class to Custom HTML widget's Save button when linting errors are present.
* Remove redundant `span` inside CodeEditorControl's `label`.

See #41897, #12423, #41872.


git-svn-id: https://develop.svn.wordpress.org/trunk@41957 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-20 16:38:35 +00:00
Sergey Biryukov
01c7f2cf7d Customize: Use typographic quotation marks in the strings added in [41768].
Props audrasjb, tobifjellner.
Fixes #42290. See #40104.

git-svn-id: https://develop.svn.wordpress.org/trunk@41956 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-20 14:06:42 +00:00
Sergey Biryukov
771b56d944 Menus: Remove an extra space in the <ul> tag in Walker_Nav_Menu::start_lvl().
Fixes #42289.

git-svn-id: https://develop.svn.wordpress.org/trunk@41955 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-20 10:39:50 +00:00
Mel Choyce
8f08e79987 Customize Menus: Update capitalization of "next" to match case on the "Next" button.
Props hardeepasrani.
Fixes #42287.


git-svn-id: https://develop.svn.wordpress.org/trunk@41954 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-20 10:33:52 +00:00
Mel Choyce
0ff1f1b939 Customization Locking: Update error message to use existing strings.
Props ramiy.
See #42024.


git-svn-id: https://develop.svn.wordpress.org/trunk@41953 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-20 10:31:30 +00:00
Weston Ruter
620eb3052c Customize: Prevent using default template for a base control when it has content rendered on the server.
Also prevent invalid `type` attribute from being added to a `select` element.

See #30738.
Fixes #42286.


git-svn-id: https://develop.svn.wordpress.org/trunk@41952 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-20 03:29:30 +00:00
Weston Ruter
d204ba3c00 Widgets: Improve extensibility of the Gallery widget and of media widgets generally.
* Introduce a `widget_{$id_base}_instance_schema` filter for plugins to add new properties to a media widget's instance schema.
* Pass all of a gallery widget's instance props to the gallery media frame, not just the ones that core supports.

See #32417, #41914.
Fixes #42285.


git-svn-id: https://develop.svn.wordpress.org/trunk@41951 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 23:43:22 +00:00
Weston Ruter
8206a9d225 Customize: Prevent re-highlighting "Add Items" button after available nav menu items pane has already been opened.
Amends [41930].
Props bpayton.
See #42114.


git-svn-id: https://develop.svn.wordpress.org/trunk@41950 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 18:37:10 +00:00
Weston Ruter
4238b2895f Customize: Fix alignment of Customize, Activate, and Live Preview buttons appearing on the Themes admin screen.
Amends [41893].
Props Mahvash-Fatima.
See #42215.
Fixes #42275.


git-svn-id: https://develop.svn.wordpress.org/trunk@41949 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 18:09:16 +00:00
Weston Ruter
253c7f03cc Customize: Fix rendering issues in theme browsing when opening theme details or performing search in Safari.
Props sayedwp.
See #37661.
Fixes #42052.


git-svn-id: https://develop.svn.wordpress.org/trunk@41948 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 17:56:56 +00:00
Weston Ruter
d15347ae52 Customize: Prevent drawing attention to save button if status unchanged from publish; account for changes to status/date when alerting about unsaved changes.
Also fix malformed ESLint directive from [41933].

Amends [41932].
See #39896, #42211.


git-svn-id: https://develop.svn.wordpress.org/trunk@41947 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 17:41:05 +00:00
Gary Pendergast
b4ede0319c About page: Update the privacy policy dashes.
If one were to insert 1—3 dashes into a sentence - on purpose - they should use the correct da–
sh.

See #40794.



git-svn-id: https://develop.svn.wordpress.org/trunk@41946 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 15:35:47 +00:00
John Blackbourn
2364d616b9 Build/Test tools: Document the return value of WP_UnitTestCase::factory().
See #41017


git-svn-id: https://develop.svn.wordpress.org/trunk@41945 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 15:32:07 +00:00
Gary Pendergast
3507f4798f About page: Update the privacy policy language.
See #40794.



git-svn-id: https://develop.svn.wordpress.org/trunk@41944 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 15:25:54 +00:00
Mel Choyce
61c11a54d3 About Page: Commit initial strings for 4.9.
Props kristastevens, dd32, hlashbrooke.
See #42087.


git-svn-id: https://develop.svn.wordpress.org/trunk@41943 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 13:56:36 +00:00
Sergey Biryukov
083f2abada Docs: After [37329], update the documentation for register_widget() and unregister_widget().
Both functions can accept a `WP_Widget` instance object instead of a `WP_Widget` subclass name, same as `WP_Widget_Factory::register()` and `::unregister()`.

Props behzod.
Fixes #42270.

git-svn-id: https://develop.svn.wordpress.org/trunk@41942 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 13:50:56 +00:00
Sergey Biryukov
e18b4c894b Menus: Pass $recent_args parameter to nav_menu_items_{$post_type_name}_recent filter.
Props welcher, eclev91.
Fixes #39849.

git-svn-id: https://develop.svn.wordpress.org/trunk@41941 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 13:04:28 +00:00
Sergey Biryukov
731d7643d2 Docs: Reference WP_Comment_Query::__construct() as the source of information on accepted arguments in get_comments() and get_approved_comments().
See #41017.

git-svn-id: https://develop.svn.wordpress.org/trunk@41940 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 08:48:05 +00:00
Weston Ruter
ce0d7db409 Post WordPress 4.9 Beta 3 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@41939 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 05:07:23 +00:00
Weston Ruter
ea5fb388da WordPress 4.9 Beta 3.
git-svn-id: https://develop.svn.wordpress.org/trunk@41938 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 04:42:28 +00:00
Joe McGill
2cce6bb55a Customizer: Improve handling of crops in the media library.
This is a follow up on r41732, implementing the following improvements:

* Attachment parent info is now stored in attachment meta rather than a 
separate post meta key.
* Attachments created from contextual crops (e.g. header, logos, etc.) are
filtered out of the media library using a new `_filterContext` method in
`wp.media.controller.Library`.

Props joemcgill, westonruter.
See #21819.


git-svn-id: https://develop.svn.wordpress.org/trunk@41937 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 04:17:31 +00:00
Weston Ruter
aac833887e Customize: Consistently use input_attrs as control param key in JS instead of inputAttrs.
See #30738, #41897.


git-svn-id: https://develop.svn.wordpress.org/trunk@41936 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 03:24:20 +00:00
Weston Ruter
1c04006909 Customize: Move control's fallback selection of default content template to renderContent method to align with sections and panels.
* Only use default control content template when a more specific template doesn't exist.
* Remove extraneous whitespace from being output in `WP_Customize_Control::render()` method.
* Move Custom Header template printing to `customize_controls_print_footer_scripts` action.

See #30738.


git-svn-id: https://develop.svn.wordpress.org/trunk@41935 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 03:03:19 +00:00
Sergey Biryukov
b1f20b6763 I18N: Unify permission error message in wp-admin/ms-delete-site.php.
Props ramiy.
Fixes #42268.

git-svn-id: https://develop.svn.wordpress.org/trunk@41934 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 00:47:15 +00:00
Weston Ruter
0421a2b0a4 Widgets: Harden logic for checking for valid media URLs.
* Update deprecated `isHostedVideo` method to always return `true` since all oEmbeds are now supported.
* Disable `scanImage` for non-image media widgets.
* Ensure embed URL field element is matched from current media frame instance due to bug where media frames are not destroyed upon closing.
* Update error message for invalid video URLs to ask user to check the URL for validity.

Props gk.loveweb, octalmage, westonruter.
See #42039, #40935.
Fixes #41052.


git-svn-id: https://develop.svn.wordpress.org/trunk@41933 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 00:06:25 +00:00
westonruter
285be53824 Customize: Draw attention to save button after collapsing the publish settings section when the changeset status or date had been changed.
Props bpayton, westonruter.
See #42114, #39896.
Fixes #42211.


git-svn-id: https://develop.svn.wordpress.org/trunk@41932 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 23:05:02 +00:00
Sergey Biryukov
3ce1938687 Dashboard: Add missing URL to "Help with testing" link in Gutenberg callout.
See #41316.

git-svn-id: https://develop.svn.wordpress.org/trunk@41931 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 22:40:42 +00:00
Weston Ruter
1c521e35c5 Customize: Draw attention to "Add Items" button after creating a new menu.
Introduce `wp.customize.utils.highlightButton()` and `wp.customize.Menus.MenuSection#highlightNewItemButton()`.

Props bpayton, melchoyce, afercia, westonruter.
Fixes #42114.


git-svn-id: https://develop.svn.wordpress.org/trunk@41930 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 21:59:34 +00:00
Sergey Biryukov
66f9609763 Build/Test Tools: Clean up $_REQUEST and $GLOBALS after modifying them in _test_list_hierarchical_page().
Props birgire.
Fixes #42044.

git-svn-id: https://develop.svn.wordpress.org/trunk@41929 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 21:47:39 +00:00
Sergey Biryukov
40706838a1 Rewrite Rules: Remove redundant if condition in extract_from_markers().
Props Dency, yahil, appchecker.
Fixes #39920.

git-svn-id: https://develop.svn.wordpress.org/trunk@41928 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 21:27:22 +00:00
Sergey Biryukov
6426b0b400 I18N: Unify error messages in XML-RPC methods wp_deleteCategory() and wp_deleteComment().
Props ramiy.
Fixes #39019.

git-svn-id: https://develop.svn.wordpress.org/trunk@41927 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 21:11:47 +00:00
Sergey Biryukov
ac8bc46b09 Administration: After [41120], check for a registered action before sending a Bad Request HTTP response status code.
Props Clorith.
Fixes #42240.

git-svn-id: https://develop.svn.wordpress.org/trunk@41926 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 21:00:39 +00:00
Sergey Biryukov
adfa4cd450 Menus: Remove unnecessary top margin for menu item type on Menus screen for correct alignment with the dropdown icon.
Props punit5658.
Fixes #41521.

git-svn-id: https://develop.svn.wordpress.org/trunk@41925 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 20:51:23 +00:00
Sergey Biryukov
a8518be72b Network Admin: After [41923], move the second <p> tag to a new line for better readability.
See #41652.

git-svn-id: https://develop.svn.wordpress.org/trunk@41924 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 20:50:58 +00:00
Sergey Biryukov
76c2aa8c85 I18N: Remove hardcoded constant from a translatable string in network_step1().
Props ramiy.
Fixes #41652.

git-svn-id: https://develop.svn.wordpress.org/trunk@41923 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 20:01:36 +00:00
Sergey Biryukov
6561981976 Docs: Document $ini_all staticvar in wp_is_ini_value_changeable().
Props nileshdudakiya94.
Fixes #41399.

git-svn-id: https://develop.svn.wordpress.org/trunk@41922 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 19:53:40 +00:00
Sergey Biryukov
beeb0acd94 I18N: Combine two "Warning" strings in network_step1() and network_step2().
Props ramiy.
Fixes #38570.

git-svn-id: https://develop.svn.wordpress.org/trunk@41921 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 19:49:17 +00:00
Sergey Biryukov
dcb6ef8aa4 Date/Time: Use delta comparison in get_gmt_from_date() tests to avoid race conditions.
Props keesiemeijer.
Fixes #38815.

git-svn-id: https://develop.svn.wordpress.org/trunk@41920 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 19:41:46 +00:00
Weston Ruter
349ccdf2d7 Customize: Fix visibility of overlay notifications in Safari.
Props sayedwp, westonruter.
Amends [41390].
See #35210, #42024, #42052.


git-svn-id: https://develop.svn.wordpress.org/trunk@41919 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 18:12:29 +00:00
Felix Arntz
4124fbfa7c Multisite: Document all return types in get_networks().
Adds more complete documentation to get_networks() and the corresponding methods in WP_Network_Query.

Fixes #42260.


git-svn-id: https://develop.svn.wordpress.org/trunk@41918 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 18:12:20 +00:00
SergeyBiryukov
a540d91f8f Docs: Document $default_scripts parameter in _WP_Editors::enqueue_scripts().
Props danieltj, ajayghaghretiya1.
Fixes #41322.

git-svn-id: https://develop.svn.wordpress.org/trunk@41917 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 18:08:02 +00:00
Sergey Biryukov
88a6ebaa75 Plugins: Revert unintended change from [41915].
See #37430.

git-svn-id: https://develop.svn.wordpress.org/trunk@41916 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 18:00:54 +00:00
Sergey Biryukov
93a3fa4506 Plugins: After [41608], make the markup in WP_Plugin_Install_List_Table::no_items() a bit more readable.
See #37430.

git-svn-id: https://develop.svn.wordpress.org/trunk@41915 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 17:58:00 +00:00
Sergey Biryukov
dca34e10d5 Docs: Add @since entry for WP_Automatic_Updater::after_core_update(), introduced in [25841].
See #41017, #29086.

git-svn-id: https://develop.svn.wordpress.org/trunk@41914 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 17:47:34 +00:00
Weston Ruter
a7c6a25eba Widgets: Fix previewing embeds in Text widget by allowing parse-embed admin ajax requests with an empty post_ID just as WP_oEmbed_Controller::get_proxy_item_permissions_check() allows.
As of #34115 if there is no post context the oEmbed will be cached in an `oembed_cache` custom post type, so having a post as context is no longer a requirement for caching.

Props biskobe, westonruter.
See #34115, #40450.
Fixes #40854.


git-svn-id: https://develop.svn.wordpress.org/trunk@41913 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 17:39:46 +00:00