Commit Graph

23767 Commits

Author SHA1 Message Date
Andrew Nacin
9f23f85ae2 Run _fix_attachment_links() when post_status is future or private in addition to publish.
Fixes regression caused by [20308].

props jond3r.
fixes #25268.


git-svn-id: https://develop.svn.wordpress.org/trunk@25697 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 12:55:38 +00:00
Andrew Nacin
48f68c8c6b Hash password reset keys in the database.
All existing, unused password reset keys are now considered "expired" and the user will be told they should try again.

Introduces a password_reset_key_expired filter to allow plugins to introduce a grace period.

fixes #24783.


git-svn-id: https://develop.svn.wordpress.org/trunk@25696 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 11:28:42 +00:00
Andrew Nacin
352ff49768 Reverse the order of roles in wp_dropdown_roles(). Reset to 'subscriber' when the default role is removed and when a save is invalid.
props garyc40, wonderboymusic.
fixes #14578.


git-svn-id: https://develop.svn.wordpress.org/trunk@25695 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 10:55:42 +00:00
Andrew Nacin
c0fb231f92 Hide the "If you take over" string from the post locked dialog when the override_post_lock filter is used to prevent an override.
props azaozz.
fixes #24930.


git-svn-id: https://develop.svn.wordpress.org/trunk@25694 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 10:45:25 +00:00
Andrew Nacin
9bd950b6d1 New grunt copy:version task that removes -src from $wp_version on build.
props azaozz.
fixes #25161.


git-svn-id: https://develop.svn.wordpress.org/trunk@25693 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 10:33:01 +00:00
Andrew Nacin
29a12d6ee5 Append -src to the $wp_version in the develop repo (only) to allow for us to differentiate. see #25161.
git-svn-id: https://develop.svn.wordpress.org/trunk@25692 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-05 14:24:21 +00:00
Andrew Nacin
1b37564f35 Send current SSL status to the plugin information API endpoint so we can render screenshots over SSL if appropriate. fixes #11009.
git-svn-id: https://develop.svn.wordpress.org/trunk@25691 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-05 10:58:20 +00:00
Andrew Nacin
cee5480513 Avoid 404 for wp-activate.php.
props nullvariable.
fixes #24960.


git-svn-id: https://develop.svn.wordpress.org/trunk@25690 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-04 14:11:49 +00:00
Dominik Schilling (ocean90)
3f422038dd Move get_current_user_id() call out of if-block, see [25669].
props layotte.
fixes #25372.

git-svn-id: https://develop.svn.wordpress.org/trunk@25689 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 13:35:12 +00:00
Dominik Schilling (ocean90)
d529239d24 Post UI: Increase the trigger width for switching from two columns to one.
props melchoyce, vinod dalvi.
fixes #23904.

git-svn-id: https://develop.svn.wordpress.org/trunk@25688 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 09:36:36 +00:00
Dominik Schilling (ocean90)
4f7760db6f Revert [25622]. fixes #25445. see #25122.
git-svn-id: https://develop.svn.wordpress.org/trunk@25687 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 09:11:45 +00:00
Andrew Nacin
20686308d3 Reset "Page on Front" when such a page is trashed.
props danielbachhuber.
fixes #24171.


git-svn-id: https://develop.svn.wordpress.org/trunk@25686 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 03:50:26 +00:00
Andrew Nacin
83a69a16d2 Support G shorthand for WP_MEMORY_LIMIT. see #23251.
git-svn-id: https://develop.svn.wordpress.org/trunk@25685 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 03:46:01 +00:00
Andrew Nacin
d4f0c8604a Don't override a PHP memory_limit specified using G shorthand.
props peterjaap.
fixes #23251.


git-svn-id: https://develop.svn.wordpress.org/trunk@25684 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 03:27:04 +00:00
Andrew Nacin
2dae159c6e Ensure wp::send_headers() detects a comments feed when permalinks are disabled and thus the withcomments QV is omitted. This fixes Last-Modified.
props sweetie089.
fixes #24622.


git-svn-id: https://develop.svn.wordpress.org/trunk@25683 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 03:14:39 +00:00
Andrew Nacin
df0aceb365 Backport a fix for qmail from PHPMailer upstream.
props bpetty.
fixes #25014.


git-svn-id: https://develop.svn.wordpress.org/trunk@25682 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 03:00:01 +00:00
Andrew Nacin
2068a3e6da When determining a frontend, local URL in the theme customizer, match the home URL without a trailing slash.
props SergeyBiryukov.
fixes #25315.


git-svn-id: https://develop.svn.wordpress.org/trunk@25681 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 01:49:59 +00:00
Andrew Nacin
a59daf91cf Ensure we globally replace [ and ] in customizer control IDs, to match the PHP.
props westonruter.
fixes #25238.


git-svn-id: https://develop.svn.wordpress.org/trunk@25680 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 01:45:39 +00:00
Andrew Nacin
8cd52fe580 Don't let the query string pile up on successive themes.php searches.
props SergeyBiryukov.
fixes #25270.


git-svn-id: https://develop.svn.wordpress.org/trunk@25679 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 01:25:24 +00:00
Andrew Nacin
a2c2641419 Avoid counting auto-drafts in sticky.
props nofearinc.
fixes #25127.


git-svn-id: https://develop.svn.wordpress.org/trunk@25678 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 01:15:30 +00:00
Andrew Nacin
7a9a26fb84 List tables: When executing a search, reset the Bulk Actions dropdown to avoid the search from failing.
props c3mdigital, vinod-dalvi.
fixes #25034.


git-svn-id: https://develop.svn.wordpress.org/trunk@25677 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 01:08:13 +00:00
Andrew Nacin
635a1249f5 Post lists table: When counting a user's posts, use get_post_stati() instead of hardcoded internal statuses.
props creativeinfusion.
fixes #24818.


git-svn-id: https://develop.svn.wordpress.org/trunk@25676 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 00:59:12 +00:00
Andrew Nacin
f6138dc287 Remove redundant title attributes.
props sabreuse.
see #24766.


git-svn-id: https://develop.svn.wordpress.org/trunk@25675 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 22:50:50 +00:00
Andrew Nacin
df647346b1 Don't use a double negative.
props TobiasBg.
fixes #18201.


git-svn-id: https://develop.svn.wordpress.org/trunk@25674 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 21:49:34 +00:00
Scott Taylor
c03af6bbd7 WP_User::get_role_caps() now returns the caps it was already setting. The method was previously just setting $allprops and requiring that property to be read.
Props nofearinc.
Fixes #24962.




git-svn-id: https://develop.svn.wordpress.org/trunk@25673 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 21:35:20 +00:00
Andrew Nacin
6611067dee Use site_url() in theme-compat.
props technosailor.
see #25418.


git-svn-id: https://develop.svn.wordpress.org/trunk@25672 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 21:16:17 +00:00
Andrew Nacin
a05eefbd64 Ensure that get_bloginfo( 'pingback_url' ) uses site_url(), for SSL awareness.
props technosailor.
fixes #25418.


git-svn-id: https://develop.svn.wordpress.org/trunk@25671 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 21:14:05 +00:00
Andrew Nacin
69a17e3469 Links manager: Restrict field length based on DB schema.
props solarissmoke, vinod-dalvi.
fixes #17296, #12264.


git-svn-id: https://develop.svn.wordpress.org/trunk@25670 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 21:10:24 +00:00
Dominik Schilling (ocean90)
6311fbbfdb Replace use of global $user_ID in favor of get_current_user_id(). fixes #25372.
git-svn-id: https://develop.svn.wordpress.org/trunk@25669 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 21:09:52 +00:00
Andrew Nacin
dac3f63f9c Don't order feeds of search results by relevance.
Allow for orderby=relevance to explicitly request relevance.

fixes #7394.


git-svn-id: https://develop.svn.wordpress.org/trunk@25668 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 21:04:36 +00:00
Scott Taylor
f3722d70c1 Revert [25663] for UX discussion
git-svn-id: https://develop.svn.wordpress.org/trunk@25667 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 20:52:22 +00:00
Andrew Nacin
212dba1113 Show a proper error message on the dashboard when the current theme is broken.
Clean up Appearance -> Themes when we don't have enough information to show for a broken theme.

Clean up broken/ugly "alt" row styling when we are displaying broken themes.

props johnbillion for initial patch.
fixes #21670.


git-svn-id: https://develop.svn.wordpress.org/trunk@25666 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 20:49:59 +00:00
Dominik Schilling (ocean90)
27fe045132 Allow to filter the link attribute via shortcode_atts_gallery. props iworks. fixes #24979.
git-svn-id: https://develop.svn.wordpress.org/trunk@25665 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 20:45:55 +00:00
Andrew Nacin
0a13564db8 When queries fail in option functions, bail before setting cache.
Standardize variables so things are less confusing.

fixes #25015.


git-svn-id: https://develop.svn.wordpress.org/trunk@25664 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 20:42:39 +00:00
Scott Taylor
415a348999 When Quick Edit'ing a page, checks if edited page has a new parent and moves the row underneath that one. If the parent doesn't exist on this page then it hides the row altogether.
Props solarissmoke, MikeHansenMe.
Fixes #14188.



git-svn-id: https://develop.svn.wordpress.org/trunk@25663 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 20:37:48 +00:00
Scott Taylor
a27234c898 Rather than adding a taxonomy arg to get_category(), convert all uses of get_category() in core to get_term(). By doing so, we negate the need to call _make_cat_compat() in a few places that are only looking for a single property.
Fixes #8722.



git-svn-id: https://develop.svn.wordpress.org/trunk@25662 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 19:58:50 +00:00
Scott Taylor
faa8c3c9ef post_content does not have a default value in the $wpdb->posts table. Add a default value of empty string to wp_insert_attachment() to avoid a tornado of database errors in PHP 5.5/MySQL 5.6, even when debug mode is turned off.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25661 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 19:51:57 +00:00
Scott Taylor
f3488744ce Add a default value to WP_UnitTest_Factory_For_Comment::default_generation_definitions['comment_content'] to avoid a tornado of database errors in PHP 5.5/MySQL 5.6, even when WP_DEBUG is turned off.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25660 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 19:46:58 +00:00
Scott Taylor
7918d5cd98 Make url_to_postid() work for custom post type URLs. Use get_post_types() and get_taxonomies() instead of directly accessing globals. Adds unit test.
Props faishal, for the globals fix.
Fixes #19744.



git-svn-id: https://develop.svn.wordpress.org/trunk@25659 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 19:41:19 +00:00
Andrew Nacin
64d3d53838 More string cleanups.
git-svn-id: https://develop.svn.wordpress.org/trunk@25658 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 18:50:45 +00:00
Andrew Nacin
7755927e7d End sentences in periods. see #24982.
git-svn-id: https://develop.svn.wordpress.org/trunk@25657 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 17:48:55 +00:00
Andrew Nacin
fc97814a23 This error message should have a period.
git-svn-id: https://develop.svn.wordpress.org/trunk@25656 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 17:44:09 +00:00
Andrew Nacin
49e7cf1a30 Rollback is not a verb.
git-svn-id: https://develop.svn.wordpress.org/trunk@25655 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 17:43:15 +00:00
Andrew Nacin
456b8837f2 Use sentence case.
git-svn-id: https://develop.svn.wordpress.org/trunk@25654 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 17:39:26 +00:00
Sergey Biryukov
7e18d18db5 Remove inaccurate @return value from remove_role(). props tivnet. fixes #25450.
git-svn-id: https://develop.svn.wordpress.org/trunk@25653 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-01 02:52:30 +00:00
Andrew Nacin
85c8f3c68f Send back core translation information to the API. Update wp_get_installed_translations() to work with core translations. see #18200.
git-svn-id: https://develop.svn.wordpress.org/trunk@25652 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-30 19:46:15 +00:00
Dion Hulse
6d29f14560 Automatic Updates: Remove some debug from [25649] See #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25651 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-30 00:29:19 +00:00
Dion Hulse
3fa23828e3 Automatic Updates: Disable Automatic updates for Mercurial(HG) and Bazaar(bzr) version control systems in addition to Git and SVN. Props jamescollins. See #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25650 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-30 00:24:06 +00:00
Dion Hulse
05a01e5964 Automatic Updates: Add a rollback functionality upon installation failure, the rollback package will be available for partial-updates for automatic updates and be similar to our existing partial builds (but in reverse).
A further iteration of this is to also detect whitescreens (fatals) after a auto update, and trigger the rollback for that too.
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25649 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-30 00:20:35 +00:00
Dion Hulse
f1928e42bf MD5 file verification: Prevent md5_file() warnings when files don't exist, additionally, don't verify wp-content files as they can be updated separately, as well as WP_CONTENT_DIR being set elsewhere. See #22704 See #18201
git-svn-id: https://develop.svn.wordpress.org/trunk@25648 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-29 23:07:59 +00:00