Scott Taylor
99c99b77e3
Add access modifier (`public`) to methods in `WP_Importer`.
...
See #27881 , #22234 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28492 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 00:19:00 +00:00
Scott Taylor
ae31b3795c
Add access modifier (`public`) to members and methods in `WP_Filesystem_SSH2`.
...
See #27881 , #22234 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28491 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 00:17:18 +00:00
Scott Taylor
fce8b1e0c3
Add access modifier (`public`) to members and methods in `WP_Filesystem_ftpsockets`.
...
See #27881 , #22234 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28490 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 00:13:29 +00:00
Scott Taylor
434ce7f6d8
Add access modifier (`public`) to members and methods in `WP_Filesystem_FTPext`.
...
See #27881 , #22234 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28489 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 00:11:21 +00:00
Scott Taylor
ec06d96ce6
Add access modifier (`public`) to methods in `WP_Filesystem_Direct`.
...
See #27881 , #22234 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28488 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 00:08:38 +00:00
Scott Taylor
06672a6c5a
Add access modifiers to members and methods in `WP_Filesystem_Base`. Add magic `__get()` method for backwards compatibility.
...
See #27881 , #22234 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28487 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 00:05:06 +00:00
Scott Taylor
6e09b1f167
Add access modifier (`public`) to members and methods in `WP_Comments_List_Table` and `WP_Post_Comments_List_Table`.
...
See #27881 , #22234 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28486 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 23:58:38 +00:00
Scott Taylor
8af8f5f8f2
In `edit-link-form.php`, `hackificator` bails because there is a `</form>` with no open `<form>`. It exists, but is needlessly constructed with PHP. It always returns a `<form>`, only the `id` and `name` are different. The dynamic piece just returns the ID now.
...
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28485 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 22:06:22 +00:00
Scott Taylor
4f74ef5466
`hackificator` bails on this file because of mixed quote styles on some HTML attributes.
...
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28484 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 21:47:01 +00:00
Scott Taylor
c6919845ca
Remove public keyword from some JS functions. Sorry.
...
Props ocean90.
See #22234 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28483 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 21:42:32 +00:00
Scott Taylor
01fa4c0c1e
`hackificator` bails on this file because the `<meta>` isn't self-closing.
...
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28482 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 21:35:03 +00:00
Scott Taylor
e509190fb3
Use proper access modifiers and add a magic `__get()` method to `Custom_Background` and `Custom_Image_Header`.
...
See #27881 , #22234 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28481 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 21:30:43 +00:00
Scott Taylor
1b4e4e665a
`hackificator` complains if you call `include 'file.php'` without the parens, needs to be `include( 'file.php' )`
...
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28479 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 20:51:44 +00:00
Scott Taylor
af0851cc0d
Because the `WP_ADMIN` constant name can be bound in multiple files, all instances should check `! defined` first. `wp-admin/admin.php` already has this check.
...
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28478 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 20:41:28 +00:00
Scott Taylor
f083cc4e9b
The About page has a `<div>` that doesn't close. Also, `<hr>`s should self-close. `hackificator` complains about these things.
...
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28477 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 20:32:58 +00:00
Sergey Biryukov
0cc180b0a4
Fix wp_insert_link(), broken in [28406]/[28408].
...
see #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28475 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 09:55:16 +00:00
Drew Jaynes (DrewAPicture)
9e81d2d692
Add inline documentation for default arguments in `wp_insert_category()`.
...
See #28298 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28474 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 07:27:25 +00:00
Sergey Biryukov
d56f67b8e9
Update help text on Add Themes screen.
...
props thomasvanderbeek.
fixes #28132 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28473 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 23:43:41 +00:00
Scott Taylor
40e6ec443f
Add inline comment after fix in [28467].
...
Props jesin.
Fixes #28292 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28468 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 15:41:40 +00:00
Scott Taylor
14a7b47119
Restore `$soucrce` in `WP_Upgrader::install_package()`.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28467 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 15:39:33 +00:00
Scott Taylor
ccc874514c
Eliminate use of `extract()` in `request_filesystem_credentials()`.
...
The only property that doesn't need to be set to a variable is `$password`.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28456 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 18:25:41 +00:00
Andrew Ozz
6fa89637e5
DFW: fix closing only the wpLink or media modal when pressing Esc.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28455 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 18:16:59 +00:00
Scott Taylor
ec17088ff6
Update inline docs for `wp_handle_upload|sideload` to reflect their non-use of `extract()`.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28452 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 17:40:44 +00:00
Scott Taylor
8f8b12e6a6
Eliminate use of `extract()` in `wp_handle_sideload()`.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28451 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 16:14:56 +00:00
Scott Taylor
176d361626
Eliminate use of `extract()` in `wp_handle_upload()`.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28450 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 16:10:00 +00:00
Sergey Biryukov
6100833f0c
DFW: Properly handle Esc key when the content is focused or when switching browser tabs.
...
props avryl.
fixes #28279 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28443 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 10:42:03 +00:00
wonderboymusic
30dcd2c3e9
Eliminate the use of `extract()` in `WP_Upgrader`.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28418 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 05:01:02 +00:00
Scott Taylor
650e0580e4
Eliminate one of the uses of `extract()` in `wp_handle_upload()`.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28417 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 04:30:32 +00:00
Scott Taylor
219ad73200
Eliminate one of the uses of `extract()` in `wp_handle_sideload()`.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28416 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 04:28:24 +00:00
Scott Taylor
c4b23f9fc3
Eliminate use of `extract()` in `Walker_Category_Checklist::start_el()`.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28411 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 03:13:44 +00:00
Scott Taylor
85d6f8e54f
Eliminate use of `extract()` in `wp_terms_checklist()`.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28410 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 03:08:46 +00:00
Scott Taylor
98ca12ef2e
Eliminate use of `extract()` in `wp_star_rating()`.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28409 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:56:56 +00:00
Scott Taylor
5e046b92fd
(REALLY) Eliminate use of `extract()` in `wp_insert_link()`.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28408 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:54:27 +00:00
Scott Taylor
27ff2a1cd0
Eliminate use of `extract()` in `get_media_item()`.
...
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28407 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:45:01 +00:00
Scott Taylor
e0ddd2ebf0
Eliminate use of `extract()` in `wp_insert_link()`.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28406 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:27:55 +00:00
Scott Taylor
46f15a84ab
Eliminate use of `extract()` in `display_setup_form()`. Only needs to read `password` and `password_message`.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28396 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-14 16:42:42 +00:00
Drew Jaynes (DrewAPicture)
cfc1b74ddb
Properly split and document the `admin_post*` actions into the following four hooks:
...
* `admin_post_nopriv` – for logged-out requests lacking a supplied action
* `admin_post_nopriv_$action – for logged-out requests with a supplied action
* `admin_post` – for logged-in requests lacking a supplied action
* `admin_post_$action` – for logged-in requests with a supplied action
See [28349], [28350], [28351].
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28394 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 07:23:35 +00:00
Drew Jaynes (DrewAPicture)
1954f9b7d4
Clarify inline documentation for back-compat `load-*` action hooks.
...
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28393 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 06:27:11 +00:00
Scott Taylor
bc17731c23
Eliminate use of `extract()` in `post_tags_meta_box()` and `post_categories_meta_box()`.
...
Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28391 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:47:03 +00:00
Scott Taylor
b72bd1c40f
Eliminate use of `extract()` in `WP_Terms_List_Table::display_rows_or_placeholder()`:
...
* Set variables for `$page` and `$number`
* `list(...) = $this->get_column_info()` can be removed, as none of the variables returned are used.
* `orderby` and `search` can be checked from `$args`, leaving no reason to extract
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28390 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:36:22 +00:00
Scott Taylor
7c0e12f5c6
Eliminate use of `extract()` in `WP_List_Table::pagination()`:
...
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28389 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:26:34 +00:00
Scott Taylor
31e187faa3
Eliminate use of `extract()` in `WP_Plugin_Install_List_Table::get_table_classes()`. It only needs to read `plural`, no need to extract.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28388 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:16:39 +00:00
Scott Taylor
fac2faee93
Eliminate use of `extract()` in `WP_List_Table::ajax_response()`:
...
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28387 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:13:09 +00:00
Scott Taylor
a2122e6f7b
Eliminate use of `extract()` in `WP_List_Table::display()`. The method only needs to read `singular` from `$this->_args`. Extraction is unnecessary.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28386 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:07:11 +00:00
Scott Taylor
878a974477
Eliminate use of `extract()` in `WP_Post_Comments_List_Table::display()`. The method only needs to read `singular` from `$this->_args`. Extraction is unnecessary.
...
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28385 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:03:26 +00:00
Scott Taylor
f57bdbd238
Eliminate use of `extract()` in `Custom_Image_Header::step_2()`.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28384 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:53:13 +00:00
Drew Jaynes (DrewAPicture)
68f78b1dcc
Clarify documentation for *what* gets "automatically fired" when the `do_mu_upgrade` filter evaluates to true in Multisite.
...
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28376 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:17:16 +00:00
Drew Jaynes (DrewAPicture)
d59c371180
Fix incomplete inline documentation for the `wp_header_image_attachment_metadata` filter.
...
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28375 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:12:02 +00:00
Scott Taylor
4e0809e3e4
Eliminate use of `extract()` in `wp_insert_category()`. Adds unit tests. All unit tests pass.
...
Props MikeHansenMe.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28374 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 03:26:51 +00:00
Scott Taylor
3f59b86ec5
In `media_upload_gallery_form()`'s inline JavaScript, remove unnecessary comment tags.
...
Fixes #25637 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28368 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 06:11:08 +00:00