Commit Graph

32299 Commits

Author SHA1 Message Date
Sergey Biryukov
9b591d6b09 Embeds: Rename files, functions, and hooks added in [34903] to make it more clear what is oEmbed-specific and what isn't.
See https://core.trac.wordpress.org/ticket/34272#comment:7 for full list of renamed functions and hooks.

Props swissspidy.
Fixes #34272.

git-svn-id: https://develop.svn.wordpress.org/trunk@35235 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 01:20:19 +00:00
Sergey Biryukov
5c19a7a704 Replace Quick Edit and Bulk Edit headings with <legend> elements.
Props afercia.
Fixes #34289.

git-svn-id: https://develop.svn.wordpress.org/trunk@35234 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 00:44:12 +00:00
Aaron Jorbin
7db19dcda2 Improve get_post_permalink compatibility with non standard post status
This adds a new filter named `get_post_status` to the function named `get_post_status` which can be used to make additional post types behave like unpublished post status in `get_post_permalink`.

Props misterbisson, antpb, iamfriendly
Fixes #23458



git-svn-id: https://develop.svn.wordpress.org/trunk@35233 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 00:43:54 +00:00
Sergey Biryukov
fe72320f33 Merge two strings for expanding accordion and Customizer sections.
Props pavelevap.
Fixes #33939.

git-svn-id: https://develop.svn.wordpress.org/trunk@35232 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 00:27:44 +00:00
Weston Ruter
370057b5d7 Customizer: Always show Widgets panel initially if sidebars are registered; show notice to users in panel if no widget areas are in current preview.
Widgets panel will not wait to display until the preview loads.

Also fixes problems with `margin-top` in panels where other panels' `active` states change, as well as ensuring sections of deactivated panel collapse before panel is hidden to prevent the pane from becoming empty of controls.

Fixes #33052.
Fixes #33567.


git-svn-id: https://develop.svn.wordpress.org/trunk@35231 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 23:47:56 +00:00
Sergey Biryukov
de182f7736 Merge two warning strings.
Props pavelevap.
Fixes #29740.

git-svn-id: https://develop.svn.wordpress.org/trunk@35230 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 23:30:29 +00:00
Sergey Biryukov
af36c261e3 Sample permalink: Improve accessibility of changing the permalink on Edit Post screen.
Props afercia.
Fixes #34255.

git-svn-id: https://develop.svn.wordpress.org/trunk@35229 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 23:01:58 +00:00
Sergey Biryukov
7b6454bf6b Embeds: In print_oembed_embed_styles(), load non-minified file if SCRIPT_DEBUG is true.
This is consistent with `print_oembed_embed_scripts()`.

Props MikeHansenMe.
Fixes #34321.

git-svn-id: https://develop.svn.wordpress.org/trunk@35228 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 22:42:47 +00:00
Boone Gorges
f22ba848df Return null from get_term() on taxonomy mismatch.
[34997] caused `get_term()` to return an error object in the case when
`$taxonomy` did not match the taxonomy of the located term. This was an
inadvertant change from the previous behavior, when `get_term()` would return
null in these cases.

Props dlh.
See #14162. Fixes #34332.

git-svn-id: https://develop.svn.wordpress.org/trunk@35227 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 21:41:51 +00:00
Scott Taylor
61edcd5021 Unit Tests: PHP 5.2, I Hate You and You Are Bringing Me Down.
#YOLOFriday

See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35226 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 21:14:52 +00:00
Scott Taylor
e70ebea219 Unit Tests: one $factory to rule them all, and it shall be static.
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday



git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 21:04:12 +00:00
Scott Taylor
84272ff8cd Unit Tests: since [32953], we can just use self::delete_user() instead of using if logic for Multisite.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35224 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 19:51:32 +00:00
Sergey Biryukov
0d4a7ee029 In WP_Posts_List_Table, correct the type for $comment_pending_count.
See #11381.

git-svn-id: https://develop.svn.wordpress.org/trunk@35223 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 18:24:25 +00:00
Sergey Biryukov
e4c9f97fb3 In WP_Media_List_Table, rename $pending_count to $comment_pending_count and mark it as protected, for consistency with WP_Posts_List_Table.
See #11381.

git-svn-id: https://develop.svn.wordpress.org/trunk@35222 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 18:22:12 +00:00
Drew Jaynes
ea8e9f89cd Docs: Standardize the file header summary for wp-admin/includes/file.php.
Also adds an `@since` version and corrects the `@subpackage` value.

See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35221 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 16:55:24 +00:00
Andrea Fercia
cb2285f63e Accessibility: Improve headings hierarchy in the Theme browser modal dialog.
Fixes #34288.

git-svn-id: https://develop.svn.wordpress.org/trunk@35220 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 15:55:06 +00:00
Andrea Fercia
e68dfb6c6b Bump H4 headings to H2 in the Updates screen for better accessibility.
Fixes #34265.

git-svn-id: https://develop.svn.wordpress.org/trunk@35219 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 15:44:49 +00:00
Dominik Schilling (ocean90)
baf6f0bb6d Travis CI: Use a pinned version of the object cache drop-in.
Props tollmanz.
See #31491.

git-svn-id: https://develop.svn.wordpress.org/trunk@35218 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 14:15:18 +00:00
Ella Iseulde Van Dorpe
4abf64eb14 TinyMCE: add lang attribute
This is needed to make `hyphens: auto;` work correctly.

Fixes #32555.


git-svn-id: https://develop.svn.wordpress.org/trunk@35217 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 10:10:32 +00:00
Ella Iseulde Van Dorpe
093b6b5d11 TinyMCE: make sure markers are removed after first init
This is only relevant to non embeddable URLs.
After first init, markers were set but not removed,
causing an edited URL to revert when switching to text mode
or any paragraph after the URL to just contain that URL.

Fixes #33954.


git-svn-id: https://develop.svn.wordpress.org/trunk@35216 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 05:42:22 +00:00
Helen Hou-Sandi
b9c1a56e38 Account for icon alignment using text-indent in RTL.
fixes #33808.


git-svn-id: https://develop.svn.wordpress.org/trunk@35215 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 00:57:47 +00:00
Scott Taylor
2845280ffd Unit Tests: add SpeedTrapListener to phpunit/includes and add the config node to phpunit.xml.dist.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35214 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 00:27:28 +00:00
Dominik Schilling (ocean90)
159a5b518b Travis: Extend our test suite with a memcached instance.
To test persistent object caching Travis CI runs now a build on PHP 5.6 with memached enabled. The build uses the drop-in from https://github.com/tollmanz/wordpress-pecl-memcached-object-cache which is based on the PECL memcached extension.

Props pento, ocean90.
Fixes #31491.

git-svn-id: https://develop.svn.wordpress.org/trunk@35213 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 22:51:38 +00:00
Dominik Schilling (ocean90)
f75321f3ec Multisite: Remove the strictness for $using_paths in WP_Network::get_by_path().
The network lookup was broken when using an external object cache because `$using_paths` isn't always a boolean. Added in [34099].

See #31985, #31491.

git-svn-id: https://develop.svn.wordpress.org/trunk@35212 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 22:06:38 +00:00
Dominik Schilling (ocean90)
c6e2e6c1b5 Tests: Remove the @runTestsInSeparateProcesses annotation for Ajax tests.
They were added 3 years ago in [846/tests] because tests weren't excluded from the normal runs.

Reverts [35209] because it doesn't work with Xdebug.
`Tests_Ajax_Response::test_response_charset_in_header` is the only test which needs to run in a separate process, see [975/tests].

See #31491.

git-svn-id: https://develop.svn.wordpress.org/trunk@35211 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 21:30:52 +00:00
Drew Jaynes
c8bf2ce727 Docs: Fix a typo in an inline comment in wp_get_attachment_image_srcset_array().
Props neoxx.
Fixes #34319.


git-svn-id: https://develop.svn.wordpress.org/trunk@35210 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 20:51:58 +00:00
Dominik Schilling (ocean90)
666d07352e Tests: Don't preserve the global state for Ajax tests when using an external object cache.
Most of the Ajax tests are running in a separate PHP process, and thus PHPUnit attempts to preserve the global state from the parent process by serializing all globals. But this doesn't work for external object caches so we have to disable this "feature".

See #31491.

git-svn-id: https://develop.svn.wordpress.org/trunk@35209 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 20:34:08 +00:00
Aaron Jorbin
a0305d5020 Add Twenty Sixteen to travis builds
This allows the automated tests to include Twenty Sixteen.

Fixes #34315. See #34306.



git-svn-id: https://develop.svn.wordpress.org/trunk@35208 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 19:05:17 +00:00
Helen Hou-Sandi
3a8bd20594 Circular focus styling for widgets and menus in the customizer.
see #33808.


git-svn-id: https://develop.svn.wordpress.org/trunk@35207 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 18:52:24 +00:00
Boone Gorges
1b6a8019c3 Fix incorrect variable name introduced in [35197].
See #30017, #33968.

git-svn-id: https://develop.svn.wordpress.org/trunk@35206 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 18:47:11 +00:00
Sergey Biryukov
acce286d34 In WP::parse_request() and url_to_postid(), don't skip objects that have a post status with 'exclude_from_search' => false, e.g. inherit.
This fixes pretty permalinks for attachments, broken in [35195].

Fixes #21970.

git-svn-id: https://develop.svn.wordpress.org/trunk@35205 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 17:52:36 +00:00
Helen Hou-Sandi
0ff0b0e606 Make the database update button primary.
see #23738.


git-svn-id: https://develop.svn.wordpress.org/trunk@35204 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 17:34:30 +00:00
Sergey Biryukov
5b6257083d Twenty Sixteen: Update Gruntfile.js to ignore the html5 shiv for JSHint.
See #34306, #34315.

git-svn-id: https://develop.svn.wordpress.org/trunk@35203 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 17:26:44 +00:00
Drew Jaynes
ebd20119ec Docs: Walker_Nav_Menu_Checklist and Walker_Nav_Menu_Edit are part of the Navigation Menu API, but intended for use in the scope of administration.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35202 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 17:25:11 +00:00
Helen Hou-Sandi
b023eef6ca Box shadows still need -webkit-, turns out.
see #33808, [35200].


git-svn-id: https://develop.svn.wordpress.org/trunk@35201 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 17:09:00 +00:00
Helen Hou-Sandi
19bb379a17 Circular focus styling for expand/collapse arrows.
Affects postboxes, widgets, and nav menus, all in the admin.

props grvrulz for the initial patch.
see #33808.


git-svn-id: https://develop.svn.wordpress.org/trunk@35200 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 16:45:14 +00:00
Ella Iseulde Van Dorpe
017daba3d8 TinyMCE: make captioned images draggable
See #28003.


git-svn-id: https://develop.svn.wordpress.org/trunk@35199 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 15:19:04 +00:00
Ella Iseulde Van Dorpe
604fb7511c Fix close button plugin modal after [18590]
See #18590.



git-svn-id: https://develop.svn.wordpress.org/trunk@35198 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 14:51:01 +00:00
Scott Taylor
43d18b25b0 Unit Tests: add/upgrade the fixtures in Tests_User_Query.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35197 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 07:28:40 +00:00
Scott Taylor
32719bf251 Unit Tests: create fewer terms in Tests_Term_getTerms::test_get_terms_parent_zero()
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35196 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 06:52:19 +00:00
Sergey Biryukov
65390cd9cf In WP::parse_request() and url_to_postid(), if a post slug clashes with a trashed page, return the post instead of the page.
Props kovshenin, SergeyBiryukov, igmoweb.
Fixes #21970.

git-svn-id: https://develop.svn.wordpress.org/trunk@35195 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 06:48:22 +00:00
Scott Taylor
0cf7a91d3a Unit Tests: upgrade the fixtures in Tests_Post_Thumbnail_Template.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35194 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 06:39:43 +00:00
Scott Taylor
a65f390db6 Unit Tests: upgrade the fixtures in Tests_Post_Revisions.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35193 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 06:31:16 +00:00
Scott Taylor
5fc726c222 Unit Tests: in Tests_Comment_Query::test_get_comments_for_post(), create fewer comments (5, instead of 10).
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35192 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 05:56:47 +00:00
Scott Taylor
d424f690d2 Unit Tests: after [35186], "upgrade" the Canonical fixtures.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35191 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 05:50:40 +00:00
Sergey Biryukov
3d7aa47df8 Remove a one-time variable from edit_user() added in [35189].
See #27317.

git-svn-id: https://develop.svn.wordpress.org/trunk@35190 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 05:45:50 +00:00
Sergey Biryukov
e675e2ccf0 Users: Add 'illegal_user_logins' filter to allow certain usernames to be blacklisted.
Props danielbachhuber, chriscct7, crazycoolcam, SergeyBiryukov.
Fixes #27317.

git-svn-id: https://develop.svn.wordpress.org/trunk@35189 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 05:42:05 +00:00
Scott Taylor
742082c042 Unit Tests: create more fixtures for Tests_User. When using a factory to create ad hoc users, use the inherited static prop $static_factory instead of the instance prop, $factory. If 2 factories are used out of sync, the generator sequences diverge and dupes can be created, causing an untold number of unforeseen errors. Yay.
See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35188 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 05:29:40 +00:00
Sergey Biryukov
80178d8dc8 Themes: Add Install Parent Theme button for child themes that are missing a parent theme.
Props rabmalin for initial patch.
Fixes #32668.

git-svn-id: https://develop.svn.wordpress.org/trunk@35187 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 05:10:32 +00:00
Scott Taylor
16d98ebf73 Unit Tests: implement setUpBeforeClass() and tearDownAfterClass() on WP_UnitTestCase. Use late static binding (plus a gross fallback for PHP 5.2) to check if wpSetUpBeforeClass() or wpTearDownAfterClass() exist on the called class, and then call it and pass a static WP_UnitTest_Factory instance via Dependency Injection, if it exists.
This makes it way easier to add fixtures, and tear them down, without needing to instantiate `WP_UnitTest_Factory` in every class - removes the need to call `commit_transaction()` in each individual class.

See #30017, #33968.


git-svn-id: https://develop.svn.wordpress.org/trunk@35186 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 04:43:37 +00:00