Commit Graph

30 Commits

Author SHA1 Message Date
Ryan Boren 206318aeca There is no need to strip the output of get_site_option().
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23556 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:37:24 +00:00
Ryan Boren c363aea627 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
Ryan Boren a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Andrew Nacin 248b586911 Move sanitization for the multisite illegal_names, limited_email_domains, and banned_email_domains options to sanitize_option(). props wonderboymusic. fixes #21552.
git-svn-id: https://develop.svn.wordpress.org/trunk@21993 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-25 01:54:12 +00:00
Ryan Boren f1d9066aed Remove obsolete help string. Props SergeyBiryukov. fixes #20909
git-svn-id: https://develop.svn.wordpress.org/trunk@21051 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-11 20:32:21 +00:00
Andrew Nacin c16d06c447 s/website/network/ on the network settings screen. props Ipstenu, fixes #20314.
git-svn-id: https://develop.svn.wordpress.org/trunk@20442 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-11 20:45:03 +00:00
Andrew Nacin 76e4fbee38 Remove step="" from upload size inputs, as the step is enforced in the spec, rather than being a recommendation. finally fixes #17863.
git-svn-id: https://develop.svn.wordpress.org/trunk@20289 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-25 13:02:01 +00:00
Andrew Nacin eb066c0b33 Adjust site upload space HTML5 type='number' validation. see #17863.
git-svn-id: https://develop.svn.wordpress.org/trunk@20199 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-16 04:16:21 +00:00
Jon Cave 156048ca52 split was deprecated in PHP 5.3.0, so use explode instead. Props garyc40. Fixes #16325.
git-svn-id: https://develop.svn.wordpress.org/trunk@19726 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-09 21:20:51 +00:00
Ryan Boren 676ba7043e Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: https://develop.svn.wordpress.org/trunk@19593 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-13 23:45:31 +00:00
Ryan Boren 9f8cbd8efc Use WP_Screen::add_help_tab(). see #19020
git-svn-id: https://develop.svn.wordpress.org/trunk@19514 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-01 02:22:07 +00:00
Andrew Nacin 840f20feb2 More s/add_help_sidebar/set_help_sidebar/. fixes #19020.
git-svn-id: https://develop.svn.wordpress.org/trunk@19122 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 21:32:16 +00:00
Ryan Boren 71aa0059d0 Use add_help_sidebar(). see #19020
git-svn-id: https://develop.svn.wordpress.org/trunk@19114 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 05:33:53 +00:00
Andrew Nacin ac958d3ec6 Oops. see #17578.
git-svn-id: https://develop.svn.wordpress.org/trunk@18893 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-05 22:05:43 +00:00
Andrew Nacin 0a6ff4024f Kill the multisite mu_media_buttons option. see #17578.
git-svn-id: https://develop.svn.wordpress.org/trunk@18892 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-05 22:04:09 +00:00
Ryan Boren 35130709a7 s/Settings/Network Settings/. Props wpmuguru. fixes #16027
git-svn-id: https://develop.svn.wordpress.org/trunk@18842 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-30 17:26:14 +00:00
Andrew Nacin 7fe1e0fc4a Move network/settings.php POST handling out of network/edit.php. props PeteMall, see #18379.
git-svn-id: https://develop.svn.wordpress.org/trunk@18536 602fd350-edb4-49c9-b593-d223f7449a82
2011-08-11 22:32:35 +00:00
Ryan Boren 9781af86f5 Update some network admin help text. Props dougwrites. fixes #16988
git-svn-id: https://develop.svn.wordpress.org/trunk@17921 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-13 19:25:38 +00:00
Mark Jaquith 61c80bebca s/Network Options/Settings/. props wpmuguru. Not a string change (already existed). fixes #16027
git-svn-id: https://develop.svn.wordpress.org/trunk@17178 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-30 16:14:41 +00:00
Andrew Nacin 91bb1425e9 Move to what will be the new Network Admin Codex page URLs. see #15314.
git-svn-id: https://develop.svn.wordpress.org/trunk@17045 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-18 18:27:12 +00:00
Andrew Nacin b4bede6797 Move to 'Documentation on XY' in the network admin. see #15314.
git-svn-id: https://develop.svn.wordpress.org/trunk@16983 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-16 07:07:42 +00:00
Nikolay Bachiyski a643a8f79d Add New string fixes. Fixes #15577
git-svn-id: https://develop.svn.wordpress.org/trunk@16612 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-29 16:54:06 +00:00
Mark Jaquith 55e0256967 esc_textarea() and application for obvious textarea escaping. props alexkingorg. fixes #15454
git-svn-id: https://develop.svn.wordpress.org/trunk@16431 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-17 17:12:01 +00:00
Andrew Nacin 153f7bb62d Remove unnecessary message in network/settings. see #14435
git-svn-id: https://develop.svn.wordpress.org/trunk@16406 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-16 17:51:45 +00:00
Andrew Nacin ffd50167bd Network admin multisite checks and docs. see #14435.
git-svn-id: https://develop.svn.wordpress.org/trunk@16272 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-10 14:27:15 +00:00
Andrew Nacin 3c62cf9519 Network Wide Settings -> Language Settings and kill the notice, which is implicit enough with the word 'Default.' see #14435.
git-svn-id: https://develop.svn.wordpress.org/trunk@16271 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-10 14:01:39 +00:00
Andrew Nacin ba2d60c7fd Cast before implode. fixes #15167.
git-svn-id: https://develop.svn.wordpress.org/trunk@15868 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-20 14:22:47 +00:00
scribu 0911aa3e1a Use submit_button() in more places. See #15064
git-svn-id: https://develop.svn.wordpress.org/trunk@15830 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-17 18:24:34 +00:00
Ryan Boren 9ee8b20f30 First pass of user admin. Network admin and screen cleanups. see #14696
git-svn-id: https://develop.svn.wordpress.org/trunk@15746 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-07 19:34:18 +00:00
Ryan Boren edd48280e3 Network Admin, first pass. see #14435
git-svn-id: https://develop.svn.wordpress.org/trunk@15481 602fd350-edb4-49c9-b593-d223f7449a82
2010-07-30 20:34:54 +00:00