sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
26,342 Commits 2 Branches 473 Tags 137 MiB
9bb9177199
Commit Graph

26342 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Scott Taylor
599dff5c3d Add access modifiers to methods/members in WP_Roles. Add a magic __call() method for BC. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28503 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:19:36 +00:00
Scott Taylor
241d1a4d99 Add access modifiers to methods/members in WP_Object_Cache. Add a magic __get() method for BC. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28502 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:15:20 +00:00
Scott Taylor
b185ac51b2 In wp_list_bookmarks(), $categorize should now be $r['categorize]. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28501 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:10:45 +00:00
Scott Taylor
e43d2a73d8 Fix some hackificator odds and ends in wp-admin: 
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28500 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:03:44 +00:00
Drew Jaynes (DrewAPicture)
7b2c87df9a Improve inline documentation of default arguments for post_format_meta_box(), post_tags_meta_box(), and post_categories_meta_box(). 
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28499 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 03:22:21 +00:00
Drew Jaynes (DrewAPicture)
f228c5b16e Improve inline documentation of default arguments for the_title_attribute(). 
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28498 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 02:27:08 +00:00
Scott Taylor
eef0d99ed8 hackificator doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28497 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:58:28 +00:00
Scott Taylor
afe33f0f68 Add access modifier (public) to methods and members of WP_Upgrader and its subclasses. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28496 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:28:10 +00:00
Scott Taylor
17cabb1d8e Add access modifier (public) to methods and members of WP_Upgrader_Skin and its subclasses. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28495 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:22:55 +00:00
Scott Taylor
b1a09cf65d Add access modifiers to methods and members of WP_Users_List_Table. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28494 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:18:46 +00:00
Scott Taylor
d6a3c2a0de Add access modifiers to methods and members of list table classes: 
* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28493 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:16:16 +00:00
Scott Taylor
99c99b77e3 Add access modifier (public) to methods in WP_Importer. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28492 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:19:00 +00:00
Scott Taylor
ae31b3795c Add access modifier (public) to members and methods in WP_Filesystem_SSH2. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28491 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:17:18 +00:00
Scott Taylor
fce8b1e0c3 Add access modifier (public) to members and methods in WP_Filesystem_ftpsockets. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28490 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:13:29 +00:00
Scott Taylor
434ce7f6d8 Add access modifier (public) to members and methods in WP_Filesystem_FTPext. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28489 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:11:21 +00:00
Scott Taylor
ec06d96ce6 Add access modifier (public) to methods in WP_Filesystem_Direct. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28488 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:08:38 +00:00
Scott Taylor
06672a6c5a Add access modifiers to members and methods in WP_Filesystem_Base. Add magic __get() method for backwards compatibility. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28487 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 00:05:06 +00:00
Scott Taylor
6e09b1f167 Add access modifier (public) to members and methods in WP_Comments_List_Table and WP_Post_Comments_List_Table. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28486 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 23:58:38 +00:00
Scott Taylor
8af8f5f8f2 In edit-link-form.php, hackificator bails because there is a </form> with no open <form>. It exists, but is needlessly constructed with PHP. It always returns a <form>, only the id and name are different. The dynamic piece just returns the ID now. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28485 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 22:06:22 +00:00
Scott Taylor
4f74ef5466 hackificator bails on this file because of mixed quote styles on some HTML attributes. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28484 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:47:01 +00:00
Scott Taylor
c6919845ca Remove public keyword from some JS functions. Sorry. 
Props ocean90.
See #22234.



git-svn-id: https://develop.svn.wordpress.org/trunk@28483 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:42:32 +00:00
Scott Taylor
01fa4c0c1e hackificator bails on this file because the <meta> isn't self-closing. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28482 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:35:03 +00:00
Scott Taylor
e509190fb3 Use proper access modifiers and add a magic __get() method to Custom_Background and Custom_Image_Header. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28481 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:30:43 +00:00
Scott Taylor
85ac5c214d Add a unit test that demonstrates a magic getter. 
See #27881.



git-svn-id: https://develop.svn.wordpress.org/trunk@28480 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 21:14:13 +00:00
Scott Taylor
1b4e4e665a hackificator complains if you call include 'file.php' without the parens, needs to be include( 'file.php' ) 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28479 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 20:51:44 +00:00
Scott Taylor
af0851cc0d Because the WP_ADMIN constant name can be bound in multiple files, all instances should check ! defined first. wp-admin/admin.php already has this check. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28478 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 20:41:28 +00:00
Scott Taylor
f083cc4e9b The About page has a <div> that doesn't close. Also, <hr>s should self-close. hackificator complains about these things. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28477 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 20:32:58 +00:00
Drew Jaynes (DrewAPicture)
b5fdb2dc06 Improve inline documentation for default arguments in wp_get_archives(). 
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28476 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 17:19:56 +00:00
Sergey Biryukov
0cc180b0a4 Fix wp_insert_link(), broken in [28406]/[28408]. 
see #22400.

git-svn-id: https://develop.svn.wordpress.org/trunk@28475 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 09:55:16 +00:00
Drew Jaynes (DrewAPicture)
9e81d2d692 Add inline documentation for default arguments in wp_insert_category(). 
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28474 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 07:27:25 +00:00
Sergey Biryukov
d56f67b8e9 Update help text on Add Themes screen. 
props thomasvanderbeek.
fixes #28132.

git-svn-id: https://develop.svn.wordpress.org/trunk@28473 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 23:43:41 +00:00
Scott Taylor
5eecd2e62b Eliminate the use of extract() in MO::import_from_reader(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28472 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 17:20:26 +00:00
Scott Taylor
7205796cec Eliminate the use of extract() in get_pages(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28471 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 17:11:23 +00:00
Scott Taylor
b76a0d791b Eliminate the use of extract() in wp_insert_attachment(). 
`wp_insert_attachment()` and `wp_insert_post()` are incredibly similar, but have branched logic. I have annotated many places where they diverge.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28470 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 16:53:44 +00:00
Scott Taylor
9787ea4e2a Eliminate the use of extract() in wp_insert_post(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28469 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 15:52:11 +00:00
Scott Taylor
40e6ec443f Add inline comment after fix in [28467]. 
Props jesin.
Fixes #28292.



git-svn-id: https://develop.svn.wordpress.org/trunk@28468 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 15:41:40 +00:00
Scott Taylor
14a7b47119 Restore $soucrce in WP_Upgrader::install_package(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28467 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 15:39:33 +00:00
Scott Taylor
ff8ae69fce Eliminate the use of extract() in wp_delete_term(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28466 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 14:54:03 +00:00
Scott Taylor
06c87f681a Eliminate the use of extract() in get_terms(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28465 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 14:46:07 +00:00
Scott Taylor
02066d4241 Eliminate the use of extract() in wp_insert_term(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28464 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 14:15:40 +00:00
Lance Willett
c338a15b1f Twenty Ten: correct attribute escaping in the attachment template. Props philiparthurmoore, see #28251. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28463 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 22:43:31 +00:00
Lance Willett
a6129f5ea3 Twenty Fourteen: correct escaping for parent post link and attachment link in image template. Props philiparthurmoore, see #28251. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28462 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 22:30:04 +00:00
Scott Taylor
b1b30ad58c Eliminate use of extract() in wp_update_term(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28461 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 21:28:05 +00:00
Scott Taylor
54bc77cb93 The cache key for comments in WP_Comment_Query::query() needs to do wp_array_slice_assoc( $this->query_vars, array_keys( $defaults ) ) instead of compact( array_keys( $defaults ) ). The latter assumes all of those variables are still floating around. 
See #22400.



git-svn-id: https://develop.svn.wordpress.org/trunk@28460 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 21:08:15 +00:00
Scott Taylor
cb3341c03d (ACTUALLY) Eliminate use of extract() in WP_Comment_Query::query(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28459 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 20:51:23 +00:00
Scott Taylor
8d22270bc1 Eliminate use of extract() in WP_Comment_Query::query(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28458 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 19:32:05 +00:00
Scott Taylor
59f8ba6c9e Eliminate use of extract() in wp_insert_comment(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28457 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 18:51:41 +00:00
Scott Taylor
ccc874514c Eliminate use of extract() in request_filesystem_credentials(). 
The only property that doesn't need to be set to a variable is `$password`.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28456 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 18:25:41 +00:00
Andrew Ozz
6fa89637e5 DFW: fix closing only the wpLink or media modal when pressing Esc. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28455 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 18:16:59 +00:00
Scott Taylor
0d92bb2552 Eliminate use of extract() in wp_insert_user(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28454 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 18:15:00 +00:00