Commit Graph

131 Commits

Author SHA1 Message Date
Sergey Biryukov 33f793c521 Fix a warning on Menus screen if $menu_locations is false.
Fix menu selection after creating a first menu on new install.

props jkudish.
fixes #23508. see #23119.

git-svn-id: https://develop.svn.wordpress.org/trunk@23453 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-19 01:31:42 +00:00
Mark Jaquith c2945a394f Improve the UX of the Nav Menus screen. Kill the tabs, and change to a
dropdown, unless you have zero or one menus (which is the most common),
in which case you jump right into editing your sole menu.

Do assignment to location using checkboxes in the main menu editing
section instead of the backwards menu => location assignment in a
random meta box.

More to come, but this gets us started.

props lessbloat, DrewAPicture, jkudish. see #23119

git-svn-id: https://develop.svn.wordpress.org/trunk@23441 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-16 04:53:59 +00:00
Ryan Boren a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Andrew Nacin 40274b7956 Fix various typos and omissions across a number of help tabs. props DrewAPicture, Ipstenu. see #22451.
git-svn-id: https://develop.svn.wordpress.org/trunk@22812 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 08:45:15 +00:00
Andrew Nacin 903479fb96 Replace multiple wp_enqueue_script() calls in nav-menus.php with dependencies. props SergeyBiryukov. fixes #21777.
git-svn-id: https://develop.svn.wordpress.org/trunk@21696 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-03 15:35:22 +00:00
Andrew Ozz 3b9e5468e1 Add the jQuery UI Touch Punch plugin to handle dragging on mobile devices, props georgestephanis, see #20014
git-svn-id: https://develop.svn.wordpress.org/trunk@20433 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-11 02:20:51 +00:00
Ryan Boren 5e76729992 One newline is enough.
git-svn-id: https://develop.svn.wordpress.org/trunk@19684 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-05 20:10:39 +00:00
Ryan Boren 54067a5f20 Remove extraneous spaces. Props kenan3008, dimadin. fixes #19501 #19433
git-svn-id: https://develop.svn.wordpress.org/trunk@19596 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-14 17:36:38 +00:00
Ryan Boren 6610e321e7 Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@19528 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-01 04:51:35 +00:00
Andrew Nacin 29bacb72f0 Help tweaks for themes, plugins screens. props jane, see #19020.
git-svn-id: https://develop.svn.wordpress.org/trunk@19510 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-01 01:24:39 +00:00
Ryan Boren 4ae0813953 Help tabs. Props chexee. see #19020
git-svn-id: https://develop.svn.wordpress.org/trunk@19445 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-24 00:21:39 +00:00
Andrew Nacin 33ee9a7d04 s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020, #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@19119 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 20:14:10 +00:00
Ryan Boren db63861af8 Use add_help_sidebar(). see #19020
git-svn-id: https://develop.svn.wordpress.org/trunk@19111 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 03:12:37 +00:00
Andrew Nacin 2efff75050 Revert [18861], [18862], [18864], [18874], [18879], and [18880]. see #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@18911 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-07 04:57:12 +00:00
Dion Hulse c91838bd7d Fix admin_body_class filter for Menu's and Widgets pages, Include the filter in Iframe's. Props SergeyBiryukov & johnbillion. Fixes #18853
git-svn-id: https://develop.svn.wordpress.org/trunk@18882 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-05 07:09:51 +00:00
Andrew Ozz 98554b4bb6 Use add_option() method, introduce add_option_context() method for adding specific text above the screen options, see #18690
git-svn-id: https://develop.svn.wordpress.org/trunk@18867 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-03 04:00:57 +00:00
Andrew Ozz d0d3855285 Add screen_options with contextual content, see #18690
git-svn-id: https://develop.svn.wordpress.org/trunk@18864 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-02 06:59:36 +00:00
Andrew Ozz dde77fd41b Merge most admin css files, first run, see #18314
git-svn-id: https://develop.svn.wordpress.org/trunk@18577 602fd350-edb4-49c9-b593-d223f7449a82
2011-08-21 03:46:43 +00:00
Peter Westwood 7fa99c4253 Help Tab text updatates. Fixes #17312 prop dougwrites.
git-svn-id: https://develop.svn.wordpress.org/trunk@18092 602fd350-edb4-49c9-b593-d223f7449a82
2011-06-01 15:37:04 +00:00
Ryan Boren ccba8dfbf3 Validation fixes. Props ocean90, peaceablewhale. see #17364
git-svn-id: https://develop.svn.wordpress.org/trunk@18010 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-23 23:33:30 +00:00
Andrew Nacin f504e221e1 Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265.
git-svn-id: https://develop.svn.wordpress.org/trunk@17748 602fd350-edb4-49c9-b593-d223f7449a82
2011-04-28 15:24:49 +00:00
Andrew Nacin 3697db55bc Don't show two 'Create Menu' buttons on nav-menus.php. fixes #16715.
git-svn-id: https://develop.svn.wordpress.org/trunk@17543 602fd350-edb4-49c9-b593-d223f7449a82
2011-03-23 18:47:45 +00:00
Andrew Nacin c5efc2d6aa Fix one of my typos. props SergeyBiryukov, fixes #15346.
git-svn-id: https://develop.svn.wordpress.org/trunk@17039 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-18 06:18:44 +00:00
Andrew Nacin a3a37df98a Help fixes. props zeo, fixes #15346.
git-svn-id: https://develop.svn.wordpress.org/trunk@17014 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-17 03:32:46 +00:00
Andrew Nacin 7feeb0a320 Help text edits. props dougwrites, fixes #15346.
git-svn-id: https://develop.svn.wordpress.org/trunk@16980 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-16 06:37:03 +00:00
Mark Jaquith d65cdf4ba8 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064
git-svn-id: https://develop.svn.wordpress.org/trunk@16061 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-28 21:56:43 +00:00
Mark Jaquith d901f3af6b Duplicate Save button for nav menus at the bottom. fixes #14265. props duck_
git-svn-id: https://develop.svn.wordpress.org/trunk@15588 602fd350-edb4-49c9-b593-d223f7449a82
2010-09-07 04:40:53 +00:00
Mark Jaquith 59f6264c64 These are not verbs. http://notaverb.com/badbad_verbs
git-svn-id: https://develop.svn.wordpress.org/trunk@15473 602fd350-edb4-49c9-b593-d223f7449a82
2010-07-27 18:02:45 +00:00
Andrew Nacin bf425efae3 Don't publish the first menu to the first menu location immediately on create. Bad UX. for 3.1.
git-svn-id: https://develop.svn.wordpress.org/trunk@15430 602fd350-edb4-49c9-b593-d223f7449a82
2010-07-14 15:13:01 +00:00
Andrew Nacin bea71072af Give nav-menus.php some better include paths.
git-svn-id: https://develop.svn.wordpress.org/trunk@15361 602fd350-edb4-49c9-b593-d223f7449a82
2010-07-01 00:24:36 +00:00
Andrew Nacin 36a12c4dc3 Proper handling of menu nonsupport message. props deanjrobinson, fixes #14098 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@15334 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-26 07:12:15 +00:00
Andrew Nacin 09f7a954bf Revert [15219], [15250], some of [15249] for 3.0, revisit in 3.0.1. see #13822.
git-svn-id: https://develop.svn.wordpress.org/trunk@15254 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-14 19:52:30 +00:00
Ron Rennick 9c74b84590 hide unpublished items on frontend nav menus, props filosofo, fixes #13822
git-svn-id: https://develop.svn.wordpress.org/trunk@15219 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-11 15:34:32 +00:00
Andrew Nacin e8f7f12adf Horizontal scrolling/resizing fixes for nav menu UI. Also some RTL fixes. props koopersmith, see #13525
git-svn-id: https://develop.svn.wordpress.org/trunk@15214 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-11 05:19:36 +00:00
Andrew Nacin a53e7e3018 Switch to current_theme_supports(menus) internally. Adding theme support for 'nav-menus' is deprecated in favor of register_nav_menu(s). fixes #13825.
git-svn-id: https://develop.svn.wordpress.org/trunk@15193 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-10 17:57:30 +00:00
Andrew Nacin 5dcf82f22f Don't show an error when the theme supports widgets but not menus. see #13825.
git-svn-id: https://develop.svn.wordpress.org/trunk@15191 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-10 17:37:15 +00:00
Andrew Nacin acbc109260 Server-side check for an empty menu name on save. props ocean90, fixes #13703.
git-svn-id: https://develop.svn.wordpress.org/trunk@15189 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-10 15:28:39 +00:00
Andrew Nacin 53d3846f6a target=blank for help. props jorbin, see #13467
git-svn-id: https://develop.svn.wordpress.org/trunk@15132 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-03 21:00:39 +00:00
Ryan Boren 0922715668 Cut 'em out, move 'em on, trailing whitespace
git-svn-id: https://develop.svn.wordpress.org/trunk@15116 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-02 20:04:07 +00:00
Andrew Nacin dd5d1692b8 Clear nav menu from menu locations on delete. Additional sanity checks. fixes #13690.
git-svn-id: https://develop.svn.wordpress.org/trunk@15100 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-02 05:10:31 +00:00
Ryan Boren e69a801048 Punctuation fix. Props dougwrites. see #13467
git-svn-id: https://develop.svn.wordpress.org/trunk@15095 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-01 17:45:56 +00:00
Mark Jaquith b5cd195f68 Do not load window.onbeforeonload event if we are not on an existing nav menu. props filosofo. Reduce opacity on nav menu postboxes if we are not on an existing nav menu, and for JS users, deactivate all links and form elements, to make it obvious that those UI elements are not usable at this stage. fixes #13615
git-svn-id: https://develop.svn.wordpress.org/trunk@15062 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-29 19:39:40 +00:00
Andrew Nacin 51cc204001 Sanity check menu item parents and fix HTML issues. props filosofo, fixes #13600.
git-svn-id: https://develop.svn.wordpress.org/trunk@15049 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-28 23:04:00 +00:00
Andrew Nacin d7607a4cdd Menu touchups. see #13525.
git-svn-id: https://develop.svn.wordpress.org/trunk@15010 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-27 22:45:52 +00:00
Andrew Nacin 29ccf1ec31 New pending menu item behavior. props filosofo, see #13579.
git-svn-id: https://develop.svn.wordpress.org/trunk@15008 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-27 22:22:09 +00:00
Andrew Nacin 7679315725 Some minor IE6/7 tweaks for menus. props ocean90, see #13525.
git-svn-id: https://develop.svn.wordpress.org/trunk@14993 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-27 13:54:14 +00:00
Nikolay Bachiyski 432ac03fb2 Menu translatable strings cleanup.
* Take out <strong> of the translatable part of For more information:
 * Include support forums and Codex links inside translations, because most translators would want to change them to their local documentation sites or Codex prefixes


git-svn-id: https://develop.svn.wordpress.org/trunk@14989 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-27 11:52:15 +00:00
Andrew Nacin 9b8998cb46 Clean up the menu name/actions section. see #13525.
git-svn-id: https://develop.svn.wordpress.org/trunk@14977 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-27 04:19:23 +00:00
Andrew Nacin 9b4a85cdaf Move the "Add Home Link" functionality to a checkbox on the View All tab of the Pages metabox. Also makes it work non-JS. props filosofo, fixes #13213.
git-svn-id: https://develop.svn.wordpress.org/trunk@14971 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-27 02:24:33 +00:00
Ryan Boren 2c97921f07 Help for Appearance screens. Props duck_, jane. see #13467
git-svn-id: https://develop.svn.wordpress.org/trunk@14951 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-26 18:27:13 +00:00