Commit Graph

20951 Commits

Author SHA1 Message Date
Andrew Nacin 3f57bfeb9d Use correct variable. see #17860.
git-svn-id: https://develop.svn.wordpress.org/trunk@22689 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 21:43:47 +00:00
Lance Willett 7aa32f4ed8 Twenty Twelve: add RTL overrides for IE7 and IE8, props DrewAPicture. Closes #22044.
git-svn-id: https://develop.svn.wordpress.org/trunk@22688 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 21:41:04 +00:00
Andrew Nacin a164ab840b As wp_dropdown_roles() only prints editable roles, ensure that the
"selected" role passed into it on the user-edit screen is editable.

props johnjamesjacoby. see #22361.



git-svn-id: https://develop.svn.wordpress.org/trunk@22687 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 19:23:54 +00:00
Andrew Nacin 6a9c6e8543 Less insane multiple role handling in the users list table.
If the user has more than one role, opt to show the first role that is
'editable', if present. Otherwise, fall back to the remaining roles.

In the future, we should show a comma-separated list of all roles,
editable or otherwise, and this list should be filterable, either by user,
or by the roles which can appear. Probably both.

In multisite, only hide users that have no capabilities (in case they
possess a leftover, empty wp_xx_capabilities key from the MU days),
not users that have no role, as they may have a cap but no role.

see #22361. fixes #17860.



git-svn-id: https://develop.svn.wordpress.org/trunk@22686 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 19:16:31 +00:00
bumpbot 9d6e6d3e3f Compress scripts/styles: 3.5-beta3-22685.
git-svn-id: https://develop.svn.wordpress.org/trunk@22685 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 12:58:31 +00:00
Daryl Koopersmith 15b3c31767 Media: Add silent options to the views; improve documentation. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22684 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 12:11:16 +00:00
bumpbot b311202274 Compress scripts/styles: 3.5-beta3-22683.
git-svn-id: https://develop.svn.wordpress.org/trunk@22683 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 10:58:31 +00:00
Daryl Koopersmith aa6b7069e6 Media: Add a method to fetch the first subview. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22682 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 10:41:24 +00:00
Daryl Koopersmith 17af1e2366 Media: Add documentation to media.Views. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22681 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 10:40:49 +00:00
Andrew Nacin 1a979e637a IE sanity for the welcome panel. props lessbloat, JustinSainton. fixes #19687.
git-svn-id: https://develop.svn.wordpress.org/trunk@22680 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 09:53:31 +00:00
Andrew Nacin f5fb08658f Remove errant return. props SergeyBiryukov. see #22186.
git-svn-id: https://develop.svn.wordpress.org/trunk@22679 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 09:48:34 +00:00
bumpbot bf46cc71b5 Compress scripts/styles: 3.5-beta3-22678.
git-svn-id: https://develop.svn.wordpress.org/trunk@22678 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 08:58:31 +00:00
Andrew Nacin 870d1d05db Revert [22675]. wp_mime_type_icon() is more accurate when given a post ID, rather than a mime type. The "speed" mostly comes down to the ordering of cache hits, rather than any performance issues like #22503. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22677 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 08:44:37 +00:00
Andrew Nacin 52cc02a9be This should be a cache add, not a cache set. see #22503.
git-svn-id: https://develop.svn.wordpress.org/trunk@22676 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 08:39:52 +00:00
Andrew Nacin 68a3e80d4d wp_mime_type_icon() is faster when given a mime type, rather than a post ID. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22675 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 08:39:14 +00:00
Andrew Nacin 4cba7e30e0 Call wp_cache_set() with a group and then an expiration in wp_mime_type_icon(). fixes #22503. see #22186.
git-svn-id: https://develop.svn.wordpress.org/trunk@22674 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 08:31:43 +00:00
Andrew Nacin f4b9859903 Move code from image_attachment_fields_to_edit() to get_attachment_fields_to_edit(). The level of abstraction is unnecessary, and it makes it more difficult to call only the filter in the new media modal. Also, that function is sloooow. see #22186.
git-svn-id: https://develop.svn.wordpress.org/trunk@22673 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 08:10:38 +00:00
Daryl Koopersmith ae2f322e25 Media: Insert each attachment into the editor individually.
This allows the `wpeditimage` plugin to correctly identify `caption` shortcodes.

fixes #22459, see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22672 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 07:30:53 +00:00
Daryl Koopersmith 893c538066 Media: Only show the alignment setting when viewing an image. fixes #21836, see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22671 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 07:24:47 +00:00
Andrew Nacin 4d0670723d Avoid doing all of the extra work in get_attachment_fields_to_edit() for fields we will just discard. We just need the filter, and the taxonomies. see #22186.
git-svn-id: https://develop.svn.wordpress.org/trunk@22670 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 07:20:47 +00:00
Andrew Nacin a3023b8483 In get_custom_header(), support a default header that is registered using default-image but not register_default_headers(). fixes #22221.
git-svn-id: https://develop.svn.wordpress.org/trunk@22669 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 06:59:25 +00:00
bumpbot 94b4a602af Compress scripts/styles: 3.5-beta3-22668.
git-svn-id: https://develop.svn.wordpress.org/trunk@22668 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 06:58:29 +00:00
Daryl Koopersmith 1fb6abded8 Media: Properly display selected featured image data if the featured image is not in the first section of the library. see #22494, #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22667 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 06:56:54 +00:00
Daryl Koopersmith 1b42cd449c Media: Use correct variable name. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22666 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 06:43:01 +00:00
Daryl Koopersmith 395fd933c9 Media: Blur the "Add Images" button when the media modal is opened. fixes #22445, see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22665 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 06:34:41 +00:00
Andrew Nacin de15d6636a Add manual new lines to a string, as double quotes with \n is not optimal due to sprintf-parsing reasons. props SergeyBiryukov, fixes #22486. see #22260.
git-svn-id: https://develop.svn.wordpress.org/trunk@22664 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 06:11:42 +00:00
Andrew Nacin f01d10e9ac Re-enable a .wp-upload-form submit button whenever any file input in that form has a file selected, to minimize the potential for issues. props kovshenin. fixes #20855. see [22459].
git-svn-id: https://develop.svn.wordpress.org/trunk@22663 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 06:07:04 +00:00
Daryl Koopersmith 16ef935110 Media: Add default render method to views.
* Use default `render` method in the `Frame` view.
* Rename `Views.attach` to `Views.insert`.
* Add `Views.all` to retrieve all subviews.
* Add `Views.detach` to detach all subviews.
* Detect whether views are going to be reused in `View.set` and `detach` them instead of calling `dispose`.

see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22662 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 06:02:00 +00:00
bumpbot 7de47b2867 Compress scripts/styles: 3.5-beta3-22661.
git-svn-id: https://develop.svn.wordpress.org/trunk@22661 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 04:58:32 +00:00
Daryl Koopersmith 54f70dec05 Media: Allow subviews to be inserted at a specific index. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22660 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 04:41:57 +00:00
Daryl Koopersmith 46da78b32e Media: Convert the attachments browser view's destroy method to the newer dispose method. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22659 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 03:33:29 +00:00
Daryl Koopersmith 2411401f1b Media: Remove unused batch edit states and strings. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22658 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 03:11:48 +00:00
bumpbot eda9828244 Compress scripts/styles: 3.5-beta3-22657. TinyMCE updated.
git-svn-id: https://develop.svn.wordpress.org/trunk@22657 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 02:58:28 +00:00
Daryl Koopersmith 47b883764e Media: Remove debug cruft from [22655]. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22656 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 02:44:34 +00:00
Daryl Koopersmith 5b426eac50 Media: Optimize media models.
* Merge `Composite` model with general `Attachments` model, as `Attachments.validate` and `Composite.evaluate` were functionally equivalent.
* Queries should only watch `wp.Uploader.queue`, as watching `Attachments.all` results in queries attempting to add attachments before their properties are set (which then results a few too many irrelevant adds/removes). `Attachments.all` should potentially be removed or rethought.

see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22655 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 02:43:10 +00:00
Daryl Koopersmith 5c2e5e3231 Media: Remove redundant sorting logic from composite models. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22654 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 02:00:01 +00:00
Andrew Nacin 34985fbc7a Revert page on front changes. Reverts [22127] [22129] [22135] [22136]. see #16379.
git-svn-id: https://develop.svn.wordpress.org/trunk@22653 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 01:28:32 +00:00
Daryl Koopersmith f2d2f6bb45 Media: Make TinyMCE attachment and gallery controls always show when the corresponding view is selected. props SergeyBiryukov. fixes #22463, see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22652 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 01:23:45 +00:00
Daryl Koopersmith 646c90861f Media: Move Attachments view preventDefault handler to the events object. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22651 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 01:17:30 +00:00
bumpbot 930790f78c Compress scripts/styles: 3.5-beta3-22650.
git-svn-id: https://develop.svn.wordpress.org/trunk@22650 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 00:58:49 +00:00
Daryl Koopersmith c5ee034c29 Media: Allow for the views manager to be extended. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22649 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 00:54:18 +00:00
Daryl Koopersmith 101c5a5371 Media: Add a base view class.
* Centralizes view and subview management, unifying several disjointed constructs.
* Utilizes the `dispose` functionality found in Backbone master, providing a standard method for memory management.

see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22648 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 00:36:47 +00:00
Andrew Nacin d25a4e9795 Blue admin color scheme fixes. Fix admin menu styling. props melchoyce, helenyhou. fixes #22248.
git-svn-id: https://develop.svn.wordpress.org/trunk@22647 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-18 23:49:54 +00:00
Andrew Nacin 7122ba3414 Fix QuickPress submission spinner. props ocean90. fixes #22496.
git-svn-id: https://develop.svn.wordpress.org/trunk@22646 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-18 23:46:01 +00:00
bumpbot 8edc223912 Compress scripts/styles: 3.5-beta3-22645. TinyMCE updated.
git-svn-id: https://develop.svn.wordpress.org/trunk@22645 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-18 18:58:32 +00:00
Andrew Ozz 37a39cbefa TinyMCE: place the caret after/under images with captions when inserting content, fixes #19389
git-svn-id: https://develop.svn.wordpress.org/trunk@22644 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-18 18:04:20 +00:00
Andrew Ozz b706fe2780 RTL: remove unneeded toolbar border-right, props ocean90, see #22453
git-svn-id: https://develop.svn.wordpress.org/trunk@22643 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-18 17:59:27 +00:00
bumpbot 70f7d88916 Compress scripts/styles: 3.5-beta3-22642.
git-svn-id: https://develop.svn.wordpress.org/trunk@22642 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-18 16:58:30 +00:00
Andrew Ozz ae6db5cab0 RTL: fix styling of Skip To links, see #22453
git-svn-id: https://develop.svn.wordpress.org/trunk@22641 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-18 16:49:17 +00:00
Andrew Ozz 805c464c27 RTL fixes and improvements: add-media, image-editor, the spinners, the featured image button, some css cleanup, props ocean90, maor, SergeyBiryukov, ramiy, see #22453
git-svn-id: https://develop.svn.wordpress.org/trunk@22640 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-18 16:19:37 +00:00