Commit Graph

34022 Commits

Author SHA1 Message Date
Mark Jaquith
9deec9e723 REST API: Deliver parameters unadulterated instead of slashed.
We goofed, and parameters accessed through the REST API's methods
were slashed (inconsistently, even). This unslashes the data, so
you get the un-messed-with data that was sent.

Props joehoyle.
Fixes #36419.

git-svn-id: https://develop.svn.wordpress.org/trunk@37163 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-06 21:01:11 +00:00
Dominik Schilling (ocean90)
28699803ee I18N: On the Updates screen simplify plugin's version details link.
Replace the use of a `.screen-reader-text` element with an `aria-label` attribute to make the text easier to translate.

Props dimadin, ocean90.
See #35001.
Fixes #36410.

git-svn-id: https://develop.svn.wordpress.org/trunk@37162 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-06 12:51:57 +00:00
Aaron Jorbin
2b5f172b57 Make Moderate Comment Screen Great Again by showing links
You know what's wrong with the Moderate Comment Screen? It doesn't win anymore. Well, I'm going make the Moderate Comment screen win. It's going to win by showing the urls that are linked to from every anchor. It's going to win by having those urls be a lighter shade of gray than the surrounding text. Spammy links aren't going to be able to hide in commas. Spammy links aren't going to win.  The Moderate Comment Screen is going to win and we are going to make the Moderate Comment Screen Great Again.

Fixes #36380
Props rachelbaker, mikeschroder, adamsilverstein, boonebgorges, melchoyce, ocean90, jorbin, pento


git-svn-id: https://develop.svn.wordpress.org/trunk@37161 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-06 00:34:23 +00:00
Andrea Fercia
68a8211a55 Accessibility: improvements for the Editor wpLink modal form fields.
Adds `aria-describedby` attributes to the modal form fields after it
was partly restored in [37154].

Fixes #33301.

git-svn-id: https://develop.svn.wordpress.org/trunk@37160 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-05 22:23:23 +00:00
Dominik Schilling (ocean90)
d9212519fa Editor: Remove trailing space from a help text string.
Props dimadin.
Fixes #36407.

git-svn-id: https://develop.svn.wordpress.org/trunk@37159 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-05 10:53:15 +00:00
John Blackbourn
2d95d4187d Comments: Wrap the formatted comment text on the comment moderation screen in comment_text() so paragraphs and texturisation are applied.
Fixes #34133


git-svn-id: https://develop.svn.wordpress.org/trunk@37158 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-04 23:32:15 +00:00
John Blackbourn
6c79b715bd Role/Capability: Add create_sites and delete_sites to the list of capabilities that are checked as part of the comporehensive roles and capabilities tests.
See #32394, #36413


git-svn-id: https://develop.svn.wordpress.org/trunk@37157 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-04 22:29:55 +00:00
Dominik Schilling (ocean90)
7ef7a98dd1 Plugins: Use correct placeholder for the number of reviews.
`number_format_i18n()` returns a string, not an integer.

See #35111.
Fixes #36395.

git-svn-id: https://develop.svn.wordpress.org/trunk@37156 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-02 11:16:32 +00:00
Dominik Schilling (ocean90)
6bf0509046 I18N: Clarify translator comment for an a11y label added in [36618].
Props TacoVerdo.
See #35111.
Fixes #36396.

git-svn-id: https://develop.svn.wordpress.org/trunk@37155 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-02 11:11:52 +00:00
Andrew Ozz
bd800fbca4 Editor, wpLink:
- Restore the bottom half of the modal.
- Make it always expanded and remove the toggle. It is used as advanced link options now, no need to have simple mode.

Props iseulde, adamsilverstein, azaozz.
Fixes #36359.

git-svn-id: https://develop.svn.wordpress.org/trunk@37154 602fd350-edb4-49c9-b593-d223f7449a82
2016-04-01 21:12:18 +00:00
Weston Ruter
cfd07d69cf Customize: Fix toggle of title attribute field visibility on nav menus admin page.
Improves alignment with nav menus in the Customizer, fixing regression introduced in [36908].

See #35273.
Props sidati, westonruter.
Fixes #36353.


git-svn-id: https://develop.svn.wordpress.org/trunk@37153 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 21:54:45 +00:00
Weston Ruter
0bc533e10b Customize: Put focus on change button instead of remove button in media control.
Allow controls to specify the primary element to receive focus by adding a `control-focus` class.

Props adamsilverstein, westonruter.
Fixes #36337.


git-svn-id: https://develop.svn.wordpress.org/trunk@37152 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 21:40:43 +00:00
Aaron Jorbin
253308253b Adjust unit tests to account for change in [37144]
git-svn-id: https://develop.svn.wordpress.org/trunk@37150 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 19:52:14 +00:00
Aaron Jorbin
565ac1efc6 Remove Debugging code introduced in [37145]
git-svn-id: https://develop.svn.wordpress.org/trunk@37148 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 18:57:26 +00:00
Aaron Jorbin
bd0c3bf0c7 Add Nonce to updating wporg_favorites user meta field
git-svn-id: https://develop.svn.wordpress.org/trunk@37145 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 18:35:37 +00:00
Nikolay Bachiyski
f1680acb86 Add nonce to AJAX action for script compression setting
git-svn-id: https://develop.svn.wordpress.org/trunk@37143 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 18:20:31 +00:00
Konstantin Obenland
ef53a0db39 Template: Remove $size reference from get_custom_logo().
Argument was removed in [37077] in favor of `with` and `height` arguments.

Props ocean90.
Fixes #36327.



git-svn-id: https://develop.svn.wordpress.org/trunk@37135 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 17:19:41 +00:00
Nikolay Bachiyski
c1c0759ab0 Taxonomies: make sure taxonomy functions work correctly with taxonomy names with special characters
The codex says that taxonomy names "should only contain lowercase letters and the underscore character", but that's not enforced. It's too late to enforce it, since some plugins haven't been following it and the official phpdoc doesn't mention this restriction.


git-svn-id: https://develop.svn.wordpress.org/trunk@37133 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 17:12:08 +00:00
Jeremy Felt
914df85ab4 Multisite: Improve escaping in network settings.
git-svn-id: https://develop.svn.wordpress.org/trunk@37124 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 15:58:29 +00:00
Dominik Schilling (ocean90)
826b822214 HTTP: Improve detection of valid IP addresses.
git-svn-id: https://develop.svn.wordpress.org/trunk@37115 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 15:37:26 +00:00
Drew Jaynes
14d4060c4e Docs: Ignore _wp_upload_dir_baseurl() from parsing for the Code Reference.
See #36371.


git-svn-id: https://develop.svn.wordpress.org/trunk@37114 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 15:28:17 +00:00
Konstantin Obenland
783102fcdc Customize: Respect aspect ratio on cropped images.
Takes into account whether the control supports `flex_width` and/or
`flex_height` and adjusts destination measurements accordingly.

Fixes #36318.



git-svn-id: https://develop.svn.wordpress.org/trunk@37113 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 15:13:34 +00:00
Andrew Ozz
0e99aea684 Add deprecated notice and removal warning to _wp_upload_dir_baseurl().
Props DrewAPicture, azaozz.
Fixes #36371.

git-svn-id: https://develop.svn.wordpress.org/trunk@37112 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 15:09:16 +00:00
Dominik Schilling (ocean90)
7987d26847 Multisite: Validate new email address confirmations.
git-svn-id: https://develop.svn.wordpress.org/trunk@37103 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 14:44:00 +00:00
Nikolay Bachiyski
8d55453ef4 Snoopy: use escapeshellarg instead of escapeshellcmd
We are escaping arguments, not commands, so we'd better use the semantically correct function, even though they are similar.


git-svn-id: https://develop.svn.wordpress.org/trunk@37094 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 13:57:40 +00:00
Aaron Jorbin
f531959fa2 Prevent PHP Warnings when using Custom Logo with no params
The parsing of defaults assumes that $args will be an array. This solves it for Custom Logo the same way it is solved for custom-header and custom-background.

Props obenland.
Fixes #36332.



git-svn-id: https://develop.svn.wordpress.org/trunk@37092 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-30 02:21:57 +00:00
Dominik Schilling (ocean90)
0a9951a3b9 Editor: Make the tooltip for the 'apply' button in the inline link dialog translatable.
Props SergeyBiryukov.
Fixes #36366.

git-svn-id: https://develop.svn.wordpress.org/trunk@37091 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-29 21:10:39 +00:00
Drew Jaynes
0a5885ce3c Docs: Standardize file headers for two embed templates introduced in [36693] for #34561.
Props flixos90.
Also missed props for flixos90 on [37087].

See #35986. See #36352.


git-svn-id: https://develop.svn.wordpress.org/trunk@37088 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-28 18:26:43 +00:00
Drew Jaynes
b26e3d0508 Docs: Reference the correct embed templates and template parts filenames in headers for embed files introduced or changed in 4.5.
See [36693], #34561. See #35986. Fixes #36352.


git-svn-id: https://develop.svn.wordpress.org/trunk@37087 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-28 18:23:53 +00:00
Drew Jaynes
b7e91e1dcc Docs: Following [37085], properly indent the markdown-formatted examples in the DocBlock for wpdb::esc_like().
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@37086 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-27 18:26:33 +00:00
Drew Jaynes
2ac50341ab Docs: Add missing quotes around a specifier in a query example in the DocBlock for wpdb::esc_like().
Props madvic.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@37085 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-27 18:24:45 +00:00
Pascal Birchler
b4c43b0005 Taxonomy: After [36874], run the correct load-edit-tags.php hook on the new term edit page.
When not misspelled, this hook is useful (and needed) for backward compatibility.

Unprops swissspidy.
Fixes #34988.

git-svn-id: https://develop.svn.wordpress.org/trunk@37084 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-27 15:15:48 +00:00
Drew Jaynes
0b6af900f1 Docs: Improve the DocBlocks for get_header_textcolor() and header_textcolor() to mention that they both retrieve color values in the HEX format.
Props theMikeD.
Fixes #36336.


git-svn-id: https://develop.svn.wordpress.org/trunk@37083 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-25 23:05:42 +00:00
Ella Iseulde Van Dorpe
859d40bd24 Editor: wptextpattern: add back inline tests
See [37024].
See #33300.


git-svn-id: https://develop.svn.wordpress.org/trunk@37080 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-25 13:30:10 +00:00
Mike Schroder
ea2590a6c4 Post 4.5-RC1 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@37079 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-24 03:58:00 +00:00
Mike Schroder
895b213e62 4.5-RC1
git-svn-id: https://develop.svn.wordpress.org/trunk@37078 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-24 03:31:51 +00:00
Konstantin Obenland
c35484581d Customize: Bring custom-logo args closer to custom-header.
Allows themes to specify the desired width and height of logos, and whether
that is flexible or not. Has the benefit of not having to generate a logo-sized
file for every image uploaded.

Props westonruter, celloexpressions.
Fixes #36255.



git-svn-id: https://develop.svn.wordpress.org/trunk@37077 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-24 02:01:50 +00:00
Ella Iseulde Van Dorpe
e6b5f3316f Update TinyMCE and jQuery UI button styles
Part props liljimmi.
Fixes #35571.



git-svn-id: https://develop.svn.wordpress.org/trunk@37076 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-24 00:56:14 +00:00
Sergey Biryukov
0058968499 Canonical / Query: Restore the is_404() check in wp_old_slug_redirect() which was removed in [34659].
This reverts part of [34659] due to excessive canonical problems it's caused in 4.4.x.

Remove the unit tests which are no longer supported.
This also removes the `is_feed()` code to avoid confusion - only pages & embeds will be redirected.

Merges [36280] and [36281] to trunk.

Props dd32.
See #21602, #35344.

git-svn-id: https://develop.svn.wordpress.org/trunk@37075 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 21:53:44 +00:00
Andrew Ozz
9f03a3bd5e TinyMCE: include the upstream fix for inserting <hr> while the caret is in an inline element: b1618d1adb.
Fixes #36165.

git-svn-id: https://develop.svn.wordpress.org/trunk@37074 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 21:44:05 +00:00
Dominik Schilling (ocean90)
f903fb5160 Common CSS: Reset bottom padding for .nav-tab-wrapper.
Props ericdaams.
Fixes #35960.

git-svn-id: https://develop.svn.wordpress.org/trunk@37073 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 20:13:57 +00:00
Dominik Schilling (ocean90)
4727f60c15 External Libraries: Update jQuery Migrate to 1.4.0.
Changes: https://github.com/jquery/jquery-migrate/compare/1.3.0...1.4.0

Fixes #35380.

git-svn-id: https://develop.svn.wordpress.org/trunk@37072 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 19:43:17 +00:00
Boone Gorges
8e317daa37 Tests: Ensure that the default wp_die() handler can handle a WP_Error object.
Props dd32, utkarshpatel.
Fixes #36166.

git-svn-id: https://develop.svn.wordpress.org/trunk@37071 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 19:00:38 +00:00
Dominik Schilling (ocean90)
703bd5f97f External Libraries: Update jQuery to 1.12.2.
Release post: http://blog.jquery.com/2016/03/17/jquery-1-12-2-and-2-2-2-released/
Changelog: https://github.com/jquery/jquery/compare/1.12.1...1.12.2

See #35380.

git-svn-id: https://develop.svn.wordpress.org/trunk@37070 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 18:46:19 +00:00
Drew Jaynes
979d8931d3 Docs: Properly mark $args parameters in two WP_oEmbed methods as optional.
Also clarify that the `$args` parameters can accept a string (the default) in addition to an array.

Props ramiy.
See #36296.


git-svn-id: https://develop.svn.wordpress.org/trunk@37069 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 17:07:58 +00:00
Drew Jaynes
79150b2561 Docs: Use third-person singular verbs for summary DocBlocks in WP_oEmbed.
Also fixes inline `@see` formatting in appropriate places (summaries should not contain tags or markdown).

Props ramiy.
See #36296.


git-svn-id: https://develop.svn.wordpress.org/trunk@37068 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 16:57:08 +00:00
Drew Jaynes
d793244e3c Docs: Improve and add missing DocBlocks for methods and properties in WP_oEmbed.
Props ramiy.
See #36296.


git-svn-id: https://develop.svn.wordpress.org/trunk@37067 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 16:51:48 +00:00
Weston Ruter
b5cd3f862c Customize: Replace site logo with custom logo terminology, fixing failure to preview logo changes.
Fixes regression introduced in [37040] which was from a patch that did not include the terminology change. 

See #36255.
Fixes #35855.


git-svn-id: https://develop.svn.wordpress.org/trunk@37066 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 06:26:00 +00:00
Drew Jaynes
1395ff6db4 Docs: Improve inline documentation syntax throughout WP_Widget.
Fixes #36298.


git-svn-id: https://develop.svn.wordpress.org/trunk@37065 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 05:31:31 +00:00
Drew Jaynes
43dfcc5fa8 Docs: Add missing information to the WP_Widget PHP4 constructor DocBlock.
Also add several missing at `@access` tags to other method DocBlocks and clarify parameter docs for `WP_Widget::form_callback()`.

Props raimy.
See #36298.


git-svn-id: https://develop.svn.wordpress.org/trunk@37064 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-23 05:09:48 +00:00