Commit Graph

11414 Commits

Author SHA1 Message Date
Sergey Biryukov
9defec712a Properly truncate UTF-8 post slugs in wp_unique_post_slug(). fixes #21013.
git-svn-id: https://develop.svn.wordpress.org/trunk@23420 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-15 14:35:41 +00:00
bumpbot
2d34b9a876 Compress scripts/styles: 3.6-alpha-23417.
git-svn-id: https://develop.svn.wordpress.org/trunk@23418 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:58:42 +00:00
Mark Jaquith
bfd0b6fb37 Refactor the Customizer accordion so that it can be used in other locations.
fixes #23449. props lessbloat, aaroncampbell

git-svn-id: https://develop.svn.wordpress.org/trunk@23417 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:58:04 +00:00
Ryan Boren
a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Peter Westwood
4ca366a0d1 Revisions: Allow a plugin to force us to skip the don't save this revision because it hasn't changed code if it knows better.
See #7392 and #9843. Also cleans up the whitespace.


git-svn-id: https://develop.svn.wordpress.org/trunk@23415 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 16:45:43 +00:00
Peter Westwood
671a9b2017 Revisions: Before saving a new post revision make sure that something has changed in the fields that we are revisioning.
Fixes: #7392 and #9843 props adamsilverstein.


git-svn-id: https://develop.svn.wordpress.org/trunk@23414 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 11:36:32 +00:00
Sergey Biryukov
16e16c7ee4 Use correct escaping function. fixes #23334.
git-svn-id: https://develop.svn.wordpress.org/trunk@23413 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 05:52:23 +00:00
Sergey Biryukov
74f5d9dcb3 Remove unused error string. props pavelevap. fixes #22107.
git-svn-id: https://develop.svn.wordpress.org/trunk@23412 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 05:36:28 +00:00
Sergey Biryukov
142c4ee92b Use correct escaping function. props jkudish. fixes #20771.
git-svn-id: https://develop.svn.wordpress.org/trunk@23411 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 05:12:23 +00:00
Sergey Biryukov
04778f60ac Return from image_downsize() earlier if a custom resize function is used. props anatolbroder. fixes #23392.
git-svn-id: https://develop.svn.wordpress.org/trunk@23410 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 04:30:55 +00:00
bumpbot
6b63e085ef Compress scripts/styles: 3.6-alpha-23408.
git-svn-id: https://develop.svn.wordpress.org/trunk@23408 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-13 22:58:44 +00:00
Helen Hou-Sandi
4b2173708d Begin simplifying some of the visual elements in the admin, starting with gradients. White space purposefully not currently altered. props lessbloat, melchoyce, aaroncampbell, sabreuse. see #23415.
git-svn-id: https://develop.svn.wordpress.org/trunk@23407 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-13 22:43:48 +00:00
bumpbot
42926ca699 Compress scripts/styles: 3.6-alpha-23403. TinyMCE updated.
git-svn-id: https://develop.svn.wordpress.org/trunk@23403 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-12 22:58:43 +00:00
Andrew Ozz
6d0ee4dc7d TinyMCE: include cd84a63d4a to fix backspace and line breaks issues in WebKit, see #23337
git-svn-id: https://develop.svn.wordpress.org/trunk@23402 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-12 02:04:09 +00:00
Ryan Boren
77e5536195 Use microtime() instead of incrementors for last_changed to to avoid race conditions with cache evictions.
Props westi
fixes #23448


git-svn-id: https://develop.svn.wordpress.org/trunk@23401 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-11 18:08:14 +00:00
bumpbot
679339ffaa Compress scripts/styles: 3.6-alpha-23400.
git-svn-id: https://develop.svn.wordpress.org/trunk@23400 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-08 22:58:42 +00:00
Mark Jaquith
9f02654b0d Introduce wp_remove_object_terms() and wp_add_object_terms(). No more fetch-alter-update nonsense. Use wp_remove_object_terms() in a few places internally.
props simonwheatley, scribu, ericmann, maxcutler. fixes #15475

git-svn-id: https://develop.svn.wordpress.org/trunk@23398 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-08 18:45:34 +00:00
Helen Hou-Sandi
efda431bc2 Open external links to plugin homepages, plugin author homepages, and theme author homepages in a new window/tab. props SergeyBiryukov. fixes #20839.
git-svn-id: https://develop.svn.wordpress.org/trunk@23394 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-08 16:20:01 +00:00
Andrew Nacin
5dd8a15b26 Add underscore and backbone to the do-not-deregister list of scripts.
props adamsilverstein.
see [23378]. see #22896.



git-svn-id: https://develop.svn.wordpress.org/trunk@23391 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-08 05:11:27 +00:00
Mark Jaquith
e3a1266c0c Revert [23375] until we can get Media fixed to work with newer versions of Backbone. see #23262
git-svn-id: https://develop.svn.wordpress.org/trunk@23390 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-08 03:15:22 +00:00
Andrew Ozz
b38675a65a Heartbeat API: fix error in IE < 9, props SergeyBiryukov, don't attempt to bind events to cross-domain iframes, see #23216
git-svn-id: https://develop.svn.wordpress.org/trunk@23389 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-06 07:10:04 +00:00
Sergey Biryukov
12fcb94781 Use a human-readable constant in wp_set_auth_cookie(). fixes #23372.
git-svn-id: https://develop.svn.wordpress.org/trunk@23388 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-06 03:44:43 +00:00
Sergey Biryukov
163f0a4769 Correct the documentation for _publish_post_hook(). Remove unused global declaration. props roulandf. fixes #23376.
git-svn-id: https://develop.svn.wordpress.org/trunk@23387 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-05 15:45:37 +00:00
bumpbot
68360b40ab Compress scripts/styles: 3.6-alpha-23386.
git-svn-id: https://develop.svn.wordpress.org/trunk@23386 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-04 14:38:03 +00:00
Ryan Boren
51e5049575 In wp_get_archives(), cache queries to individual cache buckets instead of storing them in one cached array. Use incrementor style passive cache invalidation.
fixes #23206
see #23173


git-svn-id: https://develop.svn.wordpress.org/trunk@23385 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-04 13:54:15 +00:00
Ryan Boren
8b07ad9884 Use incrementors for cache invalidation in get_terms().
fixes #23326
see #23173


git-svn-id: https://develop.svn.wordpress.org/trunk@23384 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-04 13:48:46 +00:00
Mark Jaquith
bd80d92a89 Update Underscore to version 1.4.4. see #23262
git-svn-id: https://develop.svn.wordpress.org/trunk@23383 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-04 06:40:21 +00:00
Andrew Ozz
682b66b560 Heartbeat API: throttle down when the window looses focus or when the user is inactive, always send 'screen_id', change the interval settings to 'fast' (5sec), 'standard' (15sec) and 'slow' (60sec), the interval can be changed from PHP, see #23216
git-svn-id: https://develop.svn.wordpress.org/trunk@23382 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-03 07:03:27 +00:00
Sergey Biryukov
795ea73568 Mark the string for translation. see #22896.
git-svn-id: https://develop.svn.wordpress.org/trunk@23379 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-02 03:42:10 +00:00
Andrew Nacin
ca3bfb34f9 Do not allow accidental or negligent deregistering of critical scripts in the admin. (Defined for now as jQuery and jQuery UI.) Show minimal remorse if the correct hook is used. see #22896.
git-svn-id: https://develop.svn.wordpress.org/trunk@23378 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-02 03:01:20 +00:00
Andrew Nacin
2b1d2bfa78 Stop recommending the init hook in the _doing_it_wrong() message for too-early scripts and styles. Instead, recommend the three _enqueue_scripts hooks. If they're noticing they are doing it wrong, let's push them to 100% correct, not partly correct.
see #22896.



git-svn-id: https://develop.svn.wordpress.org/trunk@23377 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-02 02:42:09 +00:00
Andrew Nacin
d5de4a9bbd Update to Services_JSON 1.0.3. props bpetty. fixes #21568.
git-svn-id: https://develop.svn.wordpress.org/trunk@23376 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-02 02:09:01 +00:00
Andrew Nacin
faa884032e Update Backbone.js to 0.9.10. props aaronholbrook, fixes #23262.
git-svn-id: https://develop.svn.wordpress.org/trunk@23375 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-02 02:02:53 +00:00
Andrew Nacin
2604bfffbf Ensure we have a charset before calling mb_internal_encoding(), avoiding an unnecessary (if suppressed) warning. props dfavor. fixes #23093.
git-svn-id: https://develop.svn.wordpress.org/trunk@23373 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-02 02:01:29 +00:00
Sergey Biryukov
ce72d762f8 Correct the documentation for balanceTags(). Remove unnecessary boolean inversion. props TobiasBg. fixes #22537.
git-svn-id: https://develop.svn.wordpress.org/trunk@23368 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-01 22:20:06 +00:00
Sergey Biryukov
35453dc623 Properly check if the custom header/background has been initialized. fixes #23170. see #22246.
git-svn-id: https://develop.svn.wordpress.org/trunk@23367 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-01 20:33:27 +00:00
Sergey Biryukov
78b83d3fc1 PHPDoc fixes and additions. props bananastalktome, DrewAPicture. fixes #23313.
git-svn-id: https://develop.svn.wordpress.org/trunk@23365 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-01 18:07:08 +00:00
Sergey Biryukov
d4f8fff530 Merge two different descriptions of siteurl and home options. fixes #22771.
git-svn-id: https://develop.svn.wordpress.org/trunk@23363 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-01 01:35:37 +00:00
Sergey Biryukov
98cbf77a95 Use digraphs for German umlauts in remove_accents(). props SergeyBiryukov, ocean90. fixes #3782.
git-svn-id: https://develop.svn.wordpress.org/trunk@23361 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-31 01:55:09 +00:00
Sergey Biryukov
2b5a4c5596 Display username (user_login) rather than user_nicename in Toolbar. fixes #22121.
git-svn-id: https://develop.svn.wordpress.org/trunk@23360 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-31 01:39:08 +00:00
Sergey Biryukov
5948d92355 Cast post_author to string in XML-RPC methods. props markoheijnen. fixes #22324.
git-svn-id: https://develop.svn.wordpress.org/trunk@23359 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-31 01:25:26 +00:00
Sergey Biryukov
78b69ff012 Pass old roles to set_user_role action. props awellis13. fixes #19134.
git-svn-id: https://develop.svn.wordpress.org/trunk@23358 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-31 01:15:25 +00:00
Sergey Biryukov
633d1902b5 Avoid 'Only variables should be passed by reference' warning. fixes #23232.
git-svn-id: https://develop.svn.wordpress.org/trunk@23357 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-31 01:01:19 +00:00
Andrew Ozz
23ef0e4e0b Remove BOM from jquery.query.js, fixes #23315
git-svn-id: https://develop.svn.wordpress.org/trunk@23356 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-29 20:52:32 +00:00
Andrew Ozz
5edc6b2711 Heartbeat API: first run, see #23216
git-svn-id: https://develop.svn.wordpress.org/trunk@23355 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-29 06:15:25 +00:00
Sergey Biryukov
9a00a0dcce Sanitize post_author and comment_count as integer fields. props GeertDD. fixes #22324.
git-svn-id: https://develop.svn.wordpress.org/trunk@23353 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-28 04:17:05 +00:00
Sergey Biryukov
3870e8f25c Make sure the array exists before adding an element to it. props rodrigosprimo. fixes #23272.
git-svn-id: https://develop.svn.wordpress.org/trunk@23346 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-25 12:24:10 +00:00
Andrew Nacin
44a1c8b227 Use correct cache bucket. Fixes copy-paste error in r23320. props kurtpayne. see #23167.
git-svn-id: https://develop.svn.wordpress.org/trunk@23341 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-24 17:21:55 +00:00
Andrew Ozz
995de61c9d Update Plupload to 1.5.5, fixes #23277 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@23339 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-23 20:54:42 +00:00
bumpbot
5d2f7a3a4d Compress scripts/styles: 3.6-alpha-23334. TinyMCE updated.
git-svn-id: https://develop.svn.wordpress.org/trunk@23334 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-22 22:57:24 +00:00