Commit Graph

42360 Commits

Author SHA1 Message Date
Sergey Biryukov
d3614d49fe Administration: Don't override the $mode global in WP_Screen::render_view_mode() if it's already set.
Follow-up to [48398], [48423], [48424], [48450].

See #49715.

git-svn-id: https://develop.svn.wordpress.org/trunk@48670 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 16:53:03 +00:00
Jake Spurlock
af4127ab84 Upgrade/Install: Enhance auto-updates to be disabled for plugins that don't suport updates.
This removes the toggle UI when updates aren't available. When plugins use the filter, the UI is updated to show that they are being controlled via code. And then removed entirely when not available.

See #50798.
Fixes #50280.

Props elrae, pbiron, SergeyBiryukov, audrasjb, azaozz, StephenCronin, whyisjake, dd32, TimothyBlynJacobs, desrosj.



git-svn-id: https://develop.svn.wordpress.org/trunk@48669 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 16:30:48 +00:00
Sergey Biryukov
828d287cab Administration: Pull the table_view_mode filter for now.
The extensibility of list table view modes will be explored in a future release.

Props audrasjb.
See #49715.

git-svn-id: https://develop.svn.wordpress.org/trunk@48668 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 16:17:13 +00:00
Sergey Biryukov
18f5561dfd Upgrade/Install: Disable the plugin/theme auto-updates UI if AUTOMATIC_UPDATER_DISABLED is defined and set as true.
Props pbiron, dd32.
Fixes #50798. See #50280.

git-svn-id: https://develop.svn.wordpress.org/trunk@48667 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 16:13:03 +00:00
Sergey Biryukov
9636a9d4d7 Upgrade/Install: Check WordPress and PHP version requirements when uploading a plugin or theme from ZIP file.
Props mariovalney, desrosj.
See #50593.

git-svn-id: https://develop.svn.wordpress.org/trunk@48666 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 16:05:39 +00:00
Sergey Biryukov
cded42aa94 Taxonomy: Rename the default_taxonomy_$taxonomy option key to default_term_$taxonomy.
This better reflects the purpose of the option.

Follow-up to [48356], [48480].

See #43517.

git-svn-id: https://develop.svn.wordpress.org/trunk@48665 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 15:40:35 +00:00
Sergey Biryukov
2547c15fee Coding Standards: Reformat a condifion for default taxonomy terms in map_meta_cap() for better readability.
Follow-up to [48356], [48480].

See #43517.

git-svn-id: https://develop.svn.wordpress.org/trunk@48664 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 14:40:06 +00:00
Sergey Biryukov
6e66f08ec9 Taxonomy: Ensure the child_of argument of get_terms() works as expected with 'fields' => 'id=>name' or 'id=>slug'.
Props Howdy_McGee, deepaklalwani, planvova.
Fixes #46768.

git-svn-id: https://develop.svn.wordpress.org/trunk@48663 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 14:21:54 +00:00
Sergey Biryukov
faa6036d08 Bootstrap/Load: Remove the wp_environment_type and wp_get_environment_type filters.
Since `wp_get_environment_type()` runs too early for plugins to hook these filters, and the result is then cached in a static variable and cannot be changed later, the filters are not that useful.

The `WP_ENVIRONMENT_TYPES` and `WP_ENVIRONMENT_TYPE` constants and environment variables should be enough for now.

Follow-up to [47919], [48188], [48372].

Props Clorith, SergeyBiryukov.
Fixes #33161.

git-svn-id: https://develop.svn.wordpress.org/trunk@48662 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 12:08:41 +00:00
Sergey Biryukov
ae65f096b0 Docs: Add missing documentation for various upgrade/install class properties and methods.
Props ramiy.
Fixes #42923.

git-svn-id: https://develop.svn.wordpress.org/trunk@48661 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 11:55:19 +00:00
Sergey Biryukov
deb78bdf1c Themes: Display a message on Themes list table if a theme update requires a higher version of PHP or WordPress.
This applies to the Themes screen in Multisite network admin.

Props afragen, SergeyBiryukov.
Fixes #48507. See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48660 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 11:32:53 +00:00
Sergey Biryukov
d67c469b0d Themes: Include theme name in available update messages, for better accessibility and consistency with other similar messages.
Follow-up to [48652-48654].

See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48659 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 11:29:28 +00:00
Sergey Biryukov
b7a5c75686 Docs: Document that various metadata functions return false for an invalid ID.
Props salcode.
See #40519.

git-svn-id: https://develop.svn.wordpress.org/trunk@48658 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 10:13:50 +00:00
Mike Schroder
81c39e949f Upgrade/Install: Improve wp_opcache_invalidate() performance.
Changes from using `preg_match()` based `.php` extension checking to using `substr()` in `wp_opcache_invalidate()`.

Props jnylen0, aaroncampbell, SergeyBiryukov, desrosj, mikeschroder.
Fixes #50784.

git-svn-id: https://develop.svn.wordpress.org/trunk@48657 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 08:07:04 +00:00
Timothy Jacobs
b29101aca0 REST API: Remove assets field from block directory controller.
Gutenberg no longer uses the assets field to fetch the assets for the installed block so this field can be dropped from the endpoint. This allows us to reintroduce it at a later point without needing to worry about backward compatibility.

See #50732.


git-svn-id: https://develop.svn.wordpress.org/trunk@48656 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 04:08:56 +00:00
Jake Spurlock
5bb5053127 Site Health: Incorrect file path in require_once.
Ensure that background updater can be loaded for testing to see if auto-updates can enable automatic updates.

Fixes #50793.
Props dd32.


git-svn-id: https://develop.svn.wordpress.org/trunk@48655 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 02:19:17 +00:00
Sergey Biryukov
6f79ff4d1c Themes: Display a message in theme updates list if an update requires a higher version of PHP or WordPress.
This applies to the WordPress Updates screen.

Props afragen, SergeyBiryukov.
Fixes #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48654 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 01:00:40 +00:00
Sergey Biryukov
d29535c25e Themes: Correct the logic for displaying a message in theme grid if a theme update requires a higher version of PHP or WordPress.
This applies to the Themes screen fallback used when JS is turned off.

Follow-up to [48652].

See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48653 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 00:41:56 +00:00
Sergey Biryukov
7ea44b5add Themes: Display a message in theme grid and Theme Details modal if a theme update requires a higher version of PHP or WordPress.
This applies to the Themes screen and the Customizer theme browser.

Props afragen, SergeyBiryukov.
See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48652 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 00:08:00 +00:00
Sergey Biryukov
72dfc468c5 Docs: Correct alignment for some parameters in JS documentation.
Follow-up to [48650].

See #43828.

git-svn-id: https://develop.svn.wordpress.org/trunk@48651 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-28 00:05:59 +00:00
Jake Spurlock
9ed92faaca Build/Test Tools: Enable JSDocs to be linted with ESLint.
As part of the [Javascript Inline Docs Initiative](https://make.wordpress.org/core/handbook/docs/inline/js/) this add some tooling to lint Javascript docblocks. Two new commands:

* `npm run lint:jsdoc`
* `npm run lint:jsdoc:fix`

The latter will run the linter and try to fix an possible issues automatically.

Fixes #43828.
Props netweb, atimmer, kamataryo, whyisjake.



git-svn-id: https://develop.svn.wordpress.org/trunk@48650 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 23:33:51 +00:00
Sergey Biryukov
a1a1173250 Docs: Correct description for wp_filter_content_tags() per the documentation standards.
DocBlocks should start with a brief, one sentence explanation of the purpose of the function spanning a maximum of two lines.

Follow-up to [48648].

See #44427.

git-svn-id: https://develop.svn.wordpress.org/trunk@48649 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 21:47:18 +00:00
Andrew Ozz
3e1083a37e Media: Improve inline docs for wp_filter_content_tags().
Props johnstonphilip.
See #44427.

git-svn-id: https://develop.svn.wordpress.org/trunk@48648 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 21:04:34 +00:00
Jake Spurlock
c230d7a07c Post WordPress 5.5 Beta 4 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@48647 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 20:59:03 +00:00
Jake Spurlock
92521657af WordPress 5.5 Beta 4.
git-svn-id: https://develop.svn.wordpress.org/trunk@48646 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 20:38:25 +00:00
Jake Spurlock
8c9b33c3b6 Mail: PHPMailer swap to use is_email for the default validator.
Prior to the PHPMailer update in 5.5, old version of the PHPMailer was setting the validator to 'auto' resulting in a sophisticated logic for determining what email address validation should be used. But the new version defaults to 'php', possibly leading to rejection of email addresses which were fine prior to the upgrade. Let's use the WordPress core function `is_email()` so that it can be fully pluggable.

Fixes #50720.
Props david.binda, ayeshrajans, Synchro, SergeyBiryukov, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@48645 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 20:17:36 +00:00
Riad Benguella
e03be98644 Block Editor: Updated WordPress Packages for 5.5 beta 4
Updated packages:

 - @wordpress/annotations@1.20.3
 - @wordpress/block-directory@1.13.3
 - @wordpress/block-editor@4.3.3
 - @wordpress/block-library@2.22.3
 - @wordpress/blocks@6.20.3
 - @wordpress/components@10.0.3
 - @wordpress/compose@3.19.3
 - @wordpress/core-data@2.20.3
 - @wordpress/data-controls@1.16.3
 - @wordpress/data@4.22.3
 - @wordpress/e2e-test-utils@4.11.1
 - @wordpress/e2e-tests@1.20.3
 - @wordpress/edit-post@3.21.3
 - @wordpress/edit-site@1.11.3
 - @wordpress/editor@9.20.3
 - @wordpress/format-library@1.22.3
 - @wordpress/interface@0.7.3
 - @wordpress/keyboard-shortcuts@1.9.3
 - @wordpress/list-reusable-blocks@1.21.3
 - @wordpress/notices@2.8.3
 - @wordpress/nux@3.20.3
 - @wordpress/plugins@2.20.3
 - @wordpress/rich-text@3.20.3
 - @wordpress/server-side-render@1.16.3
 - @wordpress/viewport@2.21.3

Fixes #50791.


git-svn-id: https://develop.svn.wordpress.org/trunk@48644 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 20:08:53 +00:00
Riad Benguella
f660784d43 Administration: Fix the red links on the Media Modal.
The custom link colors for admin scheme colors were overriding the danger color.

Props kebbet, dlh.
Fixes #50547.


git-svn-id: https://develop.svn.wordpress.org/trunk@48643 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 19:15:55 +00:00
Timothy Jacobs
5149a7efd5 REST API: Fix warning when using set_param() on a JSON request with no body.
In [47559] the `WP_REST_Request::set_param()` method was adjusted to try and overwrite an existing parameter definition before forcing the value in the first parameter slot. If `set_param()` was called on a request with an `application/json` content type and an empty body, a PHP warning would be issued. This was due to the JSON parameter type not being set to an array when the body is empty.

This commit avoids the warning by adding an `is_array()` check before calling `array_key_exists`. Ideally, `WP_REST_Reuest::parse_json_params()` would set the JSON parameter type to an empty array in this case, but that is too large of a change at this point in the cycle.

Props manooweb.
Fixes #50786.


git-svn-id: https://develop.svn.wordpress.org/trunk@48642 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 18:44:14 +00:00
Jake Spurlock
beba4bb73a REST API: Install plugin translations after the plugin install. This only installs for the plugin in question, not all plugins.
Support for retrieving the langauge pack alongside the install API request was added in https://meta.trac.wordpress.org/changeset/10091 to avoid having to make a plugin update check during the REST API check.

Fixes #50732.
Props dd32, ocean90, ryelle, swissspidy, tellyworth, whyisjake, TimothyBlynJacobs.


git-svn-id: https://develop.svn.wordpress.org/trunk@48641 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 18:29:43 +00:00
Sergey Biryukov
598a5a5bc2 Themes: Display a message in theme grid if a theme requires a higher version of PHP or WordPress.
This applies to the Themes screen fallback used when JS is turned off.

Props afragen, desrosj, SergeyBiryukov.
See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48640 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 15:19:09 +00:00
Riad Benguella
6475d32964 Block Editor: Update the Core Block Patterns.
Backport the latest block patterns from the Gutenberg plugin.
The new patterns adapt properly to Core themes.

Props nrqsnchz.
Fixes #50550, #50594.


git-svn-id: https://develop.svn.wordpress.org/trunk@48639 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 15:12:13 +00:00
Sergey Biryukov
782454b39c Themes: Display a message in theme grid if a theme requires a higher version of PHP or WordPress.
This applies to the Themes screen, Add Themes screen, and the Customizer theme browser.

Props afragen, desrosj, SergeyBiryukov.
See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48638 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 15:02:19 +00:00
Sergey Biryukov
332ce58d5c Themes: Display a message in Details & Preview modal on Add Themes screen if a theme requires a higher version of PHP or WordPress.
Props afragen, desrosj, SergeyBiryukov.
See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48637 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 14:24:19 +00:00
Sergey Biryukov
3b0b11acc6 Themes: Display a message in Theme Details modal if a theme requires a higher version of PHP or WordPress.
Props afragen, desrosj, SergeyBiryukov.
See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@48636 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 13:10:04 +00:00
Sergey Biryukov
38cf369a7a Posts, Post Types: Pass correct variable to the get_lastpostdate filter.
Follow-up to [48634].

See #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@48635 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 11:36:27 +00:00
Sergey Biryukov
382834e730 Docs: Synchronize documentation for get_lastpostdate() and get_lastpostmodified().
See #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@48634 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 11:15:44 +00:00
Sergey Biryukov
fc62131e31 Tests: Add more fixtures to get_lastpostdate() and get_lastpostmodified() tests.
Follow-up to [48631].

Props munyagu.
See #47777.

git-svn-id: https://develop.svn.wordpress.org/trunk@48633 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 11:15:04 +00:00
Mike Schroder
838f9884d7 Docs: Correct wp_opcache_invalidate_file filter docs.
Changes incorrectly named `$filename` variable to `$filepath` and adjusts wording to align with PHP docs.

See #36455.

git-svn-id: https://develop.svn.wordpress.org/trunk@48632 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 09:06:58 +00:00
Sergey Biryukov
581deff371 Posts, Post Types: Pass the post type to get_lastpostdate() in get_lastpostmodified().
This ensures that the correct values are being compared when retrieving the result for custom post types.

Additionally, pass the `$post_type` parameter to `get_lastpostdate` and `get_lastpostmodified` filters.

Props mikaumoto, munyagu, donmhico, johnbillion, SergeyBiryukov.
Fixes #47777.

git-svn-id: https://develop.svn.wordpress.org/trunk@48631 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-27 02:16:46 +00:00
Sergey Biryukov
a1c40b346c Docs: Improve documentation for WP_Http::processHeaders().
Document the `@return` value using hash notation.

Props marekdedic, valchovski, davidbaumwald, deepaklalwani, thimalw, SergeyBiryukov.
Fixes #48350.

git-svn-id: https://develop.svn.wordpress.org/trunk@48630 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-26 22:43:47 +00:00
Sergey Biryukov
10563ae9e7 Docs: Add a note that the $args parameter of register_block_type() accepts any public property of WP_Block_Type.
Follow-up to [47754].

Props ediamin.
See #48640.

git-svn-id: https://develop.svn.wordpress.org/trunk@48629 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-26 22:15:20 +00:00
Sergey Biryukov
01d58943a1 REST API: Use a consistent description for the textdomain schema property between plugins and themes controllers.
Follow-up to [48242], [48627].

Props audrasjb.
Fixes #50776. See #50321.

git-svn-id: https://develop.svn.wordpress.org/trunk@48628 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-26 21:52:41 +00:00
Sergey Biryukov
40dd42c35d REST API: Use a consistent name for the textdomain schema property between plugins, themes, and block directory controllers.
Follow-up to [48242].

See #50321, #50776.

git-svn-id: https://develop.svn.wordpress.org/trunk@48627 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-26 21:47:56 +00:00
Sergey Biryukov
dbb88efe5c Docs: Correct @since version for WP_REST_Plugins_Controller::get_item_schema().
Follow-up to [48242].

See #50321.

git-svn-id: https://develop.svn.wordpress.org/trunk@48626 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-26 21:40:43 +00:00
Sergey Biryukov
0dd00badb2 Revisions: Ensure the global $post remains the same after revision is restored.
Because `wp_insert_post()` and `wp_transition_post_status()` are called during the process, plugins can unexpectedly modify `$post`.

Props markparnell, tofandel, archon810, SergeyBiryukov.
Fixes #46671.

git-svn-id: https://develop.svn.wordpress.org/trunk@48625 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-26 21:24:00 +00:00
Sergey Biryukov
5c064bb139 Docs: Synchronize some comments in wp-admin/revision.php.
See #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@48624 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-26 20:41:13 +00:00
Sergey Biryukov
565de1735c Docs: Improve documentation for various category functions.
Props atachibana.
Fixes #48394.

git-svn-id: https://develop.svn.wordpress.org/trunk@48623 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-26 17:16:32 +00:00
Sergey Biryukov
5ca5435aa9 Coding Standards: Rename the $id parameter in various category functions for clarity.
See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@48622 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-26 16:05:39 +00:00
Sergey Biryukov
6fa3286a1b Pings/Trackbacks: Avoid a PHP notice in do_enclose() when encountering a URL without a path in post content.
Props jbouganim, mukesh27, Otto42, SergeyBiryukov.
Fixes #49872.

git-svn-id: https://develop.svn.wordpress.org/trunk@48621 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-26 14:06:03 +00:00