Commit Graph

38224 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90) 2468899f38 Customize: Remove a stray whitespace.
Props tfrommen.
Fixes #43762.


git-svn-id: https://develop.svn.wordpress.org/trunk@42975 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-13 15:09:30 +00:00
Dominik Schilling (ocean90) 9f9facad50 Administration: Avoid an extra space in the admin body class.
Props jainnidhi, rhetorical, birgire, mathieuhays.
Fixes #43465.

git-svn-id: https://develop.svn.wordpress.org/trunk@42974 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-13 14:02:10 +00:00
Gary Pendergast b57b486d96 REST API: Fix a typo introduced in [42729].
Props danielbachhuber.
Fixes #42707.



git-svn-id: https://develop.svn.wordpress.org/trunk@42973 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-13 00:55:28 +00:00
Gary Pendergast 30354e5a9b Tests: Update the REST API fixtures.
[42967] included new post statii, but didn't add them to the REST API tests.

See #43481.



git-svn-id: https://develop.svn.wordpress.org/trunk@42972 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-13 00:53:31 +00:00
Andrew Ozz 43b5e9ac20 Privacy: add helper function for anonymizing data in a standardized way.
Props jesperher, allendav, iandunn, birgire, azaozz.
Fixes #43545.

git-svn-id: https://develop.svn.wordpress.org/trunk@42971 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-12 21:19:24 +00:00
Dion Hulse 1d0963afbd Bump `$wp_version` to latest revision.
https://core.trac.wordpress.org/ has been moved to new infrastructure, this is a test commit to verify that trunk builds continue to work as expected.

If you notice any breakage on Trac, please report it to https://meta.trac.wordpress.org/ticket/3526 - there's a number of known UI issues at present which will be resolved soon.


git-svn-id: https://develop.svn.wordpress.org/trunk@42970 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-11 02:58:45 +00:00
Dion Hulse f4d279af85 Bump `$wp_version` to latest revision.
https://core.trac.wordpress.org/ has been moved to new infrastructure, this is a test commit to verify that trunk builds continue to work as expected.

If you notice any breakage on Trac, please report it to https://meta.trac.wordpress.org/ticket/3526 - there's a number of known UI issues at present which will be resolved soon.


git-svn-id: https://develop.svn.wordpress.org/trunk@42969 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-11 02:49:49 +00:00
Ian Dunn ede824e3cd Dashboard: Strip more extraneous IP parts to prevent PHP warnings.
This iterates on earlier versions of the code, in order to handle more edge cases. An arbitrary string like `or=\"` will now be stripped, as well as reachability scopes like `%eth0`.

Props eamax, soulseekah, iandunn.
Fixes #41083.


git-svn-id: https://develop.svn.wordpress.org/trunk@42968 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-10 23:18:04 +00:00
Andrew Ozz 33979450ac Privacy: add new wp-admin screens for exporting and removing of personal data.
Props @melchoyce, @mikejolley, @allendav, @xkon.
See #43481.

git-svn-id: https://develop.svn.wordpress.org/trunk@42967 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-10 18:01:20 +00:00
Adam Silverstein d68affa9c2 Revisions: improve show_split_view=false support for title.
* When show_split_view argument false, show title changes in a single column and only show title once if title is unchanged.

Props johnbillion, mbelchev.
Fixes #42402.  



git-svn-id: https://develop.svn.wordpress.org/trunk@42966 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-10 16:11:55 +00:00
Adam Silverstein 495ac15555 REST API: Handle api-request query parameters with plain permalinks.
When constructing the request URL, ensure that  `?` is replaced with `&` when the API root  already contains a `?`. Fixes an issue where requests were broken when sites had permalinks set to plain.

Props aduth.
Fixes #42382.



git-svn-id: https://develop.svn.wordpress.org/trunk@42965 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-09 13:09:41 +00:00
Andrew Ozz 531abcbdd4 Privacy: fixes and updates for the method to confirm user requests by email.
- Improve function and variable names.
- Allow extra data to be passed with the request.
- Make the option/user meta names more consistent.
- Adds an inline comment explaining use of hash.

Props mikejolley.
See #43443.

git-svn-id: https://develop.svn.wordpress.org/trunk@42964 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-06 19:09:53 +00:00
Anton Timmermans 3a78d2e0fb Docs: Improve JSDoc for `wp-admin/js/tags-box.js`.
Props carolinegeven, andizer, ireneyoast, herregroen, jjcomack.
Fixes #43499.


git-svn-id: https://develop.svn.wordpress.org/trunk@42963 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-06 07:46:14 +00:00
Anton Timmermans da6b1b64ae Docs: Fix JS Docs for `custom-header.js`.
Amends [42385].

Props herregroen.
See #42678.


git-svn-id: https://develop.svn.wordpress.org/trunk@42962 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-05 13:39:42 +00:00
Gary Pendergast dc24919339 Build Tools: Update the description in package.json and composer.json.
The description now matches the tagline on the front page of WordPress.org.

Props ocean90.
Fixes #43558.



git-svn-id: https://develop.svn.wordpress.org/trunk@42961 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-05 07:15:25 +00:00
Gary Pendergast aee223f097 Build Tools: Add a composer.json for development environments.
This allows Core developers to more easily run coding standards checks on PHP code.

Props netweb.
Fixes #43558.



git-svn-id: https://develop.svn.wordpress.org/trunk@42960 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-05 07:04:08 +00:00
Dominik Schilling (ocean90) f68e0ab848 Media: Update built files after [42798].
See #43500.

git-svn-id: https://develop.svn.wordpress.org/trunk@42931 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 19:48:11 +00:00
Dominik Schilling (ocean90) fd168e955c Media: Update minified version of imgAreaSelect after [42874].
Adds imgAreaSelect to the uglify grunt process.

Props adamsilverstein.
Fixes #41242.

git-svn-id: https://develop.svn.wordpress.org/trunk@42930 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 19:45:39 +00:00
Dominik Schilling (ocean90) b3943d5742 HTTP: Don't treat `localhost` as same host by default.
git-svn-id: https://develop.svn.wordpress.org/trunk@42894 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 14:59:44 +00:00
Dominik Schilling (ocean90) 768f303004 Template: Make sure the version string is correctly escaped for use in attributes.
git-svn-id: https://develop.svn.wordpress.org/trunk@42893 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 14:58:48 +00:00
Dominik Schilling (ocean90) 7a62871459 Login: Use `wp_safe_redirect()` when redirecting the login page if forced to use HTTPS.
git-svn-id: https://develop.svn.wordpress.org/trunk@42892 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-03 14:31:16 +00:00
Felix Arntz 0db556da6c General: Improve wording for PHP version nag.
This changeset adjusts the tone of the message to fit the usual core voice better and addresses accessibility concerns.

Props schlessera.
See #41191.


git-svn-id: https://develop.svn.wordpress.org/trunk@42891 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-02 10:14:53 +00:00
Sergey Biryukov 7c38750b16 Taxonomy: In `category_description()`, don't pass the `$taxonomy` parameter to `term_description()`.
The parameter was deprecated in [42368] and is now unused.

Props chetan200891.
Fixes #43381. See #42771.

git-svn-id: https://develop.svn.wordpress.org/trunk@42890 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-28 23:24:25 +00:00
Andrew Ozz a0cd3d6d7a Privacy: add support for exporting multiple pages of personal data.
Props allendav.
See #43438.

git-svn-id: https://develop.svn.wordpress.org/trunk@42889 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-28 19:27:59 +00:00
Andrew Ozz 9c6b0a2548 Privacy: add functionality for exporting personal data from comments.
Props allendav, xkon.
Fixes #43440.

git-svn-id: https://develop.svn.wordpress.org/trunk@42888 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-28 17:24:06 +00:00
Aaron Jorbin 73d060e5ac Bump grunt-patch-wordpress to 1.0.0
Adds the ability to do file mapping (see #43055 ), reformats all of the code to bring it inline with the current WordPress coding standards, and fixes a small number of bugs.

Props pento, netweb, boblinthorst, ireneyoast, omarreiss, herregroen, jorbin
Fixes #43646



git-svn-id: https://develop.svn.wordpress.org/trunk@42887 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-28 16:23:19 +00:00
Sergey Biryukov 7e64beacf7 Twenty Ten: Restore `max-width` on `.wp-caption`.
[42837] fixed the compatibility issue caused by [41724], returning the caption shortcode to the pre-4.9.0 behavior.

Reverts [42386].
Fixes #42604.

git-svn-id: https://develop.svn.wordpress.org/trunk@42886 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-28 01:50:56 +00:00
Sergey Biryukov f4f630e889 Twenty Seventeen: Bump version and update the changelog.
Props audrasjb.
Fixes #43572.

git-svn-id: https://develop.svn.wordpress.org/trunk@42881 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-27 21:05:40 +00:00
Sergey Biryukov c8fa6497aa Formatting: Permit use of `text-transform` in `safecss_filter_attr()`.
Add unit tests for `safecss_filter_attr()`.

Props birgire, juiiee8487, danielbachhuber.
Fixes #42729.

git-svn-id: https://develop.svn.wordpress.org/trunk@42880 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-27 00:53:20 +00:00
Sergey Biryukov f44423cfb9 Media: Pass EXIF data to the `wp_read_image_metadata` filter.
Props desrosj.
Fixes #43624.

git-svn-id: https://develop.svn.wordpress.org/trunk@42879 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-25 20:44:16 +00:00
Sergey Biryukov 0c2bbd4441 Media: In `wp_read_image_metadata()`, rename `$sourceImageType` variable to `$image_type` to match coding standards.
See #43624.

git-svn-id: https://develop.svn.wordpress.org/trunk@42878 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-25 20:40:03 +00:00
John Blackbourn cf400b9bc4 Docs: Correct and improve various inline documentation.
See #42505


git-svn-id: https://develop.svn.wordpress.org/trunk@42877 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-25 19:34:31 +00:00
John Blackbourn e207cdf2bb Docs: Document more parameters and properties using typed array notation.
See #41756


git-svn-id: https://develop.svn.wordpress.org/trunk@42876 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-25 19:32:24 +00:00
John Blackbourn d541798a64 Docs: Document more parameters and properties using typed array notation.
See #41756


git-svn-id: https://develop.svn.wordpress.org/trunk@42875 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-25 18:09:56 +00:00
Sergey Biryukov 7c2f97597d Docs: Correct method reference in a comment for `Bulk_Plugin_Upgrader_Skin::$plugin_info`.
See [42677] for `Bulk_Theme_Upgrader_Skin::$theme_info`.

See #42505.

git-svn-id: https://develop.svn.wordpress.org/trunk@42873 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-23 00:33:53 +00:00
John Blackbourn 58dd2c9559 Docs: Revert some sneaky debugging code.
See #41756


git-svn-id: https://develop.svn.wordpress.org/trunk@42872 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-22 20:28:42 +00:00
John Blackbourn f12dec95fe Docs: Document many more parameters and properties using typed array notation.
See #41756


git-svn-id: https://develop.svn.wordpress.org/trunk@42871 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-22 20:26:06 +00:00
John Blackbourn 100efa7e1c Docs: Document `WP_Roles` properties with typed array notation.
Props stevenlinx

Fixes #38732
See #41756 


git-svn-id: https://develop.svn.wordpress.org/trunk@42870 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-22 18:55:20 +00:00
Jeremy Felt 96695f2864 Multisite: Return `WP_Site` as expected in `get_active_blog_for_user()`.
Previously it was possible for a standard object representing the site to be returned in some cases.

Fixes #38430.


git-svn-id: https://develop.svn.wordpress.org/trunk@42866 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-20 23:06:57 +00:00
Sergey Biryukov f9b33fb524 Media: On Media Settings screen, make the pairs of labels and inputs always stacked vertically, on both mobile and desktop screens.
Make `<br />` tags on the screen behave as line breaks again after [41836]. Add a missing fieldset + legend for better accessibility.

Props afercia, RavanH, obenland, garrett-eclipse.
Fixes #42724. See #34539.

git-svn-id: https://develop.svn.wordpress.org/trunk@42864 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-20 22:43:58 +00:00
John Blackbourn 3bb3d7a6c7 Build/Test Tools: Implement `assertNotWPError()` in appropriate places in the test suite.
Props birgire

Fixes #42065


git-svn-id: https://develop.svn.wordpress.org/trunk@42863 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-20 22:34:11 +00:00
John Blackbourn 71d2050014 General: Instruct file editors not to trim trailing whitespace in markdown files.
Two trailing spaces in a markdown file indicates a line break.

Props netweb

Fixes #43104


git-svn-id: https://develop.svn.wordpress.org/trunk@42862 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-20 22:14:53 +00:00
Sergey Biryukov db606c9bb2 Formatting: Avoid a PHP 7.2 warning in `wp_kses_attr()` when one of `$allowedtags` elements is an uncountable value.
Props andrei0x309, soulseekah, SergeyBiryukov.
Fixes #43312.

git-svn-id: https://develop.svn.wordpress.org/trunk@42860 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-20 21:34:15 +00:00
Jeremy Felt 4902da091c Multisite: Use case-insensitive check on email domain whitelist.
Props greatislander.
Fixes #43148.


git-svn-id: https://develop.svn.wordpress.org/trunk@42858 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-20 19:06:09 +00:00
Andrea Fercia 6f408cf561 Accessibility: Menus screen: Improve headings and instructions for better accessibility.
Props audrasjb, melchoyce, juliemoynat.
Fixes #43397.


git-svn-id: https://develop.svn.wordpress.org/trunk@42857 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-20 17:46:12 +00:00
Dominik Schilling (ocean90) 0cc1c11049 Users: Don't show roles dropdown on user-edit.php if current user cannot promote user.
Fixes #43580.

git-svn-id: https://develop.svn.wordpress.org/trunk@42856 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-19 20:55:20 +00:00
Dominik Schilling (ocean90) 877a59a843 Users: Use `promote_users` for role updates in `edit_user()`.
`edit_user()` can also update user roles but was still using the `edit_users` capability instead of the newer `promote_users` capability introduced in [14176].
This makes the role handling consistent with the bulk dropdown menu for role changes.

Props flixos90, johnjamesjacoby, ocean90.
Fixes #42564.

git-svn-id: https://develop.svn.wordpress.org/trunk@42855 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-19 20:28:28 +00:00
Dominik Schilling (ocean90) ff5180e2a5 REST API JavaScript Client: Support an empty string for `nonce` to disable sending the X-WP-Nonce header.
Passing a `nonce` argument with an empty string to `wp.api.init()` now does no longer fall back to `wpApiSettings.nonce`. This makes it possible to stop sending nonce headers, for example to a read-only endpoint on another site in a multisite install.

Props adamsilverstein, FPCSJames, ocean90, swissspidy.
Fixes #42948, #43266.

git-svn-id: https://develop.svn.wordpress.org/trunk@42852 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-18 17:20:47 +00:00
Dominik Schilling (ocean90) cde40c918f REST API JS Client: Extend custom nonce functionality to collections.
This brings the improved nonce handling from [41553] to collections to remove the direct `wpApiSettings.nonce` dependency.

Props adamsilverstein, ocean90, swissspidy.
Fixes #43265.

git-svn-id: https://develop.svn.wordpress.org/trunk@42851 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-18 17:03:20 +00:00
Dominik Schilling (ocean90) 4b89863ddd Multisite: Use a numbered placeholder in `sprintf()` for the site URL.
Fixes missing site domain in the link and a PHP warning.

Props Thomas Vitale, conner_bw.
See #41645.
Fixes #43568.

git-svn-id: https://develop.svn.wordpress.org/trunk@42844 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-18 14:44:47 +00:00