Commit Graph

31486 Commits

Author SHA1 Message Date
Scott Taylor
532baa4c5f In WP_Posts_List_Table::column_date(), the order of status and time should be switched. It doesn't make sense for phrases like "Last Modified" to occur AFTER the date. Should be before.
Props johnbillion, wonderboymusic.
Fixes #18641. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34005 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 17:42:55 +00:00
Scott Taylor
f5ce2ba96d Cleanup the text for Publish Settings > Publish in the edit-form-advanced help tab. Clarify that Private posts aren't hidden from editors and administrators.
Props sillybean.
Fixes #18418. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34004 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 17:35:17 +00:00
Scott Taylor
0a7636cfa3 In wp_media_upload_handler(), replace a lingering instance of media_upload_gallery() with wp_iframe(...)
Props jeffstieler, antpb.
Fixes #17812. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34003 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 17:23:23 +00:00
Scott Taylor
7178b67671 media-new.php, when using the browser uploader, if the result of uploading is a WP_Error - wp_die() with the error, instead of redirecting with a generic error.
Props solarissmoke.
Fixes #16820. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34002 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 17:17:22 +00:00
Scott Taylor
ad163d3547 In get_page_uri(), do not add parent slugs to orphaned pages.
Adds unit test.

Props filosofo, MikeHansenMe, MikeHansenMe, chriscct7.
Fixes #15963. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34001 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 16:53:52 +00:00
Scott Taylor
2deb9565c0 When deleting via User List Table, don't prompt for re-attribution if the user(s) do(es) not have any posts.
Props rajnikmit, wojtek.szkutnik, benjmay, wonderboymusic.
Fixes #6405. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34000 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 16:46:38 +00:00
Jeremy Felt
9473a479d9 Multisite: Correct ms_not_installed() @since version for new parameters
Props dimadin.
See 27264.


git-svn-id: https://develop.svn.wordpress.org/trunk@33999 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 16:20:29 +00:00
Sergey Biryukov
5d8eb77621 Merge two similar strings.
Props dipesh.kakadiya.
Fixes #33777.

git-svn-id: https://develop.svn.wordpress.org/trunk@33998 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 10:58:58 +00:00
Jeremy Felt
837b6c3e3e Multisite: Add action to handle network not found
`ms_network_not_found` fires when the global `$current_site` has not been filled and `ms_not_installed()` is about to fire. It cannot be used to populate `$current_site`, but can be used to capture the request and redirect or present a custom error.

Props rmccue.
Fixes #31702.


git-svn-id: https://develop.svn.wordpress.org/trunk@33990 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 05:05:14 +00:00
Jeremy Felt
d0706ac9ca Multisite: Remove $domain and $path globals in ms_not_installed()
Further reduces the reliance on these unnecessary globals.

Fixes #27264.


git-svn-id: https://develop.svn.wordpress.org/trunk@33989 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 03:52:21 +00:00
Jeremy Felt
ef1f697564 Multisite: Allow users with manage_network_users to edit network users.
Other users in a network can now be given capabilities to manage users without also having global super admin privileges.

* Users with `manage_network_users` can not edit super admins.
* Users with `manage_network_users` can not promote users to super admin.
* Uses of `is_super_admin()` in `user-new.php` are now updated to `manage_network_users`.

Props daniellandau, chriscct7.
Fixes #16860.


git-svn-id: https://develop.svn.wordpress.org/trunk@33988 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 03:33:22 +00:00
Jeremy Felt
c89822ebe0 Multisite: Test edit_user capabilities for multisite administrators
An administrator in multisite can not edit users other than itself.

Props daniellandau for the initial patch.
See #16860.


git-svn-id: https://develop.svn.wordpress.org/trunk@33987 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 03:20:11 +00:00
Scott Taylor
a025ce4f12 After the global churn in [33964], also set $post to null at the end of WP_Comments_List_Table::single_row() to ensure that an orphaned comment doesn't inherit the previous row's $post context.
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33986 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 03:11:09 +00:00
Scott Taylor
6bc498c0e6 Implement a priority system for Help Tabs to add them at specific positions.
Adds unit tests.

Props swissspidy.
Fixes #19828.


git-svn-id: https://develop.svn.wordpress.org/trunk@33985 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 01:26:26 +00:00
Scott Taylor
89f4c471fa Add @access docs to class-wp-filesystem-* files.
Props wenthemes.
Fixes #33725.


git-svn-id: https://develop.svn.wordpress.org/trunk@33984 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 01:20:58 +00:00
Scott Taylor
c5220e43f5 Plugins page: re-word "No out of date plugins were selected." to "All selected plugins are up to date." since it's not really an error condition.
Props swissspidy.
Fixes #26494.


git-svn-id: https://develop.svn.wordpress.org/trunk@33983 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 01:10:25 +00:00
Scott Taylor
c83106d13f After [33821], when dynamically updating the document title text of the Comments List Table page, operate only on the fragment that contains the comment count. This prevents us from including other numbers that may be present in the other title parts (site title, etc).
See #33414.


git-svn-id: https://develop.svn.wordpress.org/trunk@33982 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 01:02:05 +00:00
Andrew Ozz
cc18f258cb TinyMCE: update to 4.2.5, changelog: http://www.tinymce.com/develop/changelog/?ctrl=version&act=index&pr_id=1.
Fixes #33782 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@33981 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 19:44:09 +00:00
Drew Jaynes
81ec5c8e91 Docs: Add a changelog entry to the DocBlock for touch_time() to mention the shift from accessing the global $comment to using get_comment().
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33979 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 15:47:43 +00:00
Drew Jaynes
d651587a0d Docs: Use the $widget_links_args parameter in the hook doc for the widget_links_args filter, introduced when the args array was split out to a variable in [33971].
See #20788.


git-svn-id: https://develop.svn.wordpress.org/trunk@33978 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 15:44:46 +00:00
Scott Taylor
ab9bbfa9ce WP_Widget_Links: pass widget instance to widget_links_args filter
Props SergeyBiryukov, MikeHansenMe, DrewAPicture.
Fixes #20788.


git-svn-id: https://develop.svn.wordpress.org/trunk@33971 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 04:41:21 +00:00
Scott Taylor
d6e73d47e4 Round 2 of: We should use ellipses … / … instead of three dots/periods ... e.g Loading… not Loading...
Props yoavf.
Fixes #32875.


git-svn-id: https://develop.svn.wordpress.org/trunk@33970 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 04:38:31 +00:00
Scott Taylor
9eefbd1999 Deprecate wp_get_http() - function isn't used anywhere (apart from itself).
Props swissspidy.
Fixes #33709.


git-svn-id: https://develop.svn.wordpress.org/trunk@33969 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 04:25:24 +00:00
Scott Taylor
4016b77b1a Add a parameter, $post, to get_{$adjacent}_post_join, get_{$adjacent}_post_where, and get_{$adjacent}_post_sort
Props JustinSainton.
Fixes #24597.


git-svn-id: https://develop.svn.wordpress.org/trunk@33968 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 03:49:00 +00:00
Scott Taylor
05e249d5ac Ensure that role is not empty before adding it in add_role() function and methods.
Props MikeHansenMe, dannydehaan, michielhab.
Fixes #23746.


git-svn-id: https://develop.svn.wordpress.org/trunk@33967 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 03:41:27 +00:00
Scott Taylor
047f3ef01a Revisions screen: change language from "Return to post editor" to "Return to editor" - more generic for usage by custom post types.
Props lancewillett, adamsilverstein.
Fixes #31910.


git-svn-id: https://develop.svn.wordpress.org/trunk@33966 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 03:22:36 +00:00
Scott Taylor
42e8258275 Use get_comment() instead of a global in touch_time().
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33965 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 03:04:38 +00:00
Scott Taylor
df637648e2 In WP_Comments_List_Table, favor passing WP_Comment instances instead of $comment_ID to template functions. This allows us to bypass unnecessary cache lookups and simply pass the object through when it is set.
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33964 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:59:54 +00:00
Scott Taylor
38d374ab01 After [33891], get_comment() returns global $comment if no args are passed and the global is set (after setting the default to null here). This allows us to ditch global comment imports.
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33963 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:50:43 +00:00
Scott Taylor
8088ffafd6 Walker_Comment should be in its own file. Loaded now via wp-includes/comment.php, which makes it 100% BC.
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33962 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:40:53 +00:00
Scott Taylor
95247e5bd8 After [33891], a lot of comment functions can take WP_Comment instead of only accepting comment_ID. Update the @param docs to reflect this.
See #33638.


git-svn-id: https://develop.svn.wordpress.org/trunk@33961 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:33:19 +00:00
Scott Taylor
16312b141b Speed up browserify builds, don't uglify the media builds on watch.
Props iseulde.
Fixes #31911.


git-svn-id: https://develop.svn.wordpress.org/trunk@33960 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:11:23 +00:00
Scott Taylor
220ba402e5 Pre-req for Media builds: make sure the watcher actually works for browserify.
See #31911.


git-svn-id: https://develop.svn.wordpress.org/trunk@33959 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 02:02:14 +00:00
Scott Taylor
5936394bb6 In WP_User, add @property docs for description, first_name, and last_name. user_firstname and user_lastname only exist for back-compat.
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33958 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 01:12:41 +00:00
Scott Taylor
297df83c5d WP_Theme has an ad hoc property in WP_MS_Themes_List_Table, $update. This can be set to a default value on the class, as it's not obtained via __get().
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33957 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 01:01:12 +00:00
Scott Taylor
ae16cec9fb In wpdb::get_col_length(), the final return false is unreachable since the default switch case returns.
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33956 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-09 00:47:31 +00:00
Andrew Ozz
bb6dee64ae Formatting: maintain the content of HTML comments when they contain <object> tags. Add more tests for wpaitop().
Props miqrogroove.
Fixes #33645 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@33955 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 22:54:08 +00:00
Scott Taylor
a4a469d887 After [33843], update the location of some files in This filter is documented in docs
Props dimadin.
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@33954 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 22:16:57 +00:00
Scott Taylor
f8b6a357a0 Multisite: Don't allow sites to be created with the following reserved slugs: wp-admin, wp-content, wp-includes
Props austinginder.
Fixes #33615.


git-svn-id: https://develop.svn.wordpress.org/trunk@33952 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 19:31:52 +00:00
Scott Taylor
44286b9ac1 After [33814], checked() outputs a leading space, so some extra spaces can be removed in the HTML for default widget forms.
See #23012.


git-svn-id: https://develop.svn.wordpress.org/trunk@33951 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 19:22:19 +00:00
Scott Taylor
ae8a4e496e Bump the timeout in trackback() to 10 seconds (from 4) to match wp_xmlrpc_server::pingback_ping() and prevent trackback timeouts.
Props gnaka08 for the initial patch.
Fixes #10414.


git-svn-id: https://develop.svn.wordpress.org/trunk@33948 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 18:55:45 +00:00
Scott Taylor
6d0c15836b After [33840], JS regex needs the g modifier.
Add another unit test case.

Props kitchin.
Fixes #22781.


git-svn-id: https://develop.svn.wordpress.org/trunk@33947 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 16:43:27 +00:00
Gary Pendergast
f921391922 Tests: Check that readme.html is recommending an actively supported version of MySQL.
Per the MySQL support guidelines (https://www.mysql.com/support/), Oracle provides active support for MySQL releases for 5 years from the General Availality release.

See #33758.



git-svn-id: https://develop.svn.wordpress.org/trunk@33946 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-08 03:23:29 +00:00
Andrea Fercia
9f2738924c Bump H3 headings to H2 on the Network Add New User screen for better accessibility.
Props Cheffheid.
Fixes #33605.

git-svn-id: https://develop.svn.wordpress.org/trunk@33945 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 16:02:43 +00:00
Gary Pendergast
65156c6fc5 Tests: Add an extra warning message when checking the recommended PHP version.
See #33758.



git-svn-id: https://develop.svn.wordpress.org/trunk@33944 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 07:27:34 +00:00
Weston Ruter
395c8b7cd4 Customize: Fix logic for determining the container element when focusing on a panel, section, or control.
Fixes #33695 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33939 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 05:58:44 +00:00
Weston Ruter
0c101e8cf6 Customize: Fix clearing of a color control's setting by using proper empty value.
Props stevehenty.
Fixes #30280.



git-svn-id: https://develop.svn.wordpress.org/trunk@33938 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 05:47:17 +00:00
Gary Pendergast
0b6454bac5 Readme: Update the recommended PHP version to 5.6.
This also includes a unit test to ensure we're only recommending actively supported versions of PHP in the future.

Fixes #33758.



git-svn-id: https://develop.svn.wordpress.org/trunk@33937 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 05:22:03 +00:00
Dion Hulse
95b3edd4ce Cron: Reject events when the provided $timestamp is not a valid timestamp.
Invalid timestamps were previously accepted by the scheduling functions but would never be run due to our implementation which caused the cron option to forever contain the events.
This rejects such events which most likely only occur due to developer error.

Props utkarshpatel, wonderboymusic, SergeyBiryukov.
See #33423, Fixes #33475


git-svn-id: https://develop.svn.wordpress.org/trunk@33936 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 02:38:12 +00:00
Dion Hulse
628440fe5d Favicon: Do not specify a Content-Length: 0 header for our "empty" response to fail more gracefully on environments with extra whitespace on output.
This allows for the web server to generate the appropriate `Content-Length` header for the request, allowing for strict clients/proxies/servers to process the response.

Props swissspidy.
Fixes #33626


git-svn-id: https://develop.svn.wordpress.org/trunk@33935 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-07 02:17:32 +00:00