Commit Graph

3354 Commits

Author SHA1 Message Date
Andrew Nacin
a30c7c32c4 Remove type='number' from list table page inputs out of a concern for UX, as well as styling issues. fixes #20247. see #17863 for further discussion.
git-svn-id: https://develop.svn.wordpress.org/trunk@20198 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-16 04:04:07 +00:00
Andrew Nacin
ce48b0d471 Revert type="email" (HTML5) as some browsers that do validation on these fields do not work for IDN domains yet. Core does not support these well either, but server-side validation can at least be dealt with by a plugin. see #17863.
git-svn-id: https://develop.svn.wordpress.org/trunk@20196 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-15 18:09:14 +00:00
Andrew Nacin
a72a104a4c Change 'Post Format' bulk/quick edit label to 'Format'. Consistent with the UI and prevents word wrapping. Tidy logic. see #20245.
git-svn-id: https://develop.svn.wordpress.org/trunk@20195 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-15 17:19:30 +00:00
Andrew Nacin
183c5df8c2 Hide unsupported post formats from bulk edit. fixes #20245.
git-svn-id: https://develop.svn.wordpress.org/trunk@20194 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-15 17:17:56 +00:00
Andrew Nacin
e71167bbee Updates to WP_Theme, wp_get_themes(), and related deprecated functions, after [UT570] [UT578] [UT579]. see #20103.
* ['Template Files'] and ['Stylesheet Files'] need to return files from the parent theme as well.
 * Don't strip links from the Author header. Some themes rely on the previous behavior, such as to link multiple authors (Sandbox, for example.) Don't restore links to the Name, that's just a bad idea.
 * Ensure we are always passing around arrays in get_files/scandir.
 * Better inline doc for wp_get_themes() arguments.
 * Introduce a 'force' flag for search_theme_directories() to re-scan, rather than return the cache. We will use this to re-build the theme_roots transient in get_theme_roots(), but it is more helpful for unit tests. Since search_theme_directories() is cached, don't cache again in wp_get_themes(). (Again benefits testing.)
 * Handle duplicate theme names in the old get_themes() when two themes match (and neither are a default theme, which is already handled). wp_get_themes() will consider both names to be the same; this is just for back compat since get_themes() is keyed by name.
 * Include an old array key in wp_broken_themes().



git-svn-id: https://develop.svn.wordpress.org/trunk@20193 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-15 15:39:21 +00:00
Andrew Nacin
681c6ea428 Remove index-extra.php. Move dashboard widget XHR callbacks to ajax-actions.php. fixes #20242.
git-svn-id: https://develop.svn.wordpress.org/trunk@20190 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-15 13:20:00 +00:00
Daryl Koopersmith
d254551dd7 Theme Customizer: First pass for upload controls, using background image as an example. Add a wrapper for Plupload that allows for custom upload UIs. see #19910.
wp.Uploader is a wrapper that provides a simple way to upload an attachment (using the wp_ajax_upload_attachment handler). It is intentionally decoupled from the UI. When an upload succeeds, it will receive the attachment information (id, url, meta, etc) as a JSON response. If the upload fails, the wrapper handles both WordPress and plupload errors through a single handler.

As todos, we should add drag classes for the uploader dropzone and account for the rough 100mb filesize limit in most browsers. The UI for the customizer upload controls could be improved as well.

git-svn-id: https://develop.svn.wordpress.org/trunk@20179 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-15 04:14:05 +00:00
Andrew Ozz
995926a5f0 Add support for line breaks to the caption textareas, see #18311
git-svn-id: https://develop.svn.wordpress.org/trunk@20174 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-14 21:53:11 +00:00
Andrew Nacin
0459805741 Increase default upload space for sites on a network from 10M to 100M. props andrea_r. fixes #18831.
git-svn-id: https://develop.svn.wordpress.org/trunk@20170 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-10 22:07:17 +00:00
Andrew Ozz
fcbd8f7f57 Set proper HTML5 input types in the admin, props georgestephanis, fixes #17863
git-svn-id: https://develop.svn.wordpress.org/trunk@20168 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-10 01:23:48 +00:00
Andrew Ozz
654e72714c Add new comment from post edit screen, partial props: garyc40, see #15527
git-svn-id: https://develop.svn.wordpress.org/trunk@20164 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-09 01:30:11 +00:00
Andrew Nacin
f173370ae1 Don't show the Network Enable link for broken themes. Include broken themes in searching on network/themes.php. fixes #20099, see #20103.
git-svn-id: https://develop.svn.wordpress.org/trunk@20160 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-08 17:08:55 +00:00
Andrew Nacin
c7b3d21c18 In multisite, list broken themes on network/themes.php instead of on individual Manage Themes pages. see #20103.
git-svn-id: https://develop.svn.wordpress.org/trunk@20151 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-08 07:32:42 +00:00
Andrew Nacin
f9d7952855 The allowed_themes rolling upgrade for individual sites should not add empty allowedthemes arrays. If there are no allowed themes, don't add an empty option. Move the network rolling upgrade to upgrade_network(). see #20146.
git-svn-id: https://develop.svn.wordpress.org/trunk@20148 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-08 03:22:39 +00:00
Andrew Nacin
c57039543d Always print the Author in the MS themes list table. display('Author') will be 'Anonymous' if no author is specified. see #20103.
git-svn-id: https://develop.svn.wordpress.org/trunk@20147 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-08 00:01:35 +00:00
Andrew Nacin
b1ba2dd995 Deprecate display_theme(). see #19910.
git-svn-id: https://develop.svn.wordpress.org/trunk@20141 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-07 18:29:36 +00:00
Daryl Koopersmith
7464fa9565 Theme Customizer: Make theme installer no-js compatible. Fix JS click handler that caught clicks on the 'Activate' link. Relocate display_theme() to WP_Theme_Install_List_Table->single_row(). see #19910.
git-svn-id: https://develop.svn.wordpress.org/trunk@20140 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-07 18:24:34 +00:00
Daryl Koopersmith
6e93f773b4 Theme Customizer: Begin integration into the install process. Combine previews, details, and install into a single workflow. see #19910.
git-svn-id: https://develop.svn.wordpress.org/trunk@20138 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-07 17:35:17 +00:00
Jon Cave
9e9f4ad923 Use WP_Rewrite::set_permalink_structure instead of plain update_option() in populate_network(). Fixes #20174.
This has the benefit of calling WP_Rewrite::init() which correctly resets the permalink_structure
property of the $wp_rewrite global so that the rewrite rules generated on the next flush are correct.


git-svn-id: https://develop.svn.wordpress.org/trunk@20117 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-05 17:39:26 +00:00
Andrew Ozz
e169217ad0 Based on the current UX feedback, remove the "Insert Link" UI from under the caption fields, see #18311
git-svn-id: https://develop.svn.wordpress.org/trunk@20114 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-05 07:31:31 +00:00
Daryl Koopersmith
90a115e4b4 Partially revert [20100]. The list_args JS variable cannot be extended due to its use as an argument in fetch-list. see #19815.
We should reattempt extending the args created in WP_List_Table, but will need to deprecate the current list_args to do so.

Also, infinite scroll on themes pages is no longer broken. Go team.

git-svn-id: https://develop.svn.wordpress.org/trunk@20104 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-03 02:40:43 +00:00
Andrew Nacin
b6b4d37fcb Allow WP_List_Table::_js_vars() to take an array of additional args to add. Allows us to have a single variable printing data when child classes need more data. Also, fix compact() call in [20094]. see #19815.
git-svn-id: https://develop.svn.wordpress.org/trunk@20100 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 23:06:31 +00:00
Andrew Nacin
c56b5f3f59 Use sanitize_key(). sanitize_title_with_dashes() is more than we need. see #19815. see [20096], [20097].
git-svn-id: https://develop.svn.wordpress.org/trunk@20098 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:32:29 +00:00
Andrew Nacin
9f47e027ca Revert [20096] which was an accidental partial revert of [20094]. see #19815.
git-svn-id: https://develop.svn.wordpress.org/trunk@20097 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:31:15 +00:00
Andrew Nacin
7dd527a421 Use sanitize_key() for theme search tags/features. sanitize_title_with_dashes() is overkill. see #19815.
git-svn-id: https://develop.svn.wordpress.org/trunk@20096 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:26:58 +00:00
Andrew Nacin
43209998c6 Output themes and theme-install infinite scrolling args in JS, rather than parsing query strings. props DH-Shredder, helenyhou. Make WP_Theme_Install_List_Table extend WP_Themes_List_Table. Doesn't help much yet, but we should be able to dry things up further. see #19815.
git-svn-id: https://develop.svn.wordpress.org/trunk@20094 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:09:26 +00:00
Andrew Nacin
129754ed3d Don't autoload the uninstall_plugins option. fixes #16741.
git-svn-id: https://develop.svn.wordpress.org/trunk@20080 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 20:13:35 +00:00
Andrew Nacin
1bc62a722a In miscellaneous publishing actions, use :last-child instead of a separate misc-pub-section-last class to control borders. Allows for sane use of the post_submitbox_misc_actions hook. (Actually uses :first-child for browser compat reasons.) fixes #19604.
git-svn-id: https://develop.svn.wordpress.org/trunk@20077 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 19:52:23 +00:00
Andrew Nacin
f4d36e96a5 Add the wp_edit_nav_menu_walker filter to the ajax request. props wonderslug, ocean90. fixes #14527.
git-svn-id: https://develop.svn.wordpress.org/trunk@20072 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 17:50:01 +00:00
Dion Hulse
1cbc983342 Fix a small typo.
git-svn-id: https://develop.svn.wordpress.org/trunk@20070 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 11:00:51 +00:00
Andrew Nacin
eee4414129 Remove debug cruft.
git-svn-id: https://develop.svn.wordpress.org/trunk@20068 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 00:13:05 +00:00
Andrew Nacin
12aa35e6aa Remove theme tags from the themes.php UI. They just take up room and are redundant with the feature filter. The installer already does not show tags. props DH-Shredder, fixes #20147.
git-svn-id: https://develop.svn.wordpress.org/trunk@20065 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-01 23:58:10 +00:00
Andrew Nacin
76a0adc5e2 Remove extra $. see #20103.
git-svn-id: https://develop.svn.wordpress.org/trunk@20052 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-29 22:54:50 +00:00
Andrew Nacin
cc503e4315 In WP_Themes_List_Table, don't perform unnecessary sanitization on search terms or filter features. We only use these for case-insensitive comparison. see #19815.
git-svn-id: https://develop.svn.wordpress.org/trunk@20048 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-29 22:19:18 +00:00
Andrew Nacin
d7b7ac8c1b 'Network Activate' should be the bulk action on network/plugins.php, to match the action link. props ampt, fixes #19946.
git-svn-id: https://develop.svn.wordpress.org/trunk@20046 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-29 21:52:27 +00:00
Andrew Nacin
47db4344b9 Have WP_Theme::get_screenshot() default to an absolute URI. Allow 'relative' to be requested. see #20103, see #19816.
git-svn-id: https://develop.svn.wordpress.org/trunk@20043 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-29 20:31:56 +00:00
Andrew Nacin
cdaee9042d Translate page template names! Have WP_Theme::get_page_templates() return templates keyed by filename, not by template name, as it makes more sense. Flip this in get_page_templates() to be compatible. fixes #6007.
git-svn-id: https://develop.svn.wordpress.org/trunk@20041 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-29 20:18:53 +00:00
Andrew Nacin
9cc63bb04f Use proper object. see #20103.
git-svn-id: https://develop.svn.wordpress.org/trunk@20038 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-29 18:11:49 +00:00
Andrew Nacin
53a209a4ee Introduce WP_Theme, wp_get_themes(), and wp_get_theme() to replace get_themes(), get_theme(), get_theme_data(), current_theme_info(), and others.
* Getters and Helpers: Introduces a series of methods to allow for easy generation of headers for display, and other theme metadata, including page templates.
 * Screenshots: Handles support for multiple screenshots. (see # Additional screenshots must be PNG and start with screenshot-2.png, and be sequential to be counted. see #19816.
 * Error Handling: Broken themes have a WP_Error object attached to them.
 * Caching: Introduces a wp_cache_themes_persistently filter (also in [20020]) to enable persistent caching of all filesystem and sanitization operations normally handled by WP_Theme (and formerly get_file_data() and get_themes()). Themes are cached individually and across five different cache keys for different data pieces.
 * Compatibility: A WP_Theme object is backwards compatible with a theme's array formerly returned by get_themes() and get_theme(), and an stdClass object formerly returned by current_theme_info().
 * i18n/L10n: Theme headers are now localizable with proper Text Domain and Domain Path headers, like plugins. (Language packs may remove the requirement for headers.) For page templates, see #6007 (not fixed yet, but will be easy now). For headers, fixes #15858.
 * PHP and CSS files: New methods that fetch a list of theme files (for the theme editor) only on demand, rather than only loading them into memory. fixes #11214.

Functions deprecated:
 * get_themes(), get_allowed_themes() and get_broken_themes() -- use wp_get_themes()
 * get_theme() and current_theme_info() -- use wp_get_theme()
 * get_site_allowed_themes() -- use WP_Theme::get_allowed_on_network()
 * wpmu_get_blog_allowedthemes() -- use WP_theme::get_allowed_on_site()

see also [20016], [20018], [20019], [20020], [20021], [20022], [20025], [20026], [20027]. also fixes #19244.

see #20103.



git-svn-id: https://develop.svn.wordpress.org/trunk@20029 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 21:24:44 +00:00
Andrew Nacin
f0c5c18d81 Faster theme searching. Only calculate what is necessary -- if the theme doesn't have all of the features, bail. If a word matches a tag or header, jump to the next word, we don't care how many times it matches. see #20103.
git-svn-id: https://develop.svn.wordpress.org/trunk@20027 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 20:51:19 +00:00
Andrew Nacin
3924c4aab5 Don't sanitize theme tags while trying to search through them, as it is unnecessary. It is also very expensive -- 50% of the pageload for a search was spent sanitizing tags. see #20103.
git-svn-id: https://develop.svn.wordpress.org/trunk@20026 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 20:41:53 +00:00
Andrew Nacin
11c4081aaf Add argument to get_theme_feature_list() to allow the tags to be returned without hitting the WP.org API. We'll be using this to translate tags. Remove trailing space in the 'Light' string. see #20103.
git-svn-id: https://develop.svn.wordpress.org/trunk@20025 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 20:38:09 +00:00
Jon Cave
cafa8dab24 Reduce references to the $wp_rewrite global because it's no longer used or a wrapper function can be used instead. Fixes #14546.#14546.
git-svn-id: https://develop.svn.wordpress.org/trunk@20023 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 20:29:33 +00:00
Andrew Nacin
21630b2828 Do not save the last visited tab on the multisite Network Themes page and Site Themes tab. These are poor UX, see #18810 for plugins. Entering these screens will always default to 'all' themes view. see #20103.
git-svn-id: https://develop.svn.wordpress.org/trunk@20022 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 20:13:21 +00:00
Jon Cave
4c99743d06 Drop image resizing code from wp_handle_upload(). Fixes #19800.
This code stops wp_handle_upload() from reporting errors when the upload couldn't be moved to its final local and it was a non-JS fallback that is unused.


git-svn-id: https://develop.svn.wordpress.org/trunk@20019 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 20:02:43 +00:00
Ryan Boren
5648306064 Pass post id to get_upload_iframe_src() instead of relying on a global. Props tott. fixes #20003
git-svn-id: https://develop.svn.wordpress.org/trunk@19999 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-27 19:23:03 +00:00
Andrew Nacin
682b2a4b6d Remove out-of-place double quote. props niallkennedy. fixes #20113.
git-svn-id: https://develop.svn.wordpress.org/trunk@19987 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-24 20:49:54 +00:00
Andrew Ozz
0fa723245a HTML in image captions, first run, see #18311
git-svn-id: https://develop.svn.wordpress.org/trunk@19982 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-24 01:58:18 +00:00
Andrew Nacin
7327a30867 Preserve keys when splitting themes up for pagination. props Utkarsh. fixes #15306.
git-svn-id: https://develop.svn.wordpress.org/trunk@19980 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-23 14:42:01 +00:00
Andrew Nacin
082f9f9739 Use version_compare() when checking installed themes in the theme installer. fixes #20097.
git-svn-id: https://develop.svn.wordpress.org/trunk@19979 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-22 14:03:59 +00:00