Sergey Biryukov
a5d26f78db
Users: Introduce `admin_email_remind_interval` filter for dismissing the admin email confirmation screen.
...
Props desrosj, birgire.
Fixes #48334 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46838 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-09 13:24:20 +00:00
Sergey Biryukov
ed126e5f52
Docs: Correct DocBlock formatting for `admin_email_confirm` and `admin_email_confirm_form` hooks.
...
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46837 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-09 13:08:53 +00:00
Sergey Biryukov
d706e903b7
Twenty Twenty: Pass `$post_meta` and `$location` values to `twentytwenty_start_of_post_meta_list` and `twentytwenty_end_of_post_meta_list` actions to provide better context.
...
Props msaari, SergeyBiryukov.
Fixes #48906 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46832 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-09 11:48:00 +00:00
Sergey Biryukov
8b0feef2fe
Twenty Twenty: Use duplicate hook references for `page_css_class` and `page_menu_link_attributes` filters in `TwentyTwenty_Walker_Page`.
...
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46828 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-07 14:01:44 +00:00
Sergey Biryukov
ac6dc8aa0c
Bundled Themes: Correct `@since` tags to refer to the theme version instead of WordPress version.
...
This makes `@since` notations in Twenty Seventeen, Twenty Nineteen, and Twenty Twenty consistent with the previous bundled themes.
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46827 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-07 13:54:43 +00:00
John Blackbourn
e12f866db2
Docs: Further docblock corrections and improvements.
...
See #48303
git-svn-id: https://develop.svn.wordpress.org/trunk@46826 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-07 13:21:07 +00:00
Sergey Biryukov
388524c939
Twenty Twenty: Replace Smooth Scroll JS implementation with `scroll-behavior` CSS property.
...
The JS implementation had multiple issues and did not work as expected.
This change includes an accessibility enhancement by using `prefers-reduced-motion: reduce` media query property for users that don't want motion effects. For further explanation on this media query, see MDN documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior#Accessibility_concerns
Props audrasjb, melchoyce, joostdevalk, Anlino, mauteri, sergiomdgomes, littlebigthing, williampatton, netweb, andraganescu, joyously, acosmin, mukesh27, hareesh-pillai.
Fixes #48763 , #48551 , #48866 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46824 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-07 11:03:09 +00:00
John Blackbourn
726d3a1d9c
Docs: Increase the specificity of various docblock parameter types and return types.
...
See #48303
git-svn-id: https://develop.svn.wordpress.org/trunk@46823 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-06 22:41:26 +00:00
Andrew Ozz
5464dcb2c5
Upload: fix `wp_unique_filename()` to prevent name collisions with existing or future image sub-size file names, and add unit tests.
...
Props Viper007Bond, pbiron, azaozz.
Fixes #42437 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46822 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-06 22:26:19 +00:00
John Blackbourn
bcfccc7344
Docs: Correct various docblocks documentation.
...
See #48303
git-svn-id: https://develop.svn.wordpress.org/trunk@46821 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-06 22:21:07 +00:00
Aaron Jorbin
8ed3551c81
Text Changes: Rename Comment Blacklist option to be more inclusive
...
This doesn't change the underlying option name as that would be a backcompat break, but it makes the UI a bit more inclusive.
Props dartiss, jeremyfelt, aaronjorbin.
Fixes #48900 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46820 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-06 18:10:58 +00:00
Sergey Biryukov
47e38ea2e9
Accessibility: Administration: Correct active button color for the alternative color schemes.
...
Follow-up to [46815].
Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Fixes #48598 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46817 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-05 22:10:29 +00:00
Sergey Biryukov
94b37d4f90
Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes.
...
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.
Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Fixes #48585 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46815 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-05 21:30:58 +00:00
Sergey Biryukov
eb4b070009
XML-RPC: Unify some "could not be created/updated/deleted" error messages for consistency.
...
Props ramiy, SergeyBiryukov.
Fixes #48883 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46814 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-05 13:46:43 +00:00
Ian Belanger
46cffd88e5
Bundled Themes: Adds Customizer option to show or hide author bio Twenty Twenty.
...
This adds an option to the Customizer that allows you to turn the author bio on or off, sitewide.
Props williampatton, nielslange acosmin, dlh.
Fixes #48550 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46813 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-04 15:57:54 +00:00
Sergey Biryukov
8b08d641a7
I18N: Change context for the "Add New" string on Themes screen for consistency with other similar strings.
...
Props ramiy.
Fixes #48875 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46812 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-04 10:34:03 +00:00
Sergey Biryukov
972ca00d2d
Docs: Move the canonical DocBlock for `handle_bulk_actions-{$screen}` action to `wp-admin/edit.php`.
...
* Document accepted values for the `$items` parameter.
* Use interpolated syntax for the filter name.
Props dilipbheda, johnbillion, SergeyBiryukov.
Fixes #48857 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46811 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-03 13:56:25 +00:00
Sergey Biryukov
9440ad966b
Taxonomy: Remove redundant caching from `get_all_category_ids()`, deprecated in favor of `get_terms()` in [28679].
...
The `all_category_ids` cache key it relied on was removed in [5555] and never repopulated, causing invalid or unexpected results when using a persistent object cache.
Props itowhid06, johnjamesjacoby.
Fixes #48176 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46810 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-02 14:47:27 +00:00
Andrew Ozz
8917973d52
Upload: Exclude PNG images from scaling after uploading. Fixes a case where resizing a very large PNG may create a scaled image that has smaller dimensions but larger file size than the original.
...
Fixes #48736 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46809 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-01 18:24:30 +00:00
Sergey Biryukov
2a85333570
Widgets: Remove `WP_Widget_Factory::$hashed_class_counts` property, unused since [46220].
...
The `spl_object_hash()` function was introduced in PHP 5.2.0. As of PHP 5.3, the PHP SPL extension can no longer be disabled, so the `WP_Widget_Factory::hash_object()` workaround was removed in [46220].
See #48074 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46808 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-01 12:11:57 +00:00
Sergey Biryukov
bf3295d10f
Administration: Correct font size for comment count in "At a Glance" dashboard widget on mobile.
...
Props donmhico, jeremyfelt.
Fixes #48799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46807 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-30 00:40:24 +00:00
Sergey Biryukov
aacfec6734
Plugins: In `_wp_filter_build_unique_id()`, remove `$wp_filter` global and `$filter_id_count` static variable, unused since [46220].
...
See #47407 , #48074 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46805 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-29 22:12:10 +00:00
Sergey Biryukov
b5ed00dc82
REST API: Use strict `in_array()` checks for the list of usernames blacklisted via `illegal_user_logins` filter.
...
See #48839 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46804 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-29 22:02:30 +00:00
Sergey Biryukov
e3261b601f
REST API: Use a strict `in_array()` check in `WP_REST_Request::get_parameter_order()`.
...
See #48839 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46803 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-29 21:58:37 +00:00
Sergey Biryukov
d50f672908
REST API: Use a strict `in_array()` check in `WP_REST_Meta_Fields::get_registered_fields()`.
...
Props dkarfa.
Fixes #48839 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46802 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-29 21:57:09 +00:00
Sergey Biryukov
890bd870e8
Docs: Correct `@param` type for the function parameter in `tests_add_filter()` and `_test_filter_build_unique_id()`.
...
Synchronize documentation for `add_filter()`, `tests_add_filter()`, `_wp_filter_build_unique_id()`, `_test_filter_build_unique_id()`.
Add a note that `$tag` and `$priority` are no longer used in `_wp_filter_build_unique_id()` since [46220], and the function always returns a string now.
Props donmhico, remcotolsma, SergeyBiryukov.
Fixes #47407 . See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46801 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-29 21:40:58 +00:00
Sergey Biryukov
a03bb54546
Docs: Replace `@returns` tags in JS docs with `@return`.
...
Per the documentation standards, `@returns` is an unsupported synonym, `@return` should be used instead:
https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46800 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-29 17:59:47 +00:00
Sergey Biryukov
ea5bfe134f
Docs: Add missing full stops to `@returns` tags in JS docs, per the documentation standards.
...
Props shital-patel, kalpshit.
Fixes #48305 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46799 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-29 16:55:01 +00:00
Sergey Biryukov
4b60e6a0db
Site Health: Add a test for PHP default timezone.
...
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.
WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.
Props Rarst, Clorith, TimothyBlynJacobs.
Fixes #48692 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46797 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-28 15:46:45 +00:00
Sergey Biryukov
e720a9ddc7
Date/Time: Make `get_permalink()` more resilient against PHP timezone changes.
...
Overriding default PHP timezone with `date_default_timezone_set()`, while not recommended, should not inadvertently result in changing existing permalinks.
Add a unit test.
Props Rarst, steevithak, archon810, maciejmackowiak, Ov3rfly, Cybr, hometowntrailers, scvleon, miette49.
Fixes #48623 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46795 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-28 13:40:19 +00:00
Sergey Biryukov
9737e5fdc3
KSES: Add support for gradient backgrounds.
...
Props jorgefilipecosta.
Fixes #48376 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46793 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-28 00:27:21 +00:00
Sergey Biryukov
81581b537a
Plugins: Correct default value of `$replacement` parameter in `do_action_deprecated()` and `apply_filters_deprecated()`.
...
This addresses an inconsistency with `_deprecated_hook()`, which uses `is_null()` to check if `$replacement` was provided, however the previous default value was `false`.
Props shaampk1, felipeelia.
Fixes #48817 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46792 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-27 23:53:31 +00:00
Sergey Biryukov
2dc58b9118
Menus: Improve the wording of instructions for dragging the items into the preferred order.
...
Props amolv, equin0x80, dlh.
Fixes #48184 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46791 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-27 19:49:24 +00:00
Sergey Biryukov
10d5efa604
Administration: Properly wrap long titles in list tables on smaller screens.
...
Props mukesh27, iihglobal, wpamitkumar.
Fixes #48805 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46790 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-27 16:50:59 +00:00
Sergey Biryukov
993180b9c9
Users: Display admin email verification screen in user's locale instead of site locale.
...
Props sathyapulse, TimothyBlynJacobs.
Fixes #48313 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46788 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-27 14:33:47 +00:00
Ian Belanger
43ecd78bd3
Bundled Themes: Fixes JS TypeError in Twenty Twenty.
...
On mobile devices using a webkit browser, the menu and search modals could not be opened due to a `TypeError: document.body is null`. This commit fixes that issue by adding a `touch-enabled` class to the body for browsers that do not support media queries.
Props quicoto, poena, Boga86, acosmin, macmanx.
Fixes #48601 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46786 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-26 18:19:54 +00:00
Dominik Schilling
c2413a4711
Upgrade/Install: Provide a default label for "Continue" button in language selection form.
...
Prevents an empty continue button if a translation isn't yet available.
Props sathyapulse.
Fixes #48776 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46784 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-26 15:17:30 +00:00
Sergey Biryukov
29f0d74599
Users: Use correct variable when displaying the Additional Capabilities list in user profile.
...
Addresses a regression in [45926].
Props wpgurudev, aravindajith, anantajitjg, davidbaumwald.
Fixes #48725 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46782 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-25 13:59:02 +00:00
Sergey Biryukov
752d7496b4
Options, Meta APIs: Update `@since` version for the `$force_cache` parameter added for `wp_load_alloptions()` in [46753] to 5.3.1.
...
See #31245 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46779 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-25 13:42:22 +00:00
Sergey Biryukov
7dfb911b7b
Media: Avoid a PHP notice in `image_downsize()` when trying to replace a non-image URL with a rendered image from its meta.
...
Props Mte90, jrf, hareesh-pillai.
Fixes #48324 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46772 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-25 10:05:39 +00:00
SergeyBiryukov
dc486308e6
Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined:
...
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box
Split "Manage widgets or menus" into separate items for consistency with other links.
For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.
Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone
Props afercia, audrasjb, karmatosed.
Fixes #48406 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46770 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-24 19:55:01 +00:00
Sergey Biryukov
5e801fe58e
Twenty Twenty: Remove duplicate array key/value in `TwentyTwenty_Non_Latin_Languages::get_non_latin_css()`.
...
Props manikmist09.
Fixes #48624 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46765 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-24 10:53:40 +00:00
Sergey Biryukov
29ff549800
Coding Standards: Fix WPCS issue in [46763].
...
See #48777 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46764 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-23 19:19:57 +00:00
Sergey Biryukov
fec3976927
Docs: Add missing `@since` tags for functions in `wp-admin/includes/update.php`.
...
Props sathyapulse, zodiac1978.
Fixes #48777 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46763 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-23 18:49:59 +00:00
Sergey Biryukov
c5d880c616
Twenty Twenty: Correctly align the author bio and bottom post meta on single posts on mobile.
...
Props nielslange, Anlino.
Fixes #48619 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46762 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-23 14:52:13 +00:00
Sergey Biryukov
29e97b7b0c
Embeds: Remove CollegeHumor oEmbed provider, as the service does not exist anymore.
...
Props audrasjb, youknowriad.
Fixes #48696 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46761 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-23 10:13:32 +00:00
Sergey Biryukov
b718cc0252
Docs: Adjust `wp_is_json_request()` and `wp_is_xml_request()` return value descriptions for consistency.
...
See #48771 , #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46760 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-22 18:26:41 +00:00
Sergey Biryukov
7551c2b47d
Docs: Correct spelling and capitalization in `wp-includes/load.php`:
...
* Fix typo in `is_blog_admin()` description.
* Capitalize PHP correctly in `enable_wp_debug_mode_checks` filter description.
* Capitalize XML correctly in `wp_is_xml_request()` return value description.
Props stevegrunwell.
Fixes #48771 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46759 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-22 18:14:45 +00:00
Sergey Biryukov
206ea67257
Editor: Improve the appearance of tag cloud in Tags meta box in classic editor.
...
Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Fixes #48592 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46758 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-22 00:02:12 +00:00
Sergey Biryukov
172f434332
Date/Time: Correct the time format in `get_feed_build_date()` to use 24-hour format.
...
Follow-up to [46756].
See #48675 .
git-svn-id: https://develop.svn.wordpress.org/trunk@46757 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-21 16:25:38 +00:00