Commit Graph

40790 Commits

Author SHA1 Message Date
Jonathan Desrosiers 6d413590b7 Customize: Formally deprecate unused Customizer classes.
The `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` PHP classes and `wp.customize.Menus.NewMenuControl` JS class were deprecated in 4.9 through [42034] with the intention of removing them in 5.0. Since more time has passed than originally intended, this change leaves `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` to prevent any potential backwards compatibility issues, and formally deprecates them. The `wp.customize.Menus.NewMenuControl` JS class is removed.

Props weston.ruter, matthias-reuter, jrf.
Fixes #42364.

git-svn-id: https://develop.svn.wordpress.org/trunk@46637 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-03 16:46:55 +00:00
Jonathan Desrosiers ab361359f6 Add `svn:auto-props` for `eol-style` and `mime-type` to `trunk`.
`svn:eol-style` and `svn:mime-type` property default values are now provided for all file types currently in `trunk`.

This also reverts the `eol-style` change to `wp-config-sample.php` made in [46586].

Fixes #42594.

git-svn-id: https://develop.svn.wordpress.org/trunk@46636 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-03 16:19:15 +00:00
Jonathan Desrosiers 0a9437d987 Remove unintended change to `svn:ignore` in [46634].
git-svn-id: https://develop.svn.wordpress.org/trunk@46635 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-03 15:32:04 +00:00
Jonathan Desrosiers 669e701a5b External Libraries: Update Plupload from 2.1.9 to 2.3.6.
This change also updates the MoxieJS dependency from 1.3.5 to 1.5.7, converts Plupload to a dependency in NPM, and integrates all relevant parts into the build process.

For a full list of upstream changes, see https://github.com/moxiecode/plupload/compare/v2.1.9...v2.3.6.

Props desrosj, hareesh-pillai.
Fixes #48277.

git-svn-id: https://develop.svn.wordpress.org/trunk@46634 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-03 15:29:46 +00:00
Sergey Biryukov b0cdad744b General: Wrap the error message in `_deprecated_constructor()` in `<code>` tags instead of `<pre>`.
Props aftabmuni.
Fixes #48483.

git-svn-id: https://develop.svn.wordpress.org/trunk@46633 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-03 10:54:39 +00:00
Sergey Biryukov 358364e1ca Code Modernization: Call PHP 5 constructors in methods extending `POMO_Reader`.
Follow-up to [46629].

See #48252.

git-svn-id: https://develop.svn.wordpress.org/trunk@46632 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-02 20:47:44 +00:00
Sergey Biryukov 74795ca384 Docs: Correct version number in `@deprecated` tags for PHP 4 constructors in `pomo/entry.php` and `pomo/streams.php`.
Follow-up to [46629].

Props jrf.
See #48252.

git-svn-id: https://develop.svn.wordpress.org/trunk@46631 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-02 20:28:31 +00:00
Sergey Biryukov d3f486ed3f Docs: Correct `@see` references for PHP 4 constructors in `wp-includes/class-json.php`.
See #48252, #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46630 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-02 20:11:20 +00:00
Sergey Biryukov 168bb48084 Docs: Add missing `@deprecated` tags to PHP 4 constructors in `pomo/entry.php` and `pomo/streams.php`.
Props jrf.
Fixes #48252.

git-svn-id: https://develop.svn.wordpress.org/trunk@46629 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-02 20:09:35 +00:00
Sergey Biryukov 095ef4a2a2 Twenty Eleven: Add missing `@deprecated` tag to PHP 4 constructor in `Twenty_Eleven_Ephemera_Widget`.
Props jrf.
See #48252.

git-svn-id: https://develop.svn.wordpress.org/trunk@46628 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-02 20:06:55 +00:00
Sergey Biryukov dcced77dbb Docs: Add missing `@deprecated` tags to PHP 4 constructors in `WP_Widget` and `WP_Widget_Factory()`.
Correct version number in `_deprecated_constructor()` call in `WP_Widget_Factory()`, see [32990].

Props jrf.
See #48252.

git-svn-id: https://develop.svn.wordpress.org/trunk@46627 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-02 20:04:27 +00:00
Sergey Biryukov 00384f94db Docs: Update URLs in some `@link` tags and switch them to HTTPS.
Props tsuyoring.
Fixes #48479.

git-svn-id: https://develop.svn.wordpress.org/trunk@46626 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-01 14:55:51 +00:00
Sergey Biryukov 89621877f8 Code Modernization: Pass an appropriate error level to `trigger_error()` in `_doing_it_wrong()` and related functions:
* `_deprecated_function()`
* `_deprecated_argument()`
* `_deprecated_constructor()`
* `_deprecated_file()`

The error level passed is `E_USER_DEPRECATED` for the deprecated function group and `E_USER_NOTICE` for `_doing_it_wrong()`.

Props jrf.
Fixes #36561.

git-svn-id: https://develop.svn.wordpress.org/trunk@46625 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-01 00:39:04 +00:00
johnbillion 3623ab0ad8 Docs: Correct some more invalid inline docs.
See https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#summary-formerly-short-description

See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46624 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-31 21:18:01 +00:00
John Blackbourn 669cefe587 Docs: Correct some incorrect docblock tags.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46623 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-31 17:49:12 +00:00
Sergey Biryukov fe9b176aef Docs: Add `@since` tag for the `$context` parameter added to `wp_generate_attachment_metadata` filter in [46621].
See #48472.

git-svn-id: https://develop.svn.wordpress.org/trunk@46622 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-31 00:11:20 +00:00
Andrew Ozz b9c02b3729 Upload:
- Run the `wp_generate_attachment_metadata` filter at the end in `wp_update_image_subsizes()` when new metadata was generated and additional image sub-sizes were created.
- Add another arg in the `wp_generate_attachment_metadata` filter for additional context.
- Fix inline docs and ensure the new image meta is always saved before starting post-processing.

Fixes #48472 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@46621 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-30 21:08:32 +00:00
Sergey Biryukov 6582966e2e Docs: Document `$error`, `$interim_login`, and `$action` globals in `login_header()` and `login_footer()`.
Props priyankabehera155, faisal03, mukesh27, SergeyBiryukov.
Fixes #45777.

git-svn-id: https://develop.svn.wordpress.org/trunk@46620 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-30 02:57:16 +00:00
Jonathan Desrosiers 7d2bb9f8c6 Help/About: Update the 5.3 About page for RC3.
Previously [46556], [46572].
Props ryelle, SergeyBiryukov, afercia, desrosj, davidbaumwald, azaozz.
See #47708.

git-svn-id: https://develop.svn.wordpress.org/trunk@46616 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-29 20:08:32 +00:00
Jonathan Desrosiers 52508537cb Bundled Themes: Update Twenty Twenty.
This brings trunk’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46571], see 4549fd9...dea9290.

Props anlino, ianbelanger, poena, williampatton, collet, erikkroes, torres126, intimez, byalextran, mehidi258, swapnild, nielslange.
Fixes #48450.

git-svn-id: https://develop.svn.wordpress.org/trunk@46613 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-29 14:53:27 +00:00
Sergey Biryukov b0419afba6 Build/Test Tools: Ignore EOL differences in tests using multiline string assertions.
Unix vs. Windows EOL style mismatches can cause misleading failures in tests using the heredoc syntax (`<<<`) or multiline strings as the expected result.

Fixes #31432. See #42594, #47411.

git-svn-id: https://develop.svn.wordpress.org/trunk@46612 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-29 14:26:41 +00:00
John Blackbourn c6c46a5a48 Docs: Miscellaneous docblock corrections.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46610 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-28 19:46:13 +00:00
John Blackbourn 38dd307f5a Docs: Coding standards fix after [46608].
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46609 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-28 19:33:24 +00:00
John Blackbourn 0cd24d5c60 Docs: Remove some funky nested filters.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46608 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-28 19:02:31 +00:00
Sergey Biryukov 7548aa86ba Docs: Restore correct placement for duplicate hook reference in `render_block_core_latest_comments()`.
Previously fixed in [46604], accidentally reverted in [46606].

See #48447, #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46607 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-28 15:15:51 +00:00
Riad Benguella 6352823e6e Block Editor: Bug fixes targetted for WordPress 5.3 RC3.
The list of included fixes is:

- https://github.com/WordPress/gutenberg/pull/18108
- https://github.com/WordPress/gutenberg/pull/18051
- https://github.com/WordPress/gutenberg/pull/18106
- https://github.com/WordPress/gutenberg/pull/18102

Updated packages:
 - @wordpress/api-fetch@3.6.4
 - @wordpress/block-directory@1.0.4
 - @wordpress/block-library@2.9.4
 - @wordpress/core-data@2.7.4
 - @wordpress/data-controls@1.3.4
 - @wordpress/edit-post@3.8.4
 - @wordpress/editor@9.7.4
 - @wordpress/list-reusable-blocks@1.8.4
 - @wordpress/media-utils@1.2.4
 - @wordpress/server-side-render@1.3.4

Props desrosj.
See #48447.


git-svn-id: https://develop.svn.wordpress.org/trunk@46606 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-28 14:11:06 +00:00
Jake Spurlock cf014839a5 Build/Test Tools: Don't hardcode the directory name of the repo
When Travis builds the directory, it was looking for a hardcoded `wordpress-develop` directory. If the repo is sitting in another directory, the memcache install will fail. This allows a dynamic path for the directory.

Fixes #48444.
Props pento, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@46605 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-28 04:15:37 +00:00
John Blackbourn 8c21607a97 Docs: Correct invalid hook docblock placement.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46604 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-27 19:33:12 +00:00
John Blackbourn b422cc2ef6 Docs: Correct invalid hook docblocks.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46603 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-27 19:09:10 +00:00
Sergey Biryukov 6ac79feeeb Docs: Remove "private" designation from `_doing_it_wrong()` and related functions:
* `_deprecated_function()`
* `_deprecated_argument()`
* `_deprecated_constructor()`
* `_deprecated_file()`

Plugins and themes should be allowed to use these functions to throw appropriate error notices.

This brings them in line with newer `do_action_deprecated()` and `apply_filters_deprecated()` functions, which are not marked as private.

Props jrf.
Fixes #48251.

git-svn-id: https://develop.svn.wordpress.org/trunk@46602 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-27 14:19:13 +00:00
Sergey Biryukov f06419d070 Editor: Fix typo in an error message in `WP_Block_Styles_Registry::register()`.
Props man4toman, alishankhan, shaampk1.
Fixes #48437.

git-svn-id: https://develop.svn.wordpress.org/trunk@46601 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-27 14:06:04 +00:00
Sergey Biryukov fa02b8917e Docs: Improve DocBlock formatting in `WP_Block_Styles_Registry` per the documentation standards.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46600 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-27 14:05:18 +00:00
John Blackbourn 1ec1c5872b Docs: Correct and improve inline docs for the file type functions.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46599 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 23:47:04 +00:00
John Blackbourn e228178d1b Docs: Add missing docs for the `auth_cookie_bad_session_token` action.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46598 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 23:44:02 +00:00
John Blackbourn 3559504161 Docs: Update the docs for the error parameter that gets passed around during filesystem credential collection.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46597 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 23:14:59 +00:00
John Blackbourn 4f281f1650 Docs: Switch more docs over to typed array notation, plus some fixes.
See #48303, #41756


git-svn-id: https://develop.svn.wordpress.org/trunk@46596 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 21:07:10 +00:00
John Blackbourn e07cf22fd0 Docs: Switch to typed array notation for the docs for asset dependency functions.
Props marekdedic

See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46595 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 21:00:08 +00:00
John Blackbourn a2e08032dc Docs: Miscellaneous docblock fixes and improvements.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46594 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 20:42:00 +00:00
Sergey Biryukov c951d94c72 Docs: Improve documentation for `esc_attr_e()`, `esc_html_e()`, `esc_attr_x()`, `esc_html_x()`.
Props atachibana.
Fixes #48383.

git-svn-id: https://develop.svn.wordpress.org/trunk@46593 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 17:28:20 +00:00
Sergey Biryukov e2c34a76f9 Docs: Improve documentation for `wptexturize()`.
Props atachibana.
Fixes #48397.

git-svn-id: https://develop.svn.wordpress.org/trunk@46592 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 00:56:50 +00:00
Sergey Biryukov 21ce200edb Docs: Improve formatting of various `WP_Screen` DocBlocks.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46591 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 00:34:10 +00:00
Sergey Biryukov d490968297 Docs: Improve documentation for `WP_Screen::add_help_tab()`.
Props atachibana.
Fixes #48395.

git-svn-id: https://develop.svn.wordpress.org/trunk@46590 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 00:32:20 +00:00
Sergey Biryukov 354fc5cba0 Build/Test Tools: Add banner to RTL CSS and minified JS files.
Patches occasionally come in on generated files. We should be kind to new contributors and give them a hint that these files are auto-generated.

This is a follow-up to [41271], which added the banner to minified CSS files.

Fixes #48424. See #30666.

git-svn-id: https://develop.svn.wordpress.org/trunk@46589 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-26 00:15:53 +00:00
Jonathan Desrosiers 59ae54b759 Ensure `svn:mime-type` is consistently set for appropriate files.
Continuation of [46586], [46587]

See #42594.

git-svn-id: https://develop.svn.wordpress.org/trunk@46588 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-25 19:31:54 +00:00
Jonathan Desrosiers 10c787f0ca Ensure `svn:eol-style` is consistently set for all files (part 2).
Continuation of [46586]

See #42594.

git-svn-id: https://develop.svn.wordpress.org/trunk@46587 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-25 19:27:49 +00:00
Jonathan Desrosiers d376fedd89 Ensure `svn:eol-style` is consistently set for all files.
See #42594.

git-svn-id: https://develop.svn.wordpress.org/trunk@46586 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-25 16:36:41 +00:00
Jonathan Desrosiers 3646ed75c1 Remove the `svn:executable` property from files that don't need it.
See #42594.

git-svn-id: https://develop.svn.wordpress.org/trunk@46585 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-25 15:34:43 +00:00
Sergey Biryukov ee5227550d Date/Time: Remove incomplete and redundant test for `get_post_time()` added in [46580].
There is no functional difference between `gmt_offset` and `timezone_string` timezone modes for the issue.

See #48384.

git-svn-id: https://develop.svn.wordpress.org/trunk@46583 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-25 15:09:30 +00:00
Jonathan Desrosiers 4b1dd6e549 Trunk is now 5.4 alpha.
git-svn-id: https://develop.svn.wordpress.org/trunk@46582 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-25 14:22:40 +00:00
Sergey Biryukov c67b47c66e Date/Time: Make sure `get_post_time()` keeps UTC time on timezone change.
Add `$source` parameter to `get_post_datetime()` to instantiate from local or UTC time in database.

Props Rarst, david.binda.
Reviewed by azaozz, SergeyBiryukov.
Fixes #48384.

git-svn-id: https://develop.svn.wordpress.org/trunk@46580 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-25 13:06:29 +00:00