sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
21,431 Commits 2 Branches 473 Tags 137 MiB
a6c8efadb9
Commit Graph

40 Commits

Author SHA1 Message Date
Ryan Boren
a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments. 
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
 2013-02-14 22:51:06 +00:00
Andrew Nacin
da1fac02ad Trailing slash the URL for the 'Visit' link in network/sites.php. 
git-svn-id: https://develop.svn.wordpress.org/trunk@22190 602fd350-edb4-49c9-b593-d223f7449a82
 2012-10-11 17:48:42 +00:00
Ryan Boren
7c52a19a5a Reduce reliance on global variables in the list tables. Allow passing a screen ID to the list tables so that ajax handlers can set the needed screen. 
Props nacin
fixes #21871


git-svn-id: https://develop.svn.wordpress.org/trunk@21914 602fd350-edb4-49c9-b593-d223f7449a82
 2012-09-19 12:43:31 +00:00
Ryan Boren
ce960f67a0 Deprecate get_blog_option(), add_blog_option(), update_blog_option(), and delete_blog_option(). 
Use the regular option functions wrapped in switch_to_blog() and restore_current_blog() instead.

Group multiple operations within a single switch where possible.

fixes #21432


git-svn-id: https://develop.svn.wordpress.org/trunk@21414 602fd350-edb4-49c9-b593-d223f7449a82
 2012-08-03 17:51:42 +00:00
Ryan Boren
dd15327790 More screen reader text for list table checkboxes and theme install search. Props MikeLittle, SergeyBiryukov. see #21325 
git-svn-id: https://develop.svn.wordpress.org/trunk@21323 602fd350-edb4-49c9-b593-d223f7449a82
 2012-07-25 16:18:14 +00:00
Ryan Boren
2b186b0c45 Lose EOF ?>. Clean up EOF newlines. fixes #12307 
git-svn-id: https://develop.svn.wordpress.org/trunk@19712 602fd350-edb4-49c9-b593-d223f7449a82
 2012-01-08 17:01:11 +00:00
Ryan Boren
676ba7043e Use one space, not two, after trailing punctuation. fixes #19537 
git-svn-id: https://develop.svn.wordpress.org/trunk@19593 602fd350-edb4-49c9-b593-d223f7449a82
 2011-12-13 23:45:31 +00:00
Ryan Boren
ac34546770 Consolidate larg network criteria into wp_is_large_network(). Allow plugins to change this criteria via filter. Props PeteMall. fixes #18464 
git-svn-id: https://develop.svn.wordpress.org/trunk@18871 602fd350-edb4-49c9-b593-d223f7449a82
 2011-10-03 16:30:07 +00:00
Andrew Nacin
13999695f1 Dissolve wp-admin/network/edit.php. props PeteMall, fixes #18379. 
git-svn-id: https://develop.svn.wordpress.org/trunk@18562 602fd350-edb4-49c9-b593-d223f7449a82
 2011-08-18 02:29:06 +00:00
Ryan Boren
4dcfeabff1 Sites search improvements. fixes #18013 
git-svn-id: https://develop.svn.wordpress.org/trunk@18442 602fd350-edb4-49c9-b593-d223f7449a82
 2011-07-15 15:42:26 +00:00
Ryan Boren
9730cb8d15 Constructor cleanup. Props ocean90. fixes #16768 
git-svn-id: https://develop.svn.wordpress.org/trunk@17771 602fd350-edb4-49c9-b593-d223f7449a82
 2011-04-29 20:05:12 +00:00
Andrew Nacin
b905438706 Avoid mangling the current site path variable with the search query. props greuben, fixes #16720 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@17496 602fd350-edb4-49c9-b593-d223f7449a82
 2011-03-02 18:33:55 +00:00
Andrew Nacin
b789eb1ace Link to site-users and network/user-edit on sites.php. props PeteMall, see #16322. 
git-svn-id: https://develop.svn.wordpress.org/trunk@17336 602fd350-edb4-49c9-b593-d223f7449a82
 2011-01-20 22:08:24 +00:00
Andrew Nacin
2b4674a3b4 Remove AJAX from list tables. first pass. see #16262. 
git-svn-id: https://develop.svn.wordpress.org/trunk@17322 602fd350-edb4-49c9-b593-d223f7449a82
 2011-01-16 21:47:24 +00:00
Ryan Boren
1ac9d9092d Fix registered and path column sorting. Props garyc40. fixes #16034 
git-svn-id: https://develop.svn.wordpress.org/trunk@17180 602fd350-edb4-49c9-b593-d223f7449a82
 2010-12-30 18:06:33 +00:00
Andrew Nacin
de8fda19e3 Validation fixes. props ocean90, fixes #15287. 
git-svn-id: https://develop.svn.wordpress.org/trunk@17129 602fd350-edb4-49c9-b593-d223f7449a82
 2010-12-24 14:19:41 +00:00
Andrew Nacin
266cd3f5df Replace check_permissions() with ajax_user_can(). New method returns true/false to current_user_can(), which we then handle in admin ajax. see #15326. 
git-svn-id: https://develop.svn.wordpress.org/trunk@16992 602fd350-edb4-49c9-b593-d223f7449a82
 2010-12-16 09:18:28 +00:00
Ryan Boren
6dc2d07bc4 Pink trailing whites. 
git-svn-id: https://develop.svn.wordpress.org/trunk@16900 602fd350-edb4-49c9-b593-d223f7449a82
 2010-12-13 21:21:50 +00:00
Peter Westwood
4e3458f227 Actions and Filters for the Network Admin sites panel to make it easier to add custom actions. 
git-svn-id: https://develop.svn.wordpress.org/trunk@16707 602fd350-edb4-49c9-b593-d223f7449a82
 2010-12-03 12:12:44 +00:00
scribu
22f5bc004f Fix problems with hidden columns on network users screen. Props ocean90. See #14579 
git-svn-id: https://develop.svn.wordpress.org/trunk@16601 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-28 17:39:44 +00:00
Peter Westwood
33e3c14b11 And proper context too! 
git-svn-id: https://develop.svn.wordpress.org/trunk@16550 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-23 13:50:23 +00:00
Peter Westwood
2be428108c Correct incorrect action name. 
git-svn-id: https://develop.svn.wordpress.org/trunk@16549 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-23 13:41:57 +00:00
Peter Westwood
ecdda2ce86 Require nonces for all the confirm links so we know they actually came from us. 
Add a nonce check on the confirm links in the Network Admin stage two.


git-svn-id: https://develop.svn.wordpress.org/trunk@16548 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-23 12:14:03 +00:00
Peter Westwood
66a5b13074 Implement proper column show/hide behaviour based on screen options for the Network Admin Sites table column added for the wpmublogsaction hook. 
git-svn-id: https://develop.svn.wordpress.org/trunk@16546 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-23 11:46:10 +00:00
Peter Westwood
40115d566d Implement proper column show/hide behaviour based on screen options for the Network Admin Sites table. 
git-svn-id: https://develop.svn.wordpress.org/trunk@16545 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-23 11:39:50 +00:00
Ryan Boren
c245d5f44b Site search performance tweaks. Use subquery for registration log queries to allow cross DB queries. Lose order by id by default. Search only by blog_id for numeric search strings. see #15170 
git-svn-id: https://develop.svn.wordpress.org/trunk@16489 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-19 18:16:03 +00:00
Ryan Boren
4b33a0e9c4 Pinking shears 
git-svn-id: https://develop.svn.wordpress.org/trunk@16438 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-17 18:47:34 +00:00
Ryan Boren
53ae0610e6 Check delete_site and delete_sites caps. Check for delete_user is more places. 
git-svn-id: https://develop.svn.wordpress.org/trunk@16329 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-12 16:35:28 +00:00
scribu
d95cfc6eab Make 'registered' column sort by site id. See #14579 
git-svn-id: https://develop.svn.wordpress.org/trunk@16289 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-11 11:45:32 +00:00
scribu
7edd2f0090 Default to get_current_screen() in list table classes. See #14579 
git-svn-id: https://develop.svn.wordpress.org/trunk@16182 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-04 15:00:55 +00:00
Peter Westwood
817aa1975c Revert [16171] and [16172] - The class names were fine as they were and the MultiSite classes stand out more with the original naming. 
git-svn-id: https://develop.svn.wordpress.org/trunk@16175 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-04 08:07:03 +00:00
scribu
ed884411fe List-table Class Names: Consistency's Revenge. See #14579 
git-svn-id: https://develop.svn.wordpress.org/trunk@16171 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-03 21:09:27 +00:00
Ryan Boren
0ab95195d0 Allow trailing wildcard site searches by appending *. see #15170 
git-svn-id: https://develop.svn.wordpress.org/trunk@16169 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-03 19:26:23 +00:00
Ryan Boren
358cdf6e23 Make IP query threshold more restrictive. see #15170 
git-svn-id: https://develop.svn.wordpress.org/trunk@16167 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-03 18:40:12 +00:00
Ryan Boren
103523a499 Drop Sites search action dropdown. Determine the search action from the search string. see #15170 
git-svn-id: https://develop.svn.wordpress.org/trunk@16166 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-03 18:28:02 +00:00
Ryan Boren
3c007cce8e Lose wildcards in site search. Maybe bring it back as an option. see #15170 
git-svn-id: https://develop.svn.wordpress.org/trunk@16161 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-03 13:57:43 +00:00
Peter Westwood
bb52f64946 Revert part of [16126] and restore the correct behaviour in the ms sites list. Fixes #15297 props ronbme 
git-svn-id: https://develop.svn.wordpress.org/trunk@16158 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-02 22:13:16 +00:00
Ryan Boren
d6e8a729a9 Default to id since registered doesn't have an index. see #15170 
git-svn-id: https://develop.svn.wordpress.org/trunk@16157 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-02 21:23:26 +00:00
Ryan Boren
a0349d55a1 For large networks, show the latest registered blogs without paging to avoid expensive count queries. see #15170 
git-svn-id: https://develop.svn.wordpress.org/trunk@16137 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-01 17:53:03 +00:00
Peter Westwood
c4633bbd54 The big renaming of the list-table class files. 
See #14579

git-svn-id: https://develop.svn.wordpress.org/trunk@16128 602fd350-edb4-49c9-b593-d223f7449a82
 2010-11-01 09:19:50 +00:00