Gary Pendergast
ce14a63214
Permalinks: Add pretty permalinks for unattached attachments.
...
Previously, unattached attachments would have unsightly `/?attachment_id=1` URLs. As we've moved away from attachments being specifically attached to posts, instead being Media items, this has made the unattached URLs a more common occurrence.
We can breath easy once more, knowing that the world is a little bit safer from the horror of unnecessarily ugly URLs.
Props SergeyBiryukov, wonderboymusic, pento.
Fixes #1914 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34690 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-29 09:41:14 +00:00
DrewAPicture
133b204471
Docs: Move the hook doc to once again directly precede the hook line for the getarchives_where
filter following [34686].
...
See #21596 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34689 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-29 06:38:02 +00:00
Scott Taylor
1ac3ba0828
Allow wp_get_archives()
to accept post_type
as an arg.
...
Adds unit test.
Fixes #21596 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34686 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-29 05:10:10 +00:00
Gary Pendergast
070b65dcfc
Rewrite: Redirect attachment URLs when their slug changes.
...
Using the same logic that we use to redirect posts when their slug changes, we can provide the same functionality for attachments. Attachment pages are posts, too.
Props swissspdy.
Fixes #34043 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34685 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-29 04:57:02 +00:00
Scott Taylor
999e54c8d3
RSS Widget: add a class, rss-widget-icon
, to the RSS icon to allow devs to hide it. Not going to remove to not break visual BC.
...
Fixes #22010 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34683 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-29 04:31:10 +00:00
Scott Taylor
948ab018d2
XML-RPC: calculate the proper offset for GMT in wp.newPost
, mw.newPost
, and mw.editPost
when post_date
is set, wp.editComment
when comment_date
is set. post|comment_date
is assumed to be GMT. This is only true if the timezone string for the site matches GMT.
...
Adds unit tests for each.
Props smerriman, justdaiv, wonderboymusic.
Fixes #30429 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34681 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-29 04:04:16 +00:00
Boone Gorges
36af857315
Don't require explicit taxonomy when getting terms by term_taxonomy_id.
...
Props wonderboymusic.
Fixes #30620 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34679 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-29 03:51:11 +00:00
Drew Jaynes
3edc3b46f2
Introduce get_the_author_posts_link()
, which returns the HTML link to the author page for the current post's author.
...
`the_author_posts_link()` has in-turn been converted into a wrapper, with most of its logic moved to the new function.
Adds tests for the new function.
Props chipbennett, zrothauser, wonderboymusic, DrewAPicture.
Fixes #30355 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34677 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-29 01:48:47 +00:00
Jeremy Felt
fbce07b386
Docs: Clarify $user
parameter documentation in wpmu_validate_blog_signup
.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34676 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-29 01:32:47 +00:00
John Blackbourn
f0200152be
Revert r34674 due to failures on PHP < 5.4.
...
See #16859
git-svn-id: https://develop.svn.wordpress.org/trunk@34675 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-29 01:00:17 +00:00
John Blackbourn
2183725c54
Avoid stripping square brackets from URLs, and instead correctly encode them.
...
Square brackets must be encoded in the path, path parameters, query parameters, and fragment, but must not be encoded in anything up to the domain and port.
Adds a bunch of tests, including square brackets in query parameters, IPv6 URLs, and several other permutations.
See #16859
git-svn-id: https://develop.svn.wordpress.org/trunk@34674 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-29 00:40:30 +00:00
Boone Gorges
f261d3ac8a
Fix comment_order for single page comment threads.
...
The old comment pagination logic had a separate block for comment threads that
appeared on a single page. After the refactoring in [34561], all comment
pagination logic is unified.
This change ensures that 'comment_order' is respected in all scenarios.
Fixes #8071 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34669 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-28 19:29:22 +00:00
John Blackbourn
ac85963ad4
Correctly slash post fields when trashing and untrashing posts.
...
Fixes #27550
Props dmenard, Denis-de-Bernardy
git-svn-id: https://develop.svn.wordpress.org/trunk@34668 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-28 19:25:05 +00:00
John Blackbourn
aaa6e1c27e
Add a nav_menu_item_title
filter for filtering nav menu item titles.
...
Fixes #33447
Props paulwilde
git-svn-id: https://develop.svn.wordpress.org/trunk@34666 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-28 18:40:56 +00:00
John Blackbourn
8823432749
Update get_the_post_thumbnail_url()
so it returns false on failure, to bring it inline with wp_get_attachment_image_url()
. Correct and introduce new tests.
...
Fixes #33070
git-svn-id: https://develop.svn.wordpress.org/trunk@34663 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-28 15:33:12 +00:00
Drew Jaynes
7fce79698a
Widgets: Pass $instance
to the widget_nav_menu_args
filter in the Custom Menu widget.
...
Props walterbarcelos for the initial patch.
Fixes #33944 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34662 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-28 15:30:21 +00:00
Boone Gorges
c1d7e7f5aa
In get_page_of_comment()
, use a true COUNT
query.
...
This improves memory usage by not compiling a list of comment IDs.
See #34057 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34661 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-28 15:09:46 +00:00
Boone Gorges
05e0a3b97e
Use correct 'page_id' parameter in get_page_of_comment()
.
...
See #34057 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34660 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-28 15:09:34 +00:00
Gary Pendergast
6d87c4cecb
Rewrite: When redirecting old slugs, include URL endpoints.
...
Historically, `wp_old_slug_redirect()` has only ever redirected the old slug of posts, it hasn't included URL endpoints, or worked with comment feed URLs. By adding support for these, we ensure a greater range of URLs aren't killed when the slug changes.
Props swissspdy.
Fixes #33920 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34659 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-28 06:56:54 +00:00
Scott Taylor
9d0f206ee1
After [34629], use $size_class
instead of $size
.
...
See #32093 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34657 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-28 02:49:05 +00:00
Gary Pendergast
2b78c9579a
WPDB: Make sure we don't run sanity checks on DB dropins.
...
Previously, we'd run the sanity checks if `is_mysql` was not set to `false`. This caused problems for DB drop-ins that didn't define `is_mysql` at all. Instead, we can just check if `is_mysql` is `empty()`.
Also fix some unit tests that accidently ran correctly because of the strict `false ===` comparison.
Fixes #33501 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34655 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-28 01:16:29 +00:00
Scott Taylor
a155c5dcfd
After [34200], force 'before' and 'after' to <ul>
and </ul>
when wp_nav_menu()
falls back to wp_page_menu()
.
...
See #11095 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34653 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 23:38:32 +00:00
Drew Jaynes
c64bab4531
Docs: Slightly improve the readability of the data table in the DocBlock description for the oembed_providers
hook by centering the HTTPS column.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34644 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 22:11:01 +00:00
Scott Taylor
813bff7bdb
Canonical: after [34272], don't redirect rewrite endpoints on attachment URLs when pretty permalinks are enabled.
...
Fixes #19918 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34643 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 22:10:08 +00:00
John Blackbourn
a0be6bbb12
Don't set CURLOPT_CAINFO
when sslverify
is false when sending HTTP API requests through cURL. This avoids sending redundant information to cURL, and avoids a bug in Apple's SecureTransport library which causes a request to fail when a CA bundle is set but certificate verification is disabled.
...
This fixes issues with local HTTPS requests (eg. WP Cron) on OS X where cURL is using SecureTransport instead of OpenSSL.
Fixes #33978
git-svn-id: https://develop.svn.wordpress.org/trunk@34639 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 21:37:00 +00:00
Drew Jaynes
b3f49e0cdf
Docs: Fix some syntatical issues in the DocBlock for WP::send_headers()
following [34632].
...
See #20226 . See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34635 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 18:48:14 +00:00
Scott Taylor
f802fef76f
Update the docs in WP
to explain the need to do [34476].
...
Fixes #20226 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34632 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 18:27:15 +00:00
Scott Taylor
61d6854bae
Nav Menus: in wp_nav_menu()
, $container
is already bound to a list of allowed tags. PHP, being its whimsical self, while return true
if someone sets $container
to true
via in_array( true, [ 'div', 'nav' ] )
. Check that $container
is a string before the in_array()
check. 'true'
does not pass.
...
Props shedonist for the original patch.
Fixes #32464 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34630 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 18:12:20 +00:00
Scott Taylor
b45a72a67c
Add size-$size
class to <img>
in wp_get_attachment_image()
.
...
Fixes #32093 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34629 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 17:54:01 +00:00
Boone Gorges
de0b5c846f
Introduce 'the_category_list'
filter.
...
Used to filter categories as structured data, before building markup in
`get_the_category_list()`.
We use this filter in addition to upstream filters (such as
'get_the_categories'`) because those upstream filters are used in numerous
contexts, while `'the_category_list'` is always used for generating markup
for display.
Props KevinB, ericlewis, SergeyBiryukov, DrewAPicture.
Fixes #9227 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34625 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 02:21:43 +00:00
Boone Gorges
c39a4a6447
Pass the post ID to the get_the_categories
filter.
...
Props SergeyBiryukov.
See #9227 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34624 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 02:16:23 +00:00
Drew Jaynes
5d9625c28c
Restore and deprecate the WP_Widget_Recent_Comments::flush_widget_cache()
method, removed in [34580].
...
Fixes #25556 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34622 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 01:39:37 +00:00
Drew Jaynes
7510d4e58c
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Nav_Menu_Widget
.
...
Props leemon.
Fixes #34015 . Fixes #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34621 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 01:15:13 +00:00
Drew Jaynes
982d5b99ea
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Archives
.
...
Props leemon.
Fixes #34016 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34620 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 01:10:38 +00:00
Drew Jaynes
9909c7ff2b
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Calendar
.
...
Props leemon.
Fixes #34017 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34619 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 01:06:20 +00:00
Drew Jaynes
b8264d11bc
Docs: Improve documentation for the __construct()
, widget()
, update()
, form()
, and _get_current_taxonomy()
methods in WP_Widget_Categories
.
...
Props leemon.
Fixes #34018 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34618 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 01:03:31 +00:00
Drew Jaynes
aec4d6abe9
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Links
.
...
Props leemon.
Fixes #34019 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34617 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:59:44 +00:00
Drew Jaynes
e9f835dc43
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Meta
.
...
Props leemon.
Fixes #34020 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34616 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:57:03 +00:00
Drew Jaynes
f90a2dbe1c
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Pages
.
...
Props leemon.
Fixes #34021 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34615 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:53:36 +00:00
Drew Jaynes
f2af1a6a1f
Docs: Improve documentation for the __construct()
, recent_comments_style()
, widget()
, update()
, and form()
methods in WP_Widget_Recent_Comments
.
...
Also fixes a typo in the class DocBlock.
Props leemon.
Fixes #34022 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34614 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:50:04 +00:00
Drew Jaynes
fdd92e64cd
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Recent_Posts
.
...
Also fixes a typo in the class DocBlock.
Props leemon.
Fixes #34023 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34613 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:45:42 +00:00
Drew Jaynes
14cac9aded
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_RSS
.
...
Props leemon.
Fixes #34024 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34612 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:41:47 +00:00
Drew Jaynes
f111c41375
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Search
.
...
Props leemon.
Fixes #34025 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34611 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:36:26 +00:00
Drew Jaynes
b28f41f852
Docs: Improve the documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Tag_Cloud
.
...
Props leemon.
Fixes #34026 . See #34013 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34610 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:31:59 +00:00
Drew Jaynes
d6169cab23
Docs: Improve documentation for the __construct()
, widget()
, update()
, and form()
methods in WP_Widget_Text
.
...
(first!) Props leemon.
Fixes #34027 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34609 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-27 00:26:56 +00:00
Scott Taylor
591b743362
After [34577], alter wp_xmlrpc_server::mw_newMediaObject()
to check upload space in multisite.
...
See #21292 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34603 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 19:48:57 +00:00
Boone Gorges
eb8b241559
Improve post field lazyloading for comments.
...
[34583] modified comment queries so that all post fields are no longer loaded
by default. Instead, they are loaded only when requested on individual comment
objects. This changeset improves that flow:
* `WP_Comment` magic methods `__isset()` and `__get()` should only load the post when a post field is being requested.
* The new `update_comment_post_cache` argument for `WP_Comment_Query` allows developers to specify that, when comments are queried, all of the posts matching those comments should be loaded into cache with a single DB hit. This parameter defaults to false, since typical comment queries are linked to a single post.
Fixes #27571 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34599 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 16:01:05 +00:00
John Blackbourn
60660b0055
Remove the unnecessary horizontal rules in the oEmbed providers table to tidy up the Code Reference.
...
See #32246
git-svn-id: https://develop.svn.wordpress.org/trunk@34597 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 15:16:05 +00:00
Boone Gorges
ecf4b81d72
Use correct property name when setting child comments.
...
This fixes a typo from [34546], uncovered by unrelated changes in [34583].
See #8071 , #27571 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34595 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 14:40:15 +00:00
Drew Jaynes
8ec9d5e9e9
Docs: Adjust the table of providers in the hook doc for oembed_providers
to use "No" instead of "!" to signify lack of SSL support.
...
When displayed in the Code Reference, the "!" doesn't convey enough information.
See #32246 . See #28507 .
git-svn-id: https://develop.svn.wordpress.org/trunk@34589 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-26 12:49:44 +00:00