Scott Taylor
3cc9adb890
Unit Tests: in `Tests_Media::test_wp_get_attachment_image_srcset_array_no_width()`, just toggle metadata, instead of creating a new attachment. Shaves 75ms off the test.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35181 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 02:54:20 +00:00
Sergey Biryukov
0f944bb515
Theme Editor: Repurpose the `'wp_theme_editor_filetypes'` filter added in [35134] to actually filter file types instead of files.
...
Default types include 'php' and 'css' and cannot be removed, only new types can be added.
Props DrewAPicture, SergeyBiryukov.
Fixes #22924 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35180 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 02:19:45 +00:00
Scott Taylor
011c1a2e2c
Unit Tests: make a fixture in `Tests_Media` to represent the large image, instead of creating it 10 times.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35179 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 01:42:27 +00:00
Scott Taylor
75e4de9671
Unit Tests: move some oEmbed tests that can trigger HTTP calls to `Tests_External_HTTP_OEmbed`.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35178 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 01:28:05 +00:00
Scott Taylor
fc7efaf9b1
Unit Tests: `Tests_Canonical` doesn't need to call `wp_set_current_user()` or implement `tearDown` because its grandparent calls `wp_set_current_user( 0 )` in `tearDown()`.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35177 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 01:17:22 +00:00
Scott Taylor
a270d619ad
Unit Tests: `Tests_Comment` needs a `tearDownAfterClass` impl to avoid spillage.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35176 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 01:05:50 +00:00
Scott Taylor
9d5c7055e6
Unit Tests: `Tests_Auth` needs a `tearDownAfterClass` impl to avoid spillage.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35175 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 01:03:16 +00:00
Scott Taylor
5fc04e0e26
Unit Tests: call `commit_transaction()` in `Tests_Auth` set up.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35174 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 00:48:22 +00:00
Scott Taylor
5d91776307
Unit Tests: reuse fixtures in `Tests_Comment`.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35173 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 00:38:26 +00:00
Scott Taylor
6f80581b80
Unit Tests: move `->test_readme()` out of `Tests_Basic` and into `Tests_External_HTTP_Basic` in `tests/external-http/`.
...
I intend to move other `wp_remote_get()` tests into similar classes.
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35172 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 00:22:50 +00:00
Scott Taylor
c1b2a034d3
Unit Tests: wrestle performance out of `Tests_Auth` by cloning the same user for a majority of the tests.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35171 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 00:10:45 +00:00
Drew Jaynes
0cb7c0bd9f
Docs: Add missing descriptions for the `$wpdb` global in DocBlocks all the places.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35170 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 23:43:10 +00:00
Drew Jaynes
68a3c0cc73
Docs: Fix third-person singular verbs for summaries in wp-admin/includes/bookmarks.php.
...
Also adds some missing parameter, return, and global descriptions, and one missing summary.
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35169 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 23:24:46 +00:00
Drew Jaynes
c163beb1db
Docs: Standardize file header summary for wp-admin/includes/ajax-actions.php.
...
See #33701 .
[ci skip]
git-svn-id: https://develop.svn.wordpress.org/trunk@35168 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 22:48:24 +00:00
Drew Jaynes
e8a1b5dcdb
Docs: wp-admin/includes/admin-filters.php is part of the Administration subpackage, update the summary.
...
See #33701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35167 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 22:34:55 +00:00
Drew Jaynes
a845610bc6
Docs: Add a version and standardize the file header summary for wp-admin/includes/admin.php.
...
See #33701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35166 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 22:31:55 +00:00
Boone Gorges
734d3794ac
Fix incorrect variable names from [35164].
...
Cool story - the tests appeared to pass with the typos.
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35165 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 21:59:14 +00:00
Boone Gorges
8c7dc25bed
Share fixtures in `Tests_Admin_includesListTable` tests.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35164 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 21:40:44 +00:00
Boone Gorges
9f7bfa9805
Share fixtures in `Tests_Get_Archives`.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35163 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 21:29:59 +00:00
Boone Gorges
6c28fe3853
Create fewer fixtures in some tests.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35162 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 21:23:03 +00:00
Helen Hou-Sandi
c98ac461a9
Screen options: Improve the "Apply" button
...
Previously the button was output as a part of the per-page option rendering, inline with that input. While this was appropriate for core's usage, the `screen_settings` filter has allowed plugins to place additional items at the bottom of the panel, which a number take advantage of. This leads to confusing situations where plugins that don't save settings via Ajax either have to add their own button or piggyback onto the existing button, which doesn't make any sense in the flow of additional options. It also hinders core from adding any other options that need to be submitted.
Also, when the screen options panel is open, a submit button there is the primary action at that moment. The "Apply" button also does a full page load, which a primary button indicates better.
fixes #34295 . see #22222 , #23738 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35161 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 18:57:16 +00:00
Andrea Fercia
33a3d1bba8
Bump the "Status" H3 heading to H2 on the Edit Comment screen for better accessibility.
...
Fixes #34286 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35160 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 17:43:42 +00:00
Jeremy Felt
896b29c857
MS: Introduce action `before_signup_header`.
...
This aligns `wp-signup.php` a bit more `with `wp-activate.php` and, among other things, allows a plugin to redirect signup requests.
Props pbearne.
Fixes #17630 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35159 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 17:31:54 +00:00
Andrea Fercia
359b826e2c
Bump H3 headings to H2 on the legacy Link Manager screen for better accessibility.
...
Fixes #34285 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35158 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 17:31:29 +00:00
Drew Jaynes
5ffe8f5aef
Docs: Add missing file headers to two Toolbar API files: wp-includes/admin-bar.php and wp-includes/class-wp-admin-bar.php.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35157 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 17:26:28 +00:00
Jeremy Felt
224efdf892
MS: Add "Settings" link under "Network Admin" toolbar menu.
...
Props johnjamesjacoby.
Fixes #34287 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35156 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 16:59:33 +00:00
Andrea Fercia
83fd029f6d
Accessibility: update a jQuery selector used for the Plugin Cards after [35009].
...
When updating a plugin from its details modal dialog, focus should be moved back to the plugin title which now is a H3 heading.
Fixes #33818 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35155 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 15:26:31 +00:00
Boone Gorges
6c674cfe20
Create fewer fixtures in XML-RPC `getComments` tests.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35154 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 14:38:30 +00:00
John Blackbourn
ad519f2ee0
Reinstate the Link Category admin screen after [34359].
...
See [13216]
Fixes #34284
git-svn-id: https://develop.svn.wordpress.org/trunk@35153 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 01:50:25 +00:00
John Blackbourn
9fa4df5955
Introduce a language chooser to the site signup process on Multisite.
...
If your Multisite installation is one of the relatively few that allows new sites to be registered, either by existing users or by new visitors to your site, a 'Site Language' dropdown menu will now be presented if your network has additional languages installed. This option defaults to the value of the 'Default Language' setting on the Network Admin Settings screen, and is restricted to currently installed languages.
The languages available in this setting can be controlled via the `signup_get_available_languages` filter. To disable it completely, return an empty array.
Fixes #33844
Props DrewAPicture, johnbillion
git-svn-id: https://develop.svn.wordpress.org/trunk@35152 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 23:45:14 +00:00
John Blackbourn
b5c3abcdfa
Include network-active plugins and inactive network-only plugins on the Plugins listing screen for individual sites on Multisite.
...
These plugins are only shown to users with the `manage_network_plugins` capability, which is Super Admins by default. This new feature lowers the blood pressure of Super Admins who may browse or search the Plugins listing screen of an individual site, having forgotten that a particular plugin is network-active. Showing inactive network-only plugins here also reduces friction when searching the Plugins listing screen on individual sites.
This change introduces a `show_network_active_plugins` filter which controls whether the network-active plugins and inactive network-only plugins are shown. This can be used to enable this functionality for regular site admininstrators, or, indeed, to disable this functionality for Super Admins.
Fixes #20104
git-svn-id: https://develop.svn.wordpress.org/trunk@35151 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 22:11:36 +00:00
Sergey Biryukov
f25ef0e846
Remove `fast_finish: true` from Travis CI configuration for now.
...
Upstream: https://github.com/travis-ci/travis-ci/issues/4928
git-svn-id: https://develop.svn.wordpress.org/trunk@35150 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 21:35:43 +00:00
John Blackbourn
61a40366e6
Improve the docs for the `$expiration` parameter in `set_transient()`, `set_site_transient()`, and associated filters.
...
See #32246
git-svn-id: https://develop.svn.wordpress.org/trunk@35149 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 21:30:41 +00:00
Dominik Schilling (ocean90)
5fc2385b1a
Improve [35146] to only skip pluggable function signature tests for `wp-includes/cache.php` when an external object cache is in use.
...
See #31491 , #33867 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35148 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 20:44:16 +00:00
John Blackbourn
b2fd51c648
Reinstate `wp_cache_get()` into the pluggable function tests. The signature tests are now skipped if an external object cache is in use.
...
See #31491
git-svn-id: https://develop.svn.wordpress.org/trunk@35147 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 19:32:27 +00:00
John Blackbourn
8c1781953c
Skip the pluggable function signature tests when an external object cache is in use.
...
See #31491
git-svn-id: https://develop.svn.wordpress.org/trunk@35146 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 19:30:34 +00:00
John Blackbourn
9d23a7ff96
Remove `wp_cache_reset()` from the pluggable functions signature tests, as the function is deprecated and no longer used.
...
See #31491 , #33867
git-svn-id: https://develop.svn.wordpress.org/trunk@35145 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 19:19:04 +00:00
Drew Jaynes
99ec80b140
Upgrader: Introduce a new action hook `pre_auto_update`, which fires immediately prior to an auto-update for core, themes, plugins, or translations.
...
Props DavidAnderson, welcher.
Fixes #30441 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35144 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 18:58:00 +00:00
Sergey Biryukov
a15ff7d800
Correct the error message displayed on setup when `wp-config-sample.php` does not exist.
...
Props bradparbs.
Fixes #23247 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35143 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 17:35:22 +00:00
Drew Jaynes
7cb8fc1b3b
Multisite: Improve two error strings specifying allowed characters in usernames and site names.
...
Also removes two error strings that were likely never being triggered anyway due to the stricter character matching higher up.
Props atomicjack, bjornjohansen, DrewAPicture.
Fixes #33336 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35142 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 17:32:17 +00:00
Scott Taylor
16b02b6768
KSES: have you ever heard of the `<bdo>` HTML tag? Same. http://www.w3schools.com/tags/tag_bdo.asp
...
Adds unit test.
Props iandunn.
Fixes #34063 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35141 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 17:17:13 +00:00
Scott Taylor
55a42e8afa
Taxonomy: in `wp_list_categories()`, add an arg: `separator`, to allow the overriding of `<br/>`.
...
Props wojtek.szkutnik.
Fixes #9025 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35140 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 17:01:10 +00:00
Scott Taylor
d929461fd8
Taxonomy: `get_terms_to_edit()` can also return `false` or `WP_Error`. Vars using it should be set to empty string when errors are returned to avoid producing fatal errors when used in string operations.
...
Props valendesigns.
Fixes #30472 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35139 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 16:39:47 +00:00
Drew Jaynes
0a8b41c950
Users: Restore changes from [35114] accidentally reverted in [35135].
...
See #28631 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35138 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 15:44:14 +00:00
Boone Gorges
c067ef07ec
Create fewer fixtures in some XML-RPC tests.
...
See #30017 , #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35137 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 15:31:26 +00:00
Boone Gorges
e3f8b888ad
In `WP_UnitTestCase`, only flush rewrite rules when they're set.
...
See [34810]. See #33968 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35136 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 15:21:20 +00:00
Drew Jaynes
5e37130fcd
Docs: Add a changelog entry mentioning that the `number` argument now supports -1 (all).
...
Also fixes the argument description.
-1 support was added in [35114].
See #28631 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35135 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 15:15:30 +00:00
Scott Taylor
eb85b2c11b
Theme Editor: add a filter, `wp_theme_editor_filetypes`, to allow more filetypes to be edited via the Theme Editor. Usage of the Theme Editor is strenuously discouraged, but we should allow you to add whatever filetypes (`.less`, `.scss`) you would like.
...
Props MikeHansenMe, pross.
Fixes #22924 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35134 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 14:13:12 +00:00
Scott Taylor
b9e34ce4a2
Theme Installer: fix the theme "Install"/"Installed" button's vertical alignment for HiDPI displays.
...
Props paulwilde.
Fixes #34198 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35133 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 13:51:45 +00:00
Sergey Biryukov
c5c5bd31dd
Toolbar: Improve padding of toolbar submenu items on small screens.
...
Props tillkruess.
Fixes #28608 .
git-svn-id: https://develop.svn.wordpress.org/trunk@35132 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 07:39:54 +00:00