Anton Timmermans
dcc39fc4e7
Docs: Improve JSDoc for wp-admin/js/user-suggest.js
.
...
Amend r42708 by fixing the 80 character wrap around.
Props timhavinga.
See #43270 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42714 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-15 13:25:22 +00:00
Sergey Biryukov
602724f7a8
Twenty Seventeen: Underline links in comments.
...
Props jainnidhi, larrach, audrasjb.
Fixes #43317 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42713 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-15 03:33:35 +00:00
Sergey Biryukov
43ed92210c
Docs: Move inline comments in wp_kses_split2()
before the blocks they apply to.
...
See #42505 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42712 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-14 11:45:56 +00:00
Sergey Biryukov
b252154091
Customize: Correct closing tags in customize_themes_print_templates()
.
...
Props johnpgreen, nandorsky.
Fixes #43307 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42711 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-13 22:14:36 +00:00
Drew Jaynes
1b46470b75
Docs: Link to the "Conditional Tags" article in the Theme Developer Handbook from the descriptions for a variety of core conditional tag functions.
...
These notations largely serve to direct consumers (of both the source and the parsed code reference) to extended information on individual and related conditional tags throughout WordPress. The changeset also standardizes corresponding DocBlock summaries to use third-person singular verbs.
Notations been added for the following functions:
* comments_open()
* email exists()
* has_excerpt()
* has_post_thumbnail()
* has_tag()
* in_category()
* in_the_loop()
* is_404()
* is_active_sidebar()
* is_active_widget()
* is_admin()
* is_admin_bar_showing()
* is_archive()
* is_attachment()
* is_author()
* is_blog_installed()
* is_category()
* is_comments_popup()
* is_date()
* is_day()
* is_dynamic_sidebar()
* is_feed()
* is_front_page()
* is_home()
* is_local_attachment()
* is_main_query
* is_month()
* is_multi_author
* is_new_day()
* is_page()
* is_page_template()
* is_paged()
* is_plugin_active()
* is_plugin_active_for_network()
* is_plugin_inactive()
* is_plugin_page()
* is_post_type_archive()
* is_preview()
* is_rtl()
* is_search()
* is_single()
* is_singular()
* is_sticky()
* is_tag()
* is_tax()
* is_taxonomy_hierarchical()
* is_time()
* is_trackback()
* is_user_logged_in()
* is_year()
* pings_open()
* post_type_exists()
* taxonomy_exists()
* term_exists()
* username exists()
* wp_attachment_is_image()
* wp_script_is()
Props janalwin.
Fixes #43254 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42710 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-13 16:53:44 +00:00
Anton Timmermans
6a81ffff31
Docs: Improve JSDoc for media/views/spinner.js
.
...
Amends r42675 - includes the built media files.
git-svn-id: https://develop.svn.wordpress.org/trunk@42709 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-13 15:44:14 +00:00
Anton Timmermans
56cef1dc9d
Docs: Improve JSDoc for wp-admin/js/user-suggest.js
.
...
Props timhavinga.
Fixes #43270 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42708 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-13 15:37:07 +00:00
Sergey Biryukov
e1840719e0
Docs: Add documentation for header_video_settings
filter.
...
Props milana_cap.
Fixes #43300 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42707 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-12 22:38:15 +00:00
Sergey Biryukov
954afd1571
Media: In img_caption_shortcode()
, make sure $id
and $caption_id
are always defined.
...
See #34595 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42706 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-12 22:35:56 +00:00
Sergey Biryukov
aee17a059f
Docs: Use code formatting for tags in img_caption_shortcode()
DocBlock.
...
See #34595 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42705 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-12 21:39:40 +00:00
Sergey Biryukov
32e994e478
Media: Pass original attribute values to img_caption_shortcode_width
filter instead of markup pieces.
...
Add `caption_id` to the list of documented `[caption]` shortcode attributes.
See #34595 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42704 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-12 21:36:36 +00:00
Sergey Biryukov
6a43b1658f
Comments: Avoid a PHP notice in paginate_comments_links()
if type
argument is set to array.
...
The function is a wrapper for `paginate_links()`, which returns an array if requested.
Props anantajitjg.
Fixes #43299 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42703 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-12 21:11:13 +00:00
Sergey Biryukov
a62a77eeb7
Media: After [42695], remove redundant check that is already performed a few lines above.
...
Props gnif.
See #43255 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42702 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 21:54:23 +00:00
Sergey Biryukov
9cde54cbda
Database: In require_wp_db()
, check if database constants are defined before using them.
...
Otherwise, `wp-admin/setup-config.php` triggers an undefined constant warning in PHP 7.2.
Props mariusvw, jryancard for initial patch.
Fixes #35560 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42701 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 18:46:48 +00:00
Sergey Biryukov
ff8e7c03d2
Administration: Make sure wp.updates.addAdminNotice
is displayed after the page header and does not unexpectedly push down "Add New" and other buttons.
...
Props shivapoudel.
Fixes #41221 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42700 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 17:27:17 +00:00
Sergey Biryukov
1ac83e86f5
Docs: Fix typo in term_exists()
DocBlock.
...
Props milana_cap, danieltj.
Fixes #43268 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42699 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 17:15:47 +00:00
Sergey Biryukov
2e2fd97287
Networks and Sites: In get_site_by_path()
, use single domain
and path
parameters if there's only one item to look for.
...
This should increase the chances of `WP_Site_Query::get_sites()` hitting an existing cache.
Props spacedmonkey.
Fixes #42299 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42698 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 17:08:58 +00:00
Sergey Biryukov
4bc7afd701
Media: Add aac
to the list of allowed file types.
...
Props desrosj.
Fixes #42919 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42697 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 16:39:54 +00:00
Sergey Biryukov
fca30d4b0e
Docs: Fix typo in wp_audio_extensions
and wp_video_extensions
filter descriptions.
...
See #42505 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42696 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 16:28:29 +00:00
Sergey Biryukov
909424b9af
Media: In WP_Image_Editor::make_image()
, close previously opened output buffer if the file could not be created.
...
Props dhanendran, gnif.
Fixes #43255 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42695 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 16:24:05 +00:00
Sergey Biryukov
0711e585fb
Media: After [42693], update HTML4 markup in img_caption_shortcode()
to avoid an empty ID attribute as well.
...
Add a unit test for `aria-describedby` in `img_caption_shortcode()`.
See #34595 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42694 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 15:39:20 +00:00
Sergey Biryukov
bff366759c
Media: Only add aria-describedby
in img_caption_shortcode()
if a non-empty attachment ID attribute was provided.
...
See #34595 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42693 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 15:19:58 +00:00
Sergey Biryukov
b66da520b3
Media: Make sure $caption_id
does not depend on an undefined variable.
...
See #34595 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42692 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 14:52:03 +00:00
Sergey Biryukov
10ee22ee46
Media: Add aria-describedby
to img_caption_shortcode()
output to improve image/caption relationship.
...
Props joedolson.
Fixes #34595 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42691 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 14:43:40 +00:00
Sergey Biryukov
2b08bfb954
Media: Convert concatenation in img_caption_shortcode()
to sprintf()
for clarity.
...
See #34595 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42690 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 14:16:43 +00:00
Sergey Biryukov
5e9067e8b9
Administration: Remove erroneous transition-delay
values from CSS files.
...
Although unitless zero is allowed for `<length>` CSS data type, it's invalid for `<time>` data type.
Props chetan200891, manuel_84, GaryJ.
Fixes #43195 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42689 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 12:54:15 +00:00
Sergey Biryukov
21258c9bc7
Users: After [41163], add a notice for Email field on Profile screen that the new address will not become active until confirmed.
...
Props dilipbheda.
Fixes #43106 . See #16470 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42688 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-11 12:22:21 +00:00
Sergey Biryukov
6e95cf3403
Build/Test Tools: Update prefixed CSS properties in about.css
.
...
Firefox 52+ supports unprefixed `column-count` and `column-gap` properties.
Props netweb, afercia.
Fixes #43190 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42687 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-10 23:46:10 +00:00
Sergey Biryukov
88d00c0fac
Plugins: Use correct variable name in install_plugin_information()
.
...
Props afragen.
Fixes #43282 . See #43192 , #29274 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42686 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-10 22:07:40 +00:00
Sergey Biryukov
e4519b3444
Administration: Rename Appearance → Editor menu item to Theme Editor and Plugins → Editor to Plugin Editor for clarity.
...
Props xkon, karmatosed.
Fixes #43072 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42685 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-10 08:42:07 +00:00
John Blackbourn
84b08f302e
Comments: Add a "Mine" link to the list of filters on the comment listing screen.
...
This filter shows comments made by the current user, and copies the same filter functionality that's available on the post listing screens.
Props Iceable
Fixes #42379
git-svn-id: https://develop.svn.wordpress.org/trunk@42684 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 18:45:30 +00:00
Drew Jaynes
849fb422f5
Docs: Fix a copy paste error in the DocBlock summary for wp_ssl_constants()
, see [13062].
...
Props terriann.
Fixes #43272 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42683 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 18:20:15 +00:00
John Blackbourn
9f154bbf21
HTTP API: Add the URL as a paramter to various HTTP related filters.
...
Props paulschreiber, purnendu
Fixes #42186
git-svn-id: https://develop.svn.wordpress.org/trunk@42682 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 18:10:15 +00:00
John Blackbourn
a88b338034
Docs: Un-correct an incorrection correction.
...
See [42680]
See #42505
git-svn-id: https://develop.svn.wordpress.org/trunk@42681 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 17:56:07 +00:00
John Blackbourn
5e0b06da49
Docs: Correct some secondary documentation for the https_local_ssl_verify
and https_ssl_verify
filters.
...
See #42505
git-svn-id: https://develop.svn.wordpress.org/trunk@42680 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 17:47:19 +00:00
John Blackbourn
47abf85ab8
Docs: First pass at switching some array parameter documentation to typed notation.
...
Props janak007
See #41756
git-svn-id: https://develop.svn.wordpress.org/trunk@42679 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 17:25:22 +00:00
John Blackbourn
4836686b6f
Docs: Add missing code formatting to various @since
entries.
...
See #42505
git-svn-id: https://develop.svn.wordpress.org/trunk@42678 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 16:54:58 +00:00
John Blackbourn
dc28b0d31d
Docs: Update the hook docs for update_bulk_theme_complete_actions
.
...
See #42505
git-svn-id: https://develop.svn.wordpress.org/trunk@42677 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 16:21:04 +00:00
John Blackbourn
209baca2ca
Posts, Post Types: Add a new add_inline_data
action which allows extra fields to be added to the inline editing fields.
...
Props mensmaximus, NathanAtmoz
Fixes #36085
git-svn-id: https://develop.svn.wordpress.org/trunk@42676 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 15:54:56 +00:00
Anton Timmermans
6e125f017e
Docs: Improve JSDoc for media/views/spinner.js
.
...
Props avillegasn.
Fixes #43230 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42675 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-09 14:31:18 +00:00
Sergey Biryukov
31816ccec2
Posts, Post Types: Remove extra tabs around page_attributes_meta_box_template
action in page_attributes_meta_box()
.
...
Props chetan200891.
See #43252 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42674 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-08 11:23:43 +00:00
Sergey Biryukov
90fe609bc4
Customize: Avoid extra tabs in a textarea in WP_Customize_Control::render_content()
.
...
See #43252 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42673 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-08 10:57:41 +00:00
Sergey Biryukov
02d8aa907a
Upgrade/Install: Avoid extra line breaks in a textarea in wp-admin/setup-config.php
.
...
See #43252 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42672 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-08 10:57:28 +00:00
Sergey Biryukov
0859c8c968
Options: Avoid extra tabs in a textarea in wp-admin/options.php
.
...
See #43252 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42671 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-08 10:57:14 +00:00
Sergey Biryukov
d6bfc44a16
Comments: Avoid extra tabs in a textarea in WP_Comments_List_Table::column_comment()
.
...
Props chetan200891, jrf.
Fixes #43252 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42670 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-08 10:56:55 +00:00
Helen Hou-Sandi
05b37069a4
Options: Use strings in the test suite that follow community guidelines.
...
Also somewhat explain to future maintainers why this pairing of strings was chosen, besides this committer's musical preferences. Social opinions on cancer are fairly clear, as are commonly accepted definitions of profanity and family-friendly language.
Shout out to the close contender, which would have been particularly appropriate here: "You could be the king // But watch the queen conquer".
see #43207 , #38176
git-svn-id: https://develop.svn.wordpress.org/trunk@42667 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 22:41:48 +00:00
John Blackbourn
b7c2dfb9ae
Build/Test Tools: Allow code coverage reports to be generated.
...
This corrects the attribute needed to allow PHPUnit to generate coverage reports, and also adds a blacklist of files and directories that are excluded from coverage reports.
Props schlessera, jipmoors
Fixes #43067 , #43240
git-svn-id: https://develop.svn.wordpress.org/trunk@42665 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 22:20:25 +00:00
John Blackbourn
37a1552e39
Docs: Copy a helpful inline doc into the function header for visibility.
...
See #42505
git-svn-id: https://develop.svn.wordpress.org/trunk@42664 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 22:12:50 +00:00
Aaron Jorbin
2c6f1b18f4
Options: Use most appropriate language in the test suite.
...
The test suite's opinion of cancer should be clear.
Reverts r42659.
See #43207 , #38176
git-svn-id: https://develop.svn.wordpress.org/trunk@42663 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 20:58:21 +00:00
Boone Gorges
fa266b4724
Improve parameter description for 'allow_empty_comments'.
...
Introduced in [42661].
Props swissspidy.
See #16979 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42662 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-07 20:49:26 +00:00