153 Commits

Author SHA1 Message Date
Helen Hou-Sandi
2fd45b514b Set default values for attachment meta and ID3 data when preparing for JS to avoid errors in rendering templates. props ericmann for the initial patch. fixes #29013.
git-svn-id: https://develop.svn.wordpress.org/trunk@29281 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 18:03:58 +00:00
Helen Hou-Sandi
5698a9dc7e Media Grid: Remove fields from showing in the grid itself.
All details are still available within the modal, and less-distinguishable non-image files still show the filename along with the file type icon.

Reverts [29079], [29078], [29077], and [28995]. see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29280 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 05:25:28 +00:00
Helen Hou-Sandi
3d3b141b30 Add support for attachment_fields_to_edit in the attachment details modal. props ericlewis. fixes #28991, see #24716.
git-svn-id: https://develop.svn.wordpress.org/trunk@29278 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-23 22:08:17 +00:00
Scott Taylor
80c4d6a96c Media Grid: general JS cleanup.
Props ericlewis.
See #28965.



git-svn-id: https://develop.svn.wordpress.org/trunk@29266 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 16:20:59 +00:00
Helen Hou-Sandi
25b733cea2 Move the "view" link for attachment details to the sidebar and use more specific language. Removes an unnecessary JS handler. fixes #28977.
git-svn-id: https://develop.svn.wordpress.org/trunk@29263 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 02:19:21 +00:00
Sergey Biryukov
f171b362a9 Media Grid: Add a View button to Attachment Details modal.
props adamsilverstein.
fixes #28977.

git-svn-id: https://develop.svn.wordpress.org/trunk@29262 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 01:29:17 +00:00
Helen Hou-Sandi
e391aa228a Media Grid:
Instead of a separate bulk selection mode, persistently show a checkbox for each item. Restores the more familiar bulk actions dropdown + action button.

props ericlewis. see #28842.



git-svn-id: https://develop.svn.wordpress.org/trunk@29212 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 20:41:40 +00:00
Scott Taylor
5e1556a4ce After [29106], check for data.meta before attempting to render data.meta.bitrate.
See #28839.


git-svn-id: https://develop.svn.wordpress.org/trunk@29208 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 17:41:06 +00:00
Helen Hou-Sandi
fdabfafa0f Media Grid Attachment Details modal UI improvements:
* Align better visually with the existing media modal and the post image edit modal.
* Add back a link to the full attachment edit screen (post.php).
* Add a title to the modal and move prev/next buttons next to the more-consistent close button.
* Remove mode tabs (metadata vs. image editing) in favor of the Edit Image button.

Still to come: responsive, IE8 testing and targeted CSS (calc() usage), general CSS cleanup.

props ericlewis, helen, melchoyce. see #28844. fixes #28915.


git-svn-id: https://develop.svn.wordpress.org/trunk@29204 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 03:54:44 +00:00
Scott Taylor
cba1ae06af Simplify creation of audio, video, and playlist MCE views by placing them in iframe sandboxes.
Wins:
* Eliminates duplication of code between PHP and JS
* Views can load JS without messing with TinyMCE and scope
* MEjs doesn't break when it loads a file plugin-mode. This allows any file type the MEjs supports to play in MCE views.
* YouTube now works as the source for video.
* Users can still style the views, editor stylesheets are included in these sandboxes.
* Audio and Video URLs and `[embed]`s are no longer broken.
* Remove the crazy compat code necessary to determine what file types play in what browser.
* Remove unneeded Underscore templates.
* Remove the compat code for playlists.

See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29179 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 22:17:58 +00:00
Dominik Schilling (ocean90)
33db0d4ff2 Lists View Switcher: Replace blank image with screen reader text.
props davidakennedy.
fixes #28871.

git-svn-id: https://develop.svn.wordpress.org/trunk@29133 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 11:04:21 +00:00
Scott Taylor
8dddb7334f Media Grid, for audio files: show Bitrate in the Edit Attachments modal a la the Edit Post screen.
See #28839.


git-svn-id: https://develop.svn.wordpress.org/trunk@29106 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 21:55:24 +00:00
Scott Taylor
16a70197ed In the Post/Select frames, for audio files:
* Show `artist` and `album` fields in the Attachment Details sidebar
* Sync their values on `change`

See #28839.


git-svn-id: https://develop.svn.wordpress.org/trunk@29105 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 21:01:08 +00:00
Scott Taylor
d1f4b3a800 Media Grid, for audio files:
* Show `artist` and `album` fields in the Edit Attachment modal
* Sync their values on `change`

See #28839.


git-svn-id: https://develop.svn.wordpress.org/trunk@29104 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 20:54:13 +00:00
Scott Taylor
0f50df6cbd Media Grid, in the Edit Attachment modal:
* Label the fields under the attachment a la the Edit Media page
* Move the audio and video previews above the info
* Remove the audio / video icon display. Unnecessary.
* Ensure that `width` and `max-width` are set for `.mejs-container`

See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29088 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 06:14:31 +00:00
Scott Taylor
e52c72c366 Media Grid:
* The "Edit Image" link in the attachment modal details is redundant.
* After an attachment is deleted in the modal, automatically move to the next attachment in the library. If there are no attachments left, close the modal.

See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29085 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 05:21:04 +00:00
Scott Taylor
ba7b26d37e Media Grid: make the Uploader closable.
Props ericlewis.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29082 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 23:05:05 +00:00
Scott Taylor
d5cbf00457 Media Grid: Screen Options for grid have to play nice with Screen Options for list. This was fun.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29078 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 21:25:49 +00:00
Scott Taylor
3ebde0c4d6 Media Grid: Move toggling of visible fields to Screen Options. This moves us in a better direction... but this will probably need to be massaged again.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29077 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 20:59:12 +00:00
Scott Taylor
868d88800c Media Grid: make the edit attachment icon clickable.
Props ericlewis.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29065 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 15:55:21 +00:00
Helen Hou-Sandi
2e0c881d54 Media grid:
* Introduce the concept of bulk editing via a separate mode. Like the list view, only bulk deleting is available. The UI is a little funky, especially with the field display toggles there, but refinements will come.
* Up the max thumbnail size from 120px to 150px.
* Slide-down panel for the add new uploader. Known issue: it doesn't close again.
* Remove the toolbar region in the EditAttachment frame.
* Defer a function call so the grid fills available space.
* Give feedback when no results are found. Also needs styling.

props ericlewis. see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29056 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 03:49:28 +00:00
Scott Taylor
d075028201 Media Grid: JSHint fixes.
See #24716. 


git-svn-id: https://develop.svn.wordpress.org/trunk@28998 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 05:13:46 +00:00
Scott Taylor
7438b91f6f Media Grid: Use the proper attachment value for uploadedToTitle.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28997 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 05:03:06 +00:00
wonderboymusic
9ba94b5c58 Media Grid: for audio and video files with covers, show that instead of the icon. The filename is still present with the extension to identify the type.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28996 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 04:59:01 +00:00
Scott Taylor
ee29246036 Make media grid text fields (data) toggle-able. Checking/unchecking is saved in user settings cookie.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28995 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 04:47:40 +00:00
Helen Hou-Sandi
e14d866665 Media grid, round 2. Expect much more to come.
* Instead of a sidebar for details, utilize a modal. The modal experience allows for a larger preview, editing images, audio/video previews, and previous/next navigation, like the theme browser. Think of it as an attachment browser.
* Show some details in the grid view to more easily distinguish items.

props ericlewis, wonderboymusic, JerrySarcastic. see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28993 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 03:38:33 +00:00
Scott Taylor
0adec3db8a Use the proper height property when calculating video size in wp_underscore_video_template().
Props Fab1en.
See #28190.


git-svn-id: https://develop.svn.wordpress.org/trunk@28807 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 20:34:14 +00:00
Andrew Ozz
09d4b541fb wpView:
- Don't wrap single-line URLs in [embed]. Use them directly in generating a view.
- If the embedding HTML contains a script, "sandbox" it in an iframe to prevent it from changing the editor DOM.
- Automatically add toolbar and overlay when needed.
- Try to embed single-line URLs only if they are pasted in an empty paragraph.
Props avryl, see #28195

git-svn-id: https://develop.svn.wordpress.org/trunk@28748 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-12 02:48:17 +00:00
Andrew Ozz
6228058b64 Fix JS error in tmpl-editor-gallery, 'string'.trim() is not available in IE < 9. See #28089
git-svn-id: https://develop.svn.wordpress.org/trunk@28683 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-06 01:49:44 +00:00
Helen Hou-Sandi
3d9fc450b2 Grid view for the media library, first pass. This is alpha; expect imperfection. We will be iterating further.
props ericlewis, shaunandrews, wonderboymusic.
see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28682 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 22:00:24 +00:00
Helen Hou-Sandi
b27a8697d6 At long last, improved keyboard accessibility for the media modal.
props lessbloat, grahamarmfield, sharonaustin, bramd.
see #23560.


git-svn-id: https://develop.svn.wordpress.org/trunk@28607 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-29 03:38:31 +00:00
Scott Taylor
792fe23675 When adding a URL in the Insert from URL state in the media modal, attempt to show a preview of the content. Drop the unused width and height fields.
This will probably be iterated upon.

Props helen, jtsternberg, wonderboymusic.
See #15490.


git-svn-id: https://develop.svn.wordpress.org/trunk@28581 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-26 23:56:27 +00:00
Sergey Biryukov
e76bfbefbd Don't include caption tags in gallery template when there is no caption.
props avryl.
fixes #28089.

git-svn-id: https://develop.svn.wordpress.org/trunk@28442 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 21:02:04 +00:00
Scott Taylor
e1b341cc59 In the Attachment Details section of the media modal, only add box-shadow to images. Other mime-type icons look strange with an arbitrary border.
Props avryl.
Fixes #27949.



git-svn-id: https://develop.svn.wordpress.org/trunk@28369 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 06:18:02 +00:00
Scott Taylor
a398f38024 First pass at wpview logic for the [embed] shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet.
Props avryl, wonderboymusic.
See #28195.



git-svn-id: https://develop.svn.wordpress.org/trunk@28358 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-10 23:35:08 +00:00
Scott Taylor
7531fd0070 Leverage size_format() when displaying max_upload_size:
* In `media_upload_form()` 
* The `uploader-inline` Underscore template in the media modal. 

Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.

Fixes #25643.



git-svn-id: https://develop.svn.wordpress.org/trunk@28343 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 18:24:47 +00:00
Scott Taylor
77c156631a Alter the layout of the checkboxes in the modal view for Audio/Video Details to allow translations more room to breathe.
See #27893.



git-svn-id: https://develop.svn.wordpress.org/trunk@28184 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-22 20:28:35 +00:00
Scott Taylor
97c497abc2 Refinements for asynchronous rendering in wp.mce.media.PlaylistView:
* Add `visibility: hidden` as an inline style to `<audio>` tags, there is a race with the stylesheet which can get enqueued in the body and loaded in the footer.
* When creating new instances of `MediaElementPlayer`, always push them onto a stack. Lone views can be responsible for multiple instances of the same shortcode on render.
* Rename `wp.media.mixin.unsetPlayer()` to `wp.media.mixin.unsetPlayers()` to reflect the above.
* Call `wp.media.mixin.unsetPlayers()` on the view's `unbind()` method, instead of inline in the `render()` method
* Make sure `WPPlaylistView` is instantiated for each editor instance
* Ensure that the `No Items Found` view state is not rendered when attachments actually do exist.

Props gcorne, wonderboymusic.
See #27899.




git-svn-id: https://develop.svn.wordpress.org/trunk@28182 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-22 17:52:06 +00:00
Andrew Nacin
51882f8707 Graceful failures for TinyMCE views of video/audio playlists.
props gcorne.
fixes #27821.


git-svn-id: https://develop.svn.wordpress.org/trunk@28144 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-16 00:22:28 +00:00
Andrew Ozz
07885ba6c9 Add hooks to the wpeditimage tinymce plugin and to the image details portion of the media modal.
- Add wp.media.events which is intended to be a global media event bus.
- Add a post-render event to the ImageDetails view that third-party code can leverage to add subviews.
- Performance improvement for the initialization of the PostImage model.
- A bit more markup to the image details template to make it easier to add a view to the advanced options.
Props gcorne, fixes #27698

git-svn-id: https://develop.svn.wordpress.org/trunk@28095 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 04:01:53 +00:00
Andrew Nacin
92381845b8 Media Templates: More escaping rather than interpolation. see #21785.
git-svn-id: https://develop.svn.wordpress.org/trunk@28039 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 05:27:44 +00:00
Andrew Nacin
d29a5cee5f Header Images: Add suggested dimensions to the media workflow.
props ehg, gcorne.
see #21785.


git-svn-id: https://develop.svn.wordpress.org/trunk@28030 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 01:54:44 +00:00
nacin
5404d9933f Gallery Views: Avoid JS errors when image attachments lack metadata.
props gcorne.
fixes #27691.


git-svn-id: https://develop.svn.wordpress.org/trunk@28008 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 21:24:02 +00:00
Drew Jaynes (DrewAPicture)
3011b3efef Space vs tab in function descriptions for wp_underscore_audio_template() and wp_underscore_video_template().
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28003 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 20:28:05 +00:00
Scott Taylor
d11d19a2b7 [27640] supported a caption for audio and video shortcodes as part of a UX iteration for the related MCE views. These captions have since be excluded, so the extra code should be removed (it was there for this sole reason).
See #27320.



git-svn-id: https://develop.svn.wordpress.org/trunk@27979 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 06:12:06 +00:00
Andrew Nacin
96e15acb2e Header images: Handle cropping failures.
props ehg.
see #21785.


git-svn-id: https://develop.svn.wordpress.org/trunk@27946 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 15:47:43 +00:00
Andrew Ozz
26391af850 Edit Image modal:
- Fix issue with adding a link to an image that didn't have one previously.
- Adjust the look-and-feel of the advance options toggle so that it becomes a section heading that can be open/closed.
- Add a Custom Size option to the size drop-down that reveals fields for soft-resizing the image inserted into the post.
Props gcorne, and props sdasse for the design help, see #27366

git-svn-id: https://develop.svn.wordpress.org/trunk@27918 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 03:20:40 +00:00
Andrew Ozz
c5f7f95979 Gallery preview: add a "No items found" state which is displayed when rendering the gallery wpview and no attachments are found. Props gcorne, fixes #27558
git-svn-id: https://develop.svn.wordpress.org/trunk@27899 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 02:17:39 +00:00
Andrew Ozz
d4f99c2142 Edit Image modal:
- Move all advanced options under a single “Show advanced options” toggle that mirrors the behavior and look-and-feel of the wplink modal.
- Switch to using <select> for the Size and Link To.
- Bring back the field for CSS Class for the image, but don’t incorporate the internally managed WordPress classes (size-, wp-image-, etc…).
- On larger screen sizes, float labels to the left. When the width drops below 900px, stack the label above the fields.
- Keep image at top on screen sizes where the two columns are stacked into a single column.
- Don't replace the nodes in the editor DOM so we don't stomp on any custom attributes that the user may have added via the Text editor or some other mechanism.
Props gcorne, see #27366

git-svn-id: https://develop.svn.wordpress.org/trunk@27898 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 01:53:56 +00:00
Scott Taylor
882df9f94a Favor escaping over interpolation in Underscore templates for media. Translate some strings directly instead of passing via JS.
Props nacin.
See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27868 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-31 05:12:29 +00:00