Dominik Schilling (ocean90)
a05bbf7e7b
Customizer Theme Switcher: Navigation streamlining.
...
* Detach Themes section from other controls
* Move to buttons to navigate back and forth
* Change titles based on current theme status, active/previewing
* Hide the active/previewing theme from the list of available themes
props folletto for the design concepts.
props designsimply, celloexpressions for initial patches.
props Team Gandalf.
see #31289 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31975 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 22:50:10 +00:00
Dominik Schilling (ocean90)
d6a590e087
Customizer: Make the available widgets overlay closable on narrow screens.
...
see #28784 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31974 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 22:24:21 +00:00
Helen Hou-Sandi
35df5592f1
Admin notices: Make (most) core notices dismissible.
...
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.
props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233 . see #23367 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31973 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 22:05:17 +00:00
Andrew Ozz
e5d660e597
TinyMCE: always focus the editor after using the floated toolbar.
...
Props iseulde. Fixes #30619 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31972 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 21:49:03 +00:00
Lance Willett
00fb680b7d
Twenty Eleven: add `postMessage` support for `header_textcolor` to improve the user experience in the Customizer.
...
Fixes #24128 , props kovshenin, jcastaneda, and lancewillett.
git-svn-id: https://develop.svn.wordpress.org/trunk@31971 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 21:41:36 +00:00
Boone Gorges
4201382267
Unit tests for `wpmu_validate_user_signup()`.
...
See #17904 , #26784 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31970 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 21:37:34 +00:00
Aaron Jorbin
5b676b4f8e
Fix colors for activated and updated plugins
...
If we don't have the updated class on the TR for he update message, then the message is red and red is scary and they just updated, they should be happy and celebrating, not scared.
See #31608
git-svn-id: https://develop.svn.wordpress.org/trunk@31969 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 21:30:50 +00:00
Dominik Schilling (ocean90)
365ed7a6cb
Customizer Theme Switcher: Remove "Add New" references.
...
The current iteration takes you out of the customizer context, which isn't great UX and doesn't really fit into the flows targeted by this particular UI.
fixes #31837 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31968 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 19:49:41 +00:00
Boone Gorges
a143f7f03b
Avoid the use of `array_replace()` in `add_query_arg()`.
...
`array_replace()` was introduced PHP 5.3+. Instead, we walk the array manually.
See [31966].
Fixes #31306 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31967 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 19:39:24 +00:00
Scott Taylor
d1235e323e
Respect numerical keys in `add_query_arg()`, use `array_replace()` instead of `array_merge()`.
...
Adds unit test.
Props tyxla.
Fixes #31306 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31966 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 19:14:46 +00:00
Scott Taylor
bcf98c7742
Alter the regex in `wptexturize()` to properly handle input like: `<> "Hello world" <>`.
...
Updates unit test data.
Props miqrogroove.
Fixes #30344 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31965 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 19:08:31 +00:00
Sergey Biryukov
e4a9e49b6d
When shifting `WP_Rewrite::flush_rules()` to a later action if it was called too early, make sure to do a hard flush if requested.
...
props Denis-de-Bernardy, mordauk for initial patch.
fixes #30501 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31964 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 19:05:21 +00:00
Scott Taylor
2418711c47
When updating the email address for an existing user, make sure the email address is not already in use.
...
Adds unit tests.
Props rittesh.patel, DrewAPicture.
Fixes #30647 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31963 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 18:22:16 +00:00
Sergey Biryukov
f898c8bd3d
Merge title strings on Edit Site screens.
...
props ramiy.
fixes #31844 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31962 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 17:59:25 +00:00
Sergey Biryukov
02253bbcb6
Remove unused `printf()` on network setup screen.
...
props ramiy.
fixes #31841 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31961 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 17:00:49 +00:00
Scott Taylor
45dfe8815f
Remove the JS part of [31619].
...
Fixes #6820 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31960 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 16:33:32 +00:00
Scott Taylor
8f8c526a56
In `WP_Posts_List_Table::get_views()`, don't add the `current` class to the `all` status link if `->user_posts_count` has a value, which triggers the additional `mine` status.
...
See [31828].
Fixes #24869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31959 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 16:17:01 +00:00
Scott Taylor
bbfabf7fb5
When editing an image from the editor, and the image has a value for alignment (but not for `width` or `caption`), don't bail without first checking that the alignment's value is not `alignnone`. If so, add the `class` to the `<a>` before bailing.
...
See #21848 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31958 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 16:03:36 +00:00
Helen Hou-Sandi
efb8f1d491
wpLink: Enable smooth scrolling on iOS devices.
...
fixes #31612 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31957 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 15:33:55 +00:00
Sergey Biryukov
3ecaee903e
Add translator comments for placeholders in network-related strings.
...
props ramiy.
fixes #31834 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31956 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 13:25:55 +00:00
Dominik Schilling (ocean90)
14dc44fb83
Accessibility: Add landmark roles to WordPress admin areas.
...
props afercia, joedolson.
fixes #31450 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31955 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 13:16:47 +00:00
Dominik Schilling (ocean90)
b194676876
Customizer Theme Switcher: Switch the details/live preview buttons.
...
props celloexpressions, ocean90.
fixes #31791 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31954 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 12:35:26 +00:00
Gary Pendergast
ed374ae10e
WPDB: Due to PHP 5.2's internal string handling, strings in Windows are encoded using UTF-16, instead of UTF-8. With the addition of the many character set tests in [30345], a couple of them were tripping up in PHP 5.2 under Windows, because of this behaviour.
...
This marks those tests as skipped.
See #31262 for more discussion.
git-svn-id: https://develop.svn.wordpress.org/trunk@31953 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 12:33:39 +00:00
Dominik Schilling (ocean90)
5f8c60d79d
Themes: Improve focus styling of add-new-theme link.
...
props celloexpressions, mrahmadawais.
fixes #31203 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31952 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 12:21:08 +00:00
Sergey Biryukov
8e9a5a7156
After [31941], use the decoupled strings from `WP_Customize_Manager::register_controls()` on the Menus screen.
...
see #28502 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31951 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 11:36:46 +00:00
Dominik Schilling (ocean90)
8f1a04d2fb
Customizer Theme Switcher: Fix invalid HTML markup when New Theme control is added.
...
see #31203 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31950 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 11:34:23 +00:00
Aaron Jorbin
9932d7973d
Refine UI for FTP modal and shiny updates
...
Numerous changes to make the FTP modal experience a good one. These include:
* Update HTML used by both the form here and the form on the standalone screen
* Allow users to cancel FTP install
* Focus locking in the modal
* Focus on modal form on load
* ARIA Attributes
* Style Enhancements
* Add low screen height (such as phone and some tablets) friendly experience for entering credentials
Props ericlewis, afercia
Fixes #31608
git-svn-id: https://develop.svn.wordpress.org/trunk@31949 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 02:47:55 +00:00
Andrew Ozz
235b83b4c0
Emoji:
...
- Enhance twemoji.js to support passing of additional attributes for the replacement images.
- Use that to add the needed attributes when replacing emoji inside the editor.
Fixes #31627 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31948 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 02:38:25 +00:00
Gary Pendergast
55792b59a8
WPDB: When we check the character set of a column, and find that it's `utf8mb4`, we should also check that the current connection supports `utf8mb4`. It's possible that the environment may have changed since upgrading the DB, so we can fall back to `utf8` when that happens.
...
Fixes #31771 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31947 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 02:21:15 +00:00
Andrew Ozz
29093fe8dc
TinyMCE emoji: fix caret position after replacing emoji in Chrome on Windows 8.
...
See #31627 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31946 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-31 23:34:23 +00:00
Dominik Schilling (ocean90)
d66ac05792
Disable body scrolling when session expired log in modal is open.
...
Fixes also the missing close icon if screen width is less than 380px.
props adamsilverstein, ocean90.
fixes #31610 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31945 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-31 22:54:40 +00:00
Dominik Schilling (ocean90)
5283d55271
Customizer: Defer rendering theme controls until the section is displayed.
...
see #31793 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31944 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-31 22:20:13 +00:00
Sergey Biryukov
78469b71b0
Themes: Add a filter to short-circuit `wp_prepare_themes_for_js()`.
...
props mattwiebe, DrewAPicture.
fixes #31789 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31943 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-31 20:03:55 +00:00
Sergey Biryukov
dcc75b1202
Media Library: Add a label for attachment type select in list mode.
...
props afercia.
fixes #31795 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31942 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-31 19:56:08 +00:00
Sergey Biryukov
0d55562fd7
Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings.
...
This allows for using proper plural forms in languages with more than two forms, and also resolves string conflicts when the same string is present in both singular and plural form.
fixes #28502 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31941 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-31 18:44:46 +00:00
Gary Pendergast
4e6cb8a5e2
Emoji: Fix a unit test which was incorrectly failing after [31926] fixed emoji being incorrectly encoded.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31940 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-31 09:36:29 +00:00
Gary Pendergast
67ae889160
WPDB: When we're checking to see if the MySQL client library supports `utf8mb4`, we need a separate check for `mysqlnd` versions, which using different version numbering to `libmysqlclient`.
...
Props MattyRob.
Fixes #31644 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31939 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-31 09:17:43 +00:00
Gary Pendergast
48e551feb5
Emoji: Change the emoji CDN to w.org, from wp.com.
...
See #31651 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31938 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-31 04:30:38 +00:00
Dion Hulse
9ce354f534
Tests: Clean up the resulting /tmp/foo* files from the `tempnam` call.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31937 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-31 02:10:52 +00:00
Dion Hulse
842d6a9b39
Add some logic into `wp_tempnam` to prevent it creating 'falsey' directory names that might get used elsewhere within WordPress.
...
Although this logic looks a little strange at this low level, it's the best location within the Upgrades code for it to happen.
Fixes #31811
git-svn-id: https://develop.svn.wordpress.org/trunk@31936 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-31 02:10:06 +00:00
Scott Taylor
71557177db
Let us pray to the gods of backwards compatibility:
...
* The way that the JS modules for media are currently set up turns the existing global `wp.media` namespace into a read-only API, this is bad.
* For the existing module implementation to work with plugins, those looking to override or extend a class would have to modify their own plugin to use `browserify` - we can't expect this to happen
* Because the general way that plugins override media classes is via machete (resetting them to something else), we cannot use `require( 'module' )` in the internal code for media modules
We CAN continue to use `require( 'fun/js' )` in the manifests for media.
Future code/projects should carefully consider what is made to be public API. In 3.5, EVERYTHING was made public, so everything shall remain public.
See #31684 , #28510 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31935 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-31 02:02:35 +00:00
Lance Willett
2d3a51d16c
Twenty Fifteen: adjust scroll behavior to make sure sidebar height is calculated during scroll events, not just resize events.
...
Fixes #31734 . Props jartes, lancewillett.
git-svn-id: https://develop.svn.wordpress.org/trunk@31934 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-30 22:48:11 +00:00
ocean90
c0104d6cc2
Customizer: Revert [31911]. We want to preserve `url` and `return` URL parameters to make the experience smoother.
...
see #31782 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31933 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-30 19:21:01 +00:00
Lance Willett
e6614d639b
Twenty Thirteen: make sure submenu links work correctly on small screens with touch events.
...
Fixes #31762 , props davidhamiltron.
git-svn-id: https://develop.svn.wordpress.org/trunk@31932 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-30 19:19:27 +00:00
Andrew Ozz
ae1538daed
TinyMCE wpView: add back the removal of selected views on inserting new content. Was removed when reverting the first fix for embedding of pasted URLs.
...
Props mattheu. Fixes #31796 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31931 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-30 18:21:56 +00:00
Sergey Biryukov
3e9c664a9b
Press This: Use the error message returned by `wp_update_post()` instead of a generic one.
...
props stephdau.
fixes #31808 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31930 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-30 14:38:35 +00:00
Sergey Biryukov
e2a54a80b5
Use a more specific selector for comment moderation hotkeys after [31513].
...
props afercia.
fixes #31545 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31929 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-30 13:53:30 +00:00
Sergey Biryukov
2b55dfcb8b
Make sure the update button in "At a Glance" dashboard widget does not overlap with long strings.
...
props SergeyBiryukov, afercia, tyxla.
fixes #30766 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31928 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-30 12:49:38 +00:00
Sergey Biryukov
dadbb9713c
Fix duplicate ID for Save Menu button on Menus screen.
...
props sagarjadhav.
fixes #31803 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31927 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-30 09:48:15 +00:00
Gary Pendergast
3945ee3f86
Emoji: When encoding emoji into HTML entities, 0 was being incorrectly trimmed from the right side of the hex string, causing some characters to be encoded incorrectly.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31926 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-30 03:26:44 +00:00