Commit Graph

40877 Commits

Author SHA1 Message Date
Sergey Biryukov
944502a094 XML-RPC: Pass correct variable as the URL parameter to http_headers_useragent filter in wp_xmlrpc_server::pingback_ping().
Props wpgurudev, andreaitm.
Fixes #48721. See #42186.

git-svn-id: https://develop.svn.wordpress.org/trunk@46750 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-19 11:05:08 +00:00
Sergey Biryukov
af941d438c Login and Registration: Pass $user_data parameter to the lostpassword_post action in retrieve_password().
Props wpgurudev, pagewidth, lukecavanagh, johnbillion, kkarpieszuk.
Fixes #38334.

git-svn-id: https://develop.svn.wordpress.org/trunk@46749 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-19 09:59:19 +00:00
Andrea Fercia
82e352e412 Accessibility: Media: Add an aria-pressed attribute to active button within a button group.
The `aria-pressed` attribute communicates semantically the "active" state of buttons that otherwise only look "active".

Fixes #48355.


git-svn-id: https://develop.svn.wordpress.org/trunk@46748 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-18 22:21:26 +00:00
Sergey Biryukov
4ebaf2b2d2 Twenty Twenty: Fix typos in a variable name and inline comment in assets/js/color-calculations.js.
Props tanvirul.
Fixes #48704.

git-svn-id: https://develop.svn.wordpress.org/trunk@46747 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-18 17:05:23 +00:00
Andrea Fercia
5e574eb45f Accessibility: Add an aria-current attribute to the Media Library switch links.
The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items.

Props mayanksonawat, afercia.
Fixes #48271.


git-svn-id: https://develop.svn.wordpress.org/trunk@46746 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-18 16:49:42 +00:00
Andrea Fercia
72e66c100e Widgets: Avoid to move focus to the Image Widget "Insert from URL" field.
Fixes a bug after [45499], where the backbone view element isn't the input field any longer. Also, managing focus programmatically is often an assumption on a specific user flow and should generally be avoided, see #43169.

Props dufresnesteven.
See #43169.
Fixes #48588.


git-svn-id: https://develop.svn.wordpress.org/trunk@46745 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-18 16:21:37 +00:00
Sergey Biryukov
22eb74c67b Administration: Switch rgb() CSS property for paused plugin error message in Plugins list table to rgba().
While technically correct as is, the latter is more consistent with other admin styles and causes less confusion.

Props manikmist09.
Fixes #48629.

git-svn-id: https://develop.svn.wordpress.org/trunk@46744 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-18 13:16:54 +00:00
Sergey Biryukov
f64a6a8da7 Taxonomy: Correct the initial value for WP_Taxonomy::$labels to match get_taxonomy_labels() return type.
Improve documentation for consistency with `WP_Post_Type::$labels`.

Props alpipego.
Fixes #48681.

git-svn-id: https://develop.svn.wordpress.org/trunk@46743 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-18 07:57:47 +00:00
Sergey Biryukov
e68601875e Docs: Update broken source code link in WP_Filesystem_SSH2 class.
Props mryoga, finchps.
Fixes #48467.

git-svn-id: https://develop.svn.wordpress.org/trunk@46742 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-17 16:14:37 +00:00
Sergey Biryukov
8781a41915 Docs: Update broken source code link in imgAreaSelect jQuery plugin.
Props mryoga, finchps.
See #48467.

git-svn-id: https://develop.svn.wordpress.org/trunk@46741 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-17 16:12:43 +00:00
Sergey Biryukov
b99845db25 Docs: Replace Codex URLs with corresponding HelpHub articles in wp-config-sample.php.
Props sebastienserre.
Fixes #48680.

git-svn-id: https://develop.svn.wordpress.org/trunk@46740 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-17 11:09:05 +00:00
Sergey Biryukov
7bb2a562a6 Docs: Correct spelling of "subclass" and "overridden" in various docblocks and error messages.
Props garrett-eclipse.
Fixes #48676.

git-svn-id: https://develop.svn.wordpress.org/trunk@46739 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-17 07:41:49 +00:00
SergeyBiryukov
24de36bc5a Docs: Fix typo in wp_credits_section_title() description.
Switch descriptions for `wp_credits_section_title()` and `wp_credits_section_list()` to third-person singular verbs, per the documentation standards.

Props hareesh-pillai.
Fixes #48674.

git-svn-id: https://develop.svn.wordpress.org/trunk@46738 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-16 21:02:02 +00:00
Sergey Biryukov
aa99cfb453 Editor: Pass $editor_id parameter to tiny_mce_plugins, mce_external_plugins, and mce_external_languages filters, for consistency with teeny_mce_plugins.
Document the `classic-block` value passed to various editor filters in `wp_tinymce_inline_scripts()`.

Add missing `@since` entries for the existing `$editor_id` parameter in various filters.

Props djp424, johnbillion, SergeyBiryukov.
Fixes #48441.

git-svn-id: https://develop.svn.wordpress.org/trunk@46737 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-16 16:34:18 +00:00
Sergey Biryukov
81f92c66c6 Security: Add WordPress 5.3.x to the "Supported Versions" section of GitHub Security Policy.
Props imath.
Fixes #48667. See #48521.

git-svn-id: https://develop.svn.wordpress.org/trunk@46736 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-16 11:17:42 +00:00
Jake Spurlock
a2b561e08e Security: Add a GitHub Security Policy.
As part of more responsible security disclosure, we are adding a security policy to GitHub.

Fixes #48521.
Props whyisjake, ayeshrajans.


git-svn-id: https://develop.svn.wordpress.org/trunk@46735 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-15 23:44:17 +00:00
Jake Spurlock
90ad63f2ce Toolbar: Properly escape the onclick attribute.
The onclick attribute was being escaped twice, once with `esc_js` and again with `esc_attr`.

Fixes #48117.
Props tmatsuur, dinhtungdu.



git-svn-id: https://develop.svn.wordpress.org/trunk@46734 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-15 23:22:19 +00:00
Sergey Biryukov
e879f7d457 Docs: Improve a comment about $doing_wp_cron global in wp-cron.php.
Props chinteshprajapati, subrataemfluence, nielslange.
Fixes #46104.

git-svn-id: https://develop.svn.wordpress.org/trunk@46733 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-15 08:57:03 +00:00
Sergey Biryukov
6cf77dbbb6 Docs: Remove incorrect @return tags.
Props diddledan.
Fixes #48613, #48614.

git-svn-id: https://develop.svn.wordpress.org/trunk@46732 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-14 09:55:21 +00:00
Sergey Biryukov
1b55f9d7bf Docs: Correct parameter type for $item in WP_REST_Terms_Controller::prepare_item_for_response().
Props diddledan, TimothyBlynJacobs.
Fixes #48616.

git-svn-id: https://develop.svn.wordpress.org/trunk@46731 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-14 08:53:16 +00:00
Sergey Biryukov
b3c54e6c08 Docs: Fix typo in @return value for PO::trim_quotes().
Props diddledan.
Fixes #48572.

git-svn-id: https://develop.svn.wordpress.org/trunk@46730 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-13 13:44:00 +00:00
John Blackbourn
f42022287a Docs: Correct some invalid hook docblocks.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46729 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 22:40:29 +00:00
Sergey Biryukov
6d27a0595f Help/About: Move images to the CDN.
Props ryelle.
Fixes #47708.

git-svn-id: https://develop.svn.wordpress.org/trunk@46724 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 18:28:40 +00:00
Sergey Biryukov
2a3cbd8e04 Bundled Themes: Update Twenty Twenty.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46715], see fa8c3fc...a9e73ab.

Props Anlino, karmatosed, williampatton, poena, joyously, ianbelanger, chetan200891.
See #48110, #48386, #48450, #48505, #48557.
Fixes #48571.

git-svn-id: https://develop.svn.wordpress.org/trunk@46722 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 18:22:39 +00:00
Sergey Biryukov
1047d80b69 Bundled Themes: Update copyright year in readme.txt for Twenty Twelve and Twenty Twenty.
Follow-up to [46719].

See #48566.

git-svn-id: https://develop.svn.wordpress.org/trunk@46720 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 17:49:24 +00:00
Sergey Biryukov
6c776ea07b Bundled Themes: Update copyright year in readme.txt.
Add a unit test to ensure the year stays up to date.

Props dkarfa, SergeyBiryukov.
Fixes #48566.

git-svn-id: https://develop.svn.wordpress.org/trunk@46719 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 17:34:05 +00:00
Sergey Biryukov
eabc288f67 Bundled Themes: Update Twenty Twenty.
* Add `.has-background` excluding condition to wide and full group-blocks.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46714], see 162edc0...fa8c3fc.

Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Fixes #48557.

git-svn-id: https://develop.svn.wordpress.org/trunk@46715 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 02:04:14 +00:00
Sergey Biryukov
732a358f61 Bundled Themes: Update Twenty Twenty.
* Add a11y-friendly default text-colors when selecting a background-color.
* Remove margins for the group block when a background-color is set.
* Excluding pullquote block from width resize rules.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46711], see ab5fa23...162edc0.

Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Fixes #48557.

git-svn-id: https://develop.svn.wordpress.org/trunk@46713 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 01:42:20 +00:00
Sergey Biryukov
14df1712fd Twenty Twenty: Make CSS adjustments to account for the latest editor changes and ensure that group blocks work in expected ways.
Props williampatton, allancole, karmatosed, pierlo, joen, ianbelanger.
Fixes #48557.

git-svn-id: https://develop.svn.wordpress.org/trunk@46711 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 20:54:49 +00:00
Sergey Biryukov
895ec7224b Help/About: Update the 5.3 About page.
* Remove extra padding on the Credits tab.

Previously [46556], [46572], [46616], [46705].
Props ryelle.
See #47708.

git-svn-id: https://develop.svn.wordpress.org/trunk@46709 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 20:43:48 +00:00
Jake Spurlock
91312ab695 Tests: Fix a typo in an inline comment.
Fix a regression from [46568].

Props david.binda.
See #48312.


git-svn-id: https://develop.svn.wordpress.org/trunk@46707 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 18:48:06 +00:00
Sergey Biryukov
385d0794ae Help/About: Update the 5.3 About page.
* Remove the SVG from the upper right corner.
* Make sure admin notices that should be hidden stay hidden.
* Address a11y issues with contrast.
* Fix an issue with the active nav tab hover.
* Prevent names on the credits from breaking out of the box.
* Update two strings with a more accurate information.

Previously [46556], [46572], [46616].

Props ryelle, afercia, audrasjb, francina, mapk, desrosj, YordanSoares, melchoyce, azaozz, johnbillion, davidbaumwald, luminuu, bwmarkle, la-geek, SergeyBiryukov.
See #47708.

git-svn-id: https://develop.svn.wordpress.org/trunk@46705 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 16:05:39 +00:00
Sergey Biryukov
e4edcf9845 Script Loader: In wp_default_packages_inline_scripts(), make sure the root URL middleware is registered before using the media middleware.
This allows for requests to retry post-processing large images using the `post-process` REST API endpoint to work as expected.

Props azaozz, mikeschroder, TimothyBlynJacobs, epiqueras, johnbillion, youknowriad.
Fixes #48542.

git-svn-id: https://develop.svn.wordpress.org/trunk@46703 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 15:08:43 +00:00
Sergey Biryukov
fdeb2ff358 Twenty Twenty: Fix WPCS issue in [46701].
See #48557.

git-svn-id: https://develop.svn.wordpress.org/trunk@46702 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 12:57:54 +00:00
Sergey Biryukov
41a47a0168 Bundled Themes: Update Twenty Twenty.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC4, see c267289...898792b.

Props williampatton, poena, andersnoren, desrosj, schlessera, leprincenoir, alextran, aristath, b-07.
See #48110, #48386, #48450, #48505.
Fixes #48557.

git-svn-id: https://develop.svn.wordpress.org/trunk@46701 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 12:27:21 +00:00
Sergey Biryukov
ae487b5f67 Comments: Check if comment form element exists before adding a key handler to detect the cmd/ctrl-enter key press.
Follow-up to [45790].

Props raamdev.
Fixes #48543. See #41545.

git-svn-id: https://develop.svn.wordpress.org/trunk@46700 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 11:49:29 +00:00
Sergey Biryukov
1ee0c8e54f Customize: Remove the deprecated -precomposed suffix from apple-touch-icon link in wp_site_icon().
Props mukto90, khag7.
Fixes #48555.

git-svn-id: https://develop.svn.wordpress.org/trunk@46698 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 09:58:17 +00:00
Sergey Biryukov
188f809598 Networks and Sites: Pass the $blog_id parameter to the newblog_notify_siteadmin filter.
Props mukto90, virgodesign.
Fixes #48554.

git-svn-id: https://develop.svn.wordpress.org/trunk@46697 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 09:51:09 +00:00
Sergey Biryukov
cde71eed52 Docs: In various @return tags, list the expected type first, instead of WP_Error.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46696 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 02:41:15 +00:00
Sergey Biryukov
63a534030e Docs: Miscellaneous docblock corrections in wp-admin/includes/plugin.php.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46695 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 00:03:53 +00:00
Sergey Biryukov
84540ab336 Docs: Improve documentation for deactivate_plugins() and activate_plugins().
Props marekdedic, spenserhale, SergeyBiryukov.
Fixes #48352.

git-svn-id: https://develop.svn.wordpress.org/trunk@46694 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-10 23:03:34 +00:00
Sergey Biryukov
1b82ea8284 Tests: Don't skip the tests intended for Multisite when running on single site, add them to the ms-required group instead.
See #43438.

git-svn-id: https://develop.svn.wordpress.org/trunk@46693 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-10 01:53:17 +00:00
Sergey Biryukov
a31133173d Coding Standards: Fix WPCS issue in [46690].
See #41880.

git-svn-id: https://develop.svn.wordpress.org/trunk@46692 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-10 01:43:55 +00:00
Sergey Biryukov
a9b3e85dd3 Docs: Move the @link tag for Customize API in WP_Customize_Manager::add_setting() and WP_Customize_Setting to a more appropriate place.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46691 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-10 01:41:43 +00:00
Sergey Biryukov
99132f8abc Docs: Improve documentation for WP_Http per the documentation standards.
Props hareesh-pillai, adnan.limdi, isabel_brison.
Fixes #41880.

git-svn-id: https://develop.svn.wordpress.org/trunk@46690 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-10 01:17:00 +00:00
Sergey Biryukov
00aff3a706 Docs: Use 3-digit, x.x.x style semantic versioning for $version argument in do_action_deprecated() and apply_filters_deprecated() calls.
Props jrf.
Fixes #48255.

git-svn-id: https://develop.svn.wordpress.org/trunk@46689 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-09 13:55:43 +00:00
Sergey Biryukov
67e82bc32a Docs: Correct the documentation placement for wp_print_styles and shortcode_atts_{$shortcode} hooks.
Props jrf.
See #48255.

git-svn-id: https://develop.svn.wordpress.org/trunk@46688 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-09 13:41:29 +00:00
Sergey Biryukov
36994ef153 Coding Standards: Fix WPCS issue in [46684].
See #48255.

git-svn-id: https://develop.svn.wordpress.org/trunk@46687 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-09 13:31:07 +00:00
Sergey Biryukov
51d64085dc Coding Standards: Revert the change to wp-includes/class-wp-xmlrpc-server.php in [46684] to investigate unit test failures.
See #48255.

git-svn-id: https://develop.svn.wordpress.org/trunk@46686 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-09 13:29:14 +00:00
Sergey Biryukov
26dec96b21 Docs: Use the {@see ...} tag for the replacement in @deprecated tags, so that Developer Reference could automatically link to the replacement.
Props jrf.
See #48255.

git-svn-id: https://develop.svn.wordpress.org/trunk@46685 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-09 13:03:02 +00:00