Commit Graph

36411 Commits

Author SHA1 Message Date
Sergey Biryukov
15346053d6 List Tables: Pass the $which parameter to restrict_manage_posts filter instance in WP_Media_List_Table, missed in [37422].
Props wpsmith.
Fixes #38772.

git-svn-id: https://develop.svn.wordpress.org/trunk@39917 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-17 02:37:14 +00:00
Andrew Ozz
e3ffbce181 TinyMCE: strip browser inserted <u> and <font>` tags from inside links when copying and pasting in IE and Edge.
Fixes #39570.

git-svn-id: https://develop.svn.wordpress.org/trunk@39916 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-17 01:24:35 +00:00
Gary Pendergast
8e3b56fbe3 User Query: Cast $user_total as an int.
The `$user_total` member of `WP_User_Query`, and corresponding `get_total()` method, have always been documented as returning an `int`. `$user_total`, however, is populated by `$wpdb->get_var()`, which returns 
a string (containing an integer value). Casting the return value from `get_var()` as an `int` rectifies this discrepency.

Props runciters.
Fixes #39297.



git-svn-id: https://develop.svn.wordpress.org/trunk@39915 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-16 23:23:06 +00:00
Andrew Ozz
708c750b2e Tests: wpautop() should not add extra </p> before <figcaption>.
Props pbearne.
See #39307.

git-svn-id: https://develop.svn.wordpress.org/trunk@39914 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-16 17:56:34 +00:00
James Nylen
79589f4195 REST API: Improve test coverage of single user endpoint for public data.
Add test coverage for requests of a single user resource for authors of post types registered as:

- public = true, show_in_rest = true: success without auth.
- public = true, show_in_rest = false: fail without auth.
- public = false, show_in_rest = true: success without auth.
- public = false, show_in_rest = false: fail without auth.

See #38878.
Fixes #39546.


git-svn-id: https://develop.svn.wordpress.org/trunk@39913 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-16 16:21:00 +00:00
Andrew Ozz
14e5a08f5c Formatting: fix wpautop() to stop adding paragraph tags around <figcaption>.
Fixes #39307 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@39912 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-16 01:05:33 +00:00
Andrew Ozz
f8cc0fda44 Docs: some improvements/fixes for editor.js.
See #38933.

git-svn-id: https://develop.svn.wordpress.org/trunk@39911 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-16 00:48:49 +00:00
Andrew Ozz
cc8cc98e92 TinyMCE: ensure the inline toolbar is shown and properly positioned when there are several wpview blocks in the editor and the user selects one after the other.
Props gitlost.
Fixes #38849.

git-svn-id: https://develop.svn.wordpress.org/trunk@39910 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-16 00:21:29 +00:00
Sergey Biryukov
19ca7cb022 Twenty Seventeen: Remove duplicate global $post declaration in twentyseventeen_front_page_section().
Props ixkaito.
Fixes #39590.

git-svn-id: https://develop.svn.wordpress.org/trunk@39909 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-15 12:49:25 +00:00
Sergey Biryukov
2904099432 I18N: Reference correct placeholder in a translator comment added in [30333].
See #30264.

git-svn-id: https://develop.svn.wordpress.org/trunk@39908 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-15 08:06:50 +00:00
Sergey Biryukov
fa174e4a06 Users: Display the name of user being edited on Edit User screen.
Props seanchayes.
Fixes #28182.

git-svn-id: https://develop.svn.wordpress.org/trunk@39907 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-15 07:13:11 +00:00
Sergey Biryukov
40f076d756 Themes: Add a unit test for get_theme_feature_list() to make sure that the list of theme features pulled from the WordPress.org API returns the expected data structure.
Props iandunn.
Fixes #28121.

git-svn-id: https://develop.svn.wordpress.org/trunk@39906 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-15 06:50:00 +00:00
Sergey Biryukov
1348f5f3fe Posts, Post Types: Increase the height of post slug input to prevent certain characters from being cut in Firefox on Windows.
Props Ankit K Gupta, Presskopp.
Fixes #28084.

git-svn-id: https://develop.svn.wordpress.org/trunk@39905 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-15 04:02:26 +00:00
Andrew Ozz
e66dc656b3 TinyMCE: prevent the inline toolbar from appearing on partially selected wpview nodes. This can happen when HTML is initially loaded in the editor and wpview is the first node, or sometimes on repeatedly pasting the same wpview.
Props gitlost.
Fixes #38849.

git-svn-id: https://develop.svn.wordpress.org/trunk@39904 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-15 02:59:45 +00:00
Andrew Ozz
7592ee11bd TinyMCE: when inserting a wpview, place the caret after is so the user can continue typing without interruption.
Props iseulde.
Fixes #39337.

git-svn-id: https://develop.svn.wordpress.org/trunk@39903 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-15 02:40:30 +00:00
Andrew Ozz
976976b4a1 TinyMCE: improve removal of spaces from empty paragraphs when loading HTML in the editor.
Fixes #39437.

git-svn-id: https://develop.svn.wordpress.org/trunk@39902 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-15 02:05:44 +00:00
Sergey Biryukov
2fa90d1077 Twenty Seventeen: Correct @param entries for twentyseventeen_custom_colors_css filter.
Props Soean.
Fixes #39575.

git-svn-id: https://develop.svn.wordpress.org/trunk@39901 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-13 15:02:08 +00:00
Sergey Biryukov
e6ae5711e5 Docs: Add missing @param type for wp_cache_get_last_changed().
Props afzalmultani, Soean.
Fixes #39571.

git-svn-id: https://develop.svn.wordpress.org/trunk@39900 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-13 14:15:22 +00:00
Sergey Biryukov
287e5501ab REST API: Update unit tests to account for the string changes in [39896].
See #39054.

git-svn-id: https://develop.svn.wordpress.org/trunk@39899 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-13 05:14:43 +00:00
Sergey Biryukov
2f6e33dd2e Build/Test Tools: After [29858], update .jsintrc to use spaces, not tabs.
Props netweb.
Fixes #39359.

git-svn-id: https://develop.svn.wordpress.org/trunk@39898 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-13 04:44:53 +00:00
SergeyBiryukov
fa4968e343 Administration: Improve tab character width in Plugins and Themes editor.
Props afercia.
Fixes #38684.

git-svn-id: https://develop.svn.wordpress.org/trunk@39897 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-13 04:40:02 +00:00
Sergey Biryukov
18eab18694 REST API: Improve error messages for number relational validation.
Props jblz.
Fixes #39054.

git-svn-id: https://develop.svn.wordpress.org/trunk@39896 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-13 04:37:03 +00:00
Sergey Biryukov
ce89e8dd48 Taxonomy: Add an explanation for "Parent" dropdown for hierarchical custom taxonomies.
Props F J Kaiser, raggedrobins, DrewAPicture, diddledan, SergeyBiryukov.
Fixes #23447.

git-svn-id: https://develop.svn.wordpress.org/trunk@39895 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-13 04:18:16 +00:00
Sergey Biryukov
040362a5e0 Twenty Seventeen: Remove extra asterisk from a translator comment so the comment could be parsed correctly.
Props swissspidy.
See #39116.

git-svn-id: https://develop.svn.wordpress.org/trunk@39894 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-12 21:36:13 +00:00
Sergey Biryukov
bce2389633 Docs: In wp_set_object_terms(), add a note that passing an empty value as $terms argument will remove all related terms.
Props barryceelen.
Fixes #36690.

git-svn-id: https://develop.svn.wordpress.org/trunk@39893 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-12 06:53:21 +00:00
Sergey Biryukov
c2fe0f3dc1 Widgets: In unregister_sidebar(), rename the $name parameter to $sidebar_id for consistency with is_registered_sidebar().
Also correct the parameter type in `@param` entry.

Props Soean, tmatsuur.
Fixes #35147.

git-svn-id: https://develop.svn.wordpress.org/trunk@39892 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-12 06:37:06 +00:00
Sergey Biryukov
d788c3ffed Media: Use a consistent error message for file type errors on uploading.
Props pavelevap, jackreichert.
Fixes #33242.

git-svn-id: https://develop.svn.wordpress.org/trunk@39891 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-12 06:28:32 +00:00
Sergey Biryukov
e9be135754 Docs: Use a consistent description for $plugin parameter in various plugin API functions.
See #36333.

git-svn-id: https://develop.svn.wordpress.org/trunk@39890 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-12 06:15:23 +00:00
Sergey Biryukov
1c66c0ac3c Docs: Improve the DocBlock for validate_plugin().
Props theMikeD.
Fixes #36333.

git-svn-id: https://develop.svn.wordpress.org/trunk@39889 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-12 06:14:31 +00:00
Sergey Biryukov
02cd4a1e97 Docs: After [37083], change "HEX format" to "3- or 6-digit hexadecimal form" for clarity.
Props swissspidy, theMikeD.
Fixes #36336.

git-svn-id: https://develop.svn.wordpress.org/trunk@39888 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-12 05:55:01 +00:00
Sergey Biryukov
98657431de Docs: Make $meta parameter description in multisite signup and registration functions more consistent.
See #38781.

git-svn-id: https://develop.svn.wordpress.org/trunk@39887 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-12 05:20:57 +00:00
Sergey Biryukov
41134d34da Users: In wpmu_signup_blog() and wpmu_signup_user(), pass unserialized signup meta data to after_signup_site and after_signup_user filters introduced in [34112], to match the documented value.
Props MaximeCulea.
Fixes #38781.

git-svn-id: https://develop.svn.wordpress.org/trunk@39886 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-12 04:56:28 +00:00
Sergey Biryukov
89f6427e01 I18N: Move "Site Language" setting above "Timezone".
This brings all locale-specific site settings closer together and prevents the language setting from being pushed down by unrelated settings added by plugins.

Props johnjamesjacoby.
Fixes #38562.

git-svn-id: https://develop.svn.wordpress.org/trunk@39885 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-12 04:27:17 +00:00
Sergey Biryukov
6afc94def0 Themes: Use curly braces for variables inside strings in `get_page_template() to explicitly specify the end of the variable name.
Props kuck1u.
Fixes #38625.

git-svn-id: https://develop.svn.wordpress.org/trunk@39884 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-12 04:12:22 +00:00
Joe McGill
9d9ab96249 Media: Fix exif_imagetype check in wp_get_image_mime
This is a follow up to [39831].

Props gitlost.
See #11946.

git-svn-id: https://develop.svn.wordpress.org/trunk@39850 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-11 16:35:21 +00:00
Joe McGill
9b8cc14192 Tests: Replace broken codeispoetry.png file.
This also updates the test filename in
`WP_Test_REST_Attachments_Controller::test_create_item_default_filename_title()`
to accurately match the actual file name.

git-svn-id: https://develop.svn.wordpress.org/trunk@39848 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-11 16:24:30 +00:00
Aaron D. Campbell
35bd561765 REST API: Change which users are shown in the users endpoint.
Only show users that have authored a post of a post type that has `show_in_rest` set to true.

Props rachelbaker, jnylen0.
See #38878.



git-svn-id: https://develop.svn.wordpress.org/trunk@39843 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-11 14:13:48 +00:00
Joe McGill
7710b3d3ec Media: Improve image filetype checking.
This adds a new function `wp_get_image_mime()` which is used by
`wp_check_filetype_and_ext()` to validate image files using
`exif_imagetype()` if available instead of `getimagesize()`.

`getimagesize()` is less performant than `exif_imagetype()` and is
dependent on GD. If `exif_imagetype()` is not available, it falls back to
`getimagesize()` as before.

If `wp_check_filetype_and_ext()` can't validate the filetype, we now return
`false` for ext/MIME values.

See #11946.

git-svn-id: https://develop.svn.wordpress.org/trunk@39831 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-11 13:07:54 +00:00
Dominik Schilling (ocean90)
ed25ba4f63 Updates: Translate plugin data on the Updates screen.
git-svn-id: https://develop.svn.wordpress.org/trunk@39808 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-11 10:36:59 +00:00
Dominik Schilling (ocean90)
2fc1bde29c Themes: Fix markup for theme name fallbacks.
git-svn-id: https://develop.svn.wordpress.org/trunk@39807 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-11 10:33:33 +00:00
jeremyfelt
728ef3c678 Multisite: Use wp_rand() in signup key creation.
git-svn-id: https://develop.svn.wordpress.org/trunk@39795 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-11 05:29:20 +00:00
Jeremy Felt
3cc0ac5f37 Mail: Disable wp-mail.php when mailserver_url is mail.example.com.
git-svn-id: https://develop.svn.wordpress.org/trunk@39772 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-11 05:12:01 +00:00
Aaron D. Campbell
506a4c55f8 Add nonce for widget accessibility mode.
Props vortfu.

See #23328.



git-svn-id: https://develop.svn.wordpress.org/trunk@39760 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-11 01:31:57 +00:00
Dion Hulse
b1b4d49264 Update PHPMailer to 5.2.22.
The full list of changes is available here:
https://github.com/PHPMailer/PHPMailer/compare/v5.2.21...v5.2.22

Fixes #37210 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@39759 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-11 01:22:46 +00:00
Sergey Biryukov
b8f85ab388 Docs: Make @deprecated entry for wp_kses_js_entities(), deprecated in [38785], consistent with other entries.
Props stevenkword, teinertb.
Fixes #39541.

git-svn-id: https://develop.svn.wordpress.org/trunk@39758 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-10 22:08:16 +00:00
Sergey Biryukov
cb50dc9e06 Docs: Change @param type for $user_object in WP_Users_List_Table::single_row() from object to WP_User to be more accurate.
Props sebastian.pisula.
Fixes #39536.

git-svn-id: https://develop.svn.wordpress.org/trunk@39757 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-10 12:44:29 +00:00
Sergey Biryukov
26514215a7 Posts, Post Types: Use an existing string for "Invalid post type" error message.
Props ramiy.
Fixes #39171.

git-svn-id: https://develop.svn.wordpress.org/trunk@39756 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-10 02:40:00 +00:00
Sergey Biryukov
efefa1d05e Docs: Remove incorrect @param tags for admin_print_footer_scripts-{$hook_suffix} and admin_footer-{$hook_suffix} dynamic actiona.
Remove `@global` tags as well as they are not suited to describe a function parameter and are documented in the description of the actions.

Props keesiemeijer.
Fixes #39527.

git-svn-id: https://develop.svn.wordpress.org/trunk@39755 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-09 14:37:55 +00:00
Sergey Biryukov
588290ccee Docs: Move install_global_terms() DocBlock after the function_exists() call.
Props keesiemeijer.
Fixes #39526.

git-svn-id: https://develop.svn.wordpress.org/trunk@39754 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-09 14:30:47 +00:00
Sergey Biryukov
ddbbd3e8a8 Docs: Use correct closing tag in submit_field description in comment_form().
Props truongwp.
Fixes #39508.

git-svn-id: https://develop.svn.wordpress.org/trunk@39753 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-07 14:50:55 +00:00