Commit Graph

39911 Commits

Author SHA1 Message Date
Sergey Biryukov
ae8a620efb General: First pass at replacing Codex URLs with a corresponding HelpHub or DevHub article.
Props ianbelanger, tobifjellner, SergeyBiryukov.
See #47771.

git-svn-id: https://develop.svn.wordpress.org/trunk@45674 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 22:44:48 +00:00
Sergey Biryukov
77a1f39484 Upgrade/Install: Bring some consistency to installation screen styles.
* Include `forms.css` and `l10n.css`, for consistency with login screen and other admin screens.
* Remove redundant `@import` directives from `login.css` for files already declared as dependencies.
* Adjust margin on password strength meter for consistency with other fields.
* Increase font size for "You will need this password to log in" notice.
* Fix misaligned icon on "Hide" button for the password.

Props iseulde, dan@micamedia.com, bassgang, cdog, johnbillion, nmenescardi, mukesh27, SergeyBiryukov.
Fixes #35776, #47757, #47758.

git-svn-id: https://develop.svn.wordpress.org/trunk@45673 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 19:10:33 +00:00
Sergey Biryukov
f00229ac0e Docs: Clarify that is_network_admin() does not check if the site is a Multisite network; is_multisite() should be used for that.
Props svovaf, dilipbheda, tazotodua.
Fixes #47415.

git-svn-id: https://develop.svn.wordpress.org/trunk@45672 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 15:18:05 +00:00
Sergey Biryukov
128597b69a Posts, Post Types: Introduce is_sticky filter in is_sticky() to provide more flexibility for custom sticky post implementations.
Props dehisok, greenshady.
Fixes #37629.

git-svn-id: https://develop.svn.wordpress.org/trunk@45671 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 01:35:52 +00:00
Sergey Biryukov
d758aa802d Code Editor: Check for correct mode value in wp.codeEditor.initialize to enable autocomplete support for PHP.
Props ediamin.
Fixes #47769.

git-svn-id: https://develop.svn.wordpress.org/trunk@45670 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 01:26:13 +00:00
Sergey Biryukov
85f0ec3eba Permalinks: Update URLs for "Changing File Permissions" documentation article.
Props patilswapnilv, ianbelanger, SergeyBiryukov.
Fixes #47768.

git-svn-id: https://develop.svn.wordpress.org/trunk@45669 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 01:18:01 +00:00
Sergey Biryukov
66be571e3a Coding Standards: Use correct variable in wp_dropdown_categories() after [45667].
See #45059.

git-svn-id: https://develop.svn.wordpress.org/trunk@45668 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 01:06:45 +00:00
Sergey Biryukov
e5a0610d53 Coding Standards: Rename $r variable used with wp_parse_args() to $parsed_args for clarity.
Props freewebmentor.
Fixes #45059.

git-svn-id: https://develop.svn.wordpress.org/trunk@45667 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 00:47:53 +00:00
Gary Pendergast
3d1714de71 Coding Standards: Move the remaining PHPCS errors to report as warnings, and add Travis tests.
The remaining error-level coding standards issues (specifically, associated with the sniffs `WordPress.PHP.YodaConditions.NotYoda`, `WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase`, `WordPress.DB.PreparedSQL.InterpolatedNotPrepared`, `WordPress.DB.PreparedSQL.NotPrepared`, and `WordPress.Files.FileName.InvalidClassFileName`) are marked as warnings, until they're all addressed.

This change allows us to run linting on Travis across the entire codebase, ensuring no other error-level violations can be introduced.

Additionally, PHPCS will now cache results locally, drastically improving performance for subsequent checks: scanning the entire codebase takes 1-2 minutes the first time, and less than one second for subsequent checks.

See #47632.



git-svn-id: https://develop.svn.wordpress.org/trunk@45665 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-19 07:47:16 +00:00
Gary Pendergast
ab26c9a2fb Coding Standards: Fix a filename replacement missed in [45663].
See #47632.



git-svn-id: https://develop.svn.wordpress.org/trunk@45664 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-19 04:42:00 +00:00
Gary Pendergast
4943b377ce Coding Standards: Move wp-includes/class-oembed.php to wp-includes/class-wp-oembed.php.
This renames the file containing the `WP_oEmbed` class to conform to the coding standards.

This commit also includes:

- A new `class-oembed.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.

See #47632.



git-svn-id: https://develop.svn.wordpress.org/trunk@45663 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-19 04:31:40 +00:00
Gary Pendergast
e0d8dbe350 Coding Standards: Move wp-admin/custom-background.php to wp-admin/includes/class-custom-background.php
This renames the file containing the Custom_Background class to conform to the coding standards.

This commit also includes:

- A new custom-background.php that includes the new file, for anyone that may've been including the file directly.
- Replaces a reference to the old filename with the new filename.

See #47632.


git-svn-id: https://develop.svn.wordpress.org/trunk@45662 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-19 04:01:41 +00:00
Gary Pendergast
968254f4f4 Coding Standards: Exclude a handful of incorrectly named files that won't be renamed.
See #47632.


git-svn-id: https://develop.svn.wordpress.org/trunk@45661 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-19 03:49:26 +00:00
Gary Pendergast
8cf3e59fc4 Coding Standards: Improve spacing of printf() calls in the admin About pages.
Props garrett-eclipse.
Fixes #47734.



git-svn-id: https://develop.svn.wordpress.org/trunk@45660 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-19 00:08:38 +00:00
Sergey Biryukov
6ec230ac18 I18N: Make URLs to https://wordpress.org/about/ and related pages translatable, as they can now be localized on Rosetta sites.
Props mukesh27.
Fixes #46386.

git-svn-id: https://develop.svn.wordpress.org/trunk@45659 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-18 12:40:39 +00:00
Gary Pendergast
0b06e59940 Customizer: Show all widgets when the search field is cleared.
When clicking the clear button on the widget search field, the search results should refresh to show all widgets.

Props Mahesh901122.
Fixes #47534.


git-svn-id: https://develop.svn.wordpress.org/trunk@45658 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-18 05:54:10 +00:00
Sergey Biryukov
e6e96d0ef9 Editor: Replace external Classic Editor plugin URL with a link to Add Plugins screen with Classic Editor pre-selected.
This applies to messages displayed when JavaScript is disabled in Block Editor, or an incompatible meta box is used.

Props garrett-eclipse, derweili, afercia.
Fixes #47487.

git-svn-id: https://develop.svn.wordpress.org/trunk@45657 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-18 01:32:13 +00:00
Sergey Biryukov
9db88b1b02 Coding Standards: Fix WPCS issues in [45655].
See #47723.

git-svn-id: https://develop.svn.wordpress.org/trunk@45656 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-17 19:21:28 +00:00
Sergey Biryukov
fd23000b11 Menus: Trim whitespace from custom link URLs.
Props majemedia, SergeyBiryukov.
Fixes #47723.

git-svn-id: https://develop.svn.wordpress.org/trunk@45655 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-17 18:44:56 +00:00
Gary Pendergast
8416a2b410 Coding Standards: Move wp-admin/custom-header.php to wp-admin/includes/class-custom-image-header.php
This renames the file containing the `Custom_Image_Header` class to conform to the coding standards.

This commit also includes:
- A new `custom-header.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.

See #47632.



git-svn-id: https://develop.svn.wordpress.org/trunk@45654 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-17 06:16:27 +00:00
Gary Pendergast
3686fd8c59 Coding Standards: Exclude some class names from checks when they can't be renamed.
Renaming the classes would likely cause back compat issues, so the safest option is to allow this handful to continue unchanged.

See #47632.



git-svn-id: https://develop.svn.wordpress.org/trunk@45653 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-17 04:33:27 +00:00
Sergey Biryukov
3bb75e0a3f Coding Standards: Fix WPCS issues in [45651].
See #38195.

git-svn-id: https://develop.svn.wordpress.org/trunk@45652 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-17 01:49:08 +00:00
Sergey Biryukov
916916317d Media: Add "Documents", "Spreadsheets", and "Archives" groups to file type filter in Media Library.
Props zodiac1978, swissspidy, karmatosed, SergeyBiryukov.
Fixes #38195.

git-svn-id: https://develop.svn.wordpress.org/trunk@45651 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-17 01:21:55 +00:00
Sergey Biryukov
ceeb99ecbc Administration: In admin-ajax.php, send X-Robots-Tag header earlier, so that it applies before wp_die() when no action parameter was provided.
Props robi-bobi, harryfear, garrett-eclipse.
Fixes #47711.

git-svn-id: https://develop.svn.wordpress.org/trunk@45650 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-17 01:10:59 +00:00
Sergey Biryukov
8df86efc2b Site Health: Use consistent verbiage for "Learn more" links.
Props ronakganatra, garrett-eclipse.
Fixes #47302.

git-svn-id: https://develop.svn.wordpress.org/trunk@45649 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-16 22:27:55 +00:00
Sergey Biryukov
94a6e06ab9 Site Health: Replace "harddrive" with "device" on Site Health Info screen.
Props chetan200891, timhavinga, Cybr, Clorith.
Fixes #46965.

git-svn-id: https://develop.svn.wordpress.org/trunk@45648 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-16 22:18:58 +00:00
Sergey Biryukov
a65fcde5c0 I18N: Merge duplicate "Your plugins/themes/translations are all up to date" strings.
Props ramiy.
Fixes #47252.

git-svn-id: https://develop.svn.wordpress.org/trunk@45647 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-16 22:13:01 +00:00
Sergey Biryukov
2ae276c44f Media: Add a unit test for wp_get_mime_types().
Props pbearne.
Fixes #47701.

git-svn-id: https://develop.svn.wordpress.org/trunk@45646 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-16 21:51:45 +00:00
Andrew Ozz
9d00289c60 Media: Sort the new sizes array by priority when creating image sub-sizes.
See #40439.

git-svn-id: https://develop.svn.wordpress.org/trunk@45645 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-16 21:47:35 +00:00
Sergey Biryukov
98a2971872 Customize: In WP_Customize_Widgets::capture_filter_pre_update_option(), return the filtered value instead of null when bailing early for ignored options.
Props dlh.
Fixes #47715.

git-svn-id: https://develop.svn.wordpress.org/trunk@45644 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-16 21:32:21 +00:00
Sergey Biryukov
09fc7ba6ae Docs: Move the do_mu_upgrade DocBlock out of the preceding if statement.
Props ChriCo, dkarfa.
Fixes #47710.

git-svn-id: https://develop.svn.wordpress.org/trunk@45643 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-16 13:14:45 +00:00
Sergey Biryukov
811b92192d Docs: Correct @since tag for do_mu_upgrade hook, for consistency with after_mu_upgrade and wpmu_upgrade_site.
See #47110.

git-svn-id: https://develop.svn.wordpress.org/trunk@45642 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-16 12:41:16 +00:00
Sergey Biryukov
1570f89693 Comments: Fix typo in comment reply observer options.
Props maguiar.
Fixes #47706. See #46260.

git-svn-id: https://develop.svn.wordpress.org/trunk@45641 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-15 16:45:58 +00:00
Gary Pendergast
9f8a75e154 Code Modernisation: Revert [45624].
Changing the method signatures on `Walker` causes back compat issues.

See #47678.




git-svn-id: https://develop.svn.wordpress.org/trunk@45640 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-15 07:03:54 +00:00
Gary Pendergast
2da7f9f524 Code Modernisation: Fix known instances of array access on data types that can't be accessed as arrays.
PHP 7.4 addes a warning when trying access a null/bool/int/float/resource (everything but array, string and object) as if it were an array.

This change fixes all of these warnings visible in unit tests.

Props jrf.
See #47704.




git-svn-id: https://develop.svn.wordpress.org/trunk@45639 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-15 06:24:08 +00:00
Gary Pendergast
e6c750b55c Code Modernisation: Document when the Hash polyfills can be removed.
The Hash extension cannot be disabled as of PHP 7.4. So, while we can't remove these polyfills yet, we can document when we'll be able to.

Props jrf.
Fixes #47698.



git-svn-id: https://develop.svn.wordpress.org/trunk@45638 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-15 05:13:10 +00:00
Gary Pendergast
593c402dc7 Code Modernisation: Remove the SPL autoloader polyfill.
As of PHP 5.3, the SPL extension cannot be disabled, so we no longer need this polyfill.

The file is kept with a `_deprecated_file()` call, to alert any plugins or themes that may be loading it directly.

Props jrf, ayeshrajans.
See #47698, #46630.



git-svn-id: https://develop.svn.wordpress.org/trunk@45637 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-15 05:10:36 +00:00
Gary Pendergast
f3b826dd74 Code Modernisation: Remove the array_replace_recursive() polyfill.
This function was added in PHP 5.3.0, so we no longer need the polyfill.

Props jrf.
See #47698.



git-svn-id: https://develop.svn.wordpress.org/trunk@45636 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-15 05:07:20 +00:00
Gary Pendergast
6b3ccc2c64 WPDB: Allow custom data to be added to logged queries.
This adds a new method, `wpdb::log_query()`, and a new filter, `log_query_custom_data`. The custom data is stored as a new element in each entry of the `wpdb::$queries` array.

Props CrazyJaco, johnbillion, pento.
Fixes 42151.


git-svn-id: https://develop.svn.wordpress.org/trunk@45635 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-15 04:06:24 +00:00
Sergey Biryukov
eb9f88e763 I18N: Add context for theme filter strings in WP_MS_Themes_List_Table::get_views().
Props audrasjb.
Fixes #47695.

git-svn-id: https://develop.svn.wordpress.org/trunk@45634 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-14 14:46:10 +00:00
Sergey Biryukov
60c7970d14 Upgrade/Install: Remove debugging artifacts from wp-admin/upgrade.php added in [1229].
Props rahulvaza.
Fixes #47074.

git-svn-id: https://develop.svn.wordpress.org/trunk@45633 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-14 14:38:43 +00:00
Sergey Biryukov
0492ad749d REST API: Allow rest_get_avatar_urls() to accept full user, post, or comment objects, rather than just an email address, to provide better flexibility for alternative avatar data.
Since the function uses `get_avatar_url()` internally, which already supports it, this should not have any backward compatibility concerns.

Props donmhico, dshanske, pputzer, joehoyle, TimothyBlynJacobs.
Fixes #40030.

git-svn-id: https://develop.svn.wordpress.org/trunk@45632 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-14 14:34:02 +00:00
Andrew Ozz
a7041b951b TinyMCE: fix adding of too many undo levels for wpviews. The HTML changes several times when a wpview is added. We only want one undo level. Also fixes cases when the cursor is next to an embeddable URL in the Text tab and the user switches to the Visual tab.
See #45307.

git-svn-id: https://develop.svn.wordpress.org/trunk@45631 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-12 03:24:20 +00:00
Gary Pendergast
1f8d74409b Code Modernisation: Introduce the spread operator in wpdb::prepare().
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.


git-svn-id: https://develop.svn.wordpress.org/trunk@45630 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-12 00:16:34 +00:00
Gary Pendergast
e0c9623ae1 Code Modernisation: Introduce the spread operator in widgets.php.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.


git-svn-id: https://develop.svn.wordpress.org/trunk@45629 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-12 00:13:07 +00:00
Gary Pendergast
e6cde1614b Code Modernisation: Introduce the spread operator in theme.php.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf, pento.
See #47678.


git-svn-id: https://develop.svn.wordpress.org/trunk@45628 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-12 00:09:31 +00:00
Gary Pendergast
6e829a7b26 Code Modernisation: Introduce the spread operator in walk_page_dropdown_tree().
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.


git-svn-id: https://develop.svn.wordpress.org/trunk@45627 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-12 00:04:57 +00:00
Sergey Biryukov
03b7742ee9 Customize: Fix text direction for color picker in RTL.
Props vjik for the report.
Fixes #47688. See #23740.

git-svn-id: https://develop.svn.wordpress.org/trunk@45626 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-12 00:04:41 +00:00
Gary Pendergast
17ba89b662 Code Modernisation: Introduce the spread operator in add_post_type_support().
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf, pento.
See #47678.


git-svn-id: https://develop.svn.wordpress.org/trunk@45625 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-12 00:01:19 +00:00
Gary Pendergast
6c3ba83eb9 Code Modernisation: Introduce the spread operator in Walker.
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.


git-svn-id: https://develop.svn.wordpress.org/trunk@45624 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-11 23:50:37 +00:00