Commit Graph

6342 Commits

Author SHA1 Message Date
Sergey Biryukov 84efe08557 CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/customize-widgets.css`.
Props ianbelanger, pbiron, afercia.
Fixes #46509. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45460 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-29 16:00:40 +00:00
Jonathan Desrosiers 1b4d29ab71 Administration: Add missing filter documentation for Site Health auto update tests.
Props johnbillion, mukesh27.
Fixes #47388.

git-svn-id: https://develop.svn.wordpress.org/trunk@45459 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-29 13:58:33 +00:00
Andrew Ozz 2d02bb13d1 Script loader: prevent sorting of the `load` array in the query string when passing the script handles to load-scripts.php and load-styles.php.
Fixes #45346 #26886.

git-svn-id: https://develop.svn.wordpress.org/trunk@45456 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-28 02:42:24 +00:00
Sergey Biryukov 6d523d5044 Docs: Add a comment about the reinstated `wp-admin/options-privacy.php`.
See #43895.

git-svn-id: https://develop.svn.wordpress.org/trunk@45454 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-27 03:02:33 +00:00
Sergey Biryukov 2208412015 Privacy: Remove reinstated `wp-admin/options-privacy.php` from `$_old_files`.
Fix WPCS violations in [45448].

See #43895.

git-svn-id: https://develop.svn.wordpress.org/trunk@45453 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-27 02:39:46 +00:00
Andrew Ozz d670b91335 Fix typo in [45451] and move the redirect to the proper location.
See #43895.

git-svn-id: https://develop.svn.wordpress.org/trunk@45452 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 23:20:56 +00:00
Andrew Ozz 2fb86e26e6 Privacy tools: restore `privacy.php` to its "proper" use to output the Privacy tab on the About screen, see [42814]. Then add the Privacy tab updates from freedoms.php.
See #43895.



git-svn-id: https://develop.svn.wordpress.org/trunk@45451 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 22:56:18 +00:00
John Blackbourn 41847b234e Docs: Improve documentation for some more variadic functions.
Fixes #37402


git-svn-id: https://develop.svn.wordpress.org/trunk@45450 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 22:47:23 +00:00
Andrew Ozz 9fcb362fa0 Privacy tools: Organize privacy functions into logical files and classes.
Props xkon, birgire, desrosj, garrett-eclipse, azaozz.
See #43895.

git-svn-id: https://develop.svn.wordpress.org/trunk@45448 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 20:49:04 +00:00
Sergey Biryukov b8e4a052a7 I18N: Merge duplicate "Add Comment" strings.
Props ramiy.
Fixes #47246.

git-svn-id: https://develop.svn.wordpress.org/trunk@45441 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 18:42:35 +00:00
Sergey Biryukov 3820ae932b I18N: Use consistent error messages when importing or exporting content.
Props ramiy.
Fixes #42269.

git-svn-id: https://develop.svn.wordpress.org/trunk@45440 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 18:08:55 +00:00
Sergey Biryukov e1cc160ba9 I18N: Merge duplicate "not allowed to manage options" strings.
Props ramiy.
Fixes #42271.

git-svn-id: https://develop.svn.wordpress.org/trunk@45439 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 15:59:37 +00:00
Sergey Biryukov 88f579b256 I18N: Merge duplicate "Loading..." strings.
Props ramiy.
Fixes #47248.

git-svn-id: https://develop.svn.wordpress.org/trunk@45438 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 15:45:57 +00:00
Sergey Biryukov 8bda02eec6 I18N: Merge similar strings in Edit Media help tabs.
Props ramiy.
Fixes #46919.

git-svn-id: https://develop.svn.wordpress.org/trunk@45437 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 15:37:11 +00:00
Sergey Biryukov b10cf79f01 I18N: Merge duplicate "Try Again" strings.
Props ramiy.
Fixes #47251.

git-svn-id: https://develop.svn.wordpress.org/trunk@45433 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 14:39:35 +00:00
Sergey Biryukov 2e32d4331f I18N: Remove unnecessary markup from plugin action messages, for consistency with the rest of the admin.
Props ramiy.
Fixes #47238.

git-svn-id: https://develop.svn.wordpress.org/trunk@45432 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 14:35:58 +00:00
Sergey Biryukov 85e517ca48 Administration: Merge similar "file does not exist" messages in plugin and theme editors.
Props ramiy.
Fixes #47249.

git-svn-id: https://develop.svn.wordpress.org/trunk@45431 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 12:34:09 +00:00
Sergey Biryukov 10855438ea Date/Time: Replace all instances of `date()` with `gmdate()`.
Use of `date()` in core depends on PHP timezone set to UTC and not changed by third party code (which cannot be guaranteed).

`gmdate()` is functionally equivalent, but is not affected by PHP timezone setting: it's always UTC, which is the exact behavior the core needs.

Props nielsdeblaauw, Rarst.
Fixes #46438. See #44491.

git-svn-id: https://develop.svn.wordpress.org/trunk@45424 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 00:11:37 +00:00
Andrea Fercia d013696652 Accessibility: Improve toggling the "Post locked" information visibility.
- effectively hides the "Post locked" information from assistive technologies
- when a post is locked, reveals the "Post locked" information without CSS animation
- the height CSS animation didn't work anyways after [24906]

See #24553.
Fixes #44946.


git-svn-id: https://develop.svn.wordpress.org/trunk@45417 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 17:14:29 +00:00
Andrea Fercia 12c154717b Accessibility: Improve settings tables and forms after [45403].
- adds `role="presentation"` to the edit comment table 
- removes a few pointless `<fieldset>` elements
- adds a few missing `<label>` elements
- adds the CSS class `class="td-full"` to table rows spanning to multiple cells
- adds explicit `scope="row"` attribute to the table headers in `options-permalink.php`: this table is better communicated as data table 
- uses consistent label association in the "Privacy Settings" page
- in the installation page "Set up your database connection": associates descriptions to their inout fields using `aria-describedby`
- improves the link to gravatar.com in the `user-edit.php` page

See #46899.
Fixes #47390.


git-svn-id: https://develop.svn.wordpress.org/trunk@45416 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 15:18:24 +00:00
Sergey Biryukov 56b2957c2e CSS Coding Standards: Update unitless values for `line-height` in `wp-admin/css/widgets.css` with more precise calculations.
Props ianbelanger.
Fixes #46531.

git-svn-id: https://develop.svn.wordpress.org/trunk@45415 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 14:43:29 +00:00
Sergey Biryukov 1752bc29a7 CSS Coding Standards: Update unitless values for `line-height` in `wp-admin/css/nav-menus.css` with more precise calculations.
Props ianbelanger.
Fixes #46516.

git-svn-id: https://develop.svn.wordpress.org/trunk@45414 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 14:41:55 +00:00
Sergey Biryukov 8081adfefa Editor: In `edit-form-blocks.php`, check the result of `wp_set_post_lock()`, which may return `false` and cause a warning when passed to `implode()`.
Props kakshak, aduth.
Fixes #47013.

git-svn-id: https://develop.svn.wordpress.org/trunk@45413 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 14:34:30 +00:00
Sergey Biryukov a6fa4b5491 General: Update support forum links.
There are a lot of places in Core that link to https://wordpress.org/support/ for the support forums, but that's now the URL for HelpHub. The new forums link is https://wordpress.org/support/forums/.

This is a follow-up to [45140], which changed the links in help tabs.

Props dilipbheda.
Fixes #47239. See #46790.

git-svn-id: https://develop.svn.wordpress.org/trunk@45412 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 14:23:27 +00:00
Andrea Fercia 57ebd24077 Accessibility: Fix the headings hierarchy in the legacy Custom Background and Custom Header pages.
Fixes #47386.


git-svn-id: https://develop.svn.wordpress.org/trunk@45411 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 13:31:59 +00:00
John Blackbourn 8226fe338f Users: Allow Super Admins to remove themselves from a site on a Multisite network.
Props Mista-Flo, birgire

Fixes #41439


git-svn-id: https://develop.svn.wordpress.org/trunk@45407 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-25 00:12:22 +00:00
Sergey Biryukov a3fbc75237 Accessibility: Make sure layout tables across the admin are correctly linearized.
Adds `role="presentation"` to the `<table>` elements used for layout purposes.

Ideally, HTML tables should be used for tabular data. When tables are used for layout purposes, it's important to remove any native semantics so that assistive technologies can correctly announce the table content in a linearized fashion.

Props greatislander, afercia.
Fixes #46899.

git-svn-id: https://develop.svn.wordpress.org/trunk@45403 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 21:55:21 +00:00
John Blackbourn a4d9f02eef I18N: Add a language icon next to language selectors.
This change means that users who can't read the site's current language can more easily identify controls that allow them to change either the site language or their own admin area language.

Props janak007, atlasmahesh, afercia, birgire, JoshuaWold

Fixes #43144


git-svn-id: https://develop.svn.wordpress.org/trunk@45402 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 20:42:06 +00:00
John Blackbourn 971b5daa74 Administration: Replace references to "articles" with "posts" for greater consistency of terminology.
Props angelagibson

Fixes #38517


git-svn-id: https://develop.svn.wordpress.org/trunk@45401 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 19:17:50 +00:00
Sergey Biryukov 630f4bc1ea I18N: Remove PHP function name from translatable string in `WP_Debug_Data`.
Props ramiy.
Fixes #47254.

git-svn-id: https://develop.svn.wordpress.org/trunk@45399 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 01:40:35 +00:00
Sergey Biryukov c725e9f0d8 Docs: Fix typos in DocBlocks and comments in `wp-admin/includes/file.php`.
Props mukesh27.
Fixes #47026.

git-svn-id: https://develop.svn.wordpress.org/trunk@45394 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 01:07:52 +00:00
Sergey Biryukov 60df42d187 Networks and Sites: Readjust tabs in `wp-admin/includes/network.php` for (more or less) consistent alignment.
See #47062.

git-svn-id: https://develop.svn.wordpress.org/trunk@45391 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 23:34:40 +00:00
Sergey Biryukov 4f51d3679c Networks and Sites: Remove extra whitespace in `.htaccess` rules on Network Setup page.
Props riddhiehta02 for initial patch, sebastienserre, masterforwordpress.
Fixes #47062.

git-svn-id: https://develop.svn.wordpress.org/trunk@45390 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 23:27:57 +00:00
John Blackbourn 2756e6a27f Administration: Don't apply italic formatting to code blocks in setting descriptions.
Props chetan200891

Fixes #42651


git-svn-id: https://develop.svn.wordpress.org/trunk@45389 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 23:13:51 +00:00
John Blackbourn 9b248694ac I18N: Use a complete translatable string for the "Delete My Site" email subject.
Props thrijith

Fixes #46855


git-svn-id: https://develop.svn.wordpress.org/trunk@45387 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 22:14:28 +00:00
Sergey Biryukov 70f0b32079 I18N: Capitalize "Privacy Policy Page" heading to merge two similar strings.
Props ramiy, garrett-eclipse.
Fixes #47250.

git-svn-id: https://develop.svn.wordpress.org/trunk@45384 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 21:10:56 +00:00
Sergey Biryukov e23ea906e2 I18N: Make punctuation in some `wp-admin` strings more consistent.
Props pedromendonca.
Fixes #47358.

git-svn-id: https://develop.svn.wordpress.org/trunk@45382 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 01:11:04 +00:00
Sergey Biryukov ff131f5e29 Upgrade/Install: As a follow-up to [45357], when linking to Update PHP support page in error messages, check if `wp_get_update_php_url()` and `wp_get_update_php_annotation()` exist.
`wp-admin/includes/update-core.php` runs in the context of the previous WordPress version. Any calls to newly introduced functions there need to be checked via `function_exists()`.

Reviewed by desrosj, earnjam, SergeyBiryukov.

Props dd32, imath.
Fixes #47323.

git-svn-id: https://develop.svn.wordpress.org/trunk@45365 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-20 14:28:03 +00:00
Sergey Biryukov 0205cf09f0 Upgrade/Install: Improve error messages displayed when WordPress update fails due to an incompatible PHP version by linking to the Update PHP support page.
Additionally, fix a regression in [44451] where the error message in `wp-admin/upgrade.php` was prepared, but never displayed.

Props afragen, netweb, hareesh-pillai, SergeyBiryukov.
Fixes #46937.

git-svn-id: https://develop.svn.wordpress.org/trunk@45357 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 18:10:55 +00:00
Sergey Biryukov ee8771923a Site Health: In PHP modules test description, move the space before the screen reader text out from the translatable string.
Props ocean90, tobifjellner.
Fixes #47161.

git-svn-id: https://develop.svn.wordpress.org/trunk@45346 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 11:49:52 +00:00
Alex Shiels 85a90cb244 Upgrade/Install: Don't run signature verify on slow 32-bit systems.
The sodium_compat library can be very slow for certain operations on 32-bit architectures, which can lead to web server timeouts while attempting to verify an update. This adds a runtime speed check to skip signature verification on systems that would otherwise time out. Includes simple unit tests.

Props dd32, paragoninitiativeenterprises.
See #47186.


git-svn-id: https://develop.svn.wordpress.org/trunk@45345 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 11:05:45 +00:00
Sergey Biryukov dc8c8dd878 Help/About: Restore placeholder for WordPress version in tagline on About, Credits, and Freedoms pages to include minor versions.
Props desrosj, mukesh27.
Fixes #46408.

git-svn-id: https://develop.svn.wordpress.org/trunk@45338 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 01:07:12 +00:00
Sergey Biryukov 040a58ff57 Site Health: Use correct singular string for plugin and theme version tests.
Props edocev, Presskopp.
Fixes #47264.

git-svn-id: https://develop.svn.wordpress.org/trunk@45336 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 00:59:20 +00:00
Sergey Biryukov 448234f966 I18N: Avoid using placeholders for link start and end tags in alt text description strings added in [45158].
Use an established pattern of moving additional link attributes out of the translatable string.

Props dimadin.
Fixes #47159.

git-svn-id: https://develop.svn.wordpress.org/trunk@45334 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 00:52:32 +00:00
Sergey Biryukov e6dcab7803 Site Health: In PHP modules test, ensure the description is translated as a whole sentence, not as separate string parts.
Props dimadin, SergeyBiryukov.
Fixes #47161.

git-svn-id: https://develop.svn.wordpress.org/trunk@45331 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 00:06:49 +00:00
Sergey Biryukov 0126a4bd2a Site Health: In HTTP requests test, when checking whether the `WP_HTTP_BLOCK_EXTERNAL` constant is defined, check its value as well.
Props chesio.
Fixes #47297.

git-svn-id: https://develop.svn.wordpress.org/trunk@45328 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 22:07:35 +00:00
Jonathan Desrosiers c18460698f Privacy: Prevent email field for personal data requests from overflowing.
Props anischarolia, ianbelanger, afercia.
Fixes #46961.

git-svn-id: https://develop.svn.wordpress.org/trunk@45326 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 20:44:41 +00:00
Jonathan Desrosiers cd511054a0 Menus: Fix alignment of menu actions on mobile.
In [41197], changes were made to improve the responsive view for the Menu Name field and Save buttons. This caused the Delete Menu button to be misaligned.

Props ianbelanger, audrasjb, afercia, mukesh27.
Fixes #47173.

git-svn-id: https://develop.svn.wordpress.org/trunk@45324 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 19:04:42 +00:00
Jonathan Desrosiers b7a79cf126 Site Health: Improve alignment and spacing for section headers.
This changes the CSS for Site Health headers to use flexbox, which helps ensure the text is vertically aligned center and consistently spaced in both the Status and Info tabs. It also fixes an issue where the loading spinner GIF was cut off on smaller screens (originally reported in #47203.

Props Presskopp, odminstudios, kjellr, afercia, desrosj, hedgefield, ianbelanger, xavortm.
Fixes #47063.

git-svn-id: https://develop.svn.wordpress.org/trunk@45322 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 18:29:47 +00:00
Jonathan Desrosiers 851cb8b8f2 Site Health: Improve vertical alignment of icons in test result descriptions.
This change removes redundant CSS properties for different health check statuses in favor of utilizing the `.dashicons` class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Props chetan200891, Clorith, desrosj.
Fixes #46940.

git-svn-id: https://develop.svn.wordpress.org/trunk@45309 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-15 14:24:15 +00:00
Jonathan Desrosiers f10ea0702a Site Health: Link to the correct plugin update screen in multisite installs.
Props Clorith, sebastienserre, jeremyfelt, desrosj.
Fixes #47189.

git-svn-id: https://develop.svn.wordpress.org/trunk@45308 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-15 14:11:50 +00:00
Andrea Fercia cae0608a7f Accessibility: Improve the "skip links" position for medium and small screens.
Fixes #47065.


git-svn-id: https://develop.svn.wordpress.org/trunk@45301 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-09 21:10:20 +00:00
Andrea Fercia 2ee480e11c Accessibility: Add `aria-current` to the links in the `<nav>` elements introduced in [44905].
Also fixes a few translators comments and coding standards.

Props audrasjb.
Fixes #47106.


git-svn-id: https://develop.svn.wordpress.org/trunk@45300 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-09 20:57:06 +00:00
Jonathan Desrosiers 3da0d67f80 I18N: Combine similar strings with minor differences.
Props dimadin.
Fixes #47158.

git-svn-id: https://develop.svn.wordpress.org/trunk@45298 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-09 19:47:28 +00:00
Jonathan Desrosiers a72dd388f5 Administration: Prevent cards on the Tools page from overflowing on small screens.
Props anischarolia, mukesh27.
Fixes #46972.

git-svn-id: https://develop.svn.wordpress.org/trunk@45296 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-09 14:55:18 +00:00
Jonathan Desrosiers 3607546bad Help/About: Update the 5.2 tagline on Freedoms and Credits.
Props ocean90.
See #46901.

git-svn-id: https://develop.svn.wordpress.org/trunk@45292 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-07 19:59:17 +00:00
Jonathan Desrosiers 6289d9e304 Help/About: Final 5.2 about page updates.
Use final image URLs and fix a bug in IE11 where images were being cut off.

Props afercia, SergeyBiryukov, ianbelanger, desrosj, audrasjb.
See #46901.

git-svn-id: https://develop.svn.wordpress.org/trunk@45287 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-07 17:18:34 +00:00
Jonathan Desrosiers 994950ea8c Help/About: Polish the About page for 5.2.
- The About page now uses a CSS grid to layout its design, making the page’s structure more obvious and hopefully easier for contributors in the future.
- Removes some code that is no longer used (such as videos, mejs elements, etc.).
- Update images.
- Unnecessary HTML is removed from a string on the page. This was a regression.
- Only users with the correct capability should be instructed to check their site status.
- Fixes the placement of commas.

Reviewed by melchoyce, afercia, jeremyfelt, and desrosj.

Props ryelle, melchoyce, cathibosco1, man4toman, SergeyBiryukov, afercia, ramiy, kjellr, tellyworth, earnjam, andreamiddleton, marybaum.
See #46901.

git-svn-id: https://develop.svn.wordpress.org/trunk@45278 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-02 15:43:10 +00:00
Jonathan Desrosiers f33df7cde4 Help/About: Fix tab display issues.
This change restores About page tab heights and fixes bugs with the tab bottom border caused by [44905] and [45243].

Reviewed by SergeyBiryukov and desrosj.

Props ixkaito, ianbelanger, afercia, SergeyBiryukov.
See #46901.
Fixes #47075.

git-svn-id: https://develop.svn.wordpress.org/trunk@45276 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-02 10:36:02 +00:00
Jonathan Desrosiers 62645be17e Site Health: Disable recommendations that could be problematic on multisite installs.
When viewing Site Health for a multisite install, there are a few recommendations that are not appropriate and could have negative implications for other sites on the install if the administrator follows the advice provided.

For example, Site Health recommends that inactive plugins and themes for a site should be removed. On a single site install, this is a great recommendation. However, on a multisite install, inactive plugins and themes for one site should not be removed because they could be active for other sites on the network.

This change also disables the `test_wp_version_check_attached()` test for multisite. This test checks for the presence of the `wp_version_check()` function on the `wp_version_check` hook, which is not present for every site on multisite.

Reviewed by jeremyfelt and desrosj.

Props iandunn, Clorith, azaozz, jeremyfelt.
Fixes #47084.

git-svn-id: https://develop.svn.wordpress.org/trunk@45275 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-01 18:07:46 +00:00
Aaron Jorbin a8942b4a17 Admin: Add some additional clarity to some about page links
It's important for links to have enough information in them in order to be clearly actionable. Destination and purpose should be clear. For example, `debug` isn't nearly as useful as `learn how to debug issues`.

This was signed off on by chanthaboune and jorbin.

Props afercia.
See: #46901.



git-svn-id: https://develop.svn.wordpress.org/trunk@45274 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-30 17:30:27 +00:00
Gary Pendergast 3477102cec Admin: Add the text for the WordPress 5.2 About page.
This changes includes placeholder images for now, they'll be replaced by the final images before final release.

Props chanthaboune, melchoyce, karmatosed, pento, marybaum, birgire, earnjam, andreamiddleton.
See #46901.



git-svn-id: https://develop.svn.wordpress.org/trunk@45271 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-26 00:56:57 +00:00
Sergey Biryukov 4f4f253821 Docs: Use 3-digit, x.x.x style semantic versioning for `@since 5.2.0` entries in `wp-admin/includes/file.php`.
See #46543.

git-svn-id: https://develop.svn.wordpress.org/trunk@45266 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-24 23:35:50 +00:00
Alex Shiels 1343858467 Upgrade/install: fix verification bugs and scale back signature checks.
This fixes several bugs in the signature verification code:
Disables signature checks on certain incompatible PHP versions that cause math errors when opcache is enabled;
Prevents a spurious URL and subsequent error when downloading a zip file with query arguments;
Prevents errors triggered by third-party upgrade scripts as per #46615;
Disables signature tests for Plugins, Themes, and Translations, leaving only core updates.

At the 5.2 release the API servers will only provide signatures for core update packages, which is why messages are suppressed for plugins and other package types. Signatures for those other items will become available later.

Props dd32.
See #39309, #46615



git-svn-id: https://develop.svn.wordpress.org/trunk@45262 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-24 07:43:29 +00:00
Andrew Ozz e13ef071ff Site Health: Fix count of inactive themes and the recommendation to remove them when the default theme is active or is a parent of the active child theme.
Props sudhiryadav, ianbelanger, mukesh27, azaozz.
Fixes #46900.

git-svn-id: https://develop.svn.wordpress.org/trunk@45260 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-23 21:36:02 +00:00
Andrew Ozz 14fc4634a2 Site Health: Allow some HTML (inline tags only) in the section descriptions. Add some more docs about expected formatting of the gathered data.
Props kraftbj, jeherve, mukesh27, audrasjb, azaozz.
Fixes #46878.

git-svn-id: https://develop.svn.wordpress.org/trunk@45259 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-23 21:04:19 +00:00
Sergey Biryukov f7dba2af72 Networks and Sites: Use correct escaping function for classes added via ` ms_user_list_site_class` filter.
Props david.binda.
Fixes #46990. See #41146.

git-svn-id: https://develop.svn.wordpress.org/trunk@45252 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-19 13:50:32 +00:00
Dominik Schilling 1eb665b20c Site Health: Fix debug data with nested fields for copying.
* Use `$debug_data` instead of `$field['value']` to retrieve the debug data.
* Rename inner variables to avoid overriding the output variable.

Props Clorith, ocean90.
See #46573.

git-svn-id: https://develop.svn.wordpress.org/trunk@45246 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-18 16:25:05 +00:00
Dominik Schilling eda377ba9e Site Health: Provide context for tab headings to be able to distinguish them from existing strings.
See #46573.

git-svn-id: https://develop.svn.wordpress.org/trunk@45245 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-18 16:05:17 +00:00
Gary Pendergast b074b74489 CSS: Remove the units from `line-height` properties in `common.css`.
Props ianbelanger, talldanwp.
Fixes #46493.



git-svn-id: https://develop.svn.wordpress.org/trunk@45243 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-18 06:01:56 +00:00
Andrew Ozz 288116c9ff Site Health info tab: Remove the "Directories and Sizes" section on Multisite installations. Most of the info shown there doesn't apply for multisite.
Props xkon, desrosj, azaozz.

git-svn-id: https://develop.svn.wordpress.org/trunk@45239 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-18 00:33:03 +00:00
Andrew Ozz 01719cb6b6 Site health info tab: replace "Not calculated" with "Loading..." in the "Directories and Sizes" section (that's an existing string and wouldn't cause problems for translators).
See #46707.

git-svn-id: https://develop.svn.wordpress.org/trunk@45237 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-17 21:25:05 +00:00
Sergey Biryukov 60fd53ef96 Site Health: Allow any callable added via `site_status_tests` filter to return test results for direct tests.
Async tests still need to be a string for the AJAX action.

Props kraftbj.
Fixes #46836.

git-svn-id: https://develop.svn.wordpress.org/trunk@45234 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-17 14:34:12 +00:00
Sergey Biryukov 4206fe3e05 Docs: Remove `@global` tag for `$wpdb` from `wp-admin/install.php` and `wp-admin/upgrade.php`.
Per the documentation standards, the `@global` tag is meant to list PHP globals used within functions or methods.

The code in question uses the variable in global namespace, but does not explicitly declare it.

Props jayupadhyay01, dswebsme.
Fixes #46602.

git-svn-id: https://develop.svn.wordpress.org/trunk@45233 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-17 14:06:55 +00:00
Sergey Biryukov da32612242 Docs: Correct spelling in various comments and DocBlocks, per the conventions in Core Contributor Handbook.
Props man4toman, samanehmirrajabi.
Fixes #45857.

git-svn-id: https://develop.svn.wordpress.org/trunk@45232 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-17 13:26:00 +00:00
Sergey Biryukov 691258f1f4 Site Health: Group `WP_DEBUG`-related constants together.
Props tmatsuur.
Fixes #46955.

git-svn-id: https://develop.svn.wordpress.org/trunk@45230 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-17 11:59:13 +00:00
Andrea Fercia e1022a6184 Site Health: Improve the accordions styles for small screens.
Also, changes the hex color values to lowercase.

Props subrataemfluence, man4toman, garrett-eclipse, chetan200891, mukesh27, melchoyce, karmatosed, Clorith.
Fixes #46949.


git-svn-id: https://develop.svn.wordpress.org/trunk@45229 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-17 10:59:12 +00:00
Andrea Fercia 2bf547ff53 Site Health: Remove title attribute from the directory sizes spinner.
Amends [45176].
See #46707.


git-svn-id: https://develop.svn.wordpress.org/trunk@45228 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-17 10:08:06 +00:00
Sergey Biryukov 0152c18cd2 Docs: Improve documentation for various `WP_Filesystem_Base` methods and extending classes.
Props jaydeep-rami, man4toman, SaeedFard, mukesh27, mohadeseghasemi, ebrahimzadeh, juiiee8487, SergeyBiryukov.
Fixes #42227, #46806, #46840. See #46543.

git-svn-id: https://develop.svn.wordpress.org/trunk@45226 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-17 04:12:27 +00:00
Jonathan Desrosiers d575d70fe9 Administration: Improve the accuracy of `is_block_editor()`.
Currently, there are a number of scenarios where `is_block_editor()` (and `WP_Screen::is_block_editor`) would incorrectly indicate block editor support at different points of the loading process. Most notably, checking `is_block_editor` when hooking into the `current_screen` action will always result in `false`, even when the block editor is being loaded. This is because `is_block_editor` is not set to `true` until `edit-form-blocks.php` is included.

This change adds logic to `WP_Screen` to ensure the accuracy of `is_block_editor` on block editor pages earlier in the load process.

While edit screens will now be accurate 100% of the time from `current_screen` on, there are still a few edge cases where `is_block_editor` could contain an incorrect value when creating a new post.

Because a `WP_Post` object is a required parameter for the `replace_editor` filter and `use_block_editor_for_post()` function, `WP_Screen` will fall back to the value returned by `use_block_editor_for_post_type()` for the post being created. To eliminate these edge cases, the `use_block_editor_for_post_type` filter can be used to return the appropriate boolean value to indicate support.

Props Chouby, desrosj, aduth, johnbillion.
Fixes #46195.

git-svn-id: https://develop.svn.wordpress.org/trunk@45224 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-17 01:55:21 +00:00
Sergey Biryukov dfeea03a58 Site Health: Remove reference to an undefined variable in `WP_Site_Health_Auto_Updates::test_constants()`.
Props diddledan.
Fixes #46952.

git-svn-id: https://develop.svn.wordpress.org/trunk@45223 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-17 01:09:30 +00:00
Sergey Biryukov 260ee7308d Docs: Fix typo in `WP_Site_Health_Auto_Updates::test_constants()` description.
See #46543.

git-svn-id: https://develop.svn.wordpress.org/trunk@45222 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-17 00:59:54 +00:00
Sergey Biryukov 3feb1f171a PHPCS: Fix WPCS violations in [45220].
See #46707.

git-svn-id: https://develop.svn.wordpress.org/trunk@45221 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-17 00:44:12 +00:00
Andrew Ozz e85b26d14c Site health, info tab:
- Change `recurse_dirsize()` to accept an array of excluded paths.
- Change so we don't calculate the sizes of dirs in wp-content twice.
- Add the size in bytes to the "debug" into.
- Add a custom DOM event after the dir sizes request is done. Can be used by plugins to "daisy chain" more requests.
- Move "WordPress directory location" and "WordPress directory size" to the top in the "Directories and Sizes" section.
- Move "Theme directory location" to the "Active Theme" section.
- Fix labels capitalization.

Props xkon, afercia, Clorith, azaozz.
Fixes #46707.

git-svn-id: https://develop.svn.wordpress.org/trunk@45220 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 23:01:45 +00:00
Adam Silverstein 70f16b6bf4 Media: move `get_available_post_mime_types` to `wp-includes/post.php` making it more generally available.
Address an issue since r44947 where calling `wp_enqueue_media` on the front-end would result in a PHP fatal.

Props david.binda.
Fixes #46795.


git-svn-id: https://develop.svn.wordpress.org/trunk@45219 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 20:29:42 +00:00
Andrea Fercia f969e1dfd7 Administration: Improve the Site Health "Passed tests" button style for small screens.
Props chetan200891.
Fixes #46939.


git-svn-id: https://develop.svn.wordpress.org/trunk@45217 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 16:22:41 +00:00
Sergey Biryukov c295378ecd Export: Remove extra whitespace from `<title>`, `<content:encoded>`, and `<excerpt:encoded>` elements in WXR files.
Props sgastard, juliarrr, aristath, SergeyBiryukov.
Fixes #46575.

git-svn-id: https://develop.svn.wordpress.org/trunk@45216 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 15:56:48 +00:00
Sergey Biryukov b66077a1aa I18N: Fix typo in a translator comment.
See #46920.

git-svn-id: https://develop.svn.wordpress.org/trunk@45207 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 23:55:52 +00:00
John Blackbourn 8b1ecf68d9 I18N: Improvements to and additions of translator comments for various email subject strings.
Props ramiy

Fixes #46920


git-svn-id: https://develop.svn.wordpress.org/trunk@45204 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 22:38:59 +00:00
Mel Choyce 1442389a75 Administration: Update chevron color in Site Health.
Props afercia.
Fixes #46934. See #46730.


git-svn-id: https://develop.svn.wordpress.org/trunk@45202 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 18:55:34 +00:00
Andrea Fercia 94af7683fe Administration: Add a chevron icon to the Site Health "Passed tests" button.
The chevron icon helps clarify what the button does.

Props garrett-eclipse, Clorith, xkon, melchoyce.
Fixes #46730.


git-svn-id: https://develop.svn.wordpress.org/trunk@45201 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 18:00:57 +00:00
Andrea Fercia 3eb83ade1e Administration: Provide translatable strings for the Site Health comment status report.
Props ocean90.
Fixes #46909.


git-svn-id: https://develop.svn.wordpress.org/trunk@45200 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 15:07:36 +00:00
Andrea Fercia 9f8366994b Site Health: Add missing translator comments.
Amends [45178].
See #46683.


git-svn-id: https://develop.svn.wordpress.org/trunk@45199 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 14:38:26 +00:00
Andrea Fercia 92909607d6 Site health: Improve jQuery selectors so that they don't depend on a specific markup.
Amends [45178].
See #46683.


git-svn-id: https://develop.svn.wordpress.org/trunk@45198 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-14 14:29:03 +00:00
Sergey Biryukov d52d60c809 Site Health: Merge duplicate "utf8mb4 requires a newer client library" strings.
Props ramiy.
Fixes #46917.

git-svn-id: https://develop.svn.wordpress.org/trunk@45196 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 18:17:16 +00:00
Sergey Biryukov 7d54ac58cc Site Health: Merge duplicate "Error" strings.
Props ramiy.
Fixes #46915.

git-svn-id: https://develop.svn.wordpress.org/trunk@45195 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 18:11:46 +00:00
Sergey Biryukov 68ac2e4998 Users: Merge duplicate "Download failed" strings.
Props ramiy.
Fixes #46914.

git-svn-id: https://develop.svn.wordpress.org/trunk@45194 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 18:07:35 +00:00
Sergey Biryukov 35498b090e Site Health: Merge duplicate "Latest version" strings.
Props ramiy.
Fixes #46913.

git-svn-id: https://develop.svn.wordpress.org/trunk@45193 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 18:03:23 +00:00
Sergey Biryukov b9b33979a0 Site Health: Merge duplicate "Learn more about updating PHP" strings.
Props ramiy.
Fixes #46912.

git-svn-id: https://develop.svn.wordpress.org/trunk@45192 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 17:58:12 +00:00
Sergey Biryukov 30caafae40 Bootstrap/Load: Remove duplicate leading slashes on inclusion of various files under `ABSPATH`.
Props dmsnell, birgire, szepe.viktor.
Fixes #46327.

git-svn-id: https://develop.svn.wordpress.org/trunk@45190 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 04:45:05 +00:00
Sergey Biryukov 5f93c86b84 CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/customize-controls.css`.
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46494. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45189 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 04:36:01 +00:00
Sergey Biryukov 4de00af6f8 CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/themes.css`.
Props ianbelanger, mukesh27, audrasjb, pbiron, afercia.
Fixes #46518. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45188 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 04:31:08 +00:00
Sergey Biryukov eb2f56da08 CSS Coding Standards: Use unitless values for `line-height` for count bubbles in `wp-admin/css/admin-menu.css`.
Missed in [45186].

Props ianbelanger.
See #46489, #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45187 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 04:19:52 +00:00
SergeyBiryukov 10112902ce CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/admin-menu.css`.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46489. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45186 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 00:16:01 +00:00
Sergey Biryukov 78e868e4c7 Plugins: Introduce `is_wp_version_compatible()` and `is_php_version_compatible()` for checking compatibility with the current WordPress or PHP version.
Props afragen.
Fixes #46599.

git-svn-id: https://develop.svn.wordpress.org/trunk@45185 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 23:55:19 +00:00
Sergey Biryukov e844945b31 Plugins: In `list_plugin_updates()`, only display the annotation and the surrounding tags if it's not empty.
Props afragen.
Fixes #46680.

git-svn-id: https://develop.svn.wordpress.org/trunk@45184 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 21:51:58 +00:00
Andrew Duthie f627138361 Privacy: Remove unnecessary translation from help notice action label.
As static markup, the Privacy Policy editor help notice link no longer needs to be translateable with the revisions included in [45174].

Props garrett-eclipse.
Fixes #46098. See [45174].


git-svn-id: https://develop.svn.wordpress.org/trunk@45180 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 20:43:40 +00:00
Sergey Biryukov 6627bc4967 Site Health: Use `_n()` for `%s Items with no issues detected` string, missed in [45178].
See #46683.

git-svn-id: https://develop.svn.wordpress.org/trunk@45179 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 20:39:05 +00:00
Sergey Biryukov 936db1b0e1 Site Health: i18n audit, take 2.
* Use `wp.i18n` to translate JavaScript strings.
* Use `_n()` for proper plural forms support.

Props TimothyBlynJacobs, ocean90, afercia.
Fixes #46683.

git-svn-id: https://develop.svn.wordpress.org/trunk@45178 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 20:33:48 +00:00
Andrew Ozz 05981179e4 Site health: Load the "Info" tab immediately and notify the user while gathering site data. Changes the Info tab to work similarly to the Status tab: it does separate request to fetch the directories sizes and doesn't "block" the loading of the page.
Props xkon, afercia, Clorith, azaozz.
See #46707.

git-svn-id: https://develop.svn.wordpress.org/trunk@45176 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 19:23:13 +00:00
Jonathan Desrosiers 212bbbae98 Administration: Move “Recovery Mode” to the beginning of the document title.
This improves accessibility, ensuring users utilizing screen readers are informed that the site is in recovery mode.

Props: afercia, TimothyBlynJacobs.
See #46608.

git-svn-id: https://develop.svn.wordpress.org/trunk@45175 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 19:04:13 +00:00
Andrew Duthie b0d7c97806 Privacy: Display help notice on block editor screen.
Use the Notices data module when viewing the block editor screen for the assigned Privacy Policy page to display a help notice.

Props garrett-eclipse, joen, xkon.
Fixes #46098.


git-svn-id: https://develop.svn.wordpress.org/trunk@45174 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 18:18:59 +00:00
Andrew Ozz ac97906269 TinyMCE: Fix keyboard navigation when the `dfw` button is present but hidden. Ensure that button is added last in the DOM to match where it appears visually.
Props afercia, azaozz.
Fixes #46640.

git-svn-id: https://develop.svn.wordpress.org/trunk@45172 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 18:07:47 +00:00
Jonathan Desrosiers 908b8238b9 Site Health: Correctly refer to an `.htaccess` file as hidden.
The preceding period (`.`) should always be included when referring to an `.htaccess` file.

Props: ianbelanger, garrett-eclipse, subrataemfluence, burhandodhy.
Fixes #46841.

git-svn-id: https://develop.svn.wordpress.org/trunk@45171 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 17:49:04 +00:00
Jonathan Desrosiers 94b6167a04 Site Health: Add missing actions to tests.
This change adds missing actions for several tests. This ensures that the user is provided with a next step, whenever possible.

Also, change the URL displayed in the WordPress.org communication test description to `api.wordpress.org` for accuracy.

Props: garrett-eclipse, Clorith, vaishalipanchal.
Fixes #46734.

git-svn-id: https://develop.svn.wordpress.org/trunk@45170 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 17:39:37 +00:00
Jonathan Desrosiers 3bba7f2f31 Site Health: Improve the test badge implementation.
Label badges for each Site Health test currently display in either red, orange, or green, regardless of if the test passed or failed. This is confusing, as seeing red labels in the “Passed Test” section could alarm users (when really everything is OK and no action is required), and seeing green labels in the “Failed Tests” section would not appropriately encourage the user to take appropriate action.

This change makes several improvements to the label badges:

- Always right align the badges for consistent display.
- Remove background fill for badges. Instead, use a border.
- Use a consistent styling for all tests (passed and failed).
- The text color no longer uses true black (#000000).
- The `.badge.pink` CSS definition has been switched to `.badge.purple`, and the definitions for blue, gray, and green have also been updated to more closely follow the official WordPress color palette.

Props: pbiron, garrett-eclipse, hedgefield, Clorith, xkon, melchoyce, mdwolinski, alexdenning.
Fixes #46623.

git-svn-id: https://develop.svn.wordpress.org/trunk@45169 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 17:03:24 +00:00
Jonathan Desrosiers f36d2fbbdc Administration: Remove unnecessary numbered placeholders.
Props: tobifjellner, thrijith.
Fixes #46824.

git-svn-id: https://develop.svn.wordpress.org/trunk@45167 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 16:31:37 +00:00
Jonathan Desrosiers 4740573142 Site Health: Include both site and user locales in debug information.
Previously, only the site’s locale was displayed in the Site Health debug information. Moving forward, both the site’s default locale and the user’s locale will be specified.

This change also removes the `@param` tag for `WP_Debug_Data::debug_data()`. This parameter was previously removed in [45156].

Props: mukesh27, ianbelanger, Clorith, desrosj.
Fixes #46803.

git-svn-id: https://develop.svn.wordpress.org/trunk@45166 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 15:48:13 +00:00
desrosj 26869439ff Upgrade/Install: Prevent plugin auto updates if PHP version requirements are not satisfied.
In [44937] and [44939], changes were made to prevent a user from updating any plugin that requires a higher version of PHP than the site is running. This compliments those changes to also prevent plugins from being auto updated when the same requirements are not met.

Props: TimothyBlynJacobs, davidbaumwald.
Fixes #46613.

git-svn-id: https://develop.svn.wordpress.org/trunk@45165 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 14:01:02 +00:00
Mike Schroder 635adfbe68 Site Health: Clarify `WP_DEBUG` warning and translation contexts.
Clarifies that `WP_DEBUG` can cause `WP_DEBUG_DISPLAY` to be enabled,
and uses the constants themselves in related translation contexts.

Props mukesh27, ocean90, clorith, SergeyBiryukov, mikeschroder.
Fixes #46877.

git-svn-id: https://develop.svn.wordpress.org/trunk@45164 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 02:26:44 +00:00
Andrea Fercia af0242a37b Accessibility: Improve the image "Alternative Text" field in the Edit Media screen.
Brings parity with the changes for the Media Views introduced in [44900].
- moves the alt text field to the top as first field
- adds an explanatory text with a link pointing to the W3C "alt decision tree" tutorial
- adds `aria-describedby` to target the explanatory text
- adjusts the CSS and indentation

Props chetan200891.
Fixes #46875.


git-svn-id: https://develop.svn.wordpress.org/trunk@45158 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-10 19:59:16 +00:00
Andrea Fercia 36787a2716 Login and Registration: improve the CSS padding on the login input fields.
The right padding added in [44895] needs to be set only on the input fields in the Reset Password screen and exclude other login screens.

Amends [44895].
Fixes #42853.


git-svn-id: https://develop.svn.wordpress.org/trunk@45157 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-10 16:11:56 +00:00
Andrew Ozz d09af1698f Site health: Fix gathering the site data twice on non-English locales. Introduces two sets of data:
- More verbose set used to generate the admin page.
- More concise set that is copied when clicking the "Copy the site info" button intended mostly for support and developers.

Props xkon, azaozz.
Fixes #46726.

git-svn-id: https://develop.svn.wordpress.org/trunk@45156 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-10 05:06:54 +00:00
Jonathan Desrosiers 4428086e4c Site Health: Add missing i18n for “Copied!” string.
Props: Soean, mukesh27, davidbaumwald.
Fixes #46847.

git-svn-id: https://develop.svn.wordpress.org/trunk@45155 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-09 15:23:20 +00:00
Jonathan Desrosiers 7215374431 Privacy: Pass admin URLs for data export and erase forms through `esc_url()`.
Introduced in [45149].

Props: birgire.
Fixes #44047.

git-svn-id: https://develop.svn.wordpress.org/trunk@45154 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-09 14:06:29 +00:00
Gary Pendergast 9802c065a4 Privacy: Add a missing `<form>` action on the Export/Erasure screens.
This lack of action could cause an expired nonce to end up in the URL.

Props garrett-eclipse, saimonh, xkon.
Fixes #44047.



git-svn-id: https://develop.svn.wordpress.org/trunk@45149 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-09 00:07:39 +00:00
Gary Pendergast 6dddce67fc Privacy: Only mark a personal data export as complete when the user downloads it.
An admin may download an export to check that it's all correct, but this action shouldn't mark the request as complete.

Props garrett-eclipse, JoshuaWold, birgire.
Fixes #44644.



git-svn-id: https://develop.svn.wordpress.org/trunk@45148 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-09 00:03:07 +00:00
Gary Pendergast 677c2a447b Media: Update the media bulk action labels for consistency.
Props ianbelanger, garrett-eclipse, afercia, Presskopp.
Fixes #44675.



git-svn-id: https://develop.svn.wordpress.org/trunk@45147 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:53:02 +00:00
Gary Pendergast 8eca6fd949 Site Health: Remove animated ellipsis from the status loading indicator.
This animation wasn't particularly reliable across browsers.

Props Clorith, afercia.
Fixes #46684.



git-svn-id: https://develop.svn.wordpress.org/trunk@45145 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:28:27 +00:00
Gary Pendergast 0f75356246 Privacy: Remove the privacy changes bubble.
This notification was a little too intrustive, and suffered from being difficult to dismiss.

Props garrett-eclipse, xkon, ianbelanger.
Fixes #46819.



git-svn-id: https://develop.svn.wordpress.org/trunk@45142 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:11:36 +00:00
Gary Pendergast 8efcc32fde Help: Update support forum links.
There are a lot of places in Core that link to https://wordpress.org/support/ for the support forums, but that's now the URL for HelpHub. The new forums link is https://wordpress.org/support/forums/.

Props jitendrabanjara1991, dilipbheda, mukesh27, ianbelanger.
Fixes #46790.



git-svn-id: https://develop.svn.wordpress.org/trunk@45140 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 22:58:49 +00:00
Gary Pendergast f1bef8668b Text Changes: Tweak the wording of email notification subjects.
This change brings more coherence between the subject lines of the various emails WordPress will send.

Props ramiy, pento.
Fixes #37940.


git-svn-id: https://develop.svn.wordpress.org/trunk@45137 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 06:16:41 +00:00
Gary Pendergast 95948eeed4 Post Formats: Remove the post format icons from the post list table.
Props mukesh27, melchoyce, karmatosed, afercia, mapk.
Fixes #46591.


git-svn-id: https://develop.svn.wordpress.org/trunk@45136 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 06:03:58 +00:00
Sergey Biryukov 965e7fa46e CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/color-picker.css`.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46492. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45131 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:53:37 +00:00
Sergey Biryukov 6ba1388522 CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/about.css`.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46495. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45130 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:50:18 +00:00
Sergey Biryukov 1b69643969 CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/customize-nav-menus.css`.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46495. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45129 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:48:05 +00:00
Sergey Biryukov 8c6239c27b CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/site-health.css`.
Props mukesh27, ianbelanger, pbiron, afercia.
Fixes #46760. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45128 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:43:12 +00:00
Sergey Biryukov bd25bc4473 CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/nav-menus.css`.
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46516. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45123 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 16:09:42 +00:00
Sergey Biryukov 0f534cfe11 PHPCS: Fix WPCS violation in [45119].
See #46809.

git-svn-id: https://develop.svn.wordpress.org/trunk@45122 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 16:01:36 +00:00
Sergey Biryukov c8a29d2789 Site Health: Update recommendation labels to highlight Performance instead of Security when using a supported and actively maintained version of WordPress, PHP, or MySQL.
Props Clorith, earnjam.
Fixes #46789.

git-svn-id: https://develop.svn.wordpress.org/trunk@45121 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 15:59:29 +00:00
Sergey Biryukov e0041a5794 Site Health: Use a consistent heading and description when referring to Info and Status pages.
Props chetan200891, afercia.
Fixes #46728.

git-svn-id: https://develop.svn.wordpress.org/trunk@45120 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 15:41:41 +00:00
Sergey Biryukov 17728c5215 Site Health: Restore backticks in "Copy to clipboard" functionality, accidentally removed in [45044].
The backticks ensure that the data is formatted accordingly on pasting whenever possible.

Props Clorith.
Fixes #46809.

git-svn-id: https://develop.svn.wordpress.org/trunk@45119 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 15:35:44 +00:00
Sergey Biryukov d72a0092d5 Site Health: Display a correct error message for a failing request in `wp_version_check()` test.
Props Clorith, axaak.
Fixes #46814.

git-svn-id: https://develop.svn.wordpress.org/trunk@45118 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 15:27:33 +00:00
Felix Arntz a511415d0a Administration: Improve user experience and clarify when in recovery mode.
This changeset introduces several changes around usability when recovery mode is active:

* Display a notice in the admin clarifying that the user is in recovery mode.
* Use a highlight color for the admin bar link to exit recovery mode.
* Exit recovery mode automatically when logging out.
* Include a recovery mode indicator in the title tag.

Props aandrewdixon, azaozz, dhanukanuwan, flixos90, henrywright, karmatosed, mapk, melchoyce, spacedmonkey, TimothyBlynJacobs, tinkerbelly.
See #46608.


git-svn-id: https://develop.svn.wordpress.org/trunk@45117 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 16:59:34 +00:00
Felix Arntz 075a85c05e Bootstrap/Load: Do not redefine constants because tests don't like it.
See #46045.


git-svn-id: https://develop.svn.wordpress.org/trunk@45116 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 15:52:39 +00:00
Felix Arntz dca58d725e Bootstrap/Load: Remove extension from the list of paused extensions when it is deactivated.
With this change, fatal errors recorded before a plugin was deactivated or a theme was switched away from do not persist. This ensures that re-enabling it re-checks for fatal errors correctly.

Props aandrewdixon, dhanukanuwan, henrywright.
Fixes #46812.


git-svn-id: https://develop.svn.wordpress.org/trunk@45115 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 15:32:31 +00:00
Felix Arntz 7f6adbb345 Bootstrap/Load: Ensure `WP_Fatal_Error_Handler` does not conflict with existing mechanisms treating fatal errors.
Prior to this change, resuming or activating a plugin or theme that is still broken would result in a redirect loop if in recovery mode. If outside recovery mode, it would cause the error template to be displayed.

Furthermore this applies to breaking a plugin or theme when editing from the backend.

Props aandrewdixon, azaozz, dhanukanuwan, henrywright, ocean90, ohiosierra, PandelisZ, xkon.
Fixes #46045, #46751.


git-svn-id: https://develop.svn.wordpress.org/trunk@45114 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 15:19:50 +00:00
Pascal Birchler 99a0145ba1 Site Health: Remove unused `$wp_config_path` variable.
Discovered and fixed during WordCamp London 2019 contributor day.

Props m_uysl.
Fixes #46808.


git-svn-id: https://develop.svn.wordpress.org/trunk@45113 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 11:08:30 +00:00
Alex Shiels 45771f9f11 Upgrade/Install: Add more context in signature verify failures.
This includes version numbers and signature counts in error reports, to help diagnose isolated failures that have no apparent cause.

Props dd32.
See #39309.


git-svn-id: https://develop.svn.wordpress.org/trunk@45112 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-05 05:19:15 +00:00
Andrew Ozz 9945849317 Site health: fix usage of max_execution_time. When PHP is run from the cli the default is 0.
Fixes #46645.

git-svn-id: https://develop.svn.wordpress.org/trunk@45111 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-04 21:53:45 +00:00
Jonathan Desrosiers af60a3c2bf Site Health: Ensure the user locale is listed in debug information.
This change switches to using `get_user_locale()` when adding the language to the Site Health debug information to ensure the user’s locale preference is reflected.

Also, `function_exists()` checks for `switch_to_locale()` and `restore_previous_locale()` were required in the plugin to support older versions of WordPress, but they are not required in core/

Props: Clorith, desrosj.
Fixes #46694.

git-svn-id: https://develop.svn.wordpress.org/trunk@45110 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-04 21:23:29 +00:00
Sergey Biryukov a0ca5afd89 Site Health: Use `wp_get_upload_dir()` instead of `wp_upload_dir()`, remove duplicate call.
Props m_uysl.
Fixes #46729.

git-svn-id: https://develop.svn.wordpress.org/trunk@45108 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-03 11:19:53 +00:00
Sergey Biryukov 681edf04bc Site Health: Use correct property for database-related messages.
Props mukesh27, birgire.
Fixes #46783.

git-svn-id: https://develop.svn.wordpress.org/trunk@45107 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-03 11:00:06 +00:00
Sergey Biryukov c8913b375e PHPCS: Fix WPCS violations in [45104].
See #46645.

git-svn-id: https://develop.svn.wordpress.org/trunk@45106 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-03 02:13:31 +00:00
Sergey Biryukov fa0ad447c8 Site Health: Use a consistent verbiage for the suggestion to remove inactive plugins and themes.
Props garrett-eclipse, marybaum, Clorith.
Fixes #46735.

git-svn-id: https://develop.svn.wordpress.org/trunk@45105 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-03 02:00:56 +00:00
Andrew Ozz d5d4979921 Site health:
- Prevent fatal errors from timeouts on the Tools => Site Health => Info tab.
- Use the `get_dirsize()` and `recurse_dirsize()` functions to calculate directory sizes. The results are cached.
- Introduce "timeout protection" in `recurse_dirsize()`.

Props pento, Clorith, xkon, afercia, jeremyfelt, azaozz.
Fixes #46645.

git-svn-id: https://develop.svn.wordpress.org/trunk@45104 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 23:32:31 +00:00
Sergey Biryukov 3b7028104b Site Health: Use an established pattern for numbered placeholders in translator comments in `WP_Debug_Data`.
See #46683.

git-svn-id: https://develop.svn.wordpress.org/trunk@45102 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 22:17:18 +00:00
Sergey Biryukov b3a625fdf1 Site Health: i18n audit, take 1.
* Split plural strings with multiple sentences to avoid duplicating translations.
* Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings.
* Use an established pattern for numbered placeholders in translator comments.
* Replace constants in translatable strings with placeholders, mark them as code.
* Make sure sentences are translated as a whole, not as separate string parts.
* Remove unnecessary context and escaping.

Props ocean90, SergeyBiryukov.
See #46683.

git-svn-id: https://develop.svn.wordpress.org/trunk@45099 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 21:31:43 +00:00
Sergey Biryukov e4a0f2dcab Docs: Fix typo in a comment in `unzip_file()`.
Props mukesh27.
Fixes #46766.

git-svn-id: https://develop.svn.wordpress.org/trunk@45098 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 13:33:47 +00:00
Sergey Biryukov fbf73bc8de Site Health: Add missing i18n for Security and Performance badge labels.
Props iworks.
Fixes #46755. See #46683.

git-svn-id: https://develop.svn.wordpress.org/trunk@45095 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-02 10:07:36 +00:00
Sergey Biryukov adfe5e271b Docs: Fix more typos in `WP_Site_Health` DocBlocks.
See #46753.

git-svn-id: https://develop.svn.wordpress.org/trunk@45094 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 20:29:52 +00:00
Sergey Biryukov 302233dd11 Docs: Fix typos in `WP_Site_Health` DocBlocks.
Props mukesh27.
Fixes #46753.

git-svn-id: https://develop.svn.wordpress.org/trunk@45093 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 20:22:42 +00:00
Sergey Biryukov 421da58d8e Docs: Add missing `@since` tag for `WP_Site_Health::get_test_php_extensions()`.
Props mukesh27.
Fixes #46752.

git-svn-id: https://develop.svn.wordpress.org/trunk@45092 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 20:16:54 +00:00
Andrea Fercia 1e0ef359fc Administration: Site Health: reserve some space for the admin notices.
Props xkon, Clorith, hedgefield, mapk, karmatosed, afercia.
Fixes #46651.


git-svn-id: https://develop.svn.wordpress.org/trunk@45091 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 18:00:58 +00:00
Andrea Fercia 01bc0b9772 Accessibility: Improve the Site Health accordions.
- removes the definition list and uses the markup from the ARIA Authoring Practices example
- removes incorrect ARIA roles
- avoids ARIA landmark regions proliferation

Props mukesh27 for the initial patch.
Fixes #46714.


git-svn-id: https://develop.svn.wordpress.org/trunk@45087 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 15:07:30 +00:00
Sergey Biryukov 19ef699ec5 Docs: Improve documentation for `get_plugin_page_hook()` and `get_plugin_page_hookname()`.
Props subrataemfluence, desrosj.
Fixes #44224.

git-svn-id: https://develop.svn.wordpress.org/trunk@45085 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 14:08:01 +00:00
Sergey Biryukov 0592027157 PHPCS: Fix WPCS violation in [45082].
See #42223.

git-svn-id: https://develop.svn.wordpress.org/trunk@45084 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 13:29:24 +00:00
Sergey Biryukov 63b70b892b Docs: Improve documentation for `postbox_classes()`.
Rename `$page` and `$id` variables to `$screen_id` and `$box_id` for clarity.

Props sharifkiberu, DrewAPicture.
Fixes #45179.

git-svn-id: https://develop.svn.wordpress.org/trunk@45083 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 12:46:04 +00:00
Sergey Biryukov 6abcd97c8c I18N: Merge similar strings about allowed space allocation in Multisite.
Props ramiy, Jonathandejong, pento.
Fixes #42223.

git-svn-id: https://develop.svn.wordpress.org/trunk@45082 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 12:23:54 +00:00
Sergey Biryukov f6dadb3738 Themes: Link to an updated documentation on child themes on developer.wordpress.org, instead of Codex.
Props man4toman.
See #46450.

git-svn-id: https://develop.svn.wordpress.org/trunk@45080 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 11:54:23 +00:00
Sergey Biryukov a795928e3b Site Health: If `WP_DEBUG_LOG` contains a file path, display it on Site Info tab.
Props xkon, knutsp, ocean90.
Fixes #46692.

git-svn-id: https://develop.svn.wordpress.org/trunk@45079 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 01:25:06 +00:00
Sergey Biryukov 0b63b69688 Site Health: Simplify the checks for constants that are always defined by default.
Props xkon.
Fixes #46738.

git-svn-id: https://develop.svn.wordpress.org/trunk@45078 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-01 00:09:09 +00:00
Andrea Fercia 123b973889 Administration: Display a notice in the Site Health pages when JavaScript is off.
- displays an error notice when JavaScript is off, consistently with other admin screens that depend on JavaScript
- keeps the main `h1` visible

Minor clean-ups:
- makes code indentation consistent in `site-health.php` and `site-health-info.php`
- removes a couple of `<div class="wp-clearfix"></div>` as that's not the intended usage of `wp-clearfix` (those divs didn't do anything anyways)

Fixes #46717.


git-svn-id: https://develop.svn.wordpress.org/trunk@45076 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-30 15:37:28 +00:00
Andrea Fercia 02a0911bcc Accessibility: Make sure the Site Health layout tables are correctly linearized.
Adds `role="presentation"` to the `<table>` elements used in the Site Health reports.

Ideally, HTML tables should be used for tabular data. When tables are used for layout purposes, it's important to remove any native semantics so that assistive technologies can correctly announce the table content in a linearized fashion.

Props chetan200891.
Fixes #46725.


git-svn-id: https://develop.svn.wordpress.org/trunk@45075 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-30 14:41:16 +00:00
Andrea Fercia d1dfe7c414 Coding Standards: Improve the Site Health CSS for small screens.
Amends #45071.
See #46685.


git-svn-id: https://develop.svn.wordpress.org/trunk@45074 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-30 14:08:45 +00:00
Sergey Biryukov 74211739fe Docs: Fix typos in `site_status_tests` filter DocBlock.
Props kraftbj.
Fixes #46727.

git-svn-id: https://develop.svn.wordpress.org/trunk@45073 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-30 10:58:00 +00:00
Andrea Fercia d52f7c82c1 Administration: Improve the CSS for the Site Health pages header.
Avoids the Site Health pages header layout to break when the Hello Dolly plugin or other floated content is printed out at the top of the page.

Props xkon.
Fixes #46650.


git-svn-id: https://develop.svn.wordpress.org/trunk@45072 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-29 18:54:39 +00:00
Andrea Fercia 328c4f3432 Coding Standards: Clean up the Site Health stylesheet.
- reduces selectors specificity to avoid over-qualified selectors
- removes unused rulesets / properties
- renames some CSS classes

Fixes #46685.


git-svn-id: https://develop.svn.wordpress.org/trunk@45071 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-29 18:43:09 +00:00
Andrea Fercia e1e1a40083 Accessibility: Make sure the Site Health pages have a unique document title.
The document `<title>` gives a name to a web document. In the context of the WordPress admin, a unique, meaningful, title is important for various reasons:
- it allows browser's history to store meaningful entries 
- when multiple browser's tabs are open, it allows users to better identify the tab content 
- it's the first thing screen readers announce when navigating to a web page, thus helping users to identify the nature of the page content

Props chetan200891, mukesh27.
Fixes #46699.


git-svn-id: https://develop.svn.wordpress.org/trunk@45070 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-29 18:26:28 +00:00
Sergey Biryukov 594e1802bd Site Health: Add missing `<ul>` tags for lists on Site Info page.
Props mukesh27, chetan200891, afercia.
Fixes #46693.

git-svn-id: https://develop.svn.wordpress.org/trunk@45068 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-29 11:13:27 +00:00
Sergey Biryukov 87d4d0ae92 Privacy: Ensure the personal data export email is sent in the locale of the user whose data is being exported (or the site's default locale if they are not a registered user) when the administrator fulfilling the request uses a different locale.
Props garrett-eclipse.
Fixes #46056.

git-svn-id: https://develop.svn.wordpress.org/trunk@45062 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-28 21:28:37 +00:00
Sergey Biryukov 692ecb1f97 CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/widgets.css`.
Props ianbelanger, audrasjb.
Fixes #46531. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45053 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-28 16:38:09 +00:00
Sergey Biryukov aae789324f Site Health: Add description for a successful HTTPS check.
Props Clorith, xkon.
Fixes #46617.

git-svn-id: https://develop.svn.wordpress.org/trunk@45052 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-28 16:14:03 +00:00
Sergey Biryukov 265e2da819 Site Health: Use a consistent wording and response code for capability checks.
Props mukesh27 for initial patch.
Fixes #46691.

git-svn-id: https://develop.svn.wordpress.org/trunk@45050 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-28 15:10:24 +00:00
Sergey Biryukov b45b58c6b6 Site Health: Correct `wp_version_check()` existence verification by performing a request to the Site Health page instead of Dashboard.
Props Clorith, audrasjb.
Fixes #46616.

git-svn-id: https://develop.svn.wordpress.org/trunk@45049 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-28 14:30:12 +00:00
Gary Pendergast e1f54c7db9 Upgrades: Allow upgrades to proceed when a soft failure occurs on package signatures.
In particular, this allows downgrading from WordPress 5.2 to 5.1.1, if sites wish to opt out of the beta.

Props dd32.
See #46615.



git-svn-id: https://develop.svn.wordpress.org/trunk@45046 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-27 23:05:00 +00:00
Gary Pendergast 1ab6f67ef5 Site Health: Improve the "Copy to clipboard" button.
The previous method for copying the debug report to the clipboard involved having a hidden `<textarea>`, but this shows up in screen readers and can't be reliably hidden.

To work around this, the button now uses the `clipboard.js` library, which automatically handles browser differences in the Clipboard API, and can load the text to copy from a `data-` attribute on the button.

Props pento, hedgefield, afercia.
Fixes #46647.



git-svn-id: https://develop.svn.wordpress.org/trunk@45044 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-27 22:30:26 +00:00
Sergey Biryukov 43c28f913c Plugins: Disable "Update Now" button for plugins that require a higher version of PHP or WordPress.
This complements disabling the "Install Now" button in [43436].

Props afragen.
Fixes #46677. See #43986.

git-svn-id: https://develop.svn.wordpress.org/trunk@45043 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-27 22:10:37 +00:00
Andrea Fercia 368016feb2 Accessibility: Simplify the Site Health score indicator.
The Site Health score indicator isn't exactly a "progress bar" and shouldn't use ARIA roles and properties related to progress bars. Also, some browser / screen reader combinations don't announce the score properly.
- removes any ARIA
- adds a screen-reader-text "Current health score:"
- adds `role="img" aria-hidden="true" focusable="false"` to the SVG
- reduces CSS specificity simplifying unnecessary overqualified selectors
- fixes the syntax for ::after and ::before (double colon)

Fixes #46621.


git-svn-id: https://develop.svn.wordpress.org/trunk@45041 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-27 20:38:07 +00:00
Sergey Biryukov b2f0f4d2db Taxonomy: Initialize `$noparents` variable in `wp_ajax_add_tag()` to avoid a notice with `compact()` in PHP 7.3.
Props pilou69.
Fixes #46670.

git-svn-id: https://develop.svn.wordpress.org/trunk@45034 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-27 15:32:11 +00:00
Sergey Biryukov 368cd01fa7 Database: Use `wp_die()` instead of `die()` in `wp_check_mysql_version()`, for more flexibility and consistency with other error messages in core.
Props spacedmonkey.
Fixes #45975.

git-svn-id: https://develop.svn.wordpress.org/trunk@45030 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-27 14:02:47 +00:00
Sergey Biryukov a58b5f2f70 Site Health: Update "Passed tests" button label to match both expanded and collapsed state.
Add `aria-controls` to declare what ID is being toggled.

Props Clorith, afercia.
Fixes #46663. See #46573.

git-svn-id: https://develop.svn.wordpress.org/trunk@45026 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-27 02:56:09 +00:00
Sergey Biryukov a8e61bfa86 Plugins: Use correct singular for "Drop-in" in plugins list table.
Props tobifjellner, mukesh27.
Fixes #46592.

git-svn-id: https://develop.svn.wordpress.org/trunk@45021 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-26 23:59:39 +00:00
Sergey Biryukov 448ed1adfc Privacy: Update default privacy policy text to match the current behavior of setting a temporary cookie on visiting the login page.
Props mechter, subrataemfluence, garrett-eclipse.
Fixes #44175.

git-svn-id: https://develop.svn.wordpress.org/trunk@44987 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-23 10:53:20 +00:00
Gary Pendergast dad6b61cfb Admin: Introduce the Site Health screens.
The Site Health tool serves two purposes:
- Provide site owners with information to improve the performance, reliability, and security of their site.
- Collect comprehensive debug information about the site.

By encouraging site owners to maintain their site and adhere to modern best practices, we ultimately improve the software hygeine of both the WordPress ecosystem, and the open internet as a whole.

Props Clorith, hedgefield, melchoyce, xkon, karmatosed, jordesign, earnjam, ianbelanger, wpscholar, desrosj, pedromendonca, peterbooker, jcastaneda, garyj, soean, pento, timothyblynjacobs, zodiac1978, dgroddick, garrett-eclipse, netweb, tobifjellner, pixolin, afercia, joedolson, birgire.
See #46573.


git-svn-id: https://develop.svn.wordpress.org/trunk@44986 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-23 03:54:16 +00:00
Sergey Biryukov 96922900c5 Plugins: Remove `wp_is_wp_compatible()` and `wp_is_php_compatible()` functions added in [44978] for now, to discuss use cases and better naming.
See #46599, #43992.

git-svn-id: https://develop.svn.wordpress.org/trunk@44981 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-22 12:59:02 +00:00
Sergey Biryukov d69b5eb713 Plugins: Use `<em>` instead of `<span>` for PHP annotation in `wp_plugin_update_row()`, for consistency with other instances.
Props afragen.
Fixes #46598. See #43987.

git-svn-id: https://develop.svn.wordpress.org/trunk@44980 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-22 01:07:51 +00:00
Sergey Biryukov 0e1d2b42ef PHPCS: Fix WPCS violations in [44978].
See #43992.

git-svn-id: https://develop.svn.wordpress.org/trunk@44979 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-22 00:59:25 +00:00
Sergey Biryukov 1586c43c8d Plugins: Block plugin activation if it requires a higher version of PHP or WordPress.
Introduce `validate_plugin_requirements()` for validating a plugin's WordPress and PHP version requirements.

Introduce `wp_is_wp_compatible()` and `wp_is_php_compatible()` for checking compatibility with the current WordPress or PHP version.

Props afragen, joyously, DrewAPicture, TimothyBlynJacobs, desrosj, flixos90, SergeyBiryukov.
See #43992.

git-svn-id: https://develop.svn.wordpress.org/trunk@44978 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-22 00:36:30 +00:00
Jonathan Desrosiers f170c1dd31 Networks and Sites: Introduce the `ms_user_list_site_class` filter.
In the network admin user table on multisite installs (`WP_MS_Users_List_Table`), this filter allows the classes for the `<span>` tag surrounding each site link to be modified.

Props kraftbj, flixos90, johnjamesjacoby.
Fixes #41146.

git-svn-id: https://develop.svn.wordpress.org/trunk@44977 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-21 23:54:05 +00:00