Scott Taylor
af0851cc0d
Because the WP_ADMIN
constant name can be bound in multiple files, all instances should check ! defined
first. wp-admin/admin.php
already has this check.
...
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28478 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 20:41:28 +00:00
Scott Taylor
f083cc4e9b
The About page has a <div>
that doesn't close. Also, <hr>
s should self-close. hackificator
complains about these things.
...
See #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28477 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 20:32:58 +00:00
Drew Jaynes (DrewAPicture)
b5fdb2dc06
Improve inline documentation for default arguments in wp_get_archives()
.
...
See #28298 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28476 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 17:19:56 +00:00
Sergey Biryukov
0cc180b0a4
Fix wp_insert_link(), broken in [28406]/[28408].
...
see #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28475 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 09:55:16 +00:00
Drew Jaynes (DrewAPicture)
9e81d2d692
Add inline documentation for default arguments in wp_insert_category()
.
...
See #28298 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28474 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 07:27:25 +00:00
Sergey Biryukov
d56f67b8e9
Update help text on Add Themes screen.
...
props thomasvanderbeek.
fixes #28132 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28473 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 23:43:41 +00:00
Scott Taylor
5eecd2e62b
Eliminate the use of extract()
in MO::import_from_reader()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28472 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 17:20:26 +00:00
Scott Taylor
7205796cec
Eliminate the use of extract()
in get_pages()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28471 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 17:11:23 +00:00
Scott Taylor
b76a0d791b
Eliminate the use of extract()
in wp_insert_attachment()
.
...
`wp_insert_attachment()` and `wp_insert_post()` are incredibly similar, but have branched logic. I have annotated many places where they diverge.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28470 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 16:53:44 +00:00
Scott Taylor
9787ea4e2a
Eliminate the use of extract()
in wp_insert_post()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28469 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 15:52:11 +00:00
Scott Taylor
40e6ec443f
Add inline comment after fix in [28467].
...
Props jesin.
Fixes #28292 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28468 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 15:41:40 +00:00
Scott Taylor
14a7b47119
Restore $soucrce
in WP_Upgrader::install_package()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28467 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 15:39:33 +00:00
Scott Taylor
ff8ae69fce
Eliminate the use of extract()
in wp_delete_term()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28466 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 14:54:03 +00:00
Scott Taylor
06c87f681a
Eliminate the use of extract()
in get_terms()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28465 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 14:46:07 +00:00
Scott Taylor
02066d4241
Eliminate the use of extract()
in wp_insert_term()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28464 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 14:15:40 +00:00
Lance Willett
c338a15b1f
Twenty Ten: correct attribute escaping in the attachment template. Props philiparthurmoore, see #28251 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28463 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 22:43:31 +00:00
Lance Willett
a6129f5ea3
Twenty Fourteen: correct escaping for parent post link and attachment link in image template. Props philiparthurmoore, see #28251 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28462 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 22:30:04 +00:00
Scott Taylor
b1b30ad58c
Eliminate use of extract()
in wp_update_term()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28461 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 21:28:05 +00:00
Scott Taylor
54bc77cb93
The cache key for comments in WP_Comment_Query::query()
needs to do wp_array_slice_assoc( $this->query_vars, array_keys( $defaults ) )
instead of compact( array_keys( $defaults ) )
. The latter assumes all of those variables are still floating around.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28460 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 21:08:15 +00:00
Scott Taylor
cb3341c03d
(ACTUALLY) Eliminate use of extract()
in WP_Comment_Query::query()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28459 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 20:51:23 +00:00
Scott Taylor
8d22270bc1
Eliminate use of extract()
in WP_Comment_Query::query()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28458 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 19:32:05 +00:00
Scott Taylor
59f8ba6c9e
Eliminate use of extract()
in wp_insert_comment()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28457 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 18:51:41 +00:00
Scott Taylor
ccc874514c
Eliminate use of extract()
in request_filesystem_credentials()
.
...
The only property that doesn't need to be set to a variable is `$password`.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28456 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 18:25:41 +00:00
Andrew Ozz
6fa89637e5
DFW: fix closing only the wpLink or media modal when pressing Esc.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28455 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 18:16:59 +00:00
Scott Taylor
0d92bb2552
Eliminate use of extract()
in wp_insert_user()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28454 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 18:15:00 +00:00
Scott Taylor
61d2e52e4b
In wp_xmlrpc_server::mw_editPost
, also set $post_type = $postdata['post_type']
.
...
See #22400 , [28448].
git-svn-id: https://develop.svn.wordpress.org/trunk@28453 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 18:05:21 +00:00
Scott Taylor
ec17088ff6
Update inline docs for wp_handle_upload|sideload
to reflect their non-use of extract()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28452 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 17:40:44 +00:00
Scott Taylor
8f8b12e6a6
Eliminate use of extract()
in wp_handle_sideload()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28451 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 16:14:56 +00:00
Scott Taylor
176d361626
Eliminate use of extract()
in wp_handle_upload()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28450 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 16:10:00 +00:00
Scott Taylor
8a25c0ea1e
Eliminate use of extract()
in wp_widget_rss_form()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28449 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 15:37:53 +00:00
Scott Taylor
cf3574516a
Eliminate use of extract()
in wp_xmlrpc_server::mw_editPost()
(MetaWeblog API, y'all).
...
A lot of the extracted variables are overwritten by being explicitly set later.
Only set variables that would otherwise not be present with `compact()` is called.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28448 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 15:18:17 +00:00
Scott Taylor
102806bd81
Eliminate use of extract()
in validate_blog_signup()
:
...
* `$orig_username` does not need to be pulled from `wpmu_validate_user_signup()` as it is not used in this function.
* `$user` does not need to be pulled from `wpmu_validate_blog_signup()` as it is not used in this function.
* For the `wpmu_validate_user_signup()` portion, rename `$result` and `$errors` to $user_result` and `$user_errors` for disambiguation with the blog values below.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28447 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 14:52:04 +00:00
Scott Taylor
8cdc22267b
Eliminate use of extract()
in validate_user_signup()
.
...
`$orig_username` does not need to be pulled from `validate_user_form()` as it is not used in this function.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28446 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 14:46:25 +00:00
Scott Taylor
d2965e291d
Eliminate use of extract()
in validate_another_blog_signup()
.
...
The extracted variables set/overwrite globals. `$user` does not need to be pulled from `validate_blog_form()` as it is not used in this function.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28445 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 14:42:25 +00:00
Sergey Biryukov
4585195977
Filter out empty and duplicate values in Comment Moderation and Comment Blacklist settings.
...
props GaVrA.
fixes #23800 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28444 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 11:09:28 +00:00
Sergey Biryukov
6100833f0c
DFW: Properly handle Esc key when the content is focused or when switching browser tabs.
...
props avryl.
fixes #28279 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28443 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-16 10:42:03 +00:00
Sergey Biryukov
e76bfbefbd
Don't include caption tags in gallery template when there is no caption.
...
props avryl.
fixes #28089 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28442 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 21:02:04 +00:00
Scott Taylor
ae938f524e
Eliminate use of extract()
in wp_get_object_terms()
.
...
There are 3 properties, just set them to variables. They are used too often to warrant a refactor.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28441 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 19:57:57 +00:00
Scott Taylor
1b93413580
Eliminate use of extract()
in wp_widget_rss_output()
.
...
Add `'items' => 0` to `$default_args`. When `0`, the value is set to `10` (the fallback).
Every other default arg has a default value of `0`.
`items` is expected to always be passed to this function.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28440 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 19:41:41 +00:00
Scott Taylor
ce6f3de8ff
Eliminate use of extract()
in WP_Widget_RSS::widget()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28439 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 19:35:31 +00:00
Scott Taylor
5c28e2986c
In Walker_Category::start_el()
, $title
might not be set when $args
are passed multiple levels into walk_category_tree()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28438 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 19:13:45 +00:00
Scott Taylor
ce5a31cd62
Eliminate use of extract()
in wp_allow_comment()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28437 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 18:09:09 +00:00
Scott Taylor
737ad1a878
Eliminate use of extract()
in Walker_Category::start_el()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28436 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 17:57:13 +00:00
Scott Taylor
cc64187e28
Eliminate use of extract()
in wp_generate_tag_cloud()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28435 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 17:47:21 +00:00
Scott Taylor
7793a90fd1
Eliminate use of extract()
in wp_list_categories()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28434 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 17:27:18 +00:00
Scott Taylor
812493f259
Eliminate use of extract()
in default-widgets.php
.
...
Props rzen, wonderboymusic.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28433 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 16:32:18 +00:00
Scott Taylor
29efc53b6a
Eliminate use of extract()
in wp_dropdown_categories()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28432 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 15:47:43 +00:00
Scott Taylor
4aa28e9cdc
Eliminate use of extract()
in get_comment_reply_link()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28431 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 15:34:37 +00:00
Scott Taylor
7d8a053aeb
Eliminate use of extract()
in WP_Ajax_Response::add()
. Just set most of the properties to variables to avoid interpolation churn.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28430 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 15:24:21 +00:00
Scott Taylor
e06aa222ea
Eliminate the use of extract()
in get_post_reply_link()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28429 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 06:48:16 +00:00