Commit Graph

25660 Commits

Author SHA1 Message Date
Scott Taylor b1122743c8 Call MediaElement's shim method for `setSrc()` when dynamically updating the playing source in playlists, which will properly set the source for mobile.
Make the labels for playlist items slightly smaller to account for size on mobile.

Fixes #27625.



git-svn-id: https://develop.svn.wordpress.org/trunk@27895 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-01 19:03:24 +00:00
Scott Taylor 13a0532006 Make `<audio>` elements in playlists responsive.
See #27625.



git-svn-id: https://develop.svn.wordpress.org/trunk@27894 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-01 18:46:18 +00:00
Dominik Schilling (ocean90) 3046451bf7 Cleanup [27892].
git-svn-id: https://develop.svn.wordpress.org/trunk@27893 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-01 15:29:34 +00:00
Dominik Schilling (ocean90) 11f6751d51 Widget Customizer: Use postMessage to highlight widgets in preview or sections/controls in Customizer.
fixes #27622.

git-svn-id: https://develop.svn.wordpress.org/trunk@27892 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-01 15:25:56 +00:00
Dominik Schilling (ocean90) bb7c7e06c0 Widget Customizer: Remove WidgetCustomizer.showFirstSidebarIfRequested().
It's currently unused and needs another iteration.

see #27290.

git-svn-id: https://develop.svn.wordpress.org/trunk@27891 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-01 12:37:43 +00:00
Dominik Schilling (ocean90) ab5b649243 Revert [27654] for strings.
props westonruter.
fixes #27485.

git-svn-id: https://develop.svn.wordpress.org/trunk@27890 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-01 11:07:59 +00:00
Drew Jaynes (DrewAPicture) 33acf29a46 Clarify PHPDoc return description for `media_handle_upload()`.
Props jdgrimes.
Fixes #27519.


git-svn-id: https://develop.svn.wordpress.org/trunk@27880 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-31 22:32:47 +00:00
Drew Jaynes (DrewAPicture) 1bd14badd5 Clarify inline documentation for the 'html5' case and PHPDoc return in `add_theme_support()`.
Props jond3r.
Fixes #27278.


git-svn-id: https://develop.svn.wordpress.org/trunk@27879 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-31 22:20:01 +00:00
Andrew Nacin 239ac6e830 Forward pingback IP during pingback verification.
props tellyworth, nacin.
fixes #27613.


git-svn-id: https://develop.svn.wordpress.org/trunk@27872 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-31 20:42:41 +00:00
Scott Taylor 9771a5aa78 Re-instantiate the `MediaElementPlayer` instance when switching mime types in playlists.
Fixes #27608.



git-svn-id: https://develop.svn.wordpress.org/trunk@27871 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-31 15:34:23 +00:00
Drew Jaynes (DrewAPicture) cfaf65d392 Inline documentation for hooks in wp-includes/widgets.php.
Props eliorivero and Nessworthy for the initial patches. Props kpdesign.
Fixes #27129.


git-svn-id: https://develop.svn.wordpress.org/trunk@27870 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-31 07:29:29 +00:00
Scott Taylor d8d26a4f79 Cleanup up the display, escaping, and handling of ID3 data for media. Rename `wp_get_relevant_id3_keys()` to `wp_get_attachment_id3_keys()`.
Props nacin.
See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27869 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-31 05:15:39 +00:00
Scott Taylor 882df9f94a Favor escaping over interpolation in Underscore templates for media. Translate some strings directly instead of passing via JS.
Props nacin.
See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27868 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-31 05:12:29 +00:00
Scott Taylor bce67739ff Bump the MediaElement version in `script-loader.php` to `2.14.1`.
See [27861].



git-svn-id: https://develop.svn.wordpress.org/trunk@27867 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 22:19:30 +00:00
Andrew Nacin 70beef6c31 Use correct formatting function. see [27864], see #27574.
git-svn-id: https://develop.svn.wordpress.org/trunk@27866 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 22:11:58 +00:00
Scott Taylor 35306513dc Using percentages for playlist font-sizing was ambitious, but fell prey to `editor-style.css` in the admin. We have switched to using pixels. The editor styles were also forcing MediaElement players to inherit `font-family`, which was undesirable. And while we're at it, remove the top and bottom border from the playlist's list of tracks, which adds a dash of lovely to the playlist's default styles.
Props nacin for the addition of `&mdash;` in the playlist track list.
Fixes #27600.



git-svn-id: https://develop.svn.wordpress.org/trunk@27865 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 22:11:46 +00:00
Andrew Nacin 877ffc087f Cleanups for audio/video metadata, see [27862].
see #27574.


git-svn-id: https://develop.svn.wordpress.org/trunk@27864 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 21:07:04 +00:00
Scott Taylor 2846655164 In `wp_generate_attachment_metadata()`, when an audio or video files contains upload-able image bits in its ID3 tags, only upload it if the image has not already been uploaded. Determine this by checking for a `_cover_hash` value in post meta that matches the `md5` representation of the bits.
This prevents uploading an album of 10 songs and subsequently uploading 10 copies of the same album cover.

Props GregLone for the new filter/filter docs: `'attachment_thumbnail_args'`.
Fixes #27573.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@27863 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 20:53:21 +00:00
Scott Taylor 149f36ed35 Metadata for audio and video files:
* Make attachment metadata for audio files editable by providing a metabox on the Edit Media page
* Standardize on using the attachment title everywhere
* Label the Caption and Description fields for audio and video appropriately
* Make the playlist Underscore templates more straightforward

See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27862 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 19:27:31 +00:00
Scott Taylor a9d54abfed MEjs has been fixed upstream: 1a75559c9d
No more infinite loop.

This restores MediaElement to a clean build: `2.14.0`.

Fixes #27582. 
Thanks to jeremyfelt for tracking this down.



git-svn-id: https://develop.svn.wordpress.org/trunk@27861 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 17:50:08 +00:00
Dominik Schilling (ocean90) c0373b288c Widget Customizer: Add a label to widget search.
props SergeyBiryukov.
fixes #27590.

git-svn-id: https://develop.svn.wordpress.org/trunk@27860 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 15:46:28 +00:00
Andrew Nacin 2e5586ee19 Only show test cookie warnings on submit as caching/proxies may intercept the test cookie for GET requests.
Introduce a new string for when headers are sent and link them to http://codex.wordpress.org/Cookies (new page).

props SergeyBiryukov.
fixes #27373.


git-svn-id: https://develop.svn.wordpress.org/trunk@27859 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 00:40:43 +00:00
Andrew Ozz 02a46f5368 Add class `wp-core-ui` to DFW and wpLink as it is required by buttons.css. Props avryl, see #27279
git-svn-id: https://develop.svn.wordpress.org/trunk@27858 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 00:36:12 +00:00
Andrew Ozz d6e6560980 Editor:
- Use standard button styles for the Quicktags buttons.
- Better style for the TinyMCE buttons (hover/focus/active/disabled).
- Move the fullscreen (DFW) button to the right.
- Better style for the Visual/Text buttons in DFW.
Props avryl, see #27279

git-svn-id: https://develop.svn.wordpress.org/trunk@27857 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 23:57:13 +00:00
Dominik Schilling (ocean90) d9a2370aab Customizer: Style "Cheatin’ uh?" message like wp_die().
props jackreichert.
fixes #27490

git-svn-id: https://develop.svn.wordpress.org/trunk@27856 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 23:18:54 +00:00
Dominik Schilling (ocean90) 64f5807b32 Adjust colors in wp_die() and install.css.
Missed in [26788] and [26837], see #25858.
fixes #27589.

git-svn-id: https://develop.svn.wordpress.org/trunk@27855 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 23:05:12 +00:00
Dominik Schilling (ocean90) 9fb6f9557b Widget Customizer: Remove strings from WP_Error returns and go with just IDs.
fixes #27419.


git-svn-id: https://develop.svn.wordpress.org/trunk@27854 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 21:43:39 +00:00
Scott Taylor 238459a604 Revert `mediaelement-and-player.min.js` to a usable build that doesn't cause an infinite loop. Still `2.14.0`, minus the offending pull request: a7f67b7180
Reported upstream. `2.14.0` is necessary for playing `m4a` files properly. `2.14.0` with the offending pull request is unusable in Chrome.

See #27582.



git-svn-id: https://develop.svn.wordpress.org/trunk@27853 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 21:35:58 +00:00
Helen Hou-Sandi edee5feaab Restore some CSS rules that are necessary for non-default schemes. see #18380.
git-svn-id: https://develop.svn.wordpress.org/trunk@27852 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 17:47:08 +00:00
Andrew Nacin b29fe2764c Post beta3 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@27851 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 11:39:25 +00:00
Andrew Nacin 39972a8887 3.9-beta3
git-svn-id: https://develop.svn.wordpress.org/trunk@27850 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 11:14:49 +00:00
Andrew Nacin 5f98beb862 Custom Headers: Simplify and consolidate the querying of custom headers for the customizer.
props mcsf.
see #21785.


git-svn-id: https://develop.svn.wordpress.org/trunk@27849 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 10:52:17 +00:00
Andrew Nacin b7eaebf9b3 Update grunt-patch-wordpress to 0.2.1 which applies patches with a/ b/ paths.
props jorbin.
see #27023.


git-svn-id: https://develop.svn.wordpress.org/trunk@27848 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 10:22:49 +00:00
Andrew Nacin e3171a42a3 Add PHP and JS unit tests for custom headers.
props mcsf, ehg.
see #21785.


git-svn-id: https://develop.svn.wordpress.org/trunk@27847 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 10:05:22 +00:00
Andrew Nacin d8a3ebc173 JavaScript Unit Tests: Add Sinon (sinonjs.org) for test mocks, stubs, etc. see #21785.
git-svn-id: https://develop.svn.wordpress.org/trunk@27846 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 09:58:55 +00:00
Andrew Nacin 3b11bb9e36 Theme Installer: Avoid race condition during pagination.
props matveb.
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@27845 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 09:08:16 +00:00
Andrew Nacin 33f728034d Add braces to wptexturize() after [27839]. see #22692.
git-svn-id: https://develop.svn.wordpress.org/trunk@27844 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 08:59:38 +00:00
Andrew Nacin aff33c3bca Theme Installer: Remove unused variables and undesired commas.
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@27843 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 08:52:30 +00:00
Andrew Nacin 1c3f9e542b Restyle the image editor so it looks way less hideous.
props avryl.
see #27544.


git-svn-id: https://develop.svn.wordpress.org/trunk@27842 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 08:50:57 +00:00
Andrew Nacin 73677963e3 Media Manager: Hide 'Create Playlist' menu items until the user has uploaded audio or video.
props gcorne.
fixes #27554.


git-svn-id: https://develop.svn.wordpress.org/trunk@27841 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 08:01:13 +00:00
Andrew Nacin 548a7d2b26 Fix drag-and-drop upload in distraction-free writing.
props kovshenin.
fixes #27438.


git-svn-id: https://develop.svn.wordpress.org/trunk@27840 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 07:53:47 +00:00
Andrew Nacin f0bd2b8a91 Texturize: Massive performance improvements (~600% faster); better handling of nbsp, double, and weird spaces; 136 new unit tests.
big props miqrogroove.
fixes #22692.


git-svn-id: https://develop.svn.wordpress.org/trunk@27839 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 07:15:33 +00:00
Andrew Nacin 18c8198487 Add a value to the password checkbox when creating a new user so the toggle is remembered.
props chriseverson, SergeyBiryukov.
fixes #27006.


git-svn-id: https://develop.svn.wordpress.org/trunk@27838 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 06:22:46 +00:00
Andrew Nacin 05ea231402 Avoid infinite recursion in get_term_children() when a term is incorrectly a parent of itself.
props kovshenin.
fixes #27123.


git-svn-id: https://develop.svn.wordpress.org/trunk@27837 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 06:07:17 +00:00
Andrew Nacin 0ad35e169b Revert the conversion of adjacent post queries to WP_Query. Explanation on the ticket.
Reverts [27285], [27286], [27287], [27288], [27291], [27292], [27293], [27296], [27633], [27634], [27635], and [27692].

see #26937.


git-svn-id: https://develop.svn.wordpress.org/trunk@27836 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 06:02:01 +00:00
Andrew Nacin 9b0101e59d Rewrite: Use same delimiter in url_to_postid() we use in WP::parse_request().
props stevenkword.
fixes #23587. 


git-svn-id: https://develop.svn.wordpress.org/trunk@27835 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 05:17:57 +00:00
Andrew Nacin 84cf72160d Use correct column name. See [27152].
props barry.
fixes #25545.


git-svn-id: https://develop.svn.wordpress.org/trunk@27834 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 03:38:39 +00:00
Andrew Nacin d167615ebf Restore the original z-index of the sticky admin menu, as first set in [26442].
The inline comment is now correct again. This z-index was changed in [26701], but those circumstances no longer apply after [27532].

props mordauk.
see #26442, #26952.
fixes #26567.


git-svn-id: https://develop.svn.wordpress.org/trunk@27833 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 03:29:43 +00:00
Helen Hou-Sandi 5a41c8a06c Correct cascade issues and remove some unused CSS for the admin menu. see #18380.
git-svn-id: https://develop.svn.wordpress.org/trunk@27832 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 02:46:04 +00:00
Andrew Ozz 02d1d894be Fix styling for mce-path (at the bottom of the editor), see #26952
git-svn-id: https://develop.svn.wordpress.org/trunk@27831 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 00:18:35 +00:00