Commit Graph

140 Commits

Author SHA1 Message Date
Ryan Boren
b1f07f0ae1 Back compat $_REQUEST['post_id'] for media XHR requests.
Props koopersmith, nacin.
fixes #22588


git-svn-id: https://develop.svn.wordpress.org/trunk@22865 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-27 14:58:08 +00:00
Ryan Boren
9e26663d18 Rename 'id' to 'state' in menu item view.
Props koopersmith
fixes #22594


git-svn-id: https://develop.svn.wordpress.org/trunk@22851 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-26 22:49:45 +00:00
Ryan Boren
65f7674216 Always render the attachment compat view. Assures attachment_fields_to_edit is always fired.
Props koopersmith, Chouby
fixes #22578


git-svn-id: https://develop.svn.wordpress.org/trunk@22841 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-26 15:05:14 +00:00
Andrew Nacin
faca39f74c Media: Watch more events for input changes to catch paste, autocomplete, etc.
Fixes issue where pasting a URL in 'From URL' (via the context menu) did not
enable the insert button, as the event was not yet fired.

props koopersmith.
fixes #22545.



git-svn-id: https://develop.svn.wordpress.org/trunk@22836 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-26 03:35:28 +00:00
Daryl Koopersmith
f20573509b Media: Use a full uploader status view in the inline uploader. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22825 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 12:54:49 +00:00
Daryl Koopersmith
2070f5ca49 Media: Add uploader error detection to the inline uploader view as well. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22824 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 12:35:05 +00:00
Daryl Koopersmith
e572052ab8 Media: Properly render any pre-existing upload errors in the uploader status. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22823 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 12:24:54 +00:00
Daryl Koopersmith
99def3ec51 Media: Make friends with media_upload_form. Adds notices for browser incompatibility, upload limits, maximum file size, and large file issues to the uploader. fixes #22243, see #22186, #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22821 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 11:46:03 +00:00
Daryl Koopersmith
b007f89d0d Media: Display WordPress and plupload error messages whenever an upload fails. see #22243, #22186, #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22818 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 10:56:10 +00:00
Daryl Koopersmith
ff6ae18d2d Media: Add global upload progress to the sidebar. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22816 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 09:32:21 +00:00
Daryl Koopersmith
4a99fa363e Media: Move sidebar from the frame view to the attachment browser view. Prevents juggling sidebar visibility state, and makes managing sidebar contents more reasonable. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22809 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 06:30:25 +00:00
Daryl Koopersmith
0086598c9b Media: Check to see if we need more attachments when the browser is attached to the DOM. fixes #22480, see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22806 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 03:19:08 +00:00
Daryl Koopersmith
d4be102ab2 Media: Convert the attachments browser to use internal views. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22804 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 01:43:31 +00:00
Daryl Koopersmith
02bd60e532 Media: Make priority list views leverage the subview management class. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22802 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 00:41:39 +00:00
Daryl Koopersmith
95ed1b1a45 Media: Rename PriorityList's add/remove methods to set/unset (to prevent the default remove from being overridden). see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22792 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 20:43:42 +00:00
Daryl Koopersmith
e99789f504 Media: Refresh the window-wide uploader whenever a state is activated. Properly unbind controller events. fixes #22504, see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22791 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 20:34:46 +00:00
Daryl Koopersmith
bf42e8a402 Media: Make the window-wide uploader a subview of the frame view.
Allows the uploader to leverage the ready event to know when it has been attached to the page.

see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22790 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 20:27:49 +00:00
Daryl Koopersmith
6423fba2c4 Media: Make inline uploader use main dispose method. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22787 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 19:54:06 +00:00
Daryl Koopersmith
45f6cf2fb5 Media: Remove unused variable for state attributes. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22786 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 19:21:08 +00:00
Daryl Koopersmith
8d49ec29d0 Media: Make the upload state a dedicated screen, instead of including its own library view. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22781 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 18:29:53 +00:00
Daryl Koopersmith
f8bf1ebec7 Media: Use a more specific class for toolbar buttons. see #22284, #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22779 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 17:50:02 +00:00
Daryl Koopersmith
5432b5a3f6 Media: Calculate image width and height when embedding images. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22762 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 14:32:52 +00:00
Daryl Koopersmith
aa3bfdc808 Media: Remove redundant code.
Make the composite gallery library use `mirror` instead of `observe`, as one method now invokes the other. Also, make `mirror` return the attachment collection for chaining.

see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22750 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 12:11:38 +00:00
Daryl Koopersmith
052b765819 Media: Add filters for image-only libraries. see #22514, #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22745 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 11:04:23 +00:00
Daryl Koopersmith
8e6aa60fa4 Media: Dynamically generate attachment filters using get_post_mime_types().
Moves `get_post_mime_types()` from `wp-admin/includes/post.php` to `wp-includes/post.php`.

fixes #22514, see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22743 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 10:18:59 +00:00
Daryl Koopersmith
27515780f6 Media: Remove debug cruft. props ocean90. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22741 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 09:28:58 +00:00
Daryl Koopersmith
555141ebe4 Media: Dropping images on the edit gallery view will automatically add those images to the gallery. fixes #22521, see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22738 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 08:17:45 +00:00
Daryl Koopersmith
1e83e0eaae Media: Maintain event bindings in the main embed view. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22716 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-20 14:44:23 +00:00
Daryl Koopersmith
69f9e2a1bf Media: Allow all galleries to be sortable. fixes #22488, see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22713 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-20 14:04:59 +00:00
Daryl Koopersmith
76c67989a7 Media: Add filters to the media library. fixes #22514, see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22712 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-20 13:49:35 +00:00
Daryl Koopersmith
30e1926f4b Media: Refresh the attachment display settings when the active attachment finishes uploading. fixes #22452, see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22710 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-20 11:57:08 +00:00
Daryl Koopersmith
3f362417c7 Media: Remove dead dropdown code from button view. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22708 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-20 11:29:00 +00:00
Daryl Koopersmith
ce06a037dd Media: Attachment checkboxes now function as such. fixes #22462, see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22706 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-20 11:10:04 +00:00
Daryl Koopersmith
86b1e35bcf Media: Prevent undefined errors when media scripts are enqueued outside of wp_enqueue_media(). fixes #22495, see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22694 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-20 01:48:37 +00:00
Daryl Koopersmith
49ac6ba800 Media: Detect when views are added to the DOM and fire a ready event. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22692 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-20 00:53:02 +00:00
Daryl Koopersmith
c14200e07b Media: Add render tracking to views. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22690 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 22:48:11 +00:00
Daryl Koopersmith
15b3c31767 Media: Add silent options to the views; improve documentation. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22684 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 12:11:16 +00:00
Daryl Koopersmith
aa6b7069e6 Media: Add a method to fetch the first subview. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22682 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 10:41:24 +00:00
Daryl Koopersmith
17af1e2366 Media: Add documentation to media.Views. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22681 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 10:40:49 +00:00
Daryl Koopersmith
893c538066 Media: Only show the alignment setting when viewing an image. fixes #21836, see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22671 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 07:24:47 +00:00
Daryl Koopersmith
16ef935110 Media: Add default render method to views.
* Use default `render` method in the `Frame` view.
* Rename `Views.attach` to `Views.insert`.
* Add `Views.all` to retrieve all subviews.
* Add `Views.detach` to detach all subviews.
* Detect whether views are going to be reused in `View.set` and `detach` them instead of calling `dispose`.

see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22662 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 06:02:00 +00:00
Daryl Koopersmith
54f70dec05 Media: Allow subviews to be inserted at a specific index. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22660 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 04:41:57 +00:00
Daryl Koopersmith
46da78b32e Media: Convert the attachments browser view's destroy method to the newer dispose method. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22659 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 03:33:29 +00:00
Daryl Koopersmith
2411401f1b Media: Remove unused batch edit states and strings. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22658 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 03:11:48 +00:00
Daryl Koopersmith
47b883764e Media: Remove debug cruft from [22655]. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22656 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 02:44:34 +00:00
Daryl Koopersmith
5b426eac50 Media: Optimize media models.
* Merge `Composite` model with general `Attachments` model, as `Attachments.validate` and `Composite.evaluate` were functionally equivalent.
* Queries should only watch `wp.Uploader.queue`, as watching `Attachments.all` results in queries attempting to add attachments before their properties are set (which then results a few too many irrelevant adds/removes). `Attachments.all` should potentially be removed or rethought.

see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22655 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 02:43:10 +00:00
Daryl Koopersmith
646c90861f Media: Move Attachments view preventDefault handler to the events object. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22651 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 01:17:30 +00:00
Daryl Koopersmith
c5ee034c29 Media: Allow for the views manager to be extended. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22649 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 00:54:18 +00:00
Daryl Koopersmith
101c5a5371 Media: Add a base view class.
* Centralizes view and subview management, unifying several disjointed constructs.
* Utilizes the `dispose` functionality found in Backbone master, providing a standard method for memory management.

see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22648 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 00:36:47 +00:00
Daryl Koopersmith
e36ce9af8e Media: zIndex peace was only temporary.
Revert [22611] in favor of using plupload's `container` setting. Turns out, plupload's flash shim is forced to the exact same index as the admin bar, so balancing the two is better solved by nesting the shim.

see #22441, #22446, #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22612 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-16 10:30:36 +00:00