Commit Graph

23377 Commits

Author SHA1 Message Date
Andrew Nacin 63f35ba4b4 Document the event hook in wp-cron.php. see #25229.
git-svn-id: https://develop.svn.wordpress.org/trunk@25290 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 20:51:09 +00:00
Scott Taylor 22278ec6a9 Introduce `wp_using_ext_object_cache()` - mimic `wp_suspend_cache_invalidation()` and discourage direct access to `$_wp_using_ext_object_cache`, cleaning up importing of globals in functions and provides function to modify that global. Loads the packaged object cache when an external cache hasn't been loaded or doesn't contain `wp_cache_init()`.
Fixes #21401.



git-svn-id: https://develop.svn.wordpress.org/trunk@25289 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 18:09:24 +00:00
Andrew Nacin 6bad3b660a Correct @since in admin-footer. see #25229.
git-svn-id: https://develop.svn.wordpress.org/trunk@25288 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 17:37:15 +00:00
Scott Taylor 0474a18863 Allow `is_tag()` to accept `term_id`, `slug`, 'term_name` or array of any. Many other `is_*()` funcs already do this. Adds unit tests.
Props ramiy.
Fixes #18746.



git-svn-id: https://develop.svn.wordpress.org/trunk@25287 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 17:26:04 +00:00
Andrew Nacin c4068bc95b Inline docs for hooks in MagPie.
props natejacobs.
see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25286 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 17:18:33 +00:00
Scott Taylor 2661cd53fc Use `get_the_title()` when dealing with `post_type`-like items in the admin.
Props nacin, DrewAPicture.
Fixes #14975.



git-svn-id: https://develop.svn.wordpress.org/trunk@25285 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 17:08:00 +00:00
Andrew Nacin 8a0ac73f60 Document the 'query' filter in wp-db.
props natejacobs.
see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25284 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 17:07:00 +00:00
Andrew Nacin 595284f699 Mark the hooks in custom-background.php as duplicates.
* image_size_names_choose should be documented in wp-includes/media.php
 * wp_create_file_in_uploads should be documented in custom-header.php

see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25283 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 17:04:36 +00:00
Andrew Nacin a342806b55 Document comment_edit_redirect.
props dustyf.
see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25282 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 17:00:30 +00:00
Andrew Nacin 6045b39f5a Inline documentation for hooks in xmlrpc.php.
The old link for RSD is dead; update to the new one.

props bftrick.
see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25281 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 16:55:41 +00:00
Scott Taylor 09b9c44de9 Check bad dates and redirect, instead of 404ing, as necessary and appropriate.
Adds query, conditional, and canonical Unit Tests.

Props kovshenin, SergeyBiryukov, DrewAPicture.
Fixes #10935.



git-svn-id: https://develop.svn.wordpress.org/trunk@25280 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 16:35:22 +00:00
Andrew Nacin 69a949d160 Add new ajax_query_attachments_args filter.
props alex-ye.
fixes #24285.


git-svn-id: https://develop.svn.wordpress.org/trunk@25279 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 15:17:35 +00:00
Scott Taylor 93cfccac2d Add unit test for `tax_query` against attachments.
See #22556.



git-svn-id: https://develop.svn.wordpress.org/trunk@25278 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 14:43:49 +00:00
Sergey Biryukov e8daea7de7 Use correct array key for filling the attachment title in image_attachment_fields_to_save(). props pross.
Use wp_basename() to avoid issues with UTF-8 characters.
fixes #25236.

git-svn-id: https://develop.svn.wordpress.org/trunk@25277 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 14:09:07 +00:00
Sergey Biryukov 12647e132d Deprecate get_blogaddress_by_domain(), unused since [25261]. props jeremyfelt. fixes #25235.
git-svn-id: https://develop.svn.wordpress.org/trunk@25276 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 11:40:58 +00:00
Sergey Biryukov 093a580656 Whitespace cleanup for password strength meter tests. props TobiasBg. fixes #25088.
git-svn-id: https://develop.svn.wordpress.org/trunk@25275 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 10:56:01 +00:00
Dion Hulse d9c5265303 WP_Filesystem: FTP Sockets: Avoid using the file_exists() / is_exists() / exists() PemFTP functionality as it's buggy on ncFTPd servers, switching to listing the file instead which is what we use for the FTP Extension transport. Fixes #14049
git-svn-id: https://develop.svn.wordpress.org/trunk@25274 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 08:28:59 +00:00
Andrew Nacin 37d92f4851 Short descriptions for inline docs should end with a period, per the vast majority of core. see #25229.
git-svn-id: https://develop.svn.wordpress.org/trunk@25273 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 01:37:59 +00:00
Dion Hulse 9095e4b866 Upgrader: Make clearing the Plugin and Theme update caches optional during install and upgrade proceedures. See #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25272 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 01:32:09 +00:00
Andrew Nacin 760d5825ad More adjustments and improvements for inline documentation for get_pages(). see #25186.
git-svn-id: https://develop.svn.wordpress.org/trunk@25271 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 01:20:17 +00:00
Scott Taylor bd610dd68a Simplify the check for false-y `child_of` arg.
Props SergeyBiryukov.
See #25230, [25245].



git-svn-id: https://develop.svn.wordpress.org/trunk@25270 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 23:35:30 +00:00
Scott Taylor a73d205ab8 Move `get_meta_type()` into the `WP_Meta_Query` class as `get_cast_for_type()`. `WP_Query` can then access it like: `$this->meta_query->get_cast_for_type()`.
See #21621, [25255].



git-svn-id: https://develop.svn.wordpress.org/trunk@25269 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 23:31:28 +00:00
Scott Taylor d765349b75 Fix spacing in docs for `get_pages()`.
Props DrewAPicture.
See #25186.



git-svn-id: https://develop.svn.wordpress.org/trunk@25268 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 23:20:20 +00:00
Lance Willett a1556cefb6 Twenty Fourteen: further styling for medialement players, props iamtakashi. Fixes #25209.
git-svn-id: https://develop.svn.wordpress.org/trunk@25267 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 22:14:17 +00:00
Scott Taylor dbdc3ce528 Add docs to the woefully under-documented `get_pages()`.
Props DrewAPicture.
Fixes #25186.



git-svn-id: https://develop.svn.wordpress.org/trunk@25266 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 22:12:17 +00:00
Andrew Nacin 27b0660c5f Add a test case for calling get_page_uri() with a non-existent post.
see #24491, [25262].


git-svn-id: https://develop.svn.wordpress.org/trunk@25265 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 22:02:42 +00:00
Andrew Nacin f280a2f525 Remove old WP version checks from PHPUnit test cases now that tests are branched with each version.
git-svn-id: https://develop.svn.wordpress.org/trunk@25264 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 21:56:10 +00:00
Scott Taylor a7a070cc2c Only variables should be passed by reference.
Props Askapache.
Fixes #23032.



git-svn-id: https://develop.svn.wordpress.org/trunk@25263 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 21:52:44 +00:00
Scott Taylor eb63aeff1c Add check to make sure a valid argument was passed to `get_page_uri()`.
Props Viper007Bond.
Fixes #24491.




git-svn-id: https://develop.svn.wordpress.org/trunk@25262 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 21:41:48 +00:00
Andrew Nacin ad1feed450 Stop using get_blogaddress_by_domain() when updating the siteurl/homeurl from the network admin.
props jeremyfelt, SergeyBiryukov.
fixes #18242. see #25235.


git-svn-id: https://develop.svn.wordpress.org/trunk@25261 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 18:48:26 +00:00
Lance Willett d82fd6d7ce Twenty Fourteen: add styling for medialement players, props celloexpressions. See #25209.
git-svn-id: https://develop.svn.wordpress.org/trunk@25260 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 17:51:00 +00:00
Lance Willett 24e3077d77 Twenty Fourteen: break long words in comment content (not just anchor text). Fixes #24890, props rickalee.
git-svn-id: https://develop.svn.wordpress.org/trunk@25259 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 17:44:31 +00:00
Scott Taylor a5d3bde7a0 Avoids incorrect results when `url_to_postid()` checking is not strict enough. Adds a bunch of Unit Tests for `url_to_postid()', which is currently only tested lightly in some XML-RPC tests.
Props gcorne, gradyetc.
Fixes #20560.



git-svn-id: https://develop.svn.wordpress.org/trunk@25258 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 17:28:52 +00:00
Scott Taylor e8c7634e79 Avoid database error when `include` or `exclude` is not really a `term_id`. Adds more unit tests.
Props kovshenin.
Fixes #11823.



git-svn-id: https://develop.svn.wordpress.org/trunk@25257 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 17:14:54 +00:00
Scott Taylor 4286692d7d Remove redundant checks in some update functions. Adds some readability/coding standards cleanup.
Props miqrogroove, azaozz.
Fixes #22828.


git-svn-id: https://develop.svn.wordpress.org/trunk@25256 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 17:04:03 +00:00
Scott Taylor 83d1992d34 When `meta_type` is passed with `orderby => meta_value`, `orderby` must also use `CAST()` to avoid scenarios like: `SELECT`ing by `UNSIGNED` and then ordering by `CHAR`. Adds unit test.
Fixes #21621.


git-svn-id: https://develop.svn.wordpress.org/trunk@25255 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 16:56:36 +00:00
Scott Taylor 16ef2c2e36 Remove lingering instances of call time pass-by-reference, limited to instances of `callable` - use `$this` instead of `&$this`.
Props jdgrimes.
See #25160.



git-svn-id: https://develop.svn.wordpress.org/trunk@25254 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 16:33:50 +00:00
Andrew Nacin 21511593a4 Document the trackback_post hook in wp-trackback.php.
props bananastalktome.
see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25253 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 16:22:14 +00:00
Andrew Nacin 90605e02e7 Hook docs for admin-footer.php.
props natejacobs.
see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25252 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 16:20:05 +00:00
Andrew Nacin 48a9274146 Fixes for hook inline docs in wp-comments-post.php. see #25229.
git-svn-id: https://develop.svn.wordpress.org/trunk@25251 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 16:11:34 +00:00
Andrew Nacin 2f0d581810 Inline documentation for the welcome_panel hook.
props natejacobs.
see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25250 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 16:06:16 +00:00
Andrew Nacin 7a5e1a598f Inline documentation for hooks in wp-comments-post.php.
props rzen.
see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25249 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 16:04:17 +00:00
Scott Taylor 57b1d5ab28 Introduce `author__in` and `author__not_in` query vars. Fixes issue with multiple author exclusion when comma-separated string is passed for `author`. Adds a bunch of missing unit tests.
Props pollett for initial patch.
Fixes #16854.



git-svn-id: https://develop.svn.wordpress.org/trunk@25248 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 21:32:11 +00:00
Andrew Nacin 9e6705f24e Ensure zxcvbn.min.js loads when we are guessing the wp-includes URL.
props iandunn, SergeyBiryukov.
fixes #25201.


git-svn-id: https://develop.svn.wordpress.org/trunk@25246 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 21:16:00 +00:00
Scott Taylor 44011782d3 Set `hierarchical` to `false` when `parent` is passed to `get_pages()` and `child_of` is not.
Fixes #25230.



git-svn-id: https://develop.svn.wordpress.org/trunk@25245 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 20:59:20 +00:00
Scott Taylor 0b28c0137d Allow `get_pages()` to accept an `array` for the arg `parent`. Adds unit tests, some will fail until the next commit.
Fixes #9470.



git-svn-id: https://develop.svn.wordpress.org/trunk@25244 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 20:55:05 +00:00
Andrew Nacin 0e79ec02a6 Use matchdep for Grunt tasks.
props kadamwhite.
fixes #24980.


git-svn-id: https://develop.svn.wordpress.org/trunk@25243 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 20:50:29 +00:00
Scott Taylor 0877a3eda4 Remove `error_reporting()` debug cruff.
git-svn-id: https://develop.svn.wordpress.org/trunk@25242 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 19:56:06 +00:00
Scott Taylor 89997e4c80 Introduce `description__like` arg to `get_terms()`. Make `description__like` and `name__like` perform `LIKE`s with a wildcard on both sides of passed string. Previously, strings had to match the beginning of the name, so searching for `burrito` in `This is a burrito` would fail. Adds unit tests.
Props aaroncampbell for the original patch, 5 years ago.
Fixes #8214.



git-svn-id: https://develop.svn.wordpress.org/trunk@25241 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 19:40:17 +00:00
Scott Taylor d10b9d32a0 Remove unnecessary checks before setting `$wp_settings_*` arrays. Adds unit test for setting a nonexistent variable to a multi-dimensional `array`.
Props scribu.
Fixes #17884.



git-svn-id: https://develop.svn.wordpress.org/trunk@25240 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 19:06:13 +00:00