Commit Graph

146 Commits

Author SHA1 Message Date
Drew Jaynes
b408cd37fb Docs: Standardize and clarify class DocBlocks for all of the Upgrade API classes.
Standardizes summaries and tags for the following classes:

* `WP_Upgrader`
* `Plugin_Upgrader`
* `Theme_Upgrader`
* `Language_Pack_Upgrader`
* `Core_Upgrader`
* `File_Upload_Upgrader`
* `WP_Automatic_Updater`

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34499 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:53:46 +00:00
DrewAPicture
cccd9356fe Docs: Clarify the file header for wp-admin/includes/class-wp-upgrader.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34498 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:43:02 +00:00
Drew Jaynes
ad64ee866b Docs: Mark the optional $upgrader parameter as such and add a description in the DocBlock for Language_Pack_Upgrader::async_upgrade().
See [32655].

See #30989. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34497 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:34:15 +00:00
Drew Jaynes
a65c2e068a Docs: Fix a variety of inline documentation syntax issues and add some strategic spacing.
Fixes #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33685 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 04:12:45 +00:00
Drew Jaynes
c53fe2779e Docs: Add missing @access tags to properties and methods in wp-admin/includes/class-wp-upgrader.
See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33684 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 04:04:23 +00:00
Drew Jaynes
3721940e0f Docs: Correct a typo in the summary for the Theme_Upgrader->bulk property.
Also adds a couple of missing `@access` tags.

Props kraftbj
See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@33683 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 03:14:35 +00:00
Dominik Schilling (ocean90)
dec1b4da8b Upgrade: Lowercase the "s" in remove_all_filters().
props afragen.
fixes #33173.

git-svn-id: https://develop.svn.wordpress.org/trunk@33487 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 14:56:23 +00:00
Mark Jaquith
3f2b0779f5 Don't blindly trust the output of glob() to be an array.
props kitchin
fixes #33093

git-svn-id: https://develop.svn.wordpress.org/trunk@33447 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-27 18:04:19 +00:00
Drew Jaynes
0aecc0ce8b Fix inline documentation syntax in the WP_Upgrader->clear_destination() method added in 4.3.
See [32854]. See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33209 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 19:45:45 +00:00
Scott Taylor
2a5278e2dd Some doc blocks should use bool instead of true|false
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32963 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 00:44:21 +00:00
Scott Taylor
6ffc540366 Add access modifier to WP_Upgrader::clear_destination()
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32871 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:52:44 +00:00
Dion Hulse
9c0750ac52 When updating plugins/themes verify that the files to be deleted can be modified before starting the deletion process.
This will avoid partially deleting an item during update which has inconsistent permissions.
This change only affects those using the direct & ssh transports as FTP's is_writable() currently always returns `true`.
Fixes #30921


git-svn-id: https://develop.svn.wordpress.org/trunk@32854 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 03:48:55 +00:00
Dion Hulse
8455dd10da Updats: Add a filter for the options params for the update being performed.
Props nofearinc. Fixes #27754


git-svn-id: https://develop.svn.wordpress.org/trunk@32783 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 05:34:52 +00:00
Scott Taylor
60e5c90e62 Add (more) missing doc blocks to wp-admin/includes/*.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32655 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 21:16:59 +00:00
Scott Taylor
d55800a4f2 In the style of #30947 and default-filters.php, add 2 new files to wp-admin/includes:
`admin-filters.php`
`ms-admin-filters.php`

There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.

See #32529.


git-svn-id: https://develop.svn.wordpress.org/trunk@32653 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 17:03:13 +00:00
Scott Taylor
c8a44d437a Add @static* annotations where they are missing.
Initialize all static vars that are not, most to `null`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32650 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 15:42:40 +00:00
Scott Taylor
23ce2efd12 Add @global annotations for wp-admin/*.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32642 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-28 21:40:27 +00:00
John Blackbourn
a0bd96bafb Introduce a string representing bulk plugin update success, ready for string freeze. Not used yet.
See #31770.


git-svn-id: https://develop.svn.wordpress.org/trunk@31991 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 00:17:20 +00:00
Dion Hulse
f0849242d3 Upgrader: When creating a temporary working directory, strip off .tmp as well as .zip incase we end up using that directory as the items main directory.
Fixes #30945


git-svn-id: https://develop.svn.wordpress.org/trunk@31863 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 04:39:56 +00:00
Sergey Biryukov
630aac94a3 Remove leading newlines from two translatable strings.
fixes #29480.

git-svn-id: https://develop.svn.wordpress.org/trunk@31844 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 02:41:33 +00:00
Scott Taylor
2f20da29b5 Replace array_shift() with reset() where appropriate for performance.
Props SergeyBiryukov.
Fixes #31259.


git-svn-id: https://develop.svn.wordpress.org/trunk@31829 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-19 03:55:39 +00:00
Sergey Biryukov
e3728870fb Correct parameter types for Plugin_Upgrader::bulk_upgrade() and Theme_Upgrader::bulk_upgrade().
props ipm-frommen.
fixes #31312.

git-svn-id: https://develop.svn.wordpress.org/trunk@31441 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-13 04:18:45 +00:00
Dion Hulse
4ed2d89ced WP_Upgrader: Remove references to non-existant variables that have never existed.
Props jdgrimes. Fixes  #29087


git-svn-id: https://develop.svn.wordpress.org/trunk@31327 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-03 06:17:05 +00:00
Scott Taylor
0522fcb3f9 Jump statements should not be followed by other statements (there were 5 lingering).
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31100 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 21:14:56 +00:00
Scott Taylor
6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words.
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 07:04:40 +00:00
Dion Hulse
28e22a4ec4 Background Updates: Pass back whether Group Writable support is being leveraged for an update to the WordPress.org API.
See #30245


git-svn-id: https://develop.svn.wordpress.org/trunk@30860 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 14:07:35 +00:00
Andrew Nacin
b38c603682 Rename _wp_clear_update_cache() to wp_clean_update_cache().
This makes it match most cache-clearing functions, including the ones it wraps. Also no need for it to be prefixed as "private."

wp_clean_plugins_cache() doesn't always exist, so as a quick fix, clear the transient we care to clear.

see #30369.


git-svn-id: https://develop.svn.wordpress.org/trunk@30856 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 08:54:14 +00:00
Andrew Ozz
fce20e9784 Better docs for Plugin_Upgrader::deactivate_plugin_before_upgrade(). Props DrewAPicture. Fixes #29088.
git-svn-id: https://develop.svn.wordpress.org/trunk@30762 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 01:18:21 +00:00
Andrew Ozz
d948f0bf32 Always return a value in Plugin_Upgrader::deactivate_plugin_before_upgrade(). Props jdgrimes. Fixes #29088.
git-svn-id: https://develop.svn.wordpress.org/trunk@30761 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 00:52:06 +00:00
Drew Jaynes (DrewAPicture)
3cdbc730d3 Add missing DocBlocks and parameter descriptions for a wide variety of properties and methods in WP_Upgrader, Plugin_Upgrader, Theme_Upgrader, Language_Pack_Upgrader, Core_Upgrader, and File_upload_Upgrader.
Props jdgrimes, DrewAPicture.

See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@30758 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 00:25:44 +00:00
Drew Jaynes (DrewAPicture)
18f101b4bf Using let's properly in inline comments lets us move on to more pressing matters of inline documentation.
Props trepmal.
Fixes #30570.


git-svn-id: https://develop.svn.wordpress.org/trunk@30703 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 04:42:17 +00:00
Drew Jaynes (DrewAPicture)
f45fd382b3 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*.
Also adds a few inline `@see` cross-references as they apply.

Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`

See #30552.


git-svn-id: https://develop.svn.wordpress.org/trunk@30648 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 11:27:19 +00:00
Dominik Schilling (ocean90)
f38be98c89 Clear update caches when site language is changed.
The update screen has a re-install button which could show the wrong language locale after the site language was changed. That's because the update data is cached. 
Introduce `_wp_clear_update_cache()` as a helper function to clean up the update cache.

props SergeyBiryukov, ocean90.
fixes #30369.

git-svn-id: https://develop.svn.wordpress.org/trunk@30554 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 22:49:13 +00:00
Dion Hulse
9d0c957410 Background Updates: Introduce support to take advantage of Group Writable (or World Writable) to Core Background updates.
This is only enabled when new files will not be installed during the update (as indicated by the WordPress.org API), and does not apply to Plugin/Theme/Translation Background Updates.

Additionally, the code to determine if the 'direct' filesystem transport should be used has been tweaked for wider support (where getmyuid() was unavailalbe) which fixes #10424

See #10205, #30245


git-svn-id: https://develop.svn.wordpress.org/trunk@30384 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-19 05:39:52 +00:00
Scott Taylor
7acb2c8eb1 Declare the $update_count and $update_current properties for WP_Upgrader.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30171 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 23:06:38 +00:00
Mark Jaquith
be8a0c6f89 Use HTTPS URLs for trac.wordpress.org (and use core.trac.wordpress.org)
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29789 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 13:36:38 +00:00
Mark Jaquith
7063377539 Use HTTPS URLs for core.trac.wordpress.org
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29788 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 13:27:55 +00:00
Dominik Schilling (ocean90)
350152b49e Language Pack Upgrader: Allow to disable asynchronously translation updates.
* Don't touch VCS installs.
* Use the `async_update_translation` filter (which corresponds exactly to `auto_update_translation`) to entirely disable it, or based on the update offer. 

props nacin, ocean90.
fixes #28571.

git-svn-id: https://develop.svn.wordpress.org/trunk@29694 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-03 10:37:21 +00:00
Dion Hulse
a01096b872 Language Pack Upgrader: Remove ALL pre-existing filters before performing a translation update these filters may act in an unexpected way during the upgrade process.
See #29230. Fixes #29425.


git-svn-id: https://develop.svn.wordpress.org/trunk@29685 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-03 05:37:33 +00:00
Dominik Schilling (ocean90)
1c82a3bf80 Language Pack Upgrader: Check return value before accessing the first array key.
Prevents a fatal error when Language_Pack_Upgrader::bulk_upgrade() returns a WP_Error object.

fixes #29470.

git-svn-id: https://develop.svn.wordpress.org/trunk@29675 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-02 18:27:12 +00:00
Dominik Schilling (ocean90)
5109e1cacb Theme Upgrader: Set is_multi to true when doing bulk upgrades.
fixes #29234.

git-svn-id: https://develop.svn.wordpress.org/trunk@29622 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 09:23:10 +00:00
Dominik Schilling (ocean90)
3a061c9743 Language Pack Upgrader: Remove any pre-existing package checks and then set the new one for translations.
fixes #29230.

git-svn-id: https://develop.svn.wordpress.org/trunk@29621 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 09:19:17 +00:00
Drew Jaynes (DrewAPicture)
ab6063cc88 Fix some documentation typos in various core files.
Props vlajos.
Fixes #29199.


git-svn-id: https://develop.svn.wordpress.org/trunk@29479 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-13 03:55:10 +00:00
Drew Jaynes (DrewAPicture)
6ddc1e5f6d Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:13:53 +00:00
Sergey Biryukov
8ee9631bb4 Remove non-breaking spaces from auto update email text.
props trepmal.
fixes #28715.

git-svn-id: https://develop.svn.wordpress.org/trunk@28956 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 12:45:31 +00:00
Scott Taylor
7ab6b096e6 Remove some dead variable assignments.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28629 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 16:58:36 +00:00
Sergey Biryukov
15588188e8 Fix inconsistent header underlining and spacing in background update emails.
fixes #28306.

git-svn-id: https://develop.svn.wordpress.org/trunk@28537 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 09:40:36 +00:00
Scott Taylor
afe33f0f68 Add access modifier (public) to methods and members of WP_Upgrader and its subclasses.
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28496 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 01:28:10 +00:00
Scott Taylor
1b4e4e665a hackificator complains if you call include 'file.php' without the parens, needs to be include( 'file.php' )
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28479 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 20:51:44 +00:00
Scott Taylor
40e6ec443f Add inline comment after fix in [28467].
Props jesin.
Fixes #28292.



git-svn-id: https://develop.svn.wordpress.org/trunk@28468 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-17 15:41:40 +00:00