Commit Graph

255 Commits

Author SHA1 Message Date
Mark Jaquith d8781a4f32 Keep the theme update thickbox from being obscured by the toolbar.
props ParadisePorridge, SergeyBiryukov. fixes #23984.

git-svn-id: https://develop.svn.wordpress.org/trunk@24558 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-05 15:15:58 +00:00
Sergey Biryukov 1cc916fb99 Avoid a fatal error when adding a non-existent user to a site. props duck_. fixes #24460.
git-svn-id: https://develop.svn.wordpress.org/trunk@24509 602fd350-edb4-49c9-b593-d223f7449a82
2013-06-25 14:24:18 +00:00
Sergey Biryukov 936408271f Correct phpdoc for Add New User screen in network admin. props zeo. fixes #24446.
git-svn-id: https://develop.svn.wordpress.org/trunk@24383 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-29 23:35:13 +00:00
Sergey Biryukov e8ea660108 Remove extraneous function parameters in the network admin. props rlerdorf. see #24210.
git-svn-id: https://develop.svn.wordpress.org/trunk@24120 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-29 00:26:49 +00:00
Ryan Boren fc239715ca Use API instead of bare SQL queries in site-users.php.
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23974 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-12 13:35:45 +00:00
Sergey Biryukov aa44600be8 Update Network Dashboard help text. props DrewAPicture, raggedrobins. see #23163.
git-svn-id: https://develop.svn.wordpress.org/trunk@23657 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-09 03:18:26 +00:00
Ryan Boren ec09b27a71 Call them network upgrades rather than network updates to better indicate that they are DB upgrades rather than code/file upgrades.
Improve the contextual help for the Network Upgrade screen.

Props DrewAPicture
fixes #23540


git-svn-id: https://develop.svn.wordpress.org/trunk@23619 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-05 17:02:31 +00:00
Ryan Boren 436b32ef62 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
git-svn-id: https://develop.svn.wordpress.org/trunk@23567 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 17:14:09 +00:00
Ryan Boren 206318aeca There is no need to strip the output of get_site_option().
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23556 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:37:24 +00:00
Ryan Boren c363aea627 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
Ryan Boren a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Sergey Biryukov 16e16c7ee4 Use correct escaping function. fixes #23334.
git-svn-id: https://develop.svn.wordpress.org/trunk@23413 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 05:52:23 +00:00
Ryan Boren c53137f535 Scope button classes so they can be used on the frontend without interfering with theme styles.
Props helenyhou, koopersmith
fixes #22644


git-svn-id: https://develop.svn.wordpress.org/trunk@22948 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-30 13:40:59 +00:00
Andrew Nacin de15d6636a Add manual new lines to a string, as double quotes with \n is not optimal due to sprintf-parsing reasons. props SergeyBiryukov, fixes #22486. see #22260.
git-svn-id: https://develop.svn.wordpress.org/trunk@22664 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 06:11:42 +00:00
Ryan Boren 46d017a331 Use retina logo in install, upgrade, setup-config, repair, and confirmation screens.
Props kopepasah, SergeyBiryukov
fixes #22375


git-svn-id: https://develop.svn.wordpress.org/trunk@22419 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 17:34:22 +00:00
Peter Westwood e64c828f44 i18n: Fix the usage of sprintf replacements in the Multisite Network Admin new site page. See #22260.
git-svn-id: https://develop.svn.wordpress.org/trunk@22272 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-23 11:30:09 +00:00
Ryan Boren e260aa0e7a Remove set_time_limit() from sites.php. Props dllh. fixes #19486 see #21521
git-svn-id: https://develop.svn.wordpress.org/trunk@22259 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-17 21:40:31 +00:00
Ryan Boren 8d5ca186c2 Consolidate some strings. Props pavelevap, SergeyBiryukov. see #21728
git-svn-id: https://develop.svn.wordpress.org/trunk@22124 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-05 19:04:34 +00:00
Dion Hulse 7b00e4b156 Fix Bulk Theme Deletion in the Network Admin when using FTP. Props kobenland. Fixes #20671
git-svn-id: https://develop.svn.wordpress.org/trunk@22084 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-29 01:36:14 +00:00
Ryan Boren 3ca9c27717 Remove dupe/deprecated code from sites.php.
Props wonderboymusic
fixes #21553


git-svn-id: https://develop.svn.wordpress.org/trunk@22064 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-27 17:11:07 +00:00
Mark Jaquith 52801db5fc Make Multisite work when WordPress is installed in a subdirectory. You can now have WordPress Multisite as an SVN external or a Git submodule! props johnjamesjacoby, evansolomon, duck_, jakemgold, nacin, markjaquith. see #19796
git-svn-id: https://develop.svn.wordpress.org/trunk@22042 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-27 06:07:21 +00:00
Andrew Nacin 248b586911 Move sanitization for the multisite illegal_names, limited_email_domains, and banned_email_domains options to sanitize_option(). props wonderboymusic. fixes #21552.
git-svn-id: https://develop.svn.wordpress.org/trunk@21993 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-25 01:54:12 +00:00
Andrew Nacin 73f5dd8a35 Remove unused edit-site nonce fields from site-users and site-themes. props jeremyfelt, fixes #21277.
git-svn-id: https://develop.svn.wordpress.org/trunk@21903 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-18 23:06:22 +00:00
Andrew Nacin 8437239bb2 Correct a translation context in the network admin. props SergeyBiryukov. fixes #20910.
git-svn-id: https://develop.svn.wordpress.org/trunk@21858 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-15 19:57:46 +00:00
Andrew Nacin 168d12a728 Simplify the markup and hierarchy of the Add Existing and Add New user forms on site-users.php. props obenland, fixes #21223.
git-svn-id: https://develop.svn.wordpress.org/trunk@21854 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-15 19:38:23 +00:00
Andrew Nacin 9931c1a45d Hide the link manager from the UI on upgrade, if the site has no links. New DB option, link_manager_enabled.
Enforce this by denying the 'manage_links' capability, which hides the All Links, Add New Link, and Link Categories screens. Hide WP_Widget_Links and the UI for the default_link_category as well.

Convert all references to 'posts and links' when handling reassignment on user deletion to just 'posts'.

see #21307.



git-svn-id: https://develop.svn.wordpress.org/trunk@21501 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-13 16:18:42 +00:00
Ryan Boren ce960f67a0 Deprecate get_blog_option(), add_blog_option(), update_blog_option(), and delete_blog_option().
Use the regular option functions wrapped in switch_to_blog() and restore_current_blog() instead.

Group multiple operations within a single switch where possible.

fixes #21432


git-svn-id: https://develop.svn.wordpress.org/trunk@21414 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-03 17:51:42 +00:00
Andrew Nacin a5c7405975 Move most instances of new WP_User to get_userdata(). see #21120.
git-svn-id: https://develop.svn.wordpress.org/trunk@21413 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-03 01:06:05 +00:00
Andrew Nacin 4a23ebe03d Enforce multisite plugins menu preference in map_meta_cap(). This means a simple current_user_can('activate_plugins') check will handle the 'Enable administration menus' setting.
Remove bogus checks for enabling/disabling the 'themes' menu (something core does not handle out of the box) when in the network admin.

fixes #21123.



git-svn-id: https://develop.svn.wordpress.org/trunk@21198 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-30 12:40:25 +00:00
Ryan Boren d0e8e5ca35 Use the stylesheet rather than the template to create the network enable theme nonce. Fix network enable redirect following theme installation. Props duck_, nacin. fixes #20916
git-svn-id: https://develop.svn.wordpress.org/trunk@21062 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-12 15:31:25 +00:00
Ryan Boren f1d9066aed Remove obsolete help string. Props SergeyBiryukov. fixes #20909
git-svn-id: https://develop.svn.wordpress.org/trunk@21051 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-11 20:32:21 +00:00
Andrew Nacin 245b0655d2 Remove user/site suggestions (autocompletion) from search inputs, as the UX isn't proper.
* Removes all instances of site-search, so away it goes. Sidesteps a number of bugs with site-search.
 * Renames user-search to user-suggest, which means it better describes the current behavior (autocompletion) while allowing for future behavior (instant search).
 * Ties user suggestions to a single .wp-suggest-user class.

with help from markjaquith, helenyhou, wonderboymusic. 
fixes #20835.



git-svn-id: https://develop.svn.wordpress.org/trunk@21003 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-05 18:51:33 +00:00
Andrew Nacin fd55214d96 Fix typo in the word 'administrator'.
translate.wordpress.org was manually updated to correct the typo,
so this will not result in a string change.

props ocean90
fixes #20829



git-svn-id: https://develop.svn.wordpress.org/trunk@20993 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-04 18:06:32 +00:00
Andrew Nacin 8ecb207683 Correct the link to http://codex.wordpress.org/Network_Admin_Sites_Screen in the network admin help sidebars. props Nao. fixes #20607.
git-svn-id: https://develop.svn.wordpress.org/trunk@20713 602fd350-edb4-49c9-b593-d223f7449a82
2012-05-03 13:34:33 +00:00
Andrew Nacin d8e2eb8943 Do not break a domain on network/site-new.php across two lines. props SergeyBiryukov, fixes #19895.
git-svn-id: https://develop.svn.wordpress.org/trunk@20621 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-27 19:02:10 +00:00
Andrew Nacin c16d06c447 s/website/network/ on the network settings screen. props Ipstenu, fixes #20314.
git-svn-id: https://develop.svn.wordpress.org/trunk@20442 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-11 20:45:03 +00:00
Andrew Nacin 48c5af2ac0 Clean up cap checks for autocompletes for sites and users in a network. see #19810.
git-svn-id: https://develop.svn.wordpress.org/trunk@20332 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-30 21:04:48 +00:00
Andrew Nacin 76e4fbee38 Remove step="" from upload size inputs, as the step is enforced in the spec, rather than being a recommendation. finally fixes #17863.
git-svn-id: https://develop.svn.wordpress.org/trunk@20289 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-25 13:02:01 +00:00
Mark Jaquith 461e24643c Autocomplete site names in Network Admin. More user completion areas. props Japh, DrewAPicture. see #19810.
git-svn-id: https://develop.svn.wordpress.org/trunk@20279 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-24 04:54:58 +00:00
Andrew Nacin eb066c0b33 Adjust site upload space HTML5 type='number' validation. see #17863.
git-svn-id: https://develop.svn.wordpress.org/trunk@20199 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-16 04:16:21 +00:00
Andrew Nacin ce48b0d471 Revert type="email" (HTML5) as some browsers that do validation on these fields do not work for IDN domains yet. Core does not support these well either, but server-side validation can at least be dealt with by a plugin. see #17863.
git-svn-id: https://develop.svn.wordpress.org/trunk@20196 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-15 18:09:14 +00:00
Andrew Nacin 681c6ea428 Remove index-extra.php. Move dashboard widget XHR callbacks to ajax-actions.php. fixes #20242.
git-svn-id: https://develop.svn.wordpress.org/trunk@20190 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-15 13:20:00 +00:00
Andrew Ozz fcbd8f7f57 Set proper HTML5 input types in the admin, props georgestephanis, fixes #17863
git-svn-id: https://develop.svn.wordpress.org/trunk@20168 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-10 01:23:48 +00:00
Andrew Nacin c7b3d21c18 In multisite, list broken themes on network/themes.php instead of on individual Manage Themes pages. see #20103.
git-svn-id: https://develop.svn.wordpress.org/trunk@20151 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-08 07:32:42 +00:00
Jon Cave d996b72215 Use tabs for indentation.
git-svn-id: https://develop.svn.wordpress.org/trunk@20093 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:03:15 +00:00
Jon Cave c6d3eafb7e Drop unnecessary if-statements which also have some strange logic. Fixes #20159.
git-svn-id: https://develop.svn.wordpress.org/trunk@20092 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:01:41 +00:00
Andrew Nacin c7855fb7bc Use wp_get_theme() rather than get_theme_data() in the verify theme deletion (multisite network) screen. see #20103.
git-svn-id: https://develop.svn.wordpress.org/trunk@20037 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-29 07:50:56 +00:00
Andrew Nacin 09b4c5d21f Update login-logo.png to use proper color. Copy it over wordpress-logo.png. Make that one canonical, and stop using login-logo.png. Leave it for plugins. props iammattthomas. see #19955.
git-svn-id: https://develop.svn.wordpress.org/trunk@19937 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-17 04:57:56 +00:00
Mark Jaquith 54ab38d9ed Autocomplete for add-user screens in multisite. props boonebgorges, Japh, DrewAPicture, PeteMall, nacin, koopersmith, markjaquith. see #19810.
git-svn-id: https://develop.svn.wordpress.org/trunk@19897 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-10 08:45:17 +00:00
Andrew Nacin 0c59eacb55 Use is_rtl() for html direction when possible. In sites.php, language_attributes() will always exist (MU vestige). When the DB is dead, language_attributes() is worse than a simple is_rtl() check. is_rtl() exists here due to wp_load_translations_early(). see #18180.
git-svn-id: https://develop.svn.wordpress.org/trunk@19862 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-08 06:05:35 +00:00