Commit Graph

109 Commits

Author SHA1 Message Date
Andrew Nacin b617e4742a Don't unslash variables that came from wp_reset_vars(). see #21767.
git-svn-id: https://develop.svn.wordpress.org/trunk@23580 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 18:59:54 +00:00
Ryan Boren 436b32ef62 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
git-svn-id: https://develop.svn.wordpress.org/trunk@23567 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 17:14:09 +00:00
Ryan Boren c363aea627 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
Andrew Nacin 36d09ab2ef Do not unslash variables reset by wp_reset_vars(). Remove variables that have never been used in plugin-editor.php. see #21767.
git-svn-id: https://develop.svn.wordpress.org/trunk@23419 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-15 02:01:36 +00:00
Ryan Boren a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Mark Jaquith ca7674b100 "Lookup" is a noun. "Look up" is the verb form. If you doubt me, you should have lookuped in a dictionary.
props johnbillion, SergeyBiryukov. fixes #22386

git-svn-id: https://develop.svn.wordpress.org/trunk@23393 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-08 16:19:04 +00:00
Andrew Ozz 5ed30e85b9 Move the description for tabbing out of the plugin and theme editors textareas to the Help tab, fixes #21347
git-svn-id: https://develop.svn.wordpress.org/trunk@21358 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-27 16:49:48 +00:00
Andrew Ozz 6e6b727315 Remove nearly all tabindex attributes from the admin, leaving them only where absolutely necessary (for now that's only the toolbar).
Add tabindex="-1" for the menu images links to avoid double tab stops there when the menu is expanded.

Fix/add auto-focus on the first input fields on the Add/Edit Post, all taxonomy, all edit taxonomy, Log In and Edit Comment screens.

See #21340.

git-svn-id: https://develop.svn.wordpress.org/trunk@21311 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-24 00:15:15 +00:00
Andrew Ozz dda796260d Make it possible to tab out of the plugin and theme editors textareas by pressing Esc followed by Tab, fixes #21347
git-svn-id: https://develop.svn.wordpress.org/trunk@21310 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-23 23:46:27 +00:00
Andrew Nacin 5ed7eb7f1c Clean up plugins.php with regards to recently edited files, deactivations, and the network admin. see #20468, #20104.
* Limit recently_activated to the site dashboard, and properly remove bulk-activated plugins from the array.
 * Remove code used from before the network admin, such as the unused 'network' plugin_status.
 * Don't try to deactivate a plugin already deactivated.
 * Use more specific caps (manage_network_plugins) rather than is_super_admin().



git-svn-id: https://develop.svn.wordpress.org/trunk@20525 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-19 03:41:29 +00:00
Ryan Boren 676ba7043e Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: https://develop.svn.wordpress.org/trunk@19593 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-13 23:45:31 +00:00
Ryan Boren 6610e321e7 Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@19528 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-01 04:51:35 +00:00
Ryan Boren 4ae0813953 Help tabs. Props chexee. see #19020
git-svn-id: https://develop.svn.wordpress.org/trunk@19445 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-24 00:21:39 +00:00
Andrew Nacin 840f20feb2 More s/add_help_sidebar/set_help_sidebar/. fixes #19020.
git-svn-id: https://develop.svn.wordpress.org/trunk@19122 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 21:32:16 +00:00
Ryan Boren 71aa0059d0 Use add_help_sidebar(). see #19020
git-svn-id: https://develop.svn.wordpress.org/trunk@19114 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 05:33:53 +00:00
Andrew Ozz dde77fd41b Merge most admin css files, first run, see #18314
git-svn-id: https://develop.svn.wordpress.org/trunk@18577 602fd350-edb4-49c9-b593-d223f7449a82
2011-08-21 03:46:43 +00:00
Ryan Boren d66facad6c url_encode file names in theme and plugin editor urls. Props kawauso. fixes #17038
git-svn-id: https://develop.svn.wordpress.org/trunk@18094 602fd350-edb4-49c9-b593-d223f7449a82
2011-06-01 16:14:58 +00:00
Andrew Nacin f504e221e1 Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265.
git-svn-id: https://develop.svn.wordpress.org/trunk@17748 602fd350-edb4-49c9-b593-d223f7449a82
2011-04-28 15:24:49 +00:00
Ryan Boren ebabd43ec6 Don't deactivate a plugin that is both network activated and activated on the main site after editing. Props SergeyBiryukov. fixes #16011
git-svn-id: https://develop.svn.wordpress.org/trunk@17183 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-30 19:02:14 +00:00
Andrew Nacin 9127aef074 Restore an exit we need. props duck_, fixes #15518.
git-svn-id: https://develop.svn.wordpress.org/trunk@17114 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-22 23:00:53 +00:00
Andrew Nacin 54bb5450fc Slight tweak. props andrea_r, #15314.
git-svn-id: https://develop.svn.wordpress.org/trunk@17047 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-18 18:37:11 +00:00
Andrew Nacin 27be9140d8 Network-specific language on the plugin and theme editor help tabs. props andrea_r, see #15314.
git-svn-id: https://develop.svn.wordpress.org/trunk@17046 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-18 18:33:21 +00:00
Andrew Nacin 7feeb0a320 Help text edits. props dougwrites, fixes #15346.
git-svn-id: https://develop.svn.wordpress.org/trunk@16980 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-16 06:37:03 +00:00
Andrew Nacin 3ebb27ae3e Always exit after wp_redirect. props filosofo, fixes #15518.
git-svn-id: https://develop.svn.wordpress.org/trunk@16847 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-09 18:02:54 +00:00
Andrew Nacin 8abcb8e5ce Link to network/update-core when running multisite. Remove theme/plugin editors from blog menu when running multisite. Redirect to network/* when accessing theme/plugin-install/editor. props ocean90, see #15525.
git-svn-id: https://develop.svn.wordpress.org/trunk@16747 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-06 15:41:19 +00:00
Mark Jaquith 55e0256967 esc_textarea() and application for obvious textarea escaping. props alexkingorg. fixes #15454
git-svn-id: https://develop.svn.wordpress.org/trunk@16431 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-17 17:12:01 +00:00
Mark Jaquith d65cdf4ba8 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064
git-svn-id: https://develop.svn.wordpress.org/trunk@16061 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-28 21:56:43 +00:00
Ryan Boren 5fe33fe732 Use self_admin_url(). Props PeteMall. see #14062
git-svn-id: https://develop.svn.wordpress.org/trunk@16015 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-27 16:52:35 +00:00
Dion Hulse 82443ce769 Use Absolute URL's & API's in header redirects in more locations. See #14062
git-svn-id: https://develop.svn.wordpress.org/trunk@16008 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-27 10:43:43 +00:00
Ryan Boren 898e5b0268 Plugin editing for network admin. Props PeteMall. see #14435
git-svn-id: https://develop.svn.wordpress.org/trunk@15853 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-19 18:23:23 +00:00
Andrew Nacin 53d3846f6a target=blank for help. props jorbin, see #13467
git-svn-id: https://develop.svn.wordpress.org/trunk@15132 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-03 21:00:39 +00:00
Andrew Nacin e89212637d Help whitespace/punctuation cleanup. props zeo, see #13467.
git-svn-id: https://develop.svn.wordpress.org/trunk@15054 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-29 16:16:40 +00:00
Nikolay Bachiyski 432ac03fb2 Menu translatable strings cleanup.
* Take out <strong> of the translatable part of For more information:
 * Include support forums and Codex links inside translations, because most translators would want to change them to their local documentation sites or Codex prefixes


git-svn-id: https://develop.svn.wordpress.org/trunk@14989 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-27 11:52:15 +00:00
Ryan Boren 1762f15347 Help cleanup. Props duck_. see #13467
git-svn-id: https://develop.svn.wordpress.org/trunk@14965 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-26 21:32:30 +00:00
Ryan Boren c6f462c0f6 Help for plugin-editor.php. see #13467
git-svn-id: https://develop.svn.wordpress.org/trunk@14959 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-26 20:40:57 +00:00
Andrew Nacin 8fc8e37158 Hide Flash uploader and theme/plugin editor documentation feature, if no JS. Also some validation fixes in the theme editor. props ocean90. see #13383.
git-svn-id: https://develop.svn.wordpress.org/trunk@14930 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-26 03:57:55 +00:00
Andrew Nacin cb75ebbb54 Remove autocomplete and codepress. for autocomplete, see #13283. for codepress, see #13307.
git-svn-id: https://develop.svn.wordpress.org/trunk@14718 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-18 03:48:22 +00:00
Andrew Nacin 63fa3e7f3f Support network-wide plugin re-activation in upgrades and edits. props PeteMall, fixes #13216
git-svn-id: https://develop.svn.wordpress.org/trunk@14348 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-02 22:57:44 +00:00
Ryan Boren 616f48e89d Don't call get_plugins() in menu.php. It is too slow to call on every admin page load. fixes #13117
git-svn-id: https://develop.svn.wordpress.org/trunk@14299 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-29 16:38:12 +00:00
Andrew Nacin 23cd92c6ff Don't show plugin editor when there are no plugins. props solarissmoke, fixes #13117.
git-svn-id: https://develop.svn.wordpress.org/trunk@14290 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-29 05:34:24 +00:00
Andrew Nacin ec4f5b83bf Use relative paths when including files, avoiding include_path. fixes #12594, props sorich87.
git-svn-id: https://develop.svn.wordpress.org/trunk@14139 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-18 06:14:45 +00:00
Dion Hulse 724ae803d8 Mark auto-deactivated plugins as recently active after the Plugin Editor deactivates them. Fixes #10925
git-svn-id: https://develop.svn.wordpress.org/trunk@13859 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-28 03:28:52 +00:00
Andrew Nacin 4d65e83ef9 Allow tab to intent in plugin/theme editors. Reverts first pass, [13131]. Props azaozz, fixes #12204
git-svn-id: https://develop.svn.wordpress.org/trunk@13191 602fd350-edb4-49c9-b593-d223f7449a82
2010-02-18 05:14:48 +00:00
Andrew Nacin b38b545ed4 Allow tab intents in plugin/theme editors. Utilizes the Tabby jQuery plugin, see #12204
git-svn-id: https://develop.svn.wordpress.org/trunk@13131 602fd350-edb4-49c9-b593-d223f7449a82
2010-02-14 02:14:59 +00:00
Ryan Boren 94a9904b69 Remove fix_actve_plugins(). Props hakre. fixes #11750
git-svn-id: https://develop.svn.wordpress.org/trunk@12848 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-26 18:39:12 +00:00
Andrew Ozz 060d9185e6 Remove unused .fade CSS class, props nacin, fixes #11628
git-svn-id: https://develop.svn.wordpress.org/trunk@12546 602fd350-edb4-49c9-b593-d223f7449a82
2009-12-26 09:00:58 +00:00
Ryan Boren 0042fa7b7c Fix file validation in theme editor. Props dd32. fixes #11032
git-svn-id: https://develop.svn.wordpress.org/trunk@12310 602fd350-edb4-49c9-b593-d223f7449a82
2009-12-01 22:03:13 +00:00
Ryan Boren e024f20812 Disable codepress. Maintained replacement needed.
git-svn-id: https://develop.svn.wordpress.org/trunk@12005 602fd350-edb4-49c9-b593-d223f7449a82
2009-10-07 15:22:23 +00:00
Andrew Ozz 152a0d9f3f Scroll back to the same location after saving a file in the Plugin and Theme editors
git-svn-id: https://develop.svn.wordpress.org/trunk@11788 602fd350-edb4-49c9-b593-d223f7449a82
2009-08-08 07:22:19 +00:00
Ryan Boren 79eb523554 Check that token_get_all() exists before creating documentation links. fixes #10261 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@11671 602fd350-edb4-49c9-b593-d223f7449a82
2009-06-29 20:48:12 +00:00