Commit Graph

35 Commits

Author SHA1 Message Date
Scott Taylor
3616fe5939 Widgets: add a function, is_registered_sidebar() - helps us avoid touching the $wp_registered_sidebars global.
Props GaryJ, wonderboymusic.
Fixes #24878.


git-svn-id: https://develop.svn.wordpress.org/trunk@35102 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 01:32:27 +00:00
Andrea Fercia
52c2492afb Accessibility: bump headings one level up on the Appearance > Widgets screen for a better headings hierarchy.
Props mrahmadawais, afercia.
Fixes #33659.

git-svn-id: https://develop.svn.wordpress.org/trunk@35015 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-10 16:33:33 +00:00
Drew Jaynes
a774dfbb08 Widgets: Introduce a delete_widget action, which fires after a widget has been marked for deletion.
Props afercia for the initial patch.
Fixes #27444.


git-svn-id: https://develop.svn.wordpress.org/trunk@34714 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-30 03:20:41 +00:00
Drew Jaynes
5e875e78f7 Docs: The Widget API is singular.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34392 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 12:27:33 +00:00
Scott Taylor
8af9ff0e56 Move wp_widgets_access_body_class() (a hook callback) from wp-admin/widgets.php to wp-admin/includes/widgets.php.
See #33813.


git-svn-id: https://develop.svn.wordpress.org/trunk@34017 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-10 21:21:27 +00:00
Sergey Biryukov
190561b89d Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/widgets.php.
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33680. see #14530.

git-svn-id: https://develop.svn.wordpress.org/trunk@33886 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 08:55:53 +00:00
Konstantin Obenland
8d40cdcb1b Use a less element-specific class name for links within page titles.
After [32974] these links are no longer within an `h2`, making the class name
inaccurate. `add-new-h1` has the potential to expose the same problem for in a
possible future change.

Fixes #31650.



git-svn-id: https://develop.svn.wordpress.org/trunk@33067 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 16:41:18 +00:00
Konstantin Obenland
e59592f87e Proper heading for admin screens.
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.



git-svn-id: https://develop.svn.wordpress.org/trunk@32974 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 15:40:27 +00:00
Scott Taylor
ec5758225c Add missing doc blocks to wp-admin/includes/*.
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32654 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 20:16:22 +00:00
Dominik Schilling (ocean90)
b0d6757918 Use HTTPS URLs for codex.wordpress.org.
see #27115.

git-svn-id: https://develop.svn.wordpress.org/trunk@32116 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-12 21:28:58 +00:00
Helen Hou-Sandi
35df5592f1 Admin notices: Make (most) core notices dismissible.
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.

props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233. see #23367.


git-svn-id: https://develop.svn.wordpress.org/trunk@31973 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 22:05:17 +00:00
Scott Taylor
2f20da29b5 Replace array_shift() with reset() where appropriate for performance.
Props SergeyBiryukov.
Fixes #31259.


git-svn-id: https://develop.svn.wordpress.org/trunk@31829 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-19 03:55:39 +00:00
Dominik Schilling (ocean90)
1ddd9cad9b Widgets: Add return param for widgets admin page to the "Manage in Customizer" link.
props tywayne.
fixes #30888.

git-svn-id: https://develop.svn.wordpress.org/trunk@31420 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-11 20:56:21 +00:00
Scott Taylor
83b6fad852 In HTML5, the action attribute is no longer required. Remove this attribute when empty.
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.


git-svn-id: https://develop.svn.wordpress.org/trunk@31200 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-16 04:15:52 +00:00
Dominik Schilling (ocean90)
df884cb92e Customizer: Use deep-links for Backgrounds, Headers, and Widgets.
Replace links in admin menu and toolbar to Custom Background/Header screen with deep-links to the Customizer section.
On the Widgets screen display a link to the Customizer widgets panel.

props topher1kenobe, rzen, celloexpressions, westonruter
fixes #25569, #25571, #28032.

git-svn-id: https://develop.svn.wordpress.org/trunk@30459 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 15:28:55 +00:00
John Blackbourn
4e1e4745ff Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors.
Fixes #10551
Props nacin


git-svn-id: https://develop.svn.wordpress.org/trunk@30356 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 06:15:29 +00:00
Drew Jaynes (DrewAPicture)
6ddc1e5f6d Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:13:53 +00:00
Drew Jaynes (DrewAPicture)
a2d810d024 The sidebar_admin_setup hook should only be documented once in wp-admin/widgets.php. All others are duplicates.
See #25374, #25501, #27531.


git-svn-id: https://develop.svn.wordpress.org/trunk@27823 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-28 19:46:26 +00:00
Andrew Nacin
4cf6fc1a99 Use SSL when linking to WordPress.org. see #27115.
git-svn-id: https://develop.svn.wordpress.org/trunk@27469 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-08 04:13:28 +00:00
Matt Thomas
71588c2933 Revert r26593 so Available and Inactive widgets are once again collapsible. Make the arrows only appear on hover when uncollapsed. Fixes #26327, props nacin.
git-svn-id: https://develop.svn.wordpress.org/trunk@26608 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-04 16:30:05 +00:00
Matt Thomas
933a5f252f Set Available and Inactive Widget areas to not collapse, since they don't look like collapsing elements. Fixes #26327, props MikeHansenMe.
git-svn-id: https://develop.svn.wordpress.org/trunk@26593 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-03 21:31:37 +00:00
Andrew Ozz
b33d0da84c Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119
git-svn-id: https://develop.svn.wordpress.org/trunk@26518 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-02 03:52:23 +00:00
Andrew Ozz
3f7cbafb94 Widgets: improve the help text on the Widgets screen, props siobhan, props Hanni, fixes #26244.
git-svn-id: https://develop.svn.wordpress.org/trunk@26505 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-01 18:28:12 +00:00
Andrew Ozz
f4264f9446 Widgets: drop onto closed sidebars.
- Make dropping a widget easier by preventing the source sidebar from resizing while the widget is being dragged.
- Move widgets dropped on closed sidebars to the top. UI Sortable places them randomly near the bottom.
- Fix possible regression in wp_list_widget_controls(), add an optional argument to output the sidebar name inside the sortable container.
- Updated styles for sidebar description and widget-hover class.
Part props shaunandrews, fixes #25952.

git-svn-id: https://develop.svn.wordpress.org/trunk@26426 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-27 01:29:49 +00:00
Andrew Ozz
89d0be9d3d Widgets:
- Don't deactivate "draggable" on the widget when the chooser is open. Makes it possible to still drag the "widget-in-question".
- Change the chooser's HTML id to a class to avoid collisions when cloning.
- Refresh the "sortable" positions when an open widget is dragged. Fixes problems moving the widget up or down in the same sidebar.
See #25821

git-svn-id: https://develop.svn.wordpress.org/trunk@26366 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-24 22:06:13 +00:00
Matt Thomas
9df3f0fde2 Making improvements to new styles added in the MP6 merge, and addressing visual feedback from core team.
Improved and more consistent styling on the widgets & menus pages:

* Use the same visual treatment for both widgets and menus.
* Re-use existing styles from input:focus for draggable elements.
* Use the standard H3 size for widget area titles.
* Re-style the Widgets page drop zone to match drop zone from dashboard.
* Replace the gear icon on Widgets with the standard open/close arrows.
* Remove "Choose a sidebar" header from widget area chooser.

Make open/close arrows more consistent:

* Use the same arrow direction everywhere: pointing down when its container is closed, pointing up when open (following the Dashboard example).
* Set a consistent color for open/close arrows.
* Add a hover color for open/close arrows.
* Make open/close arrows permanently visible; :hover states don't exist on touch.

Make typography and color more consistent:

* Switch all declarations of #dedede to #ddd for simplicity's sake.
* Make H3s the same weight and color as H2s.
* Make select elements the same color as text inputs.
* Make paragraph text #444 so it doesn't look washed out on grey backgrounds.

General improvements:

* Eliminate the border between rows in settings tables.
* Make text and buttons line up in the Customizer.

See #25858.



git-svn-id: https://develop.svn.wordpress.org/trunk@26293 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-20 22:47:25 +00:00
Andrew Ozz
d8077eae05 Widgets: fix html for sidebars columns when the theme has only one sidebar. See #25952.
git-svn-id: https://develop.svn.wordpress.org/trunk@26286 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-20 05:08:22 +00:00
Andrew Ozz
b31a5258cd Widgets: split the sidebars in two containers so there are no empty spaces when they are shown in two columns and some are open, other closed. See #25952.
git-svn-id: https://develop.svn.wordpress.org/trunk@26285 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-20 04:44:21 +00:00
Andrew Ozz
fdc08a857e Widgets: move the chooser inside the selected widget so it inherits the width, add some keyboard shortcuts: tab to select, enter to append and escape to cancel. Props shaunandrews, see #25821
git-svn-id: https://develop.svn.wordpress.org/trunk@26271 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-19 18:02:14 +00:00
Andrew Ozz
8ee904343b Merge the Widgets Area Chooser feature plugin. First run, see #25821
git-svn-id: https://develop.svn.wordpress.org/trunk@26054 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-08 23:04:35 +00:00
Ryan Boren
30f822b8ee Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@25880 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-23 14:37:54 +00:00
Drew Jaynes
e46830eb0b Inline documentation for hooks in wp-admin/widgets.php.
Props r3df, kpdesign.
Fixes #25501.


git-svn-id: https://develop.svn.wordpress.org/trunk@25734 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-08 20:26:25 +00:00
Andrew Nacin
8d72ad52ff Don't rely on include_path to include files.
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.


git-svn-id: https://develop.svn.wordpress.org/trunk@25616 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-25 00:17:40 +00:00
Sergey Biryukov
f913741b58 Avoid 'Only variables should be passed by reference' notice on Widgets screen. props jdgrimes. fixes #25225.
git-svn-id: https://develop.svn.wordpress.org/trunk@25226 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 05:10:43 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00