Commit Graph

33063 Commits

Author SHA1 Message Date
Andrea Fercia 455ad2fd44 Notices: improve styling consistency of links within notices.
For accessibility, links inside lines or blocks of text should be always underlined.

Props walbo.
Fixes #34606.

git-svn-id: https://develop.svn.wordpress.org/trunk@35801 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 21:59:26 +00:00
Eric Andrew Lewis a84227aab7 Posts: Don't modify post_name if it wasn't supplied to `wp_insert_post()`.
Previously when updating a post using wp_insert_post(), post_name was 
regenerated based on post_title every time if post_name was not passed in 
explicitly. This irons out the expectation that properties not passed into the 
function should not be modified.

Props jason_the_adams. 
Fixes #34865.


git-svn-id: https://develop.svn.wordpress.org/trunk@35800 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 21:57:59 +00:00
Pascal Birchler 171ae0f20d Docs: Fix a typo in the `stylesheet_directory` filter docs.
Props ixkaito.
Fixes #34859.

git-svn-id: https://develop.svn.wordpress.org/trunk@35799 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 21:56:16 +00:00
Konstantin Kovshenin c6da294f32 Docs: Make "list table table tag" a bit more readable.
See: #34885, r35796.


git-svn-id: https://develop.svn.wordpress.org/trunk@35797 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 21:53:57 +00:00
Konstantin Kovshenin 318455ff24 Docs: Remove some more dittography.
See #34885, r35793.


git-svn-id: https://develop.svn.wordpress.org/trunk@35796 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 21:49:43 +00:00
Pascal Birchler b09fd386fd Toolbar: Allow adding `lang` and `dir` attributes to toolbar items.
This is useful from a multilingual and accessibility perspective.

Props Chouby, leemon.
Fixes #33513.

git-svn-id: https://develop.svn.wordpress.org/trunk@35795 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 21:36:49 +00:00
Jeremy Felt b077af3e08 Te Docs: Fix te the misspelling.
Previously, [35793].

Fixes #34888.


git-svn-id: https://develop.svn.wordpress.org/trunk@35794 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 21:31:47 +00:00
Gary Pendergast 3025e87fa2 The the Docs: Fix the the dittography
Sometimes, it's easy to to type the the same word twice, especially if if it's a simple word. We probably shouldn't do do do (do do do doo) it, though.

(I've excluded external libs from this change.)

Fixes #34885.



git-svn-id: https://develop.svn.wordpress.org/trunk@35793 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 21:22:10 +00:00
Aaron D. Campbell 57408e271a Consider both home and site domains to be valid in `wp_validate_redirect()`.
Props layotte.
Fixes #34028.


git-svn-id: https://develop.svn.wordpress.org/trunk@35792 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 21:16:12 +00:00
Michael Arestad 53430a7343 Administration: Improve color contrast of 'Add New' buttons.
This also includes improved focus styles for 'Add New'.

fixes #34876, #34864.


git-svn-id: https://develop.svn.wordpress.org/trunk@35791 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 21:06:33 +00:00
Boone Gorges ded2547b57 Show user_login in Dashboard user dropdowns.
User dropdowns in wp-admin have traditionally shown the users' display names.
However, this causes ambiguity when users share display names. To correct this,
we now show the unique user_login in parentheses after the display name.

The new `display_name_with_login` value for the `show` parameter of
`wp_dropdown_users()` enables this functionality. The default value of `show`
has not been changed, for backward compatibility, but all instances of
`wp_dropdown_users()` in core wp-admin have been switched.

This changeset also reduces some duplicated logic when assembling a user list
when `include_selected` is true.

Props krogsgard, boonebgorges.
Fixes #31251.

git-svn-id: https://develop.svn.wordpress.org/trunk@35790 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 20:56:11 +00:00
Rachel Baker c3b6753782 Multisite: Clarify purpose of hook from [35786] and match our naming convention.
`network_site_new_created_user_pending` -> `pre_network_site_new_created_user` 

See #33631


git-svn-id: https://develop.svn.wordpress.org/trunk@35789 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 20:31:04 +00:00
Konstantin Kovshenin 1aa7dda524 Allow usage of angle brackets in a site title or tagline.
The whole string is escaped with `esc_html()` anyway, so we don't
need to `wp_kses_post()`. This is a better experience for users who
want to use angle brackets in their site title or description.
Does not allow any HTML, adds unit tests.

props BandonRandon, pauldewouters.
fixes #27942.


git-svn-id: https://develop.svn.wordpress.org/trunk@35788 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 20:28:26 +00:00
Drew Jaynes 800971f2fd Docs: Fix mid-file separator syntax in wp-includes/wp-db.php.
Props liamdempsey.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35787 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 20:25:45 +00:00
Rachel Baker a9bf2e7aaa Multisite: Add hook before a new user is created during the creation of a new site.
New `network_site_new_created_user_pending` action fires before a new user will be created via the network site-new.php page. 

Props mackensen
Fixes #33631


git-svn-id: https://develop.svn.wordpress.org/trunk@35786 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 20:09:50 +00:00
Konstantin Obenland d2bcc5fa55 Plugins: Allow long plugin names to wrap on small screens.
Props mapk, rickalee.
Fixes #32569.



git-svn-id: https://develop.svn.wordpress.org/trunk@35785 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 19:57:45 +00:00
Boone Gorges f8a0095574 Bump readme.html to 4.5.
git-svn-id: https://develop.svn.wordpress.org/trunk@35784 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 18:48:05 +00:00
Weston Ruter 1b2dae4668 Customizer: Re-use public `api.preview` instance in widgets preview instead of unnecessarily capturing in `api.Preview` constructor wrapper.
The preview instance is no longer private.

Props joshlevinson, westonruter.
Fixes #30890.
See #30726.


git-svn-id: https://develop.svn.wordpress.org/trunk@35783 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 18:38:45 +00:00
Jeremy Felt 775b27d8a5 MS: Populate `public` on empty `$current_blog` during subdomain activation.
Activation of a subdomain site is done through that new site's address. This address does not exist in the `wp_blogs` table until activation is complete.

In this case we need to make sure `public` is populated to avoid a PHP notice.

Props uglyrobot.
Fixes #24760.


git-svn-id: https://develop.svn.wordpress.org/trunk@35782 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 18:23:18 +00:00
Weston Ruter 1689948965 Customizer: Return added instances for panels, sections, controls, and settings when calling `WP_Customize_Manager::add_*()` methods.
Add missing phpDoc.

Props fusillicode, jubstuff.
Fixes #34596.


git-svn-id: https://develop.svn.wordpress.org/trunk@35781 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 18:09:42 +00:00
Mark Jaquith db288f6aa3 About Page: Add the WordPress 4.4 tagline.
"Connected" because of REST API and cross-site embeds.
"Responsive" because of responsive images and under-the-hood tweaks.

See #34663.

git-svn-id: https://develop.svn.wordpress.org/trunk@35780 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 17:51:21 +00:00
Andrew Nacin 57d7375d46 Updates: Avoid stomping global `$wp_version` in `wp_version_check()` and related.
fixes #34868.


git-svn-id: https://develop.svn.wordpress.org/trunk@35779 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 17:38:35 +00:00
Boone Gorges ee8215e442 Bump package.json to 4.5.0.
git-svn-id: https://develop.svn.wordpress.org/trunk@35778 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 17:35:35 +00:00
Dion Hulse fc87f96e07 Upgrader: FTP: Cleanup temporary files during FTP download failures.
Props ruud@joyo
Fixes #34772


git-svn-id: https://develop.svn.wordpress.org/trunk@35777 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 17:06:53 +00:00
Andrew Nacin b5bbba2026 Trunk is now 4.5-alpha.
git-svn-id: https://develop.svn.wordpress.org/trunk@35776 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 16:43:16 +00:00
Andrew Nacin 66b0dfe31b Add initial_db_version to wp_version_check().
fixes #34854.


git-svn-id: https://develop.svn.wordpress.org/trunk@35774 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 15:43:49 +00:00
Scott Taylor f89c25a43d REST API: Core typically sends nocache headers on all auth'ed responses, as in `wp`, `admin-ajax`, etc. Because the REST API infrastructure is hooked in pre-wp, we should be setting this ourselves.
Adds unit tests.

Props joehoyle.
Fixes #34832.


git-svn-id: https://develop.svn.wordpress.org/trunk@35773 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-04 23:35:54 +00:00
Boone Gorges a1f89f4e86 Use 'invalid_username' error code when tripping 'illegal_user_logins'.
This gives us better compatibility with existing errors thrown by
`sanitize_user()`, especially in Multisite, where user_login has more
restrictions on allowed characters.

Props markjaquith.
Fixes #27317.

git-svn-id: https://develop.svn.wordpress.org/trunk@35772 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-04 23:24:56 +00:00
Aaron Jorbin 6825c7226e Make comment screen row actions focusable
In [34504], tabbing through row actions on comments that lacked links was broken. This restores the desired behavior and ensures that the row actions can be seen by no-js users.

Second Permanent Committer sign off was by WonderBoyMusic

See #15520
Fixes #34791
Props afercia, azaozz



git-svn-id: https://develop.svn.wordpress.org/trunk@35771 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-04 23:12:57 +00:00
Scott Taylor 12f4c30551 Canonical: introduce `strip_fragment_from_url()` and use when comparing URLs in `redirect_canonical()`.
Props tellyworth.
Fixes #19918.


git-svn-id: https://develop.svn.wordpress.org/trunk@35770 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-04 23:10:09 +00:00
Drew Jaynes db281bf80e About page: Make strings translatable.
See #34663.


git-svn-id: https://develop.svn.wordpress.org/trunk@35769 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-04 18:08:21 +00:00
Drew Jaynes 267164d5b8 About page: Final string changes.
Props petya, ocean90, DrewAPicture
See #34663.


git-svn-id: https://develop.svn.wordpress.org/trunk@35768 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-04 17:54:35 +00:00
Dominik Schilling (ocean90) ec01033a2d Unit Tests: Implement `addWarning()` method in SpeedTrapListener.
The method was introduced in PHPUnit 5.1.0, released today.

Fixes #34846.

git-svn-id: https://develop.svn.wordpress.org/trunk@35767 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-04 16:40:10 +00:00
Drew Jaynes 1a3a997433 About page: Add non-breaking spaces to "Reddit Comments" and "Speaker Deck" oEmbed provider names to prevent line wrapping between the words.
Props ocean90.
See #34663.


git-svn-id: https://develop.svn.wordpress.org/trunk@35766 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-04 16:26:35 +00:00
Drew Jaynes cc5e86207b About page: Fix some minor string errors and simplify URL-building for the plugin install link for capable users.
Props ocean90, DrewAPicture
See #34663.


git-svn-id: https://develop.svn.wordpress.org/trunk@35765 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-04 16:12:51 +00:00
Dominik Schilling (ocean90) 5f4902605e Reset Password: Add a missing `new` operator for `WP_Error` in `get_password_reset_key()`.
Missed in [34923].

Fixes #34180.


git-svn-id: https://develop.svn.wordpress.org/trunk@35764 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-04 15:30:17 +00:00
Drew Jaynes 1035906de6 First pass of the 4.4 about page. Adds strings (not yet translatable) and screen shots (not CDN).
Props wonderboymusic, markjaquith, helen, nacin, liljimmi, mordauk, melchoyce, ryelle, ocean90, DrewAPicture
See #34663.


git-svn-id: https://develop.svn.wordpress.org/trunk@35763 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-04 12:23:24 +00:00
Andrew Nacin 12b1cc4410 Embeds: Enforce, via unit tests, the no-ampersand rule for wp-embed.js.
fixes #34698.


git-svn-id: https://develop.svn.wordpress.org/trunk@35762 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-04 05:45:29 +00:00
Scott Taylor dedff8fd0e WP oEmbed: validate the `secret` send via `postMessage` in `wp.receiveEmbedMessage`. Also, compare `window` instances.
In the data sent to us from the embedded iframe by postMessage(), the secret value is being used directly in a document.querySelectorAll() call without first being validated or escaped.

In theory, this could lead to some broken embeds.

Props mdawaffe.
Fixes #34831.


git-svn-id: https://develop.svn.wordpress.org/trunk@35761 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-03 20:16:28 +00:00
Helen Hou-Sandi 3e85312bbf Media: Avoid `rel="rel="` situations.
props lucymtc, swissspidy.
fixes #34826. see #32074.


git-svn-id: https://develop.svn.wordpress.org/trunk@35760 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-03 17:16:57 +00:00
Gary Pendergast 76367a145e Readme: Bump recommended MySQL version to 5.6, as 5.5 is now over 5 years old.
Happy birthday, MySQL 5.5! 

Fixes #34840.



git-svn-id: https://develop.svn.wordpress.org/trunk@35759 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-03 16:45:22 +00:00
Mark Jaquith 2ddab3adf8 Route HEAD API requests through the GET callback method
fixes #34837
props danielbachhuber

git-svn-id: https://develop.svn.wordpress.org/trunk@35758 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-03 16:34:00 +00:00
Boone Gorges 14eae0a8a7 Ensure that order is specified when querying for comment descendants.
Props tellyworth.
Fixes #34838.

git-svn-id: https://develop.svn.wordpress.org/trunk@35757 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-03 15:49:37 +00:00
wonderboymusic 594ce27b61 Install: after [35508], the margin on the header for the Install screen is too big.
Props SergeyBiryukov.
Fixes #34819.


git-svn-id: https://develop.svn.wordpress.org/trunk@35756 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-01 21:01:02 +00:00
Scott Taylor a8523ae92a Responsive Images: Currently images are included in the `srcset` if the aspect ratio difference is smaller than `0.01`. This number is too high, set it to `0.002`
Props joemcgill.
Fixes #34810.


git-svn-id: https://develop.svn.wordpress.org/trunk@35755 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-01 20:57:42 +00:00
Scott Taylor aad857409b Customize Unit Tests: also `remove_action( 'after_setup_theme', 'twentysixteen_setup' )`. TwentyFifteen is already removed.
See #31550.


git-svn-id: https://develop.svn.wordpress.org/trunk@35754 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-01 20:55:22 +00:00
Scott Taylor 69900349ca Media: don't use `get_media_embedded_in_content()` in `wp_make_content_images_responsive()`.
Adds unit test.

Props azaozz.
Fixes #34807.


git-svn-id: https://develop.svn.wordpress.org/trunk@35753 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-01 20:49:13 +00:00
Scott Taylor a69f591c55 Media: show Trash filter for Media list table when `MEDIA_TRASH` is true.
Props chacha102.
Fixes #34795.


git-svn-id: https://develop.svn.wordpress.org/trunk@35752 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-01 20:47:24 +00:00
Scott Taylor c8b7126cbf Unit Tests: fix responsive image unit tests. Correct the logic in video shortcode unit test for width.
Props joemcgill, wonderboymusic.
Fixes #34790.


git-svn-id: https://develop.svn.wordpress.org/trunk@35751 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-01 20:44:54 +00:00
Ryan McCue cfbd88836d REST API: Unabbreviate error string.
Props daniel-koskinen.
Fixes #34818.


git-svn-id: https://develop.svn.wordpress.org/trunk@35750 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-30 09:50:56 +00:00