Commit Graph

146 Commits

Author SHA1 Message Date
Drew Jaynes
bd39e26032 First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.


git-svn-id: https://develop.svn.wordpress.org/trunk@26868 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-24 18:56:05 +00:00
Ryan Boren
cfd5c395bb The Pinking Shears stir from their slumber, awakened by what may seem, to those
innocent in the ways of The Shears, a triviality, a nothing-of-consequence. But there are consequences indeed for recklessly trailing your whitespace. Naturally, they a dire!

One, two! One, two! And through and through
The Pinking Shears went snicker-snack!
They plucked your tail and with your space
They went sniksnuking back.

Let me tell you, that can be uncomfortable, so always pre-sniksnuk your trailing whites. May The Shears be with you.


git-svn-id: https://develop.svn.wordpress.org/trunk@26851 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-11 19:48:29 +00:00
Andrew Ozz
8f581ae3dc Themes: fix overlays and buttons in responsive mode, props matveb, fixes #26481.
git-svn-id: https://develop.svn.wordpress.org/trunk@26838 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-09 19:37:36 +00:00
Andrew Nacin
0fff0660b4 Themes: use explicit 'search installed themes' label and placeholder.
fixes #26496.


git-svn-id: https://develop.svn.wordpress.org/trunk@26827 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-09 07:40:56 +00:00
Andrew Nacin
98824e94de Themes: Avoid a JS error in the keyup event handler when the overlay is not yet initialized.
fixes #26497.


git-svn-id: https://develop.svn.wordpress.org/trunk@26826 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-09 07:06:15 +00:00
Andrew Ozz
572e5bc710 Fix error in postbox.js attempting to change screen columns on mobile devices orientation changes, fixes #26493.
git-svn-id: https://develop.svn.wordpress.org/trunk@26822 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-09 04:20:26 +00:00
Andrew Nacin
e2c2f6a402 Don't set the theme overlay active state in the Theme view, as it overwrites the same work in the Details view.
fixes #26481.


git-svn-id: https://develop.svn.wordpress.org/trunk@26815 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-09 01:26:26 +00:00
Matt Thomas
9439bb7b4f Expand the Quick Draft section by default. Fixes #26463, props bassgang.
git-svn-id: https://develop.svn.wordpress.org/trunk@26813 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-09 00:42:56 +00:00
Andrew Ozz
76d75b7d22 Fake a "non-responsive" window width for IE < 9 when folding/unfolding the menu (old IE doesn't support @media), fixes #26458.
git-svn-id: https://develop.svn.wordpress.org/trunk@26785 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-07 18:45:37 +00:00
Andrew Nacin
b08c4c109d Fix JSHint errors and remove unreachable code. props adamsilverstein. see #25963.
git-svn-id: https://develop.svn.wordpress.org/trunk@26778 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-07 07:51:35 +00:00
Andrew Nacin
e41692153c Core updates for the new color schemes.
* Update about page, there's now 8.
 * Display them four wide, not three, and ensure adequate spacing.
 * Use a dedicated nonce.
 * Push Light to the front in addition to Default.
 * Use user-profile.js on about.php. A few extra things are initialized but they are harmless.

see #26468, #26387.


git-svn-id: https://develop.svn.wordpress.org/trunk@26776 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-07 07:45:57 +00:00
Ryan Boren
85d5a58809 Make the Backbone routes pushSTate capable with ?theme=themename type urls instead of hashes. Same applies to search queries.
Props adamsilverstein, nacin
fixes #25963


git-svn-id: https://develop.svn.wordpress.org/trunk@26767 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-07 03:10:44 +00:00
Andrew Nacin
08c059e8d0 Themes: Ensure the image returns a width before checking that it is less than 300px.
see #26459.


git-svn-id: https://develop.svn.wordpress.org/trunk@26765 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-07 01:58:23 +00:00
Matt Thomas
b9893b491c Adding autosave for color schemes and removing RTL handling. See #26387, props ryelle.
git-svn-id: https://develop.svn.wordpress.org/trunk@26746 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-06 21:25:31 +00:00
Andrew Ozz
98b9246261 Responsive menu: fix calculation of the responsive trigger width from JS. It is affected by a vertical scrollbar width in some browsers. See #26458.
git-svn-id: https://develop.svn.wordpress.org/trunk@26743 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-06 20:49:46 +00:00
Andrew Nacin
63ad0a71d4 Themes: If a theme only has a very-old-school 300px-wide screenshot (or narrower), don't stretch it.
props matveb.
fixes #26459.


git-svn-id: https://develop.svn.wordpress.org/trunk@26738 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-06 19:41:19 +00:00
Matt Thomas
79cb3cf3ce Updates to the About page:
* A live color scheme preview
* Replace the hard-coded version number
* Copy edits
* New screenshots
* Size adjustments to the header and WP badge
* Capitalize 'Open Sans'

See #26387, props markoheijnen, ryelle, siobhan, melchoyce.



git-svn-id: https://develop.svn.wordpress.org/trunk@26737 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-06 19:35:25 +00:00
Andrew Nacin
195465ce38 Remove screenshotGallery. see #25948.
git-svn-id: https://develop.svn.wordpress.org/trunk@26728 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-06 17:10:38 +00:00
Andrew Nacin
b9cb349dc0 No-JavaScript and no-Customizer support for the new Themes screen.
JavaScript is rarely disabled, but graceful degradation is still important. For example, syntax errors can occur, usually with major WP updates that overhaul entire experiences and update external libraries combined with themes or plugins doing weird or old things. If this error is due to their current theme, a user needs to be able to access the themes screen to switch away from the theme. A more subtle issue could make things painful to diagnose.

This commit renders the grid in PHP (the template is duplicated, but it lightweight, fairly mundane, and easy to sync). On Backbone render, the grid is then re-rendered from JavaScript so searches can occur. Customize and Live Preview is disabled if JS fails to kick in. If JS is disabled, old-school "Preview" links are displayed.

No-Customizer support: The customizer is only supported when the browser supports postMessage (IE8+), and if the frontend is a different domain, CORS (IE10+). We use the .hide-if-no-customize class for this. Pre-customize "Preview" links should use .hide-if-customize.

The .load-customize class should be used to declare a link that opens the customizer. This enables customize-loader.js to intercept this link and load the customizer on top of the current window, making for a smoother experience.

fixes #25964.


git-svn-id: https://develop.svn.wordpress.org/trunk@26726 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-06 16:10:25 +00:00
Andrew Ozz
5454336667 Widgets: jshint cleanup of widgets.js, see #25821.
git-svn-id: https://develop.svn.wordpress.org/trunk@26703 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 23:13:22 +00:00
Andrew Nacin
3831c95a04 Widgets: Add click-to-add widgets to the bottom (not top) of the target sidebar.
fixes #25821.


git-svn-id: https://develop.svn.wordpress.org/trunk@26696 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 22:26:45 +00:00
Andrew Nacin
ddc9ed51e8 Widgets: Only scroll to the newly clicked-and-added widget if it is out of the viewport.
props shaunandrews.
see #25821.


git-svn-id: https://develop.svn.wordpress.org/trunk@26695 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 22:21:15 +00:00
Andrew Nacin
aa65527319 Final SVG painter fixes.
* wp.svgPainter and now moved to wp-admin.
 * Restore !important background-image handling.
 * Delay executing the IE9-specific base64 code if we don't need it.
 * Make painted icons lose their color after hover at the same speed as dashicons (100ms).

props azaozz.
fixes #26333.


git-svn-id: https://develop.svn.wordpress.org/trunk@26693 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 22:00:17 +00:00
Andrew Nacin
e98d56fab4 Themes: Only show author names during a search if it matches 3 or more characters.
props matveb.
fixes #26422.


git-svn-id: https://develop.svn.wordpress.org/trunk@26686 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 19:56:16 +00:00
Andrew Nacin
dc7082fbc7 Themes: when initiating a search, avoid triggering a reset event when it's not necessary.
props matveb.
fixes #26434.


git-svn-id: https://develop.svn.wordpress.org/trunk@26685 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 19:14:59 +00:00
Andrew Nacin
1ac4bceecd Define globals and add semicolons to wp-fullscreen.js.
`grunt jshint` now runs clean for WordPress core!

props mattwiebe.
fixes #26029.


git-svn-id: https://develop.svn.wordpress.org/trunk@26667 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 16:04:59 +00:00
Andrew Nacin
f883e31e3c Themes: Disable collapse actions when showing only a single theme; improve the responsive layout.
props matveb.
fixes #25962.


git-svn-id: https://develop.svn.wordpress.org/trunk@26660 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 04:56:48 +00:00
Andrew Nacin
e75582f9c8 Themes: When only one theme is available, show just the details view.
Only one theme may be available when no other themes are allowed (multisite), no other themes are installed, or when the user is denied the switch_themes capability but still has edit_theme_options.

props matveb, markjaquith.
see #25962.


git-svn-id: https://develop.svn.wordpress.org/trunk@26652 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 00:15:59 +00:00
Andrew Ozz
f90e3dc450 Widgets: on clicking Add, don't move the chooser out of the widget early as that makes is visible at the bottom of the screen. Remove the cloned copy of it instead. Part-props jeremyfelt, fixes #26417.
git-svn-id: https://develop.svn.wordpress.org/trunk@26651 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 00:01:42 +00:00
Andrew Ozz
2d254241c7 DFW: don't block the "keyup" event, fixes toggling the checkbox in the Link dialog with the spacebar. Fixes #25934.
git-svn-id: https://develop.svn.wordpress.org/trunk@26649 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-04 23:50:05 +00:00
Andrew Nacin
bda43fd107 Pinking shears. see #26086 props atimmer.
git-svn-id: https://develop.svn.wordpress.org/trunk@26627 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-04 19:33:45 +00:00
Andrew Nacin
fe7bfcdf9c Return some semicolons. fixes #25594.
git-svn-id: https://develop.svn.wordpress.org/trunk@26623 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-04 19:07:40 +00:00
Andrew Nacin
1913b4c665 Nav Menus: Delegate click events for move links.
props ankit.gade.
fixes #25594.


git-svn-id: https://develop.svn.wordpress.org/trunk@26613 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-04 17:09:20 +00:00
Andrew Ozz
93a5bff7a7 Svg-painter:
- Clean up the JS, better names, etc.
- Convert the base64 encode/decode code from jQuery plugin to local use.
- Add missing icon colors for the default theme.
- Make it more error-proof.
Fixes #26333.

git-svn-id: https://develop.svn.wordpress.org/trunk@26601 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-04 04:12:41 +00:00
Helen Hou-Sandi
6c3f6cad42 Auto-resize the Quick Draft textarea. props lessbloat, markjaquith, helen. fixes #26053.
git-svn-id: https://develop.svn.wordpress.org/trunk@26564 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-03 17:34:46 +00:00
Andrew Ozz
ba4643f76e Comments moderation screen:
- Don't resize the textarea when replying to long comments.
- Limit the resizing of the textarea when quick-editing long comments to 500px.
Props SergeyBiryukov, fixes #25746.

git-svn-id: https://develop.svn.wordpress.org/trunk@26550 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-03 00:54:42 +00:00
Andrew Ozz
75ac2cf131 Heartbeat:
- Bring back heartbeat.interval().
- Rename wp_disable_heartbeat_suspend() to wp_heartbeat_set_suspension().
- Rename the option for disabling suspension from options.suspend to options.suspension.
Fixes #25073.

git-svn-id: https://develop.svn.wordpress.org/trunk@26549 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-03 00:44:22 +00:00
Andrew Nacin
16b6b6b8e4 Simplify the color scheme profile saving JS. see #25858.
git-svn-id: https://develop.svn.wordpress.org/trunk@26535 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-02 19:44:50 +00:00
Dion Hulse
63a4a1b10c Themes: Bail if the search term matches the currently rendered themes, Fixes the events being clobbered. Props jblz. Fixes #26347
git-svn-id: https://develop.svn.wordpress.org/trunk@26521 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-02 07:15:14 +00:00
Dion Hulse
919b03d9ce Themes: Make the Theme Detail view div use more of the available viewport, Fix the Header and Footer in the viewport and only scroll the theme details, Prefix some more theme CSS classes. Props shaunandrews for the initial viewport patch. Fixes #25961, #26192
git-svn-id: https://develop.svn.wordpress.org/trunk@26519 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-02 07:11:43 +00:00
Andrew Ozz
eb2767a578 Make the responsive menu usable with a mouse, fix non-folded and :focus styles, toggle the submenus on touchend/click. Fixes #26086.
git-svn-id: https://develop.svn.wordpress.org/trunk@26516 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-02 03:18:40 +00:00
Dion Hulse
8eedbe32ac Themes: For searches, replace the document hash, don't add a new history event for each keypress. See #25948
git-svn-id: https://develop.svn.wordpress.org/trunk@26515 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-02 01:50:24 +00:00
Dion Hulse
c6e661e84d Themes: We no longer have a delete link on the multi-grid view. See #25948
git-svn-id: https://develop.svn.wordpress.org/trunk@26514 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-02 00:54:27 +00:00
Dion Hulse
e3d4717077 Themes: Fix the routing for Themes in a sub-directory (/wp-content/themes/prefix/theme-name/style.css) and navigate to hash-url's for searches. See #25948
git-svn-id: https://develop.svn.wordpress.org/trunk@26513 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-02 00:47:49 +00:00
Andrew Ozz
e5304e8470 Improve the admin color scheme picker:
- Easier to extend.
- Remove the "drop-down" look, show all choices inline.
- Some PHP and JS cleanup.
Props ryelle, fixes #26336.

git-svn-id: https://develop.svn.wordpress.org/trunk@26506 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-01 19:49:55 +00:00
Dion Hulse
056c99305b Themes: In the detailed view, disable the next/previous buttons when there are no more items. Fixes #26314
git-svn-id: https://develop.svn.wordpress.org/trunk@26498 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-01 05:58:42 +00:00
Dominik Schilling (ocean90)
510aa812ca Themes: Add type="search" to search. fixes #26331.
git-svn-id: https://develop.svn.wordpress.org/trunk@26481 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-29 22:19:08 +00:00
Dominik Schilling (ocean90)
2d74676237 Themes: Search the description too.
props dd32.
fixes #26309.

git-svn-id: https://develop.svn.wordpress.org/trunk@26480 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-29 22:17:28 +00:00
Andrew Ozz
28da4145a6 Widgets: highlight all drop zones (open and closed sidebars) on starting to drag a widget to indicate "droppability", fixes #26168.
git-svn-id: https://develop.svn.wordpress.org/trunk@26474 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-29 17:57:05 +00:00
Dion Hulse
59ecd28d2e Themes: Add a clearing <br/> to the end of .theme-browser.
This is needed to cause the browser to render .theme-browser's height as it's true height, previously the reported height was 1*.theme which caused the Theme scroller to kick in immediately (as the threshold was less than 0).
See #25981 See #25948


git-svn-id: https://develop.svn.wordpress.org/trunk@26468 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-29 05:17:00 +00:00