28 Commits

Author SHA1 Message Date
Scott Taylor
23f2e79350 Correct the param docs for comment_guid() and get_comment_guid().
Props dimadin.
Fixes #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33913 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-05 19:59:10 +00:00
Scott Taylor
60ba8b05e4 Introduce WP_Comment class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity.
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.


git-svn-id: https://develop.svn.wordpress.org/trunk@33891 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-03 18:16:35 +00:00
Helen Hou-Sandi
b9dd879f42 Site icon: Rearrange function parameters to avoid frequently passing empty values.
props obenland.
fixes #33325.


git-svn-id: https://develop.svn.wordpress.org/trunk@33605 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-10 20:14:35 +00:00
Konstantin Obenland
8c36e7b3c4 Feeds: Revert [32765] because of objections raised in #4575.
git-svn-id: https://develop.svn.wordpress.org/trunk@33281 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 19:57:47 +00:00
Drew Jaynes
8287ff9dbc Fix summaries for new feed functions added in 4.3.
* `get_last_build_date_feed()` [32765]
* `atom_site_icon()` [32994]
* `rss2_site_icon()` [32994]

See #32891.


git-svn-id: https://develop.svn.wordpress.org/trunk@33224 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-13 21:26:29 +00:00
Konstantin Obenland
ffa682bee4 Introducing Site Icon, favicon management for WordPress.
This v1 marries Jetpack's Site Icon module with the Media Modal, reusing code
from the Custom Header admin. For now, the core-provided icons will be limited
to a favicon, an iOS app icon, and a Windows tile icon, leaving `.ico` support
and additional icons to plugins to add.

Props obenland, tyxla, flixos90, jancbeck, markjaquith, scruffian.
See #16434.



git-svn-id: https://develop.svn.wordpress.org/trunk@32994 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-29 12:57:35 +00:00
Scott Taylor
9cef023a96 prep_atom_text_construct() and before_last_bar() should strictly check against false when using str(r)?pos().
Sidenote: there's a function named `before_last_bar`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32940 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 16:48:14 +00:00
Scott Taylor
646c19accf Make sure that all Gravatars are generated by get_avatar() or at least run through apply_filters( 'get_avatar', $avatar ) for the sake of extensibility.
Props miqrogroove, GlennM, SergeyBiryukov.
Fixes #22650.


git-svn-id: https://develop.svn.wordpress.org/trunk@32845 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 18:35:04 +00:00
Scott Taylor
296c559baf if is a statment, not a function.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32800 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 20:00:15 +00:00
Aaron Jorbin
caf041d76e Improve lastBuildDate timestamp in rss feeds
RSS feed timestamps should reflect the actual timestamps for those RSS feeds rather than the generic timestamp for all posts and all comments. 

Props stevenkword.
Fixes #4575.




git-svn-id: https://develop.svn.wordpress.org/trunk@32765 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 18:36:14 +00:00
Scott Taylor
e7d9eda799 In fetch_feed(), call ->set_output_encoding() on the SimplePie instance to ensure the feed is served with encoding specified by the blog_charset option.
Props chriscct7.
Fixes #10713.


git-svn-id: https://develop.svn.wordpress.org/trunk@32469 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 06:48:45 +00:00
Andrew Nacin
62b51d8c0b Clean up wp_staticize_emoji() and friends.
* DOMDocument was removed in [31752] but not the check.
 * wp_staticize_emoji() has never accepted a second arg; remove it from calls.
 * Remove wp_staticize_emoji_for_feeds(), no need for it.
 * Remove _ and @ignore from wp_staticize_emoji_for_email(), no need for it.

see #31242.


git-svn-id: https://develop.svn.wordpress.org/trunk@32161 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 04:14:32 +00:00
Gary Pendergast
2b3cfead22 Emoji: Rename the email and feed filter functions to be _ prefixed, and @ignore-d in the PHPDocs.
See #31242



git-svn-id: https://develop.svn.wordpress.org/trunk@31791 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-16 10:45:29 +00:00
Gary Pendergast
ae391ec226 Add emoji support, with Twemoji fallback.
Replace exisiting smilies with equivalent emoji, or with shiny new smiley images where no emoji existed.

Props batmoo, joen and mkaz for the original plugin upon which this is based.

Props pento, iseulde, kraftbj and peterwilsoncc for making the internet's dreams come true.

See #31242



git-svn-id: https://develop.svn.wordpress.org/trunk@31733 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-11 22:48:16 +00:00
Scott Taylor
4d46475b3d Improve various @param docs for src/wp-includes/*.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30681 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 01:33:34 +00:00
Drew Jaynes (DrewAPicture)
3cc10d77a0 Remove redundant and erroneous @uses tag from most core inline documentation.
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.

Fixes #30191.


git-svn-id: https://develop.svn.wordpress.org/trunk@30105 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 01:04:55 +00:00
Sergey Biryukov
947ca94071 Correct references to post-template.php in the inline docs.
props softmodeling.
fixes #29188.

git-svn-id: https://develop.svn.wordpress.org/trunk@29469 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-12 01:08:19 +00:00
Sergey Biryukov
1d38109297 Force a separator in get_wp_title_rss() if it was inadvertently filtered out by the theme.
fixes #22362.

git-svn-id: https://develop.svn.wordpress.org/trunk@28921 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 10:10:57 +00:00
Drew Jaynes (DrewAPicture)
8764f791f1 Where a filter no longer exists, it need not be notated.
Fixes #24444. See r28258.


git-svn-id: https://develop.svn.wordpress.org/trunk@28283 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 05:37:17 +00:00
Scott Taylor
5c306af76d When $type is atom in get_the_category_rss(), use get_bloginfo_rss( 'url' ) when setting the scheme attribute for the <category> node.
Props ejdanderson.
Fixes #24444.



git-svn-id: https://develop.svn.wordpress.org/trunk@28258 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 19:04:39 +00:00
Drew Jaynes
647f80595d Remove all @package and @subpackage PHPDoc tags not at the file- or class-levels in core.
See #27200.


git-svn-id: https://develop.svn.wordpress.org/trunk@27262 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-25 17:13:08 +00:00
Sergey Biryukov
5dae0e834a Correct @since values. see #26253.
git-svn-id: https://develop.svn.wordpress.org/trunk@26903 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-04 18:08:59 +00:00
Drew Jaynes
2959521871 Inline documentation for hooks in wp-includes/feed.php.
Props stevenkword, kpdesign, DrewAPicture.
Fixes #26253.


git-svn-id: https://develop.svn.wordpress.org/trunk@26902 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-04 06:21:14 +00:00
Drew Jaynes
bd39e26032 First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.


git-svn-id: https://develop.svn.wordpress.org/trunk@26868 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-24 18:56:05 +00:00
Dion Hulse
22738bc3d5 Remove the experimental RSS.JS feed, and move it to a plugin for feature development. Unprops pento. See #25639
git-svn-id: https://develop.svn.wordpress.org/trunk@26644 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-04 22:23:02 +00:00
Andrew Nacin
555703dff2 Add an experimental rssjs feed based on the experimental rss.js spec.
This is simply a JSON representation of the RSS 2.0 feed, accessible at /feed/rssjs/ anywhere.

props pento.
see #25639.


git-svn-id: https://develop.svn.wordpress.org/trunk@26294 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-20 22:57:09 +00:00
Andrew Nacin
8d72ad52ff Don't rely on include_path to include files.
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.


git-svn-id: https://develop.svn.wordpress.org/trunk@25616 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-25 00:17:40 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00