4415 Commits

Author SHA1 Message Date
Dion Hulse
63fd3a32dd Term Splitting: Fix a reversal of parameters to wp_schedule_single_event() introduced in [33621].
The existing invalid cron entries will not be purged automatically (as the 'timestamp' is never matched) so we do this ourselves.

Props mechter for noticing!
See #30261.
Fixes #33423 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33646 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-19 11:30:42 +00:00
Scott Taylor
80b6f4efca Playlists, for .wp-playlist-item-title elements: move the curly quotes to CSS pseudo-element content, making them easier to override or remove.
Fixes #33391.


git-svn-id: https://develop.svn.wordpress.org/trunk@33643 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-19 05:50:23 +00:00
Scott Taylor
f629e70da3 WP_Embed::maybe_run_ajax_cache() doesn't hook to pages, because it only happens on 'edit_form_advanced', not 'edit_page_form'. Make sure it runs for pages as well. This was probably not intentional, see [29557].
Fixes #32418.


git-svn-id: https://develop.svn.wordpress.org/trunk@33642 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-19 05:39:31 +00:00
Scott Taylor
32a2e5ed48 Fix case type in docs for get_children().
Props bobbingwide.
Fixes #33364.


git-svn-id: https://develop.svn.wordpress.org/trunk@33637 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-18 21:38:25 +00:00
Helen Hou-Sandi
e048854dc1 Trunk is now 4.4-alpha.
git-svn-id: https://develop.svn.wordpress.org/trunk@33636 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-18 19:31:23 +00:00
Konstantin Obenland
08a58ff927 WordPress 4.3
git-svn-id: https://develop.svn.wordpress.org/trunk@33633 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-18 18:01:25 +00:00
Boone Gorges
48beba441b When generating a fallback post_name using the post ID, wp_insert_post() should clear the post cache immediately.
If the post cache is not cleared at this point, the cache can become stale
for operations performed before the cache is cleared later in the function.
Specifically, the generation of a `guid` for new posts can use stale data,
resulting in non-unique values. [33262] introduced a call to `get_post()`
that introduced just such an invalidation problem.

Fixes #5305.

git-svn-id: https://develop.svn.wordpress.org/trunk@33630 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-18 02:50:23 +00:00
Konstantin Obenland
8f23b0db45 4.3-RC3-33629
git-svn-id: https://develop.svn.wordpress.org/trunk@33629 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 21:45:42 +00:00
Konstantin Obenland
c992631099 4.3-RC3
git-svn-id: https://develop.svn.wordpress.org/trunk@33628 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 21:39:05 +00:00
Dominik Schilling (ocean90)
0ec540b946 Pinking shears.
git-svn-id: https://develop.svn.wordpress.org/trunk@33627 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 21:38:24 +00:00
Andrew Ozz
b30fcd7597 Fix creating of extra <br /> tags in both PHP and JS variants of wpautop(). Add PHP tests to catch similar problems in the future.
Props valendesigns, azaozz. Fixes #33377.

git-svn-id: https://develop.svn.wordpress.org/trunk@33624 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 17:35:58 +00:00
Konstantin Obenland
eea1678cd3 Editor: Exclude shift from modifier keys when handling spacebar shortcuts.
Patterns that activate on enter are still canceled with any modifier active.

Props azaozz.
Fixes #33382.



git-svn-id: https://develop.svn.wordpress.org/trunk@33622 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 14:50:42 +00:00
Konstantin Obenland
e7a203cdf2 Passwords: Restore second parameter for wp_new_user_notification().
After [33023] users would always be notified, this restores previous behavior.

Props markjaquith, ocean90.
Fixes #33358.



git-svn-id: https://develop.svn.wordpress.org/trunk@33620 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-17 14:24:43 +00:00
Boone Gorges
9c70cea98f Don't suspend cache invalidation when running term splitting batch routine.
`wp_suspend_cache_invalidation()` was originally added to increase performance,
but the switch to batch processing in [33615] mitigates serious performance
concerns.

As a precaution against timeouts, the batch size has been reduced from 20 to 10.

Props Chouby.
See #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33619 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-15 19:24:42 +00:00
Boone Gorges
f18355e66e Term splitting routine should be run in a separate process, triggered via wp-cron.
[32814] introduced a routine to split shared terms, which was run during the
regular WP database upgrade. This turned out to be problematic because plugins
are not loaded during the db upgrade (due to `WP_INSTALLING`), with the result
that plugins were not able to hook into the 'split_shared_term' action during
the bulk split. We work around this limitation by moving the term splitting
routine to a separate process, triggered by a wp-cron hook.

Props boonebgorges, Chouby, peterwilsoncc, pento, dd32.
Fixes #30261.

git-svn-id: https://develop.svn.wordpress.org/trunk@33615 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-14 03:58:41 +00:00
Dominik Schilling (ocean90)
23eaa36145 Capabilities: Fall back to the edit_posts capability for orphaned comments.
Also avoid PHP notices because of orphaned comments in the comments list table.
Includes unit test.

props pento, dd32.
fixes #33154.

git-svn-id: https://develop.svn.wordpress.org/trunk@33614 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-13 22:30:26 +00:00
Scott Taylor
df480edb24 After [33325], supply a missing post_type in ->mw_editPost().
Add unit test.

Props ocean90.
Fixes #20662.


git-svn-id: https://develop.svn.wordpress.org/trunk@33612 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-13 15:27:57 +00:00
Boone Gorges
ee67bd08f9 When splitting a shared 'nav_menu' term, ensure that nav items and theme locations are retained.
Props boonebgorges, dd32.
Fixes #33187.

git-svn-id: https://develop.svn.wordpress.org/trunk@33611 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-12 14:06:21 +00:00
Konstantin Obenland
8f37374c3d Site Icon: Improvements to Site Icon API.
* Only call `get_blog_option()` when there is a blog id and we're in Mulitsite. If there is no blog id the request is for the current blog.
* Check return value of `wp_get_attachment_image_src()` before getting the URL since it could be `false`.
* Use `{bool}` rather than `!!` to return a boolean value.

Props MikeHansenMe, obenland.
Fixes #33326.



git-svn-id: https://develop.svn.wordpress.org/trunk@33606 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-11 16:24:07 +00:00
Helen Hou-Sandi
b9dd879f42 Site icon: Rearrange function parameters to avoid frequently passing empty values.
props obenland.
fixes #33325.


git-svn-id: https://develop.svn.wordpress.org/trunk@33605 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-10 20:14:35 +00:00
Helen Hou-Sandi
0999b0182b Customizer: Rename WP_New_Menu_Customize_Control to WP_Customize_New_Menu_Control for consistency.
props DrewAPicture.
fixes #33324.


git-svn-id: https://develop.svn.wordpress.org/trunk@33602 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-10 18:06:01 +00:00
ocean90
239759914f Shortcodes: Trim whitespace after sanitizing the shortcode output.
props Ankit K Gupta, obenland, miqrogroove.
fixes #33259.

git-svn-id: https://develop.svn.wordpress.org/trunk@33600 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-09 20:48:02 +00:00
Dion Hulse
7a35bff916 Fix do_shortcode('<[shortcode]') edge case.
Props miqrogroove.
Merges [33499] trunk.
See #33116.


git-svn-id: https://develop.svn.wordpress.org/trunk@33594 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-07 02:49:31 +00:00
Ella Iseulde Van Dorpe
994b1d9a5b TinyMCE: fix inline toolbar repositioning for inline editors
Fixes #33286.


git-svn-id: https://develop.svn.wordpress.org/trunk@33592 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-06 21:34:16 +00:00
Mark Jaquith
7e4a72b9bc Only use a bare URL when the link text field is used.
Fixes bug that would remove images on edit, in some circumstances.

fixes #33293
props azaozz

git-svn-id: https://develop.svn.wordpress.org/trunk@33591 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-06 20:57:31 +00:00
Mark Jaquith
3d15757198 Move media hooks out of admin-filters.php as sometimes editors are used on the front end.
fixes #33257
props wonderboymusic

git-svn-id: https://develop.svn.wordpress.org/trunk@33590 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-06 20:39:35 +00:00
Sergey Biryukov
1dcb93b541 wpLink: Make sure the link wrapper is the last element in the body, otherwise the inline editor toolbar may show up above the backdrop.
props azaozz.
fixes #33268.

git-svn-id: https://develop.svn.wordpress.org/trunk@33588 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-06 02:16:54 +00:00
Weston Ruter
fb62349c77 Customizer: Restore default fallback_cb arg for wp_nav_menu() calls in customizer preview.
Props ocean90, westonruter.
Fixes #33218.


git-svn-id: https://develop.svn.wordpress.org/trunk@33585 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-04 21:56:57 +00:00
Ella Iseulde Van Dorpe
3d88983860 TinyMCE: wplink: fix WPLinkPreview for multiple editors
Fixes #33264.


git-svn-id: https://develop.svn.wordpress.org/trunk@33584 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-04 21:41:34 +00:00
Dominik Schilling (ocean90)
e8b5345004 WordPress 4.3-RC2-33572.
git-svn-id: https://develop.svn.wordpress.org/trunk@33572 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-04 11:47:49 +00:00
Dominik Schilling (ocean90)
7fc5d6e2a4 WordPress 4.3-RC2.
git-svn-id: https://develop.svn.wordpress.org/trunk@33571 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-04 11:43:07 +00:00
Ella Iseulde Van Dorpe
aaf15cdde8 TinyMCE: wptextpattern: trim whitespace
Props iseulde and azaozz.
Fixes #33246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33563 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-03 22:06:25 +00:00
Dominik Schilling (ocean90)
9d8768f442 Comments: IDs are integers.
git-svn-id: https://develop.svn.wordpress.org/trunk@33555 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-03 21:37:26 +00:00
Dominik Schilling (ocean90)
dd5471dab2 Customizer: Use hash_equals() for widgets.
git-svn-id: https://develop.svn.wordpress.org/trunk@33535 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-03 20:56:56 +00:00
Andrew Ozz
86e10358fd TinyMCE: fix initializing the editor on switching Text => Visual when the Text editor is loaded first.
Props stuartshields, peterwilsoncc, netweb, azaozz. Fixes #33192.

git-svn-id: https://develop.svn.wordpress.org/trunk@33527 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-02 20:00:56 +00:00
Dominik Schilling (ocean90)
038e2e2e4f Editor: word count: Remove indentation from the translator comment.
Avoids a duplicate comment in the POT file.

see #30966.

git-svn-id: https://develop.svn.wordpress.org/trunk@33517 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-30 17:08:01 +00:00
Andrew Ozz
2dfd08f05a TinyMCE: update to 4.2.3, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt.
Fixes #33203.

git-svn-id: https://develop.svn.wordpress.org/trunk@33516 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-30 17:06:23 +00:00
Konstantin Obenland
37605bdd38 4.3-RC1-33514
git-svn-id: https://develop.svn.wordpress.org/trunk@33514 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 23:52:05 +00:00
Konstantin Obenland
59518e1625 4.3-RC1
git-svn-id: https://develop.svn.wordpress.org/trunk@33513 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 23:46:05 +00:00
Ella Iseulde Van Dorpe
18e5891539 TinyMCE: wptextpattern: stop propagation on undo
See #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@33512 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 23:44:08 +00:00
Helen Hou-Sandi
3fd1376418 Menu customizer: More clearly separate search results from available items.
Available items now fade from view while you're searching, and there is an explicit way to clear search results. No results gives a better message, though still brief this time around.

props valendesigns, designsimply, DH-Shredder, helen.
fixes #32710.


git-svn-id: https://develop.svn.wordpress.org/trunk@33511 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 23:39:54 +00:00
Andrew Ozz
46f0c4d4e0 TinyMCE: remove the spare string for the keyboard shortcuts modal.
See #31441.

git-svn-id: https://develop.svn.wordpress.org/trunk@33509 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 23:19:56 +00:00
Ella Iseulde Van Dorpe
662355f30c TinyMCE: wptextpattern: undo on esc after enter
See #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@33508 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 23:11:42 +00:00
Ella Iseulde Van Dorpe
976687bc59 TinyMCE: wptextpattern: reorder undo
After formatting on enter, undo should undo the formatting first, then undo the new line.

See #31441.


git-svn-id: https://develop.svn.wordpress.org/trunk@33507 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 22:48:02 +00:00
Dominik Schilling (ocean90)
709cb42ab3 Customizer: Switch buttons to match the focus order with the visual order.
props afercia.
see #33181.

git-svn-id: https://develop.svn.wordpress.org/trunk@33505 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 22:09:24 +00:00
Andrew Ozz
362bb806cd TinyMCE: fix (again) the text in the keyboard shortcuts modal for the changed patterns.
See #31441.

git-svn-id: https://develop.svn.wordpress.org/trunk@33504 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 21:53:22 +00:00
Andrew Ozz
b1933f53dc TinyMCE: fix the text in the keyboard shortcuts modal for the changed patterns.
See #31441.

git-svn-id: https://develop.svn.wordpress.org/trunk@33501 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 21:06:13 +00:00
Weston Ruter
70f461ed61 Customizer: Remove redundant translated string.
Props obenland.
Fixes #33183.


git-svn-id: https://develop.svn.wordpress.org/trunk@33493 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 18:53:00 +00:00
Dominik Schilling (ocean90)
faac72a070 Themes: Remove legacy theme preview.
The pre-3.4 theme previewer doesn't work when using a static front page.
We kept the old theme preview for no-JS and some browsers that were less capable. But since browsers are doing a better job today we don't need to continue fixing/shipping this legacy code. Bye!

fixes #33178.

git-svn-id: https://develop.svn.wordpress.org/trunk@33492 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 18:35:40 +00:00
Weston Ruter
27c7e27d8b Twenty Fifteen: Only re-initialize the main navigation in the Customizer when it is specifically updated.
* Fix a bug where updating the social menu links would cause the main navigation to get its toggle-expanded buttons duplicated.
* Persist any existing submenu expanded states on the updated menu. 
* Improve naming of `customize-preview-menu-refreshed` event param from `wpNavArgs` to `wpNavMenuArgs` (old name is retained and marked as deprecated).

Fixes #33177.


git-svn-id: https://develop.svn.wordpress.org/trunk@33491 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-29 18:12:26 +00:00