Commit Graph

125 Commits

Author SHA1 Message Date
Ryan Boren
a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Andrew Nacin
b4350a0424 Send nocache_headers() in the admin earlier, on the DB upgrade page. Prevents a potential redirect loop reproduced in Chrome from heavy caching of headers. props mdawaffe. see #21745.
git-svn-id: https://develop.svn.wordpress.org/trunk@21913 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-19 01:51:40 +00:00
Andrew Nacin
48a3353f5e Set jQuery Color to be a dependency for wp-lists, rather than enqueueing it everywhere.
Any plugin wishing to use jQuery color animations must set jquery-color as a dependency
(or enqueue it).

Remove the un-minified version of jQuery Color.

props scribu.
fixes #21692.



git-svn-id: https://develop.svn.wordpress.org/trunk@21646 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-28 17:51:35 +00:00
Mark Jaquith
b26ef93355 About ten percent
git-svn-id: https://develop.svn.wordpress.org/trunk@21422 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-05 18:32:39 +00:00
Andrew Nacin
1c4b08d998 load-importer-$importer hook. props simonwheatley. fixes #21071.
git-svn-id: https://develop.svn.wordpress.org/trunk@21183 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-29 19:24:15 +00:00
Jon Cave
cafa8dab24 Reduce references to the $wp_rewrite global because it's no longer used or a wrapper function can be used instead. Fixes #14546.#14546.
git-svn-id: https://develop.svn.wordpress.org/trunk@20023 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 20:29:33 +00:00
Ryan Boren
2b186b0c45 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: https://develop.svn.wordpress.org/trunk@19712 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 17:01:11 +00:00
Ryan Boren
a8d77cbae9 User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302
git-svn-id: https://develop.svn.wordpress.org/trunk@19687 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-05 20:50:54 +00:00
Ryan Boren
5e76729992 One newline is enough.
git-svn-id: https://develop.svn.wordpress.org/trunk@19684 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-05 20:10:39 +00:00
Andrew Nacin
d91bf70dd7 Consistently set taxnow/typenow and the current screen's post_type/taxnomy, whenever it can be detected. Allow WP_Screen::get() to accept a post type as a hook_name. Fixes issues with the meta box $page/$screen argument. fixes #19080. see #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@19097 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-31 21:28:17 +00:00
Dion Hulse
6147f81b33 Don't trigger Database Upgrades for POST requests with a body. Fixes #18712
git-svn-id: https://develop.svn.wordpress.org/trunk@18731 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-20 04:17:55 +00:00
Jon Cave
bfd95749bd Pull out old import remnant from when importers were shipped in core. Fixes #15844.
git-svn-id: https://develop.svn.wordpress.org/trunk@18640 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-05 19:18:36 +00:00
Peter Westwood
8f1955ddf5 Introduce WP_MAX_MEMORY_LIMIT constant for the high memory limit we set when image processing and unzipping.
Ensure it is always filterable by plugins as well as configurable in wp-config
Fixes #13847 props hakre


git-svn-id: https://develop.svn.wordpress.org/trunk@17749 602fd350-edb4-49c9-b593-d223f7449a82
2011-04-28 16:25:36 +00:00
Andrew Nacin
f504e221e1 Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265.
git-svn-id: https://develop.svn.wordpress.org/trunk@17748 602fd350-edb4-49c9-b593-d223f7449a82
2011-04-28 15:24:49 +00:00
Andrew Nacin
b8c1e1bb13 Add the load-edit-link-categories.php hook for back compat. fixes #16307.
git-svn-id: https://develop.svn.wordpress.org/trunk@17333 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-20 03:05:22 +00:00
Andrew Nacin
18edc09e6a More @since. props SergeyBiryukov, fixes #15445.
git-svn-id: https://develop.svn.wordpress.org/trunk@17071 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-20 09:25:21 +00:00
Andrew Nacin
3ebb27ae3e Always exit after wp_redirect. props filosofo, fixes #15518.
git-svn-id: https://develop.svn.wordpress.org/trunk@16847 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-09 18:02:54 +00:00
scribu
26f88f4b0f Deprecate update_category_cache(). Fixes #15446
git-svn-id: https://develop.svn.wordpress.org/trunk@16412 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-17 00:56:00 +00:00
Dion Hulse
82443ce769 Use Absolute URL's & API's in header redirects in more locations. See #14062
git-svn-id: https://develop.svn.wordpress.org/trunk@16008 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-27 10:43:43 +00:00
Andrew Nacin
7e48ac3e78 Pruning shears.
git-svn-id: https://develop.svn.wordpress.org/trunk@15904 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-21 19:55:28 +00:00
Andrew Nacin
fb4e38b0e7 Pinking shears.
git-svn-id: https://develop.svn.wordpress.org/trunk@15843 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-19 07:48:22 +00:00
Ryan Boren
9ee8b20f30 First pass of user admin. Network admin and screen cleanups. see #14696
git-svn-id: https://develop.svn.wordpress.org/trunk@15746 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-07 19:34:18 +00:00
Andrew Nacin
5c05a437a9 Add force_filtered_html_on_import filter. fixes #14818.
git-svn-id: https://develop.svn.wordpress.org/trunk@15600 602fd350-edb4-49c9-b593-d223f7449a82
2010-09-09 02:43:18 +00:00
Ryan Boren
b2351693de is_blog_admin(). fixes #14763
git-svn-id: https://develop.svn.wordpress.org/trunk@15558 602fd350-edb4-49c9-b593-d223f7449a82
2010-09-02 15:03:39 +00:00
Ryan Boren
edd48280e3 Network Admin, first pass. see #14435
git-svn-id: https://develop.svn.wordpress.org/trunk@15481 602fd350-edb4-49c9-b593-d223f7449a82
2010-07-30 20:34:54 +00:00
Ryan Boren
63503c5022 Back compat load actions. Props simonwheatley. fixes #14083 for 3.1
git-svn-id: https://develop.svn.wordpress.org/trunk@15387 602fd350-edb4-49c9-b593-d223f7449a82
2010-07-12 15:09:32 +00:00
Ryan Boren
d9eb60c0a0 Use WP_PLUGIN_DIR. Props bigsmoke, wojtek.szkutnik. fixes #14070 for 3.1
git-svn-id: https://develop.svn.wordpress.org/trunk@15346 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-29 13:52:56 +00:00
Ryan Boren
d599a6ca65 Make set_current_screen() taxonomy aware. Use current_screen when setting up table headers for edit-tags.php. see #13783
git-svn-id: https://develop.svn.wordpress.org/trunk@15175 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-08 15:34:42 +00:00
Andrew Nacin
fdf4f195df Nicer message for an uninstalled/invalid importer. see #13566.
git-svn-id: https://develop.svn.wordpress.org/trunk@14970 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-27 02:03:06 +00:00
Ryan Boren
68144f6136 Add install links to the importer list if popular importers are not present. see #13465
git-svn-id: https://develop.svn.wordpress.org/trunk@14759 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-20 19:20:25 +00:00
Andrew Nacin
a30c320a55 Bump memory_limit for admins in wp-admin. Should help in imports, upgrades, uploads, etc. props MarkJaquith.
git-svn-id: https://develop.svn.wordpress.org/trunk@14491 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-06 21:36:55 +00:00
Ryan Boren
8aea5863d7 Fix submenus for post types. Props TobiasBg. see #12453
git-svn-id: https://develop.svn.wordpress.org/trunk@13579 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-04 00:15:55 +00:00
Dion Hulse
8b38dceeca Move admin CSS colour themes to the admin_init hook. Fixes #11625
git-svn-id: https://develop.svn.wordpress.org/trunk@12982 602fd350-edb4-49c9-b593-d223f7449a82
2010-02-06 05:15:26 +00:00
Ryan Boren
708c01dd15 unset temp vars so they don't pollute the global namespace. Formatting cleanups
git-svn-id: https://develop.svn.wordpress.org/trunk@12846 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-26 18:16:53 +00:00
Ryan Boren
8f1e29abd1 Introduce set_current_screen(). Set current screen for inline edit ajax requests so post rows can be properly displayed. see #9674
git-svn-id: https://develop.svn.wordpress.org/trunk@12797 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-22 18:27:54 +00:00
Ryan Boren
f260b32d25 Use cap checks instead of multisite and super admin checks. Add some new caps. Merge cleanup. see #11644.
git-svn-id: https://develop.svn.wordpress.org/trunk@12753 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-18 22:21:36 +00:00
Ryan Boren
6e875ec562 Coding style
git-svn-id: https://develop.svn.wordpress.org/trunk@12736 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-15 23:49:09 +00:00
Ryan Boren
8ef8b7bad5 Trailing whitespace cleanup
git-svn-id: https://develop.svn.wordpress.org/trunk@12733 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-15 22:11:12 +00:00
Ryan Boren
482284d02f Move current_screen setup before plugin page handling so it is defined for all cases. see #9674
git-svn-id: https://develop.svn.wordpress.org/trunk@12731 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-15 20:21:18 +00:00
Ryan Boren
b74bea8a2c Merge edit-pages.php into edit.php. see #9674
git-svn-id: https://develop.svn.wordpress.org/trunk@12728 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-15 16:58:36 +00:00
Ryan Boren
31a41551ae Revert line accidentally added during merge. Props nacin. see #11644
git-svn-id: https://develop.svn.wordpress.org/trunk@12720 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-13 19:04:30 +00:00
Ron Rennick
d0f31a991c merge multisite admin - edit links,tags,cats,options, See #11644
git-svn-id: https://develop.svn.wordpress.org/trunk@12712 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-12 21:11:52 +00:00
Peter Westwood
256e7e7a07 Use a more reliable method of locating wp-load.php in the admin bootstrap. Fixes #11120.
git-svn-id: https://develop.svn.wordpress.org/trunk@12583 602fd350-edb4-49c9-b593-d223f7449a82
2009-12-30 10:15:10 +00:00
Peter Westwood
0f8b3225ed Remove unused global posts_per_page. Fixes #11458 props nacin.
git-svn-id: https://develop.svn.wordpress.org/trunk@12551 602fd350-edb4-49c9-b593-d223f7449a82
2009-12-27 09:01:53 +00:00
Ryan Boren
2f034b4430 Schedule trash collection from admin page loads. see #4529
git-svn-id: https://develop.svn.wordpress.org/trunk@12120 602fd350-edb4-49c9-b593-d223f7449a82
2009-10-27 18:13:42 +00:00
Andrew Ozz
aaae110d8f Remove remains from the old bookmarklet code
git-svn-id: https://develop.svn.wordpress.org/trunk@12029 602fd350-edb4-49c9-b593-d223f7449a82
2009-10-14 05:53:49 +00:00
Ryan Boren
2aa1252ebe Don't write to htaccess every time page is saved. Add hard/soft flush flag to flush_rules(). Make sure fopen is successful and silence errors. Props Viper007Bond. fixes #10181 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@11578 602fd350-edb4-49c9-b593-d223f7449a82
2009-06-16 02:44:28 +00:00
Ryan Boren
fc80cdec6b Remove vestiges of what_to_show. Props filosofo. fixes #9815
git-svn-id: https://develop.svn.wordpress.org/trunk@11318 602fd350-edb4-49c9-b593-d223f7449a82
2009-05-13 22:28:56 +00:00
Andrew Ozz
6358bca7d2 Notice fixes, props sivel, see #9393
git-svn-id: https://develop.svn.wordpress.org/trunk@11052 602fd350-edb4-49c9-b593-d223f7449a82
2009-04-22 12:24:45 +00:00
Mark Jaquith
3c2fd1ca40 Drop the dual-use of db_version. Now it just stores the version. Post-upgrade hook triggered by separate binary db_upgraded option. fixes #9618
git-svn-id: https://develop.svn.wordpress.org/trunk@11040 602fd350-edb4-49c9-b593-d223f7449a82
2009-04-21 23:12:57 +00:00