Commit Graph

15258 Commits

Author SHA1 Message Date
Andrea Fercia
c14ea1630f Accessibility: Improve the Screen Options and Help buttons order.
- makes the buttons visual order match the DOM order
- also, restores the focus style on the "hero" primary button after [34948]

Props vrimill, mukesh27 for reporting and testing.
Fixes #45094.


git-svn-id: https://develop.svn.wordpress.org/trunk@45503 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-08 16:30:15 +00:00
Andrea Fercia
7c04864ef5 Administration: Improve the Screen Options and Help buttons focus style after [45501].
Amends [45501].
See #46749.


git-svn-id: https://develop.svn.wordpress.org/trunk@45502 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-08 16:06:19 +00:00
Andrea Fercia
dfb4b20cbd Administration: Remove extra border from the Screen Options and Help buttons.
The extra border was visible in the responsive view for smaller screens after [32844].

Props jitendrabanjara1991.
Fixes #46749.


git-svn-id: https://develop.svn.wordpress.org/trunk@45501 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-08 14:49:50 +00:00
Andrew Ozz
0af549fdf5 Privacy tools: remove some left-over code and fix inline comment.
See #43895.



git-svn-id: https://develop.svn.wordpress.org/trunk@45500 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-08 00:29:59 +00:00
Andrea Fercia
226dc75154 Accessibility: Improve accessibility of all the media views form controls.
- changes the media views form controls to have explicitly associated labels with for/id attributes
- adds a few missing labels / aria-labels
- improves a few existing labels / aria-labels
- improves semantics in a few places, by adding visually hidden headings, fieldset + legend elements, aria-describedby attributes
- improves the image custom size input fields and their labelling
- adds `role="status"` to the "saved" indicator so that status messages are announced to assistive technologies
- swaps the columns source order in the image details template, to make visual and DOM order match
- swaps the "Replace" and "Back" buttons source order in the Replace Image view, to make visual and DOM order match
- gallery settings: move checkbox label to the right: checkboxes are supposed to have labels on the right
- merge similar strings, unified to "Drop files to upload" (removed "Drop files here", and "Drop files anywhere to upload")
- makes the "upload-ui" consistent across the media views
- hides the IE 11 "X" `::-ms-clear` button in the Insert from URL field, as it conflicts with the uploading spinner
- adds comments to all the media templates to clarify their usage
- slightly increases vertical spacing between form fields in the media sidebar
- removes some CSS selectors introduced as backwards compatibility for WordPress pre-4.4
- removes some CSS still targeting Internet Explorer 7 and 8

Fixes #47141.
Fixes #47122.


git-svn-id: https://develop.svn.wordpress.org/trunk@45499 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-07 20:43:26 +00:00
Andrea Fercia
f32683249d Fix the media player controls bar width in the media views.
Props vaishalipanchal, chetan200891.
Fixes #47457.


git-svn-id: https://develop.svn.wordpress.org/trunk@45497 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-07 13:28:37 +00:00
Sergey Biryukov
3f43833d5b Docs: Fix typo in comment_class() DocBlock.
Props mbabker.
Fixes #47499.

git-svn-id: https://develop.svn.wordpress.org/trunk@45496 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-06 23:51:24 +00:00
Sergey Biryukov
3ecc8d3f42 Media: Restore correct arrow direction in RTL in Attachment Details modal.
Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.

Props ramiy, SergeyBiryukov.
Fixes #46289.

git-svn-id: https://develop.svn.wordpress.org/trunk@45495 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-06 01:24:51 +00:00
Sergey Biryukov
f6bd90f2ef I18N: Merge duplicate "Original" strings used in the same context (referring to image size).
Props mukesh27.
Fixes #47486.

git-svn-id: https://develop.svn.wordpress.org/trunk@45494 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-05 15:22:22 +00:00
Sergey Biryukov
62385fdd00 I18N: Correct encoding for wp-includes/widgets/class-wp-widget-calendar.php, accidentally saved in ANSI instead of UTF-8.
See #47485.

git-svn-id: https://develop.svn.wordpress.org/trunk@45493 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-05 15:08:42 +00:00
Sergey Biryukov
3fc93cbbb6 I18N: Merge duplicate "A calendar of your site’s posts" strings used in the Calendar widget and the Calendar block in the editor.
Props jorgefilipecosta, ramiy.
Fixes #47485.

git-svn-id: https://develop.svn.wordpress.org/trunk@45492 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-05 15:02:56 +00:00
Sergey Biryukov
21b3d9031a Posts, Post Types: Switch the order of arguments for implode() in the_meta() to match the function notation.
Props loyaltymanufaktur.
Fixes #47481.

git-svn-id: https://develop.svn.wordpress.org/trunk@45491 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-05 00:15:06 +00:00
Jonathan Desrosiers
383b620ced Privacy: Remove inline CSS within personal data request list tables.
The `.hidden` class can be used to show and hide UI elements instead.

Props birgire, pratikthink, garrett-eclipse.
Fixes #44839.

git-svn-id: https://develop.svn.wordpress.org/trunk@45490 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-04 23:39:31 +00:00
Sergey Biryukov
ea4250beeb Docs: Correct parameter name for wp_new_user_notification_email_admin filter.
Props needle.
Fixes #47476.

git-svn-id: https://develop.svn.wordpress.org/trunk@45489 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-04 12:47:52 +00:00
Sergey Biryukov
d22572a5a5 I18N: Merge duplicate "Status" and "Info" strings on Site Health screens.
Props ramiy.
Fixes #47227.

git-svn-id: https://develop.svn.wordpress.org/trunk@45488 602fd350-edb4-49c9-b593-d223f7449a82
2019-06-01 22:09:42 +00:00
Sergey Biryukov
9172b9c16b Upgrade/Install: Correct operator precedence for an error code in WP_Ajax_Upgrader_Skin::error().
Props jrf.
Fixes #47441.

git-svn-id: https://develop.svn.wordpress.org/trunk@45487 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-31 14:13:09 +00:00
Felix Arntz
2264493b0d Bundled Theme: Load Google fonts with display=fallback parameter for better UX in case the font cannot be loaded.
Providing this query parameter ensures the stylesheet contains the `font-display: fallback` rule. This changeset also updates the Open Sans font used by core accordingly.

Props westonruter.
Fixes #47282.


git-svn-id: https://develop.svn.wordpress.org/trunk@45485 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-31 10:09:39 +00:00
Sergey Biryukov
37e745c041 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/media.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46530. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45484 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 16:44:02 +00:00
Sergey Biryukov
454cdf5f54 Media: Move tag cloud styles that accidentally ended up in Media section after the reorganization in [16136] to a more appropriate place.
Remove styles for `wp-admin/update-core.php` accidentally duplicated in Media section as part of the same reorganization.

See #46530.

git-svn-id: https://develop.svn.wordpress.org/trunk@45483 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 16:39:59 +00:00
Riad Benguella
3b248eeb83 Block Editor: Update packages to the ones slated for WP5.2.2
- Fix the template validation notice
 - Fix for focus jumps when typing in meta attributes

Packages updated:

 - @wordpress/block-editor@2.0.3
 - @wordpress/block-library@2.4.6
 - @wordpress/e2e-tests@1.1.6
 - @wordpress/edit-post@3.3.6
 - @wordpress/editor@9.2.6
 - @wordpress/format-library@1.4.6

Props aduth, desrosj.
Fixes #47429.


git-svn-id: https://develop.svn.wordpress.org/trunk@45481 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 15:40:59 +00:00
Jonathan Desrosiers
fea049171e Docs: Add missing function documentation for list_plugin_updates().
Introduced in [9543].

Props priyankkpatel, mukesh27.
Fixes #47424.

git-svn-id: https://develop.svn.wordpress.org/trunk@45480 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 15:09:32 +00:00
Jonathan Desrosiers
01cbc28400 Docs: Add missing documentation for the locale meta field.
The user’s locale is passed in the `$meta` parameter for `insert_user_meta`. Added in [38705].

Props tmatsuur.
Fixes #47423.

git-svn-id: https://develop.svn.wordpress.org/trunk@45479 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 14:36:41 +00:00
Sergey Biryukov
c60e468c6f CSS Coding Standards: Use unitless values for line-height in wp-includes/css/media-views.css.
Props ianbelanger, pbiron, afercia.
Fixes #46529. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45478 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 13:17:48 +00:00
Sergey Biryukov
a348577580 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/editor.css.
Props ianbelanger, pbiron, afercia.
Fixes #46528. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45477 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:44:43 +00:00
Sergey Biryukov
42d0a9ff5d CSS Coding Standards: Use unitless values for line-height in wp-includes/css/buttons.css.
Props ianbelanger, pbiron, afercia.
Fixes #46526. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45476 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:41:56 +00:00
Sergey Biryukov
4154cb7762 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/wp-pointer.css.
Props ianbelanger, pbiron, afercia.
Fixes #46525. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45475 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:40:59 +00:00
Sergey Biryukov
cfe0064c7a CSS Coding Standards: Use unitless values for line-height in wp-includes/css/wp-embed-template.css.
Props ianbelanger, pbiron, afercia.
Fixes #46524. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45474 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:39:26 +00:00
Sergey Biryukov
f706a2d4c4 CSS Coding Standards: Use unitless values for line-height in wp-includes/functions.php.
Props ianbelanger, pbiron, afercia.
Fixes #46523. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45473 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:38:09 +00:00
Sergey Biryukov
e7f7b81bcc CSS Coding Standards: Use unitless values for line-height in wp-includes/css/wp-auth-check.css.
Props ianbelanger, pbiron, afercia.
Fixes #46522. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45472 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:36:39 +00:00
Sergey Biryukov
6da8445436 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/jquery-ui-dialog.css.
Props ianbelanger, pbiron, afercia.
Fixes #46521. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45471 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:35:03 +00:00
Sergey Biryukov
6bd334d74b CSS Coding Standards: Use unitless values for line-height in wp-includes/css/customize-preview.css.
Props ianbelanger, pbiron, afercia.
Fixes #46520. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45470 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:33:13 +00:00
Sergey Biryukov
bf0213bbc7 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/admin-bar.css.
Props ianbelanger, pbiron, afercia.
Fixes #46519. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45469 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:31:57 +00:00
Sergey Biryukov
0b50df57a7 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/revisions.css.
Props ianbelanger, pbiron, afercia.
Fixes #46517. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45468 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:15:21 +00:00
Sergey Biryukov
efe514a8c2 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/list-tables.css.
Props ianbelanger, pbiron, afercia.
Fixes #46515. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45467 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:14:11 +00:00
Sergey Biryukov
2254e86861 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/login.css.
Props ianbelanger, pbiron, afercia.
Fixes #46514. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45466 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 12:08:53 +00:00
Sergey Biryukov
ca40b4ef9f CSS Coding Standards: Use unitless values for line-height in wp-admin/css/install.css.
Props ianbelanger, pbiron, afercia.
Fixes #46513. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45465 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 11:52:20 +00:00
Sergey Biryukov
e9f7b9a81d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/forms.css.
Props ianbelanger, pbiron, afercia.
Fixes #46512. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45464 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-30 11:48:09 +00:00
Andrea Fercia
79e2b83b8f Administration: Improve the Site Health tables layout for small screens.
Props immeet94, jankimoradiya, desrosj, shashank3105, chetan200891, Clorith, hedgefield.	
Fixes #46960.


git-svn-id: https://develop.svn.wordpress.org/trunk@45463 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-29 18:21:45 +00:00
Sergey Biryukov
663c2f6562 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/edit.css.
Props ianbelanger, pbiron, afercia.
Fixes #46511. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45462 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-29 16:04:38 +00:00
Sergey Biryukov
febf206326 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/dashboard.css.
Props ianbelanger, pbiron, afercia.
Fixes #46510. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45461 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-29 16:02:49 +00:00
Sergey Biryukov
84efe08557 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/customize-widgets.css.
Props ianbelanger, pbiron, afercia.
Fixes #46509. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45460 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-29 16:00:40 +00:00
Jonathan Desrosiers
1b4d29ab71 Administration: Add missing filter documentation for Site Health auto update tests.
Props johnbillion, mukesh27.
Fixes #47388.

git-svn-id: https://develop.svn.wordpress.org/trunk@45459 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-29 13:58:33 +00:00
Andrew Ozz
5bcaac6cfd Fix previous WPCS errors in script-loader.php triggered by [45456].
See #45346.

git-svn-id: https://develop.svn.wordpress.org/trunk@45457 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-28 03:31:55 +00:00
Andrew Ozz
2d02bb13d1 Script loader: prevent sorting of the load array in the query string when passing the script handles to load-scripts.php and load-styles.php.
Fixes #45346 #26886.

git-svn-id: https://develop.svn.wordpress.org/trunk@45456 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-28 02:42:24 +00:00
Sergey Biryukov
6d523d5044 Docs: Add a comment about the reinstated wp-admin/options-privacy.php.
See #43895.

git-svn-id: https://develop.svn.wordpress.org/trunk@45454 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-27 03:02:33 +00:00
Sergey Biryukov
2208412015 Privacy: Remove reinstated wp-admin/options-privacy.php from $_old_files.
Fix WPCS violations in [45448].

See #43895.

git-svn-id: https://develop.svn.wordpress.org/trunk@45453 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-27 02:39:46 +00:00
Andrew Ozz
d670b91335 Fix typo in [45451] and move the redirect to the proper location.
See #43895.

git-svn-id: https://develop.svn.wordpress.org/trunk@45452 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 23:20:56 +00:00
Andrew Ozz
2fb86e26e6 Privacy tools: restore privacy.php to its "proper" use to output the Privacy tab on the About screen, see [42814]. Then add the Privacy tab updates from freedoms.php.
See #43895.



git-svn-id: https://develop.svn.wordpress.org/trunk@45451 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 22:56:18 +00:00
John Blackbourn
41847b234e Docs: Improve documentation for some more variadic functions.
Fixes #37402


git-svn-id: https://develop.svn.wordpress.org/trunk@45450 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 22:47:23 +00:00
John Blackbourn
5b5ebdaa39 Docs: Improve docs for variadic functions relating to widgets and their controls.
See #37402


git-svn-id: https://develop.svn.wordpress.org/trunk@45449 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-26 22:04:04 +00:00