Commit Graph

164 Commits

Author SHA1 Message Date
Ryan Boren c21e4809c3 Show Select Files button the first time the media modal is opened.
Props koopermsith
fixes #22691


git-svn-id: https://develop.svn.wordpress.org/trunk@22990 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-03 06:32:25 +00:00
Ryan Boren 9cdc4de444 Add random and reverse sorting options to gallery settings.
Props koopersmith
fixes #22637


git-svn-id: https://develop.svn.wordpress.org/trunk@22987 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-03 05:32:25 +00:00
Andrew Nacin 6b0e365fc0 Media: Don't add menu_order to newly uploaded attachments, to match 3.4 behavior. Reverts a bit of [22967]. props koopersmith. fixes #22607.
git-svn-id: https://develop.svn.wordpress.org/trunk@22985 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-03 04:54:03 +00:00
Ryan Boren 558d134c6b Update gallery editing to work with the modal changes. Add nice handling for default states.
Props koopersmith
see #21776


git-svn-id: https://develop.svn.wordpress.org/trunk@22984 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-03 04:38:10 +00:00
Andrew Nacin f88b538001 Bring Featured Images back into the main media dialog.
Most users don't realize that the Featured Image meta box exists; if they do, few use it.

Restores the old meta box UI, including the admin_post_thumbnail_html filter. If a plugin is using _wp_post_thumbnail_html() in conjunction with Thickbox elsewhere, it will also magically still work.

Specific underlying changes:
 * Converts the modal view to use the view manager, which means that a call to open() will automatically call render and attach if necessary.
 * Doesn't automatically set a state in wp.media, to allow code to customize the states to be added before activation.

props koopersmith.
fixes #21776.



git-svn-id: https://develop.svn.wordpress.org/trunk@22979 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-03 02:38:10 +00:00
Andrew Nacin d8e714d6e3 Allow the 'Uploaded to this post' view to be sorted, saving the resulting order as menu_order.
This functionality is designed to be backwards compatible with manual querying for attachments by menu_order.

props koopersmith.
see #22607.



git-svn-id: https://develop.svn.wordpress.org/trunk@22967 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-02 16:06:31 +00:00
Ryan Boren 14bd848ee5 In the media modal, show the Link To: url.
Props nacin
fixes #22662


git-svn-id: https://develop.svn.wordpress.org/trunk@22965 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-02 00:43:08 +00:00
Ryan Boren 0996e3d153 Resolve race conditions in Attachments.more().
Props koopersmith
fixes #22656


git-svn-id: https://develop.svn.wordpress.org/trunk@22957 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-30 16:45:43 +00:00
Ryan Boren 303f2bd2ff Resolve race conditions in Attachments.more(). Provides for smoother refreshes when searching and properly cleans out content components.
Props koopersmith
fixes #22656


git-svn-id: https://develop.svn.wordpress.org/trunk@22956 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-30 16:41:38 +00:00
Ryan Boren 06b9663f58 Refine media state machine methods.
* state( id ) becomes setState( id )
* get( id ) becomes state( id )
* state() stays the same
* previous() becomes lastState()

Props koopersmith
fixes #22652


git-svn-id: https://develop.svn.wordpress.org/trunk@22952 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-30 15:19:11 +00:00
Ryan Boren d7ec10376b Update the "Uploaded to this post" filter view when uploading new files.
* Add an Attachments collection filter for uploadedTo (post_parent).
* Correct an erroneous map from the non-existent parent prop to post_parent.
* Define default menuOrder and uploadedTo props for uploading attachments.
* Unify filterable props into a single method (improving validation performance for calls to set with multiple properties).

Props koopersmith
fixes #22654


git-svn-id: https://develop.svn.wordpress.org/trunk@22951 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-30 15:11:44 +00:00
Ryan Boren c53137f535 Scope button classes so they can be used on the frontend without interfering with theme styles.
Props helenyhou, koopersmith
fixes #22644


git-svn-id: https://develop.svn.wordpress.org/trunk@22948 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-30 13:40:59 +00:00
Andrew Nacin be096cf4a5 Pressing escape now closes the media modal. props koopersmith, see #22502.
git-svn-id: https://develop.svn.wordpress.org/trunk@22946 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-30 08:37:17 +00:00
Ryan Boren 17622c2daa Improve switching between browser and upload state.
Props koopersmith
fixes #22628


git-svn-id: https://develop.svn.wordpress.org/trunk@22945 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-30 06:01:47 +00:00
Ryan Boren 6b972a4c53 In the media modal, ensure modal events are always fired on its frame. This ensures restoreThickbox() and thus tbRemove() are called properly when clicking the close button of the modal.
Props koopersmith
fixes #22632


git-svn-id: https://develop.svn.wordpress.org/trunk@22938 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-30 01:55:37 +00:00
Ryan Boren 6fbf7fcfbf Revert accidental bits from r22919. see #22628
git-svn-id: https://develop.svn.wordpress.org/trunk@22923 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-29 16:58:08 +00:00
Ryan Boren 3ad110f078 Icons for select, deselect, and window close in the media modal.
Props JerrySarcastic, helenyhou, ocean90, lessbloat
fixes #22610


git-svn-id: https://develop.svn.wordpress.org/trunk@22919 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-29 13:33:57 +00:00
Ryan Boren 4e51b43ad3 Media modal: Don't fire two AJAX calls on settings update.
Props koopersmith
fixes #22611


git-svn-id: https://develop.svn.wordpress.org/trunk@22907 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-28 22:27:13 +00:00
Andrew Nacin af63ca6803 Check if the object is empty, as objects are always truthy. props koopersmith. see #22593.
git-svn-id: https://develop.svn.wordpress.org/trunk@22892 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-28 04:41:24 +00:00
Andrew Nacin 0cebbfe3e6 Media: Remove the link to the browser uploader. The only need for it is large files (> 100MB) in certain browsers (IE, Opera), so we will show the link then only. fixes #22604.
git-svn-id: https://develop.svn.wordpress.org/trunk@22889 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-28 02:28:10 +00:00
Andrew Nacin 99845d0384 Ensure attachment modal details are saved before the attachment details view is destroyed. props koopersmith. fixes #22593.
git-svn-id: https://develop.svn.wordpress.org/trunk@22888 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-28 02:03:31 +00:00
Andrew Nacin da9ff4451d When editing a plain, legacy [gallery] shortcode, ensure we are sorting its contents using menu_order.
When attachments are sorted, we convert the shortcode to [gallery ids=""], as before.

props koopersmith.
fixes #22608.



git-svn-id: https://develop.svn.wordpress.org/trunk@22882 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-27 23:20:12 +00:00
Ryan Boren 6a9c14ed5f Add a delete link to the media modal.
Props merty, nacin, koopersmith
fixes #22524


git-svn-id: https://develop.svn.wordpress.org/trunk@22869 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-27 15:50:59 +00:00
Ryan Boren 1f4eed3141 Don't use "embed" when referring to inserting from URL.
Props nacin
fixes #22603


git-svn-id: https://develop.svn.wordpress.org/trunk@22868 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-27 15:35:36 +00:00
Ryan Boren b1f07f0ae1 Back compat $_REQUEST['post_id'] for media XHR requests.
Props koopersmith, nacin.
fixes #22588


git-svn-id: https://develop.svn.wordpress.org/trunk@22865 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-27 14:58:08 +00:00
Ryan Boren 9e26663d18 Rename 'id' to 'state' in menu item view.
Props koopersmith
fixes #22594


git-svn-id: https://develop.svn.wordpress.org/trunk@22851 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-26 22:49:45 +00:00
Ryan Boren 65f7674216 Always render the attachment compat view. Assures attachment_fields_to_edit is always fired.
Props koopersmith, Chouby
fixes #22578


git-svn-id: https://develop.svn.wordpress.org/trunk@22841 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-26 15:05:14 +00:00
Andrew Nacin faca39f74c Media: Watch more events for input changes to catch paste, autocomplete, etc.
Fixes issue where pasting a URL in 'From URL' (via the context menu) did not
enable the insert button, as the event was not yet fired.

props koopersmith.
fixes #22545.



git-svn-id: https://develop.svn.wordpress.org/trunk@22836 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-26 03:35:28 +00:00
Daryl Koopersmith f20573509b Media: Use a full uploader status view in the inline uploader. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22825 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 12:54:49 +00:00
Daryl Koopersmith 2070f5ca49 Media: Add uploader error detection to the inline uploader view as well. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22824 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 12:35:05 +00:00
Daryl Koopersmith e572052ab8 Media: Properly render any pre-existing upload errors in the uploader status. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22823 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 12:24:54 +00:00
Daryl Koopersmith 99def3ec51 Media: Make friends with media_upload_form. Adds notices for browser incompatibility, upload limits, maximum file size, and large file issues to the uploader. fixes #22243, see #22186, #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22821 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 11:46:03 +00:00
Daryl Koopersmith b007f89d0d Media: Display WordPress and plupload error messages whenever an upload fails. see #22243, #22186, #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22818 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 10:56:10 +00:00
Daryl Koopersmith ff6ae18d2d Media: Add global upload progress to the sidebar. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22816 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 09:32:21 +00:00
Daryl Koopersmith 4a99fa363e Media: Move sidebar from the frame view to the attachment browser view. Prevents juggling sidebar visibility state, and makes managing sidebar contents more reasonable. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22809 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 06:30:25 +00:00
Daryl Koopersmith 0086598c9b Media: Check to see if we need more attachments when the browser is attached to the DOM. fixes #22480, see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22806 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 03:19:08 +00:00
Daryl Koopersmith d4be102ab2 Media: Convert the attachments browser to use internal views. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22804 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 01:43:31 +00:00
Daryl Koopersmith 02bd60e532 Media: Make priority list views leverage the subview management class. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22802 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 00:41:39 +00:00
Daryl Koopersmith 95ed1b1a45 Media: Rename PriorityList's add/remove methods to set/unset (to prevent the default remove from being overridden). see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22792 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 20:43:42 +00:00
Daryl Koopersmith e99789f504 Media: Refresh the window-wide uploader whenever a state is activated. Properly unbind controller events. fixes #22504, see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22791 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 20:34:46 +00:00
Daryl Koopersmith bf42e8a402 Media: Make the window-wide uploader a subview of the frame view.
Allows the uploader to leverage the ready event to know when it has been attached to the page.

see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22790 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 20:27:49 +00:00
Daryl Koopersmith 6423fba2c4 Media: Make inline uploader use main dispose method. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22787 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 19:54:06 +00:00
Daryl Koopersmith 45f6cf2fb5 Media: Remove unused variable for state attributes. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22786 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 19:21:08 +00:00
Daryl Koopersmith 8d49ec29d0 Media: Make the upload state a dedicated screen, instead of including its own library view. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22781 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 18:29:53 +00:00
Daryl Koopersmith f8bf1ebec7 Media: Use a more specific class for toolbar buttons. see #22284, #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22779 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 17:50:02 +00:00
Daryl Koopersmith 5432b5a3f6 Media: Calculate image width and height when embedding images. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22762 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 14:32:52 +00:00
Daryl Koopersmith aa3bfdc808 Media: Remove redundant code.
Make the composite gallery library use `mirror` instead of `observe`, as one method now invokes the other. Also, make `mirror` return the attachment collection for chaining.

see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22750 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 12:11:38 +00:00
Daryl Koopersmith 052b765819 Media: Add filters for image-only libraries. see #22514, #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22745 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 11:04:23 +00:00
Daryl Koopersmith 8e6aa60fa4 Media: Dynamically generate attachment filters using get_post_mime_types().
Moves `get_post_mime_types()` from `wp-admin/includes/post.php` to `wp-includes/post.php`.

fixes #22514, see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22743 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 10:18:59 +00:00
Daryl Koopersmith 27515780f6 Media: Remove debug cruft. props ocean90. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22741 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 09:28:58 +00:00