Commit Graph

29996 Commits

Author SHA1 Message Date
Gary Pendergast cc8a9824c5 WPDB: When sanity checking a string by sending it to MySQL for conversion checks, the incorrect data structure was being returned from `wpdb::strip_invalid_text()`, causing all write queries to fail for some character sets when the query contained non-ASCII characters.
See #32051.



git-svn-id: https://develop.svn.wordpress.org/trunk@32261 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 15:01:25 +00:00
Sergey Biryukov 4e067b0354 About page design for 4.2.
props melchoyce, ryelle.
see #31929.

git-svn-id: https://develop.svn.wordpress.org/trunk@32260 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-22 06:03:03 +00:00
Helen Hou-Sandi 3fb766782d Don't add a class for comment authors who are members of the current site.
Reverts [32245] and [31518]. We'll keep the whitespace and comment clarification, though.

see #24054.


git-svn-id: https://develop.svn.wordpress.org/trunk@32259 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 23:35:55 +00:00
Andrew Ozz 925682e2d1 Revert editing of video embed parameters in the media modal, [31620] and [31626] for now. Plan on revisiting in 4.3.
Props iseulde. Fixes #31139, fixes #32006.

git-svn-id: https://develop.svn.wordpress.org/trunk@32258 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 22:40:23 +00:00
Andrew Ozz 312edcbc9d TinyMCE wpView: properly deselect views when hiding the editor. Do not remove `selected` on PreProcess.
Fixes #32045.

git-svn-id: https://develop.svn.wordpress.org/trunk@32257 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 21:31:26 +00:00
Helen Hou-Sandi 19c0b3f469 Shiny Updates: Prevent the post-update success message from jumping.
props pareshradadiya, afercia.
fixes #31984.


git-svn-id: https://develop.svn.wordpress.org/trunk@32256 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 20:40:55 +00:00
Andrew Ozz 89dee9f379 TinyMCE wpView: ensure `contentNode` is passed to all callbacks.
Props iseulde. Fixes #31669.

git-svn-id: https://develop.svn.wordpress.org/trunk@32255 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 18:35:50 +00:00
Gary Pendergast 7bfffc9b18 Bump version number for nightly builds.
git-svn-id: https://develop.svn.wordpress.org/trunk@32249 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 15:24:29 +00:00
Gary Pendergast 48a9127a87 Trunk is now 4.2-RC3.
git-svn-id: https://develop.svn.wordpress.org/trunk@32248 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 14:42:12 +00:00
Helen Hou-Sandi 345397aafb Avoid a PHP notice when adding an embed via Insert from URL.
props iseulde.
see #32006, #29476.


git-svn-id: https://develop.svn.wordpress.org/trunk@32247 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 14:35:40 +00:00
Helen Hou-Sandi b7d25c00e2 Rename the `pre_wp_prepare_themes_for_js` filter to `pre_prepare_themes_for_js`.
props DrewAPicture.
fixes #31789.


git-svn-id: https://develop.svn.wordpress.org/trunk@32246 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 14:22:15 +00:00
Helen Hou-Sandi 10640611f6 Comment: rename the `comment-author-is-site-member` class to `bysiteuser` for consistency.
Final decision on keeping the class yet to be made.

props DrewAPicture.
see #24054.


git-svn-id: https://develop.svn.wordpress.org/trunk@32245 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 14:19:58 +00:00
Helen Hou-Sandi 8ae79e3d33 Customizer: Better experience for widget filtering in desktop and iOS Safari.
Previously, the search field did not appear at all in desktop Safari, and the auto-focus keyboard fly-up in iOS rendered widget adding frustrating at best.

props dsmart, ocean90.
fixes #31987.


git-svn-id: https://develop.svn.wordpress.org/trunk@32243 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 14:14:27 +00:00
Helen Hou-Sandi 5ff0ea1fcf wpLink: Make the text editor experience the same as in the visual editor.
props azaozz.
fixes #31890.


git-svn-id: https://develop.svn.wordpress.org/trunk@32242 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 13:58:09 +00:00
Gary Pendergast afe046a84c WPDB: When deciding if a query needs extra sanity checking based on collation, we can quickly return if the query is entirely ASCII characters.
See #32029.



git-svn-id: https://develop.svn.wordpress.org/trunk@32233 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 05:23:44 +00:00
Gary Pendergast 0fe5a64e56 WPDB: When deciding if a query needs extra sanity checking based on collation, we can quickly return if it's a query that will never return user data.
Fixes #32029.



git-svn-id: https://develop.svn.wordpress.org/trunk@32232 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-21 05:10:11 +00:00
Andrew Ozz 9a4b6405bc Twenty Fifteen: remove `a img { display: block; }` from editor-style.css. Matches previous changes to style.css and fixes extra space when displaying captions in Firefox.
Fixes #32007.

git-svn-id: https://develop.svn.wordpress.org/trunk@32231 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 23:46:02 +00:00
Helen Hou-Sandi 38ee7ae7eb Press This: Prevent bottom buttons from wrapping on narrow screens.
props Michael Arestad.
fixes #32022.


git-svn-id: https://develop.svn.wordpress.org/trunk@32230 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 21:02:07 +00:00
Andrew Ozz 10bf8967d2 TinyMCE: fix creating a preview when pasting an embeddable URL in Firefox.
Part prop iseulde. Fixes #31988.

git-svn-id: https://develop.svn.wordpress.org/trunk@32229 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 20:56:10 +00:00
Helen Hou-Sandi f846003ea7 Media: Date filtering does not need to be on for all contexts.
Affected areas include customizer upload controls and video playlist editing.

props ocean90.
fixes #32004.


git-svn-id: https://develop.svn.wordpress.org/trunk@32228 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 19:48:08 +00:00
Drew Jaynes e1c4ed6e32 Post 4.2-RC2 bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@32227 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 19:43:39 +00:00
Gary Pendergast e08fe200ec Bump trunk to 4.2-RC2.
git-svn-id: https://develop.svn.wordpress.org/trunk@32222 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 17:40:43 +00:00
Sergey Biryukov 617b9a62c7 Make translator comments for the strings added in [31982] more accurate. Add some new comments.
props pavelevap.
fixes #32000.

git-svn-id: https://develop.svn.wordpress.org/trunk@32211 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 15:43:53 +00:00
Sergey Biryukov 408cca2c54 Merge two different translator comments for the same string.
props pavelevap.
fixes #31999.

git-svn-id: https://develop.svn.wordpress.org/trunk@32210 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 15:35:31 +00:00
Sergey Biryukov e71959fc57 Remove duplicate string with a typo, merge it with an existing string.
props pavelevap.
fixes #32020.

git-svn-id: https://develop.svn.wordpress.org/trunk@32209 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 15:26:04 +00:00
Boone Gorges 80ca5b2b53 In term-splitting unit tests, correct incorrect wording in an inline comment.
Props dlh.
Fixes #32014.

git-svn-id: https://develop.svn.wordpress.org/trunk@32208 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 15:17:24 +00:00
Boone Gorges 1a38d95e83 Ensure that 'who' param is respected when generating meta_query in `WP_User_Query`.
Since [31669], the 'who' param had been parsed after meta_query was generated,
so that 'who' was effectively ignored.

Props imath.
Fixes #32019.

git-svn-id: https://develop.svn.wordpress.org/trunk@32207 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 15:15:14 +00:00
Gary Pendergast c9774eac69 Unit Tests: The `get_smilies_combinations` test was failing when the tests were run with a non-default domain.
Props netweb.

Fixes #32025.



git-svn-id: https://develop.svn.wordpress.org/trunk@32178 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 10:10:53 +00:00
Gary Pendergast 8453d41a44 Fix the unit test added in [32173] to run correctly in PHP 5.2.
git-svn-id: https://develop.svn.wordpress.org/trunk@32177 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 09:40:11 +00:00
Gary Pendergast 05710aaa41 Ensure post titles are correctly escaped on the Dashboard.
Props helen, ocean90, dd32, pento.



git-svn-id: https://develop.svn.wordpress.org/trunk@32175 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 07:38:29 +00:00
Gary Pendergast 94f02ef8b1 In Multisite, prevent plugins from unintentionally switching sites.
Props mdawaffe.



git-svn-id: https://develop.svn.wordpress.org/trunk@32173 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 07:26:05 +00:00
Gary Pendergast 332750a40d Revert [30640], as it was incorrectly checking some filenames.
git-svn-id: https://develop.svn.wordpress.org/trunk@32171 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 06:38:08 +00:00
Gary Pendergast 98da14ab75 Correctly escape theme version numbers when displaying them.
Props collinsinternet.



git-svn-id: https://develop.svn.wordpress.org/trunk@32170 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 06:26:35 +00:00
Gary Pendergast 99927c319e Update the Plupload Flash file to the latest version.
Props azaozz.



git-svn-id: https://develop.svn.wordpress.org/trunk@32168 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 06:12:11 +00:00
Gary Pendergast 28de93d269 Remove some old backwards compatilibity code from TinyMCE.
Props azaozz.



git-svn-id: https://develop.svn.wordpress.org/trunk@32166 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 05:49:16 +00:00
Gary Pendergast 96f12cc588 Clean up some edge cases in `sanitize_sql_orderby()`.
Props vortfu, dd32.



git-svn-id: https://develop.svn.wordpress.org/trunk@32164 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 05:41:37 +00:00
Gary Pendergast faa66d8145 WPDB: When sanity checking read queries, there are some collations we can skip, for improved performance.
Props pento, nacin.

See #21212.



git-svn-id: https://develop.svn.wordpress.org/trunk@32162 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 04:45:12 +00:00
Andrew Nacin 62b51d8c0b Clean up wp_staticize_emoji() and friends.
* DOMDocument was removed in [31752] but not the check.
 * wp_staticize_emoji() has never accepted a second arg; remove it from calls.
 * Remove wp_staticize_emoji_for_feeds(), no need for it.
 * Remove _ and @ignore from wp_staticize_emoji_for_email(), no need for it.

see #31242.


git-svn-id: https://develop.svn.wordpress.org/trunk@32161 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 04:14:32 +00:00
Andrew Nacin 17d6534bb1 Update wp_die() calls modified in [31658] to use shorthand calling style.
see #31422.


git-svn-id: https://develop.svn.wordpress.org/trunk@32152 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-20 03:26:24 +00:00
Sergey Biryukov 3c28d7b1f6 Press This: Update documentation for `press_this_save_redirect` filter after [31992].
props kraftbj.
fixes #31996.

git-svn-id: https://develop.svn.wordpress.org/trunk@32143 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-19 01:34:01 +00:00
Andrew Ozz b7817247c5 TinyMCE: use window.twemoji directly in the `wpemoji` plugin. Gives a chance to the browser to lazy load twemoji.js when reloading the page.
Fixes #31901.

git-svn-id: https://develop.svn.wordpress.org/trunk@32142 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-18 23:28:11 +00:00
Andrew Ozz ab5685e6ad TinyMCE: remove the empty paragraph that sometimes is left over after adding an image caption.
Fixes #32003.

git-svn-id: https://develop.svn.wordpress.org/trunk@32141 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-18 21:55:45 +00:00
Andrew Ozz 9781cdb9a3 TinyMCE wpView:
- Remove selected views when inserting content but not when loading all content.
- Remove the ref. to the selected view node on resetting the views.
Fixes #31998.

git-svn-id: https://develop.svn.wordpress.org/trunk@32140 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-18 20:47:04 +00:00
Boone Gorges bf3773dbfb During PHPUnit tests, don't autodetect permalink structure during WP installation.
The unit tests expect non-pretty permalinks, so there's no benefit to detecting
the ability to have pretty permalinks. Moreover, the `wp_remote_get()` call can
cause installation to hang when there are DNS issues.

Fixes #31994.

git-svn-id: https://develop.svn.wordpress.org/trunk@32139 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-16 23:59:01 +00:00
Drew Jaynes 41b1d73c03 Post 4.2-RC1 bump
git-svn-id: https://develop.svn.wordpress.org/trunk@32138 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-15 19:05:00 +00:00
Drew Jaynes 9e3ce091fe WordPress 4.2-RC1
git-svn-id: https://develop.svn.wordpress.org/trunk@32137 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-15 18:52:08 +00:00
Dominik Schilling (ocean90) 6e6e1f45ed About page: All strings are available for translation.
* Remove AJAX call added in [30840].
* Remove `<code>` tags out of localized strings.

props johnbillion, ocean90.
see #31929.

git-svn-id: https://develop.svn.wordpress.org/trunk@32136 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-15 18:18:53 +00:00
Helen Hou-Sandi a71a815a0c About page: A last round of text updates.
props DrewAPicture, johnbillion, afercia, helen.
see #31929.


git-svn-id: https://develop.svn.wordpress.org/trunk@32135 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-15 17:33:11 +00:00
Dominik Schilling (ocean90) 7fba67e4b7 Customizer: Escape theme preview URLs.
props johnbillion, ocean90.
see #31896.

git-svn-id: https://develop.svn.wordpress.org/trunk@32134 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-15 16:32:03 +00:00
Aaron Jorbin 686b4af44d Move wp-plugin-update-success event to after lock is released
Fixes #31978
See #31819
Props DavidAnderson



git-svn-id: https://develop.svn.wordpress.org/trunk@32133 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-15 14:36:04 +00:00