Scott Taylor
fd8d6cddcd
Don't iterate over $wp_query->posts
in update_post_thumbnail_cache()
if it is empty. Adds unit tests.
...
Props SergeyBiryukov, for the original patch.
Fixes #26321 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27166 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-12 04:48:14 +00:00
Andrew Ozz
94a1bb0485
TinyMCE: fix styling in the Charmap modal so the click targets are as large as the table cells. Remove the "Close" button and close the modal after inserting the special char. Fixes #27107 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27165 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-11 23:32:11 +00:00
Dominik Schilling (ocean90)
a03b5033ce
Use jQuery.prop('checked') instead of jQuery.attr('checked'), which is deprecated.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27164 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-11 21:12:04 +00:00
Scott Taylor
2e9d155703
Partially revert [27101], [27102], [27141], and [27142]. Those commits introduced new functions to sync up cache invalidation events. The current commit alters existing internals.
...
"The cache invalidation with static was introduced in r9102 with version 2.7. Multisite wasn't in core back then, so something like switch_to_blog() wasn't a concern, but now it breaks if you switch the blog in between calls to clean_term_cache."
This solution is simpler. All unit tests pass. Removes unnecessary tests linked to removed functions.
Props kovshenin.
Fixes #14485 , #22526 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27163 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-11 16:49:11 +00:00
Scott Taylor
05b87717c8
Rather than removing the 3rd argument in WP_Object_Cache::delete()
, mark it as $deprecated
.
...
See [27064].
Props SergeyBiryukov.
Fixes #22478 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27162 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-11 16:40:30 +00:00
Scott Taylor
4f8d51257c
In remove_user_from_blog()
, avoid a potentially expensive IN
query before invalidating the reassigned post and link caches.
...
Props kovshenin.
Fixes #25545 . (Again.)
git-svn-id: https://develop.svn.wordpress.org/trunk@27161 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-11 16:27:05 +00:00
Andrew Ozz
fb3f9ff8f7
Bump the TinyMCE version, see #24409 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27160 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-11 01:07:22 +00:00
Andrew Ozz
fd19c371d1
Edit image in TinyMCE:
...
- Add a "toolbar" at the top of the image with two buttons: Edit and Delete.
- Don't open the edit modal on second click on the image. Makes the "edit" button somewhat pointless and can sometimes trigger after resizing the image.
- When the image has caption: attempt to prevent IE11 from making the caption element resizable and wrapping it in thick border.
- When the caret is inside a caption next to the image, pressing Enter will create a new <p> tag above the caption.
- Hide the image toolbar on drag, cut, align.
Props gcorne, see #24409 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27159 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-10 23:47:34 +00:00
Andrew Nacin
b7be4e98fe
Detect and handle symlinking of plugins in plugin_basename().
...
props rmccue, MikeSchinkel, jdgrimes.
see #16953 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27158 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-10 22:59:40 +00:00
Drew Jaynes
ef099f8082
Fix a typo in the PHPDoc for comment_author_email_link()
.
...
See #27083 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27157 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-10 04:06:36 +00:00
Drew Jaynes
3d67904bc7
Inline documentation cleanup in wp-includes/comment-template.php.
...
This cleanup follows [25567] and brings the docs in-line with standards that at the time had not yet been finalized.
These changes include
* Moving in-line `@see` tags to their own lines
* Using docs-specific variables in hook docs
* Fixing line-wrapping throughout
* Typos and punctuation
* Converting hash notation values to variables per the standard
Fixes #27083 . See #20495 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27156 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-10 03:19:13 +00:00
Andrew Ozz
ce2dcccf86
Incorporate the TinyMCE tests into our JS tests:
...
- Modified the original tests so TinyMCE can be loaded from /src/wp-includes/js/tinymce.
- Added "WP" option to the UI to select only tests relevant to our integration (excludes most of the default plugins tests).
- Added tests for obsolete HTML elements and attributes (html4 back-compat).
See #27014 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27155 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-10 01:11:25 +00:00
Andrew Ozz
4951bdc964
Remove unused arg from wp_auth_check(), see #27081 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27154 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 22:33:56 +00:00
Andrew Nacin
e1f6ab1ea9
Run wp_auth_check on every heartbeat tick.
...
wp_heartbeat_received only runs when data is sent. We want to always pass this data back, though.
fixes #27081 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27153 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 22:27:57 +00:00
Scott Taylor
3fce77b44d
Collect the post and link ids that will be reassigned before running the update in remove_user_from_blog()
. Use array_walk()
instead of array_map()
when invalidating the caches for the collected ids.
...
Props kovshenin.
Fixes #25545 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27152 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 21:46:43 +00:00
Sergey Biryukov
13571cf6b2
Update comment about structure of items in $menu global.
...
props kitchin.
fixes #26635 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27151 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 21:42:28 +00:00
Dominik Schilling (ocean90)
586cb2b140
Nav Menu: Remove post/page items from the Nav Menu when the post/page is deleted.
...
This was broken through a change in [25163]. `_menu_item_object` in wp_get_associated_nav_menu_items() is not relevant for post types.
Adds unit tests.
props UmeshSingla for initial patch.
fixes #26795 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27150 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 21:36:15 +00:00
Drew Jaynes
d670819b03
Improve inline documentation for wp_new_user_notification()
.
...
Props antorome for the initial patch.
Fixes #26703 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27149 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 21:07:01 +00:00
Drew Jaynes
eaff87706b
Improve inline documenation for get_the_time()
and `get_post_time().
...
Props ruud@joyo for the initial patch.
Fixes #26682 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27148 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 21:02:36 +00:00
Drew Jaynes
b013aaf4c9
Fixes for hooks documentation in wp-includes/wp-db.php.
...
See #26869 , #25229 and [25284].
git-svn-id: https://develop.svn.wordpress.org/trunk@27147 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 20:50:42 +00:00
Drew Jaynes
6229ba0bb3
Fixes for hooks documentation on xmlrpc.php.
...
Adds spacing, changes an `@see` to `@link`, adds a docs-specific variable for a parameter.
See #26869 , #25229 and [25281].
git-svn-id: https://develop.svn.wordpress.org/trunk@27146 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 20:38:39 +00:00
Drew Jaynes
e4adb8dcfe
Fixes for hooks documentation in wp-admin/admin-footer.php.
...
Adds some new lines, some hook-line spacing, docs-specific variables, and other language tweaks.
See #26869 , #25229 , [25252].
git-svn-id: https://develop.svn.wordpress.org/trunk@27145 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 20:28:01 +00:00
Drew Jaynes
1fcb6036ca
Fixes for inline documentation for hooks in wp-comments-post.php.
...
Adds missing `@since` versions, spacing, and language tweaks.
See #26869 , #25229 , [25249].
git-svn-id: https://develop.svn.wordpress.org/trunk@27144 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 20:11:34 +00:00
Andrew Ozz
0ae2aa696a
Remove a stray </div> from the Edit Image template, was breaking it in IE < 9. Props gcorne, see #24409
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27143 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 18:44:40 +00:00
Scott Taylor
e966a23683
Reuse the terms
cache group for taxonomy cache invalidation.
...
See #22526 , #14485 , [27101], [27102].
git-svn-id: https://develop.svn.wordpress.org/trunk@27142 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 17:41:07 +00:00
Drew Jaynes
eb43703bba
Improve inline documentation for several 'last_changed'-related functions introduced in [27101] and [27102].
...
Functions include:
* `get_taxonomy_last_changed()`
* `set_taxonomy_last_changed()`
* `post_taxonomy_is_fresh()`
* `taxonomy_hierarchy_is_fresh()`
Fixes #22526 , #14485 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27141 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 02:01:28 +00:00
Andrew Nacin
ee280cf8dd
has_image_size()'s parameter should be required. see [27139], see #26951 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27140 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 23:52:40 +00:00
Drew Jaynes
c0a7cd58e7
Inline documentation tweaks for has_image_size()
and remove_image_size()
.
...
See #26951 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27139 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 22:54:47 +00:00
Drew Jaynes
75c028e042
Inline documentation for the wp_insert_attachment_data
filter hook, added in [27130].
...
Fixes #20547 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27138 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 22:46:25 +00:00
Drew Jaynes
aa502ff35a
Fix docs spacing missed in [27136].
...
See #27070 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27137 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 22:18:09 +00:00
Drew Jaynes
4993a00e05
Improve inline documentation for submit_button()
.
...
See #27070 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27136 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 22:13:18 +00:00
Drew Jaynes
622d3e1338
Clarify submit_button()
$type
parameter docs to mention that the value doubles as the CSS class attribute.
...
See #27070
git-svn-id: https://develop.svn.wordpress.org/trunk@27135 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 22:10:19 +00:00
Sergey Biryukov
a3a869fdfd
Fix validation issue in get_the_password_form() caused by wpautop().
...
props andykeith.
fixes #27071 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27134 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 13:22:40 +00:00
Andrew Nacin
f3cbc44076
Add meetup.com oEmbed support. see #23171 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27133 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 01:13:52 +00:00
Andrew Nacin
3266997d99
Improve parameter documentation of add_meta_box().
...
props philiparthurmoore, DrewAPicture.
fixes #26698 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27132 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 00:54:19 +00:00
Andrew Nacin
522670cef2
Various JSHint fixes. see #26446 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27131 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 00:51:14 +00:00
Scott Taylor
2238c7fb7f
Add a filter wp_insert_attachment_data
in wp_insert_attachment()
. This is similar to the wp_insert_post_data
filter in wp_insert_post()
.
...
Fixes #20547 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27130 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 00:43:16 +00:00
Andrew Nacin
baeadcfedc
Add remove_image_size() and tests for it and has_image_size(), added in [27128].
...
props mordauk, markoheijnen.
fixes #26768 . see #26951 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27129 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 00:40:15 +00:00
Scott Taylor
d80685a46b
Introduce has_image_size( $name )
, a utility function that helps avoid loading the $_wp_additional_image_sizes
global.
...
Props mordauk.
Fixes #26951 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27128 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 00:19:29 +00:00
Scott Taylor
d6cb8c399e
Introduce maybe_regenerate_attachment_metadata( $attachment )
. On the Edit Media screen, call it for Audio and Video files.
...
The functions checks if the item is lacking metadata altogether. If a video or audio file was uploaded prior to 3.6, it does not have any metadata. This tries to fix it. Implements locking via a transient to protect against this running in parallel with another request.
This is the minimum viable product for #26825 , but leaving the ticket open unless this function needs to be called in other places.
See #26825 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27127 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 22:40:32 +00:00
Scott Taylor
4b047c21ab
Add some inline docs to media-views.js
and remove some unnecessary comments from a few super
calls.
...
Props gcorne.
See #26870 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27126 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 20:20:38 +00:00
Scott Taylor
81679ef453
When a term_id
matches in _get_term_children()
, recurse through its children until there is no more depth in the hierarchy. Since get_terms()
return terms with a count
of 0
when their children are not empty, we must return all children so that get_terms()
can check their count.
...
In [27108], #26903 was fixed, but only because we were using the example in the ticket, leaving out infinite depth for hierarchical taxonomies.
Adds unit tests, including `Tests_Term_getTerms::test_get_terms_seven_levels_deep()`.
Fixes #26903 . Again.
git-svn-id: https://develop.svn.wordpress.org/trunk@27125 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 19:53:01 +00:00
Lance Willett
5ddc101010
Twenty Fourteen: fix Ephemera Widget to avoid showing full post content when displayed in single post or page. Restore the global $more
to its original value after the widget output to avoid any issues caused by changing a global variable.
...
Props obenland, mor10, Frank Klein. See #26961 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27124 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 18:03:00 +00:00
Lance Willett
2ec5e68249
Twenty Fourteen: pinking shears.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27123 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 18:01:20 +00:00
Lance Willett
9ddb14eb97
Twenty Fourteen: translate featured
tag slug used to link to specific tags in Posts editor. See #26526 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27122 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 17:46:46 +00:00
Lance Willett
7d23aedf8b
Twenty Fourteen: fix unreachable links when the content area is shorter than the sidebar in smaller viewpoints. Props celloexpressions, see #26782 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27121 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 17:42:59 +00:00
Lance Willett
6f9758f69b
Twenty Fourteen: delete the featured_content_ids
transient on theme switch to make sure child themes can override the Featured Content quantity value. Also remove quantity parameter so child themes can change the amount of featured posts with $max_posts
.
...
Props obenland, see #26660 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27120 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 17:38:08 +00:00
Sergey Biryukov
5b7c8cf7c1
Use .screen-reader-text class instead of an alt attribute for overlay button labels on Themes screen.
...
props bramd.
fixes #26603 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@27119 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 17:32:31 +00:00
Lance Willett
cb8654eade
Twenty Fourteen: make sure featured
tag is hidden on front-end views as expected. Add a check for the tag name in case we're using default values and the default ID of 0
does not match the term id of the featured
tag.
...
Props obenland, fixes #26732 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27118 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 17:16:53 +00:00
Lance Willett
dfb4b73fbe
Twenty Fourteen: fix gap above static pages, props SergeyBiryukov. Fixes #26694 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27117 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 17:10:04 +00:00