Commit Graph

29 Commits

Author SHA1 Message Date
Scott Taylor 7301c115aa Accessibility: add missing `alt` attributes to a gaggle of `<img>`s.
Props afercia.
Fixes #34583.


git-svn-id: https://develop.svn.wordpress.org/trunk@35567 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-07 16:11:38 +00:00
Andrew Ozz 5a55add794 JS: in event callbacks replace the very outdated `return false` with `preventDefault()`.
Props adamsilverstein.
Fixes #18590.

git-svn-id: https://develop.svn.wordpress.org/trunk@34977 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-09 01:26:46 +00:00
Andrea Fercia bc8e3599e6 Quick Edit: fix the Tags auto-suggest tooltip visibility.
Be sure to hide the `jquery.suggest` Tags textarea tooltip also when using the keyboard to Save/Cancel.

Props rommelxcastro for the initial patch.
Fixes #32580.

git-svn-id: https://develop.svn.wordpress.org/trunk@34064 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-11 23:33:43 +00:00
Helen Hou-Sandi e5c4c584c0 List tables: A better responsive view.
Instead of truncating columns, the data that's already in the markup can now be toggled into view. Only seems appropriate to celebrate four years of contributing by finally doing the first thing I ever mocked up.

Known issues / concerns:
* Custom list tables that don't define a primary column will show nothing at all. These are not extremely common, as `WP_List_Table` isn't really recommended for plugin consumption, but it happens. We need to come up with some kind of fallback.
* Some visual elements, particularly whitespace, could use refining.
* Needs a11y review.
* Touch performance on iOS feels sluggish - is there anything we can do about that?
* Would this be better accordion-style (only one expanded at a time)?
* Is `wp_strip_all_tags()` good enough for column titles that have HTML in them? It's essentially a workaround for the fact that core's comments column does that for the icon, which maybe it shouldn't. Perhaps worth another ticket, as a markup change would be fairly independent.
* Visual hierarchy is not great when expanded (also worthy of another ticket).
* Quick edit now becomes noticeably more annoying to cancel out of, as you have to scroll all the way down and you lose your position from before it was opened. Again, worthy of another ticket.

props Michael Arestad, helen.
see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33016 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 01:30:23 +00:00
Helen Hou-Sandi 6130ea5a0b Bulk/quick edit: Set the correct colspan.
`thead` can contain `td`s now, too.

props afercia.
fixes #31654.


git-svn-id: https://develop.svn.wordpress.org/trunk@33015 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 01:05:29 +00:00
Scott Taylor c5f72c4ab7 Use `<button>` instead of `<a>` for non-link links in Quick Edit.
Props afercia.
Fixes #32213.


git-svn-id: https://develop.svn.wordpress.org/trunk@32869 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-19 21:41:07 +00:00
Konstantin Obenland c7a40c6847 When inline editing a post, reset password field to be editable by default.
The Quick Edit form is cloned and then populated with post-specific data. If the 
previous post was private, the password field would continue to be disabled for
the next post.

Props afercia.
Fixes #32259.



git-svn-id: https://develop.svn.wordpress.org/trunk@32716 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-09 22:01:06 +00:00
Helen Hou-Sandi 6983294161 Spinners: Toggle a class instead of show/hide.
Toggling spinners also now uses visibility instead of display, so that the space is always reserved and nothing moves around unexpectedly.

props cdog, MikeHansenMe, valendesigns.
fixes #22839. see #31875, #30725.


git-svn-id: https://develop.svn.wordpress.org/trunk@31996 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 04:51:18 +00:00
Helen Hou-Sandi 6a273462e8 List tables: Go back to inserting quick edit rows after, as some plugins rely on that assumption. Results are the same.
fixes #26060.


git-svn-id: https://develop.svn.wordpress.org/trunk@31820 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-18 21:49:26 +00:00
Gary Pendergast 37bee1ed3a Emoji: Instead of having custom hooks for Ajax callbacks, use MutationObserver to re-parse any changed elements in the DOM.
Props iseulde

See #31242



git-svn-id: https://develop.svn.wordpress.org/trunk@31750 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-12 12:51:06 +00:00
Andrew Nacin a5cd4f6284 Emoji JS cleanup.
* Filename: emoji.js => wp-emoji.js
 * Script handle: emoji => wp-emoji
 * Object: WPEmoji => wp.emoji
 * Script settings: EmojiSettings => _wpemojiSettings
 * Setting key: base_url => baseUrl
 * Remove executable bit from files

see #31242.


git-svn-id: https://develop.svn.wordpress.org/trunk@31744 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-12 03:16:51 +00:00
Sergey Biryukov 8220541799 Fix JSHint errors in [31734] and add missing dependencies.
props iseulde.
fixes #31328.

git-svn-id: https://develop.svn.wordpress.org/trunk@31741 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-12 01:04:44 +00:00
Gary Pendergast 1357e7fc2e Add emoji URL support, and Twemoji fallback for displaying slugs in wp-admin, when the browser doesn't natively support emoji.
Props pento, SergeyBiryukov and boonebgorges.

Fixes #31328



git-svn-id: https://develop.svn.wordpress.org/trunk@31734 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-11 22:54:49 +00:00
Scott Taylor 69c449963e Replace flagrant instances of `.html('')` with `.empty()`.
Props OriginalEXE, SergeyBiryukov.
Fixes #27034.


git-svn-id: https://develop.svn.wordpress.org/trunk@31690 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-09 19:43:49 +00:00
Sergey Biryukov 02b3356750 Quick Edit: Don't save the post if Enter is pressed on the Cancel link.
props afercia.
fixes #30345.

git-svn-id: https://develop.svn.wordpress.org/trunk@31274 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-24 15:06:43 +00:00
Helen Hou-Sandi 8ab449ae35 List tables: Use CSS :nth-child() selectors for zebra striping.
Note that this does not fix issues related to comment quick edit. Internal linking also continues to use the `.alternate` class for now. IE8 and below gracefully degrade by not having zebra striping.

There is some hoop jumping with adding an extra table row to maintain zebra striping during quick edit. Documenting that here for future reference; it is also in the inline documentation.

fixes #30981 and #26060. see #25060.


git-svn-id: https://develop.svn.wordpress.org/trunk@31181 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-14 22:13:03 +00:00
Sergey Biryukov 3513f37623 Fix unexpected replacement of a previous tag when selecting a tag from autosuggest results.
props camdensegal.
fixes #28471.

git-svn-id: https://develop.svn.wordpress.org/trunk@28851 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 16:07:36 +00:00
Sergey Biryukov c73f5ef2de Fix displaying taxonomies in bulk edit if the post type does not support titles.
props scribu.
fixes #16793.

git-svn-id: https://develop.svn.wordpress.org/trunk@28600 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-28 13:49:21 +00:00
Andrew Ozz 75ac2cf131 Heartbeat:
- Bring back heartbeat.interval().
- Rename wp_disable_heartbeat_suspend() to wp_heartbeat_set_suspension().
- Rename the option for disabling suspension from options.suspend to options.suspension.
Fixes #25073.

git-svn-id: https://develop.svn.wordpress.org/trunk@26549 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-03 00:44:22 +00:00
Andrew Nacin 010fbd7866 JShint fixes for inline-edit-post.js.
props dougwollison.
fixes #26001.


git-svn-id: https://develop.svn.wordpress.org/trunk@26264 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-19 04:31:42 +00:00
Andrew Ozz 8dc91f3646 Heartbeat: clean up code style, better naming, better code structure. Props carldanley, props evansolomon.
Changes:
- Add connectNow() public method to trigger a connection immediately.
- Remove the "skipping" when no data to send.
- Change the default interval to 60 sec.
- Fix resetting the next connection time when changing the interval.
See #25073.

git-svn-id: https://develop.svn.wordpress.org/trunk@26169 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-14 18:40:03 +00:00
Sergey Biryukov d3cee0734e Change jQuery selector in Quick Edit to avoid losing data in IE8.
fixes #24923 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@26123 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 04:05:57 +00:00
Andrew Nacin 7a9a26fb84 List tables: When executing a search, reset the Bulk Actions dropdown to avoid the search from failing.
props c3mdigital, vinod-dalvi.
fixes #25034.


git-svn-id: https://develop.svn.wordpress.org/trunk@25677 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 01:08:13 +00:00
Scott Taylor f3722d70c1 Revert [25663] for UX discussion
git-svn-id: https://develop.svn.wordpress.org/trunk@25667 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 20:52:22 +00:00
Scott Taylor 415a348999 When Quick Edit'ing a page, checks if edited page has a new parent and moves the row underneath that one. If the parent doesn't exist on this page then it hides the row altogether.
Props solarissmoke, MikeHansenMe.
Fixes #14188.



git-svn-id: https://develop.svn.wordpress.org/trunk@25663 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 20:37:48 +00:00
Helen Hou-Sandi 3eea90937d Allow all non-visible default row actions in the admin to be accessed via keyboard. fixes #21334.
git-svn-id: https://develop.svn.wordpress.org/trunk@25595 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-24 02:49:30 +00:00
Helen Hou-Sandi 7446faa7fb Allow non-visible post row actions to be accessed via keyboard. props adamsilverstein, lessbloat. fixes #21334.
git-svn-id: https://develop.svn.wordpress.org/trunk@25593 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-24 02:03:41 +00:00
Helen Hou-Sandi becf161fb8 Make sure quick edited non-alternate list table rows don't become alternate. props mordauk. fixes #24951.
git-svn-id: https://develop.svn.wordpress.org/trunk@25039 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-16 20:18:31 +00:00
Andrew Nacin b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00