Scott Taylor
c49c139a22
Add @access
annotations to methods that have no doc block in wp-admin/includes/*
.
...
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32656 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 21:31:56 +00:00
Scott Taylor
ec5758225c
Add missing doc blocks to wp-admin/includes/*
.
...
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32654 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 20:16:22 +00:00
Scott Taylor
23ce2efd12
Add @global
annotations for wp-admin/*
.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32642 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-28 21:40:27 +00:00
Dion Hulse
248c73b1cf
Plugins Browser: Replace the download count with the number of Active installs of the plugin.
...
Fixes #31865
git-svn-id: https://develop.svn.wordpress.org/trunk@31990 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 23:48:26 +00:00
Aaron Jorbin
dc502287ef
Update aria-label when doing a shiny plugin update
...
Also updates it again when the shiny plugin update is finished.
Also updates it if the shiny update fails
props mehulkaklotar, afercia
Fixes #31722
git-svn-id: https://develop.svn.wordpress.org/trunk@31982 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-02 05:30:13 +00:00
Dion Hulse
9eb9342a54
Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn't specified.
...
* `H:i - 09:54`
* `g:i a - 9:54 am`
* `F j, Y - January 3, 2015`
These shouldn't be used without a/A (am/AM)
* `h:i - 01:23`
* `G:i - 1:23`
Props iseulde. Fixes #31121
git-svn-id: https://develop.svn.wordpress.org/trunk@31862 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 02:13:50 +00:00
Gary Pendergast
748d595b5c
Shiny Updates: Add ajax-y updates to the plugin list page, and ajax-y updates and installs to the plugin card page.
...
This also includes JS architecture that can be expanded to support theme, core and language pack updates.
Props pento, ericlewis, lgladdy, adamsilverstein, DrewAPicture
See #29820
git-svn-id: https://develop.svn.wordpress.org/trunk@31333 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-05 04:18:57 +00:00
Drew Jaynes (DrewAPicture)
b590db9253
Ensure the correct list of default tabs for the Plugin Install screen are documented.
...
Props stevenkword.
Fixes #31017 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31244 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-19 08:43:15 +00:00
Scott Taylor
e5672bd8c5
Add a private
field to WP_Plugin_Install_List_Table
, $error
.
...
See #30891 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31164 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-12 16:18:52 +00:00
Scott Taylor
97d6901048
Access Modifiers:
...
* In `WP_Plugin_Install_List_Table`, use `public` instead of `var`
* In `WP_User`, `->data` is accessed directly on an instance if the constructor receives it: make it `public`
* In `WP_Locale`, every property is exported to a global and is already `public` via `var`, half of the properties are accessed directly already, make them all `public`
* In `WP_Rewrite`, several properties are accessed publicly in functions via the `$wp_rewrite` global, make those props `public`.
* In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled as `->comments_feed_structure`
See #30799 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31078 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 05:43:54 +00:00
Sergey Biryukov
8e9b9bc458
Use localized format for Last Updated date on Add Plugins screen.
...
props tyxla.
fixes #30717 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31055 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-06 01:02:21 +00:00
Andrew Ozz
c8e8281a05
Plugins: move the recommender results to a separate tab. Any outstanding quality issues will be fixed on the API side without needing core changes. Props tellyworth, fixes #30337 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@30782 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 23:39:54 +00:00
Scott Taylor
c0045bda84
Improve various @param
docs for List Tables.
...
See #30224 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30679 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-01 00:32:19 +00:00
Drew Jaynes (DrewAPicture)
f45fd382b3
Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*.
...
Also adds a few inline `@see` cross-references as they apply.
Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`
See #30552 .
git-svn-id: https://develop.svn.wordpress.org/trunk@30648 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 11:27:19 +00:00
Dominik Schilling (ocean90)
f7a4e22bdb
Plugin search: Wrap results in a form to fix pagination's paged
input field.
...
props jesin, ocean90.
see #18724 , for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@29829 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 13:07:18 +00:00
Sergey Biryukov
2e58e91dcc
Remove unnecessary CSS overriding on Add Plugins screen.
...
props pavelevap.
fixes #29753 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29775 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-28 20:25:33 +00:00
Helen Hou-Sandi
2cb48c1039
Plugin install: Better styling to accommodate plugin icons.
...
fixes #29466 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29679 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-02 19:46:19 +00:00
Andrew Nacin
7bdd5a7a2e
Plugin install: The sort callback doesn't need to be public.
...
props helen.
fixes #28673 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29666 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-02 06:50:48 +00:00
Andrew Nacin
61ce27e467
Adjust [29634] so the Upload Plugin button can be shown. see #29236 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@29637 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-27 02:58:46 +00:00
Andrew Nacin
8564e3a491
Plugin installer: Minor adjustments to aid with discovery.
...
fixes #29387 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29636 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-27 02:52:29 +00:00
Andrew Nacin
322991024f
Plugin/Theme Uploads: New capabilities; unify UIs; ensure compatibility with old filters.
...
Introduce upload_plugins and upload_themes capabilities to allow blocking of plugin and theme uploads, versus the old hacky (and not secure) ways of just hiding UI tabs. These are simply meta capabilities that map to install_plugins and install_themes.
Also:
* Use the same nice design for the plugin upload screen as the theme upload screen.
* Better compatibility for the old install_themes_tabs filter added in [29002]. see #28578 .
* Ensure using the install_plugins_tabs filter to remove the upload tab removes the new button.
* Use 'Add Plugins' instead of 'Install Plugins' to match 'Add Themes'.
fixes #29236 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29634 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-27 01:31:05 +00:00
Helen Hou-Sandi
9252fbec58
Only show one search form for the plugin installer.
...
The field dropdown now appears in the filter bar only when doing a search.
see #28785 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29597 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 16:02:43 +00:00
Sergey Biryukov
fae5c2de6f
Install Plugins: Don't wp_die() if API can't be reached.
...
props johnbillion.
fixes #29361 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29594 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 15:01:50 +00:00
Andrew Nacin
81b52e71e4
Plugin install: Add icons to compatible/incompatible. see #29313 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@29586 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 17:25:35 +00:00
Dominik Schilling (ocean90)
19a0a5b64f
Plugin compatibility is based on your version of WordPress, not your install.
...
fixes #29313 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29581 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-24 16:13:54 +00:00
Andrew Nacin
7a504df72a
Introduce plugin icons in the installer.
...
See http://wp.me/p2AvED-2P8 for the announcement and how to implement these.
props tellyworth.
see #28785 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29569 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-21 19:10:59 +00:00
Dominik Schilling (ocean90)
ae4830351c
Plugin install: Remove columns and screen options.
...
fixes #28803 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29498 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-15 09:37:01 +00:00
Sergey Biryukov
6d6bce429d
Plugin install: Make plugin groups translatable.
...
props ocean90 for initial patch.
fixes #29092 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29477 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-13 02:30:24 +00:00
Drew Jaynes (DrewAPicture)
8feaba4ca2
Clean up some missing @access
tags and other tweaks for 4.0.0-functionality docs.
...
See #28885 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29455 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:31:35 +00:00
Scott Taylor
277d5a633e
After [29201], use aria-label
instead of aria-labelledby
in WP_Plugin_Install_List_Table::display_rows()
.
...
Props nvwd, DrewAPicture.
Fixes #28853 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29424 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 02:55:18 +00:00
Dominik Schilling (ocean90)
a2a3e10f66
Plugin install: Improve styling of the no results message.
...
see #28753 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29359 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 15:23:17 +00:00
Dominik Schilling (ocean90)
6489b16efc
Add some braces to [29225].
...
see #28673 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29350 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 21:03:48 +00:00
Dominik Schilling (ocean90)
4c0ae9bc47
Plugin install: Add missing closing HTML tags.
...
props jwenerd.
fixes #29090 . see #28673 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29348 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 20:43:26 +00:00
Andrew Nacin
3bd777fba5
Plugin Install screens: Pass locale and installed plugins to the API, for context.
...
props tellyworth.
see #17902 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29227 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 20:49:14 +00:00
Helen Hou-Sandi
446f78396a
Plugin install: display cards in groups if the API returns them with the appropriate information. props tellyworth. fixes #28673 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@29225 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 19:34:47 +00:00
Helen Hou-Sandi
1803c4c1e8
Plugin install cards:
...
* Move author attribution to its own line.
* Use `esc_url()` where appropriate.
* Better i18n.
* min-height for cards for a more even appearance.
* Show more cards on wide screens.
* Tighten up spacing below the filter bar.
props ocean90, helen. see #28785 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29219 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 06:07:21 +00:00
Helen Hou-Sandi
b0b9655b12
Install Plugins screen:
...
* Utilize the (currently-named) filter bar from the Add Themes screen.
* Move the upload link to the h2, also like the Add Themes screen.
see #28673 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29218 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 04:49:19 +00:00
Scott Taylor
283fa473e6
In Plugin Install List Table, remove title attribute for plugin action links; add screen-reader-text.
...
Props joedolson.
Fixes #28853 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29201 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:49:53 +00:00
Dominik Schilling (ocean90)
1b2386e787
Remove plugin_install_details_link
filter, which was added in [29047].
...
see #28785 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29171 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 19:49:15 +00:00
Drew Jaynes (DrewAPicture)
f77584ea2c
Inline documentation for the 'plugin_install_details_link' hook added in [29047] should use a 3-digit, x.x.x-style @since
version.
...
See #28885 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29152 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 00:09:58 +00:00
Scott Taylor
510ad2e1e9
Fix mismatches in access modifiers for WP_List_Table
+ subclasses.
...
Fixes #28843 , #28879 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29137 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 22:08:22 +00:00
Scott Taylor
63cb20cc5a
Repent for our original OOP sins and doc blocks as pertains to access modifiers in List Table + subclasses.
...
Props SergeyBiryukov.
See #28843 and [28583].
git-svn-id: https://develop.svn.wordpress.org/trunk@29118 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 03:26:40 +00:00
Helen Hou-Sandi
2a5fa0e4c5
Display plugin install results as "cards" rather than in a list table, first run.
...
props stephdau, ryelle, tellyworth, melchoyce. see #28785 , #28646 .
git-svn-id: https://develop.svn.wordpress.org/trunk@29047 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-09 20:01:35 +00:00
Andrew Nacin
65803684f4
Add a new 'Beta Testing' tab on the plugin installer, for features as plugins such as Press This.
...
fixes #28513 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28749 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-12 18:08:56 +00:00
Scott Taylor
d6a3c2a0de
Add access modifiers to methods and members of list table classes:
...
* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`
See #27881 , #22234 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28493 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 01:16:16 +00:00
Scott Taylor
31e187faa3
Eliminate use of extract()
in WP_Plugin_Install_List_Table::get_table_classes()
. It only needs to read plural
, no need to extract.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28388 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:16:39 +00:00
Sergey Biryukov
9d94ec0cad
Use filtered per_page value in WP_Plugin_Install_List_Table and WP_Theme_Install_List_Table.
...
props brasofilo.
fixes #25675 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27221 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-21 18:29:41 +00:00
Sergey Biryukov
3a1b1ba755
Remove unnecessary sprintf(). props jdgrimes. fixes #25489 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@26943 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-14 11:17:10 +00:00
Dion Hulse
696014fff5
Replace the Star ratings in the dashboard with dashicons ratings.
...
This also moves the ratings to only displaying full, half, or empty stars (ie. 3.0, 3.5, 4.0, no 3.7 ratings - which are rounded).
Fixes #26170
git-svn-id: https://develop.svn.wordpress.org/trunk@26380 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-26 02:24:25 +00:00
Drew Jaynes
8a3df7d4b4
Inline documentation for hooks in wp-admin/includes/class-wp-plugin-install-list-table.php.
...
Props naomicbush.
Fixes #25357 .
git-svn-id: https://develop.svn.wordpress.org/trunk@25630 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-26 02:47:44 +00:00