Commit Graph

33067 Commits

Author SHA1 Message Date
Pascal Birchler 64b89c09f0 Dashboard: Do not show "Search Engines Discouraged" text when the `blog_public` option is not set.
Search engines are only discouraged from indexing the site when the option is explicitly set to `0`.

Fixes #34860.

git-svn-id: https://develop.svn.wordpress.org/trunk@35873 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 22:02:27 +00:00
johnbillion 3348774d3a Ensure that all the capabilities that any users have are being tested. This ensures that if new capabilities are introduced in the future, tests will be required for them.
See #35024


git-svn-id: https://develop.svn.wordpress.org/trunk@35872 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 21:59:01 +00:00
John Blackbourn a7f713f45d Introduce tests for the `unfiltered_upload` capability, which no user should have (unless the `ALLOW_UNFILTERED_UPLOADS` constant is defined).
See #35024


git-svn-id: https://develop.svn.wordpress.org/trunk@35871 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 21:54:05 +00:00
Pascal Birchler 410aa27b1d Passwords: Hide weak password confirmation checkbox when password strength improves.
Props subharanjan for initial patch.
Fixes #34950.

git-svn-id: https://develop.svn.wordpress.org/trunk@35870 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 21:53:29 +00:00
John Blackbourn eaa8863723 Correct the hash notation documentation introduced in [34891].
See #32147


git-svn-id: https://develop.svn.wordpress.org/trunk@35869 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 20:15:54 +00:00
Drew Jaynes 91f343c461 Docs: Remove indentation from a wrapped line in the DocBlock description for `get_post_type_labels()` to prevent incorrect formatting when parsed.
With the false indentation in place, the parser for the Code Reference incorrectly interprets it as a block quote.

Fixes #35019.


git-svn-id: https://develop.svn.wordpress.org/trunk@35868 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 18:41:37 +00:00
Sergey Biryukov e01a52e878 Post Template: Pass the post ID to `the_guid` and `get_the_guid` filters.
Props danielbachhuber for initial patch.
Fixes #35015.

git-svn-id: https://develop.svn.wordpress.org/trunk@35867 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 16:38:15 +00:00
Andrea Fercia d0da333cf0 Accessibility: on the Updates screen, remove a redundant title attribute.
Removes the title attribute from the Plugin details link and adds the Plugin name hidden with `screen-reader-text` within the link text.

Props Cheffheid.
Fixes #35001.

git-svn-id: https://develop.svn.wordpress.org/trunk@35866 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 16:31:06 +00:00
Drew Jaynes fb5997f206 Administration: Improve the message displayed in the login form modal when a user's session has expired.
Props obrienlabs.
Fixes #34340.


git-svn-id: https://develop.svn.wordpress.org/trunk@35865 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 16:00:36 +00:00
Drew Jaynes 640599e8f5 Docs: Document the optional `$options` parameter for `wp_register_widget_control()` as a hash notation.
Props stephanethomas.
Fixes #34855.


git-svn-id: https://develop.svn.wordpress.org/trunk@35864 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 15:23:26 +00:00
John Blackbourn e76be26406 Add assertions for role names as capabilities in the capabilities tests. This ensures the role name is only available as a capability to the corresponding role.
See #35007


git-svn-id: https://develop.svn.wordpress.org/trunk@35863 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 11:06:28 +00:00
Gary Pendergast d498c9f0f2 About: Add a fallback `-webkit-calc()` to `about.css`
We forgot to run `grunt precommit` before [35834] was committed.

This change doesn't need to be backported to the 4.4 branch, as it only affects Chrome < 26, it's really just to clean up the behaviour of `grunt precommit`.

See #34663.




git-svn-id: https://develop.svn.wordpress.org/trunk@35862 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 03:52:26 +00:00
Eric Andrew Lewis f1b07f779f Add inline documentation for `get_page_by_path()`.
Fixes #34964.


git-svn-id: https://develop.svn.wordpress.org/trunk@35861 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 03:49:40 +00:00
ericlewis 26e7188154 Don't suppress error messages in database function calls.
Fixes #21870.


git-svn-id: https://develop.svn.wordpress.org/trunk@35860 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 03:39:52 +00:00
Gary Pendergast 957697adf0 Build Tools: Update grunt-contrib-imagemin to v1.0.0
This updates `imagemin` to 4.0.0, which fixes an error when running `grunt imagemin:core`.

Props netweb.

Fixes #35003.



git-svn-id: https://develop.svn.wordpress.org/trunk@35859 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 03:37:36 +00:00
Boone Gorges 4c1c287413 Be sure to force-delete when cleaning up fixtures in `get_comment_link()` tests.
Introduced in [35857].

Mega-super-anti-props boonebgorges.

git-svn-id: https://develop.svn.wordpress.org/trunk@35858 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 02:46:37 +00:00
Boone Gorges 3626449004 Share fixtures in `get_comment_link()` tests.
See #30017.

git-svn-id: https://develop.svn.wordpress.org/trunk@35857 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-11 02:26:43 +00:00
Dominik Schilling (ocean90) ab584ff499 L10n: Use an absolute path for the `is_dir()` check when looking for installed translations.
Avoids warnings when `open_basedir` restrictions are in effect.

Props Profforg.
Fixes #34526.

git-svn-id: https://develop.svn.wordpress.org/trunk@35856 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-10 23:08:46 +00:00
Andrea Fercia 56dc5b5b30 Updates screen: make the new strings introduced in [35854] translatable.
Props walbo.
Fixes #34763.

git-svn-id: https://develop.svn.wordpress.org/trunk@35855 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-10 19:23:30 +00:00
Andrea Fercia f207e68c27 Accessibility: the iframes used for the update progress in the Updates screen need title attributes to describe their content.
Fixes #34763.

git-svn-id: https://develop.svn.wordpress.org/trunk@35854 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-10 17:20:18 +00:00
Rachel Baker d13adcc9bf Comments: Comments don’t need no Post ID when created, so they don’t be needing one to be edited.
In `wp_update_comment()` only check if the given `comment_post_ID` is valid if it isn’t `0`.  This allows comments that were created programmatically via `wp_insert_comment()` without the (optional) `comment_post_ID` parameter to be edited.

Props subharanjan for the initial patch.
Fixes #34954



git-svn-id: https://develop.svn.wordpress.org/trunk@35853 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-10 15:16:51 +00:00
Boone Gorges 52384c2e6b Improve handling for `WP_Error` objects in `get_the_terms()`.
`wp_get_object_terms()` can return a `WP_Error` object. As such, the
`get_the_terms()` cache wrapper should handle them properly. To wit:

* Don't try to map an error object to `get_term()`. Introduced in [35032].
* Don't cache an error object as taxonomy relationships. Introduced in at least [16487], maybe earlier.

Props stephenharris.
Fixes #34723.

git-svn-id: https://develop.svn.wordpress.org/trunk@35850 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-10 03:34:51 +00:00
John Blackbourn ad338fb3d0 Comments: Commit tests missed in [35848].
See #28617


git-svn-id: https://develop.svn.wordpress.org/trunk@35849 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-10 03:15:44 +00:00
John Blackbourn c4cf5124ca Comments: The year is 2003. Permalinks are a new thing and everyone's using Blogger. It's a time when opening a modal window in JavaScript to view a section of a website is not a completely weird thing, although many users get annoyed by it. b2 has recently become WordPress, and with it comes a bunch of functionality that will become stale over the next decade, remnants of simpler times.
Twelve years later, after no fewer than three themes have intentionally implemented popup comments in their functionality, before being abandoned for at least the last six years, we've reached a time where we can put this era behind us. A time when we can remove comment popup functionality from WordPress.

If this breaks the internet, I'll eat my hat.

Fixes #28617


git-svn-id: https://develop.svn.wordpress.org/trunk@35848 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-10 03:05:34 +00:00
John Blackbourn c2f597280b Formatting: Don't make links inside `<script>` and `<style>` tags clickable.
Fixes #30162
Props ninos-ego, adamsilverstein


git-svn-id: https://develop.svn.wordpress.org/trunk@35847 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-09 23:54:24 +00:00
Andrea Fercia 08f67db8a3 Accessibility: remove no-purpose title attributes from the login screen.
Also, it's hard to convey the ironic tone of the sentences used for these title attributes in languages other than English.

Fixes #34943.

git-svn-id: https://develop.svn.wordpress.org/trunk@35846 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-09 22:19:01 +00:00
Rachel Baker 7d1436ffb7 Docs: Better param descriptions and fix incorrect param name within REST API deprecated functions
`rest_handle_deprecated_function`: you get better parameter descriptions.
`rest_handle_deprecated_argument`: you get a corrected parameter name ($replacement->$message), appropriate i18n translation hints, and better parameter descriptions.

Props ocean90.
Fixes #34908



git-svn-id: https://develop.svn.wordpress.org/trunk@35845 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-09 21:25:15 +00:00
Drew Jaynes 3e57adcf39 Docs: Move the hook doc for the `view_mode_post_types` filter to directly precede the `apply_filters()` line.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35844 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-09 16:16:07 +00:00
Dominik Schilling (ocean90) 0339d7d145 About Page: Add release video and update post embed.
Props camikaos, siobhan, rosso99, wonderboymusic.
See #34663.

git-svn-id: https://develop.svn.wordpress.org/trunk@35839 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-08 23:22:25 +00:00
Dominik Schilling (ocean90) a6e6501fc8 Install/Upgrade: Keep indexing bots away until a site is ready to be seen.
git-svn-id: https://develop.svn.wordpress.org/trunk@35837 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-08 21:55:48 +00:00
Scott Taylor 6c2de78c9c About Page: use ReverbNation instead of Cloudup to avoid Ad Blocker cruff with tracking pixels. Adjust the layout accordingly, and improve the layout at smaller breakpoints.
Props melchoyce.
See #34663.


git-svn-id: https://develop.svn.wordpress.org/trunk@35834 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-08 20:24:52 +00:00
Dominik Schilling (ocean90) 2f7d3c9163 About Page: Remove three superfluous parentheses.
Props jaspermdegroot.
See #34663.

git-svn-id: https://develop.svn.wordpress.org/trunk@35833 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-08 18:14:57 +00:00
Dominik Schilling (ocean90) 4669e09241 About Page: Use w.org CDN for images.
See #34663.

git-svn-id: https://develop.svn.wordpress.org/trunk@35832 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-08 17:56:33 +00:00
Michael Arestad 492b67cc74 Administration: Adds a height to number inputs.
Number inputs didn't match the height of other form elements. Now they have a height of 28px and 40px on mobile. Both align with the sizes of other elements.

Props valendesigns. 
Fixes #28984.


git-svn-id: https://develop.svn.wordpress.org/trunk@35831 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-08 16:07:00 +00:00
Dominik Schilling (ocean90) 07f0443526 Bundled Themes: Update POT files.
See #34804.

git-svn-id: https://develop.svn.wordpress.org/trunk@35829 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-08 15:18:00 +00:00
Scott Taylor 70cba0dc0e About Page: use the source of the Make/Core Embed response instead of discovering it (or reading from the cache) every time.
See #34663.


git-svn-id: https://develop.svn.wordpress.org/trunk@35826 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-08 03:37:22 +00:00
Scott Taylor b67ed6e9b5 About Page: use `srcset` for images, also known as Recursive Dogfooding.
Props joemcgill.
See #34663.


git-svn-id: https://develop.svn.wordpress.org/trunk@35825 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-08 03:32:37 +00:00
Dominik Schilling (ocean90) 485ccc6ab2 About Page: Add Cloudup embed and cache the embeds as site transients.
Props wonderboymusic.
See #34663.

git-svn-id: https://develop.svn.wordpress.org/trunk@35823 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-07 23:27:32 +00:00
Rachel Baker 5ddbe89dc8 REST API: Make strings translatable in `register_rest_route`.
Adds i18n to the `doing_it_wrong()` messages for invalid parameters within `register_rest_route()`.

Props Latz,danielbachhuber.
Fixes #34902



git-svn-id: https://develop.svn.wordpress.org/trunk@35822 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-07 22:39:25 +00:00
Mike Schroder 5b025834f9 Media: Don't generate responsive image attributes if `src` does not match ID in `wp-image-` class.
We rely on the `wp-image-` class to quickly find an attachment ID to add responsive image attributes.
To avoid incorrect images being displayed, do not add these attributes if the `src` does not match the
meta from the attachment ID in the class.

Props azaozz, kovshenin, joemcgill.
Fixes: #34898.


git-svn-id: https://develop.svn.wordpress.org/trunk@35820 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-07 20:07:37 +00:00
Dominik Schilling (ocean90) 333d2f205a List Tables: Revert [34728] and [35482].
Part of [34728] was already reverted in [35682], but the default values still made it impossible to set a default ordering for custom post types.

See #25493.
See #34825.

git-svn-id: https://develop.svn.wordpress.org/trunk@35818 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-07 19:15:16 +00:00
Joe Hoyle 0a2a83056c Prevent unnecessary $wpdb->update() when hierarchical post doesn't have children.
Props danielbachhuber.
Fixes #34896.


git-svn-id: https://develop.svn.wordpress.org/trunk@35817 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-07 17:46:35 +00:00
Mel Choyce 57a81709a4 About: Update image of the Twenty Sixteen red color scheme so it matches the updated scheme color.
See #34663.


git-svn-id: https://develop.svn.wordpress.org/trunk@35816 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-07 17:07:37 +00:00
Pascal Birchler 4868527c04 Docs: After [35314], fix the DocBlock for `url_shorten()`.
See #20166.

git-svn-id: https://develop.svn.wordpress.org/trunk@35813 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-07 16:38:24 +00:00
Dominik Schilling (ocean90) a850b67ce2 About: Sync tagline from about page with credits and freedoms.
See #34663.

git-svn-id: https://develop.svn.wordpress.org/trunk@35812 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-07 16:16:48 +00:00
Ella Iseulde Van Dorpe 14c3f3c871 Make date format consistent across the admin
The 'date_format' and 'time_format' options shouldn't affect the backend.

See #30864



git-svn-id: https://develop.svn.wordpress.org/trunk@35811 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-07 04:25:53 +00:00
Weston Ruter f57e09f0fc Customizer: Apply `customize_dynamic_setting_class` and `customize_dynamic_setting_args` filters in calls to `WP_Customize_Manager::add_setting( $id, $args )`.
Ensure that plugin filters apply as expected for any settings registered statically without passing in an explicit class instance to `WP_Customize_Manager::add_setting()`.

Fixes #34597.


git-svn-id: https://develop.svn.wordpress.org/trunk@35810 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 23:21:46 +00:00
Michael Adams (mdawaffe) 0eb87d02c5 Meta Boxes: Preserve radio inputs' state when sorting metaboxes.
When sorting a metabox, a clone of that metabox is created as a drag/drop "helper".
Previously, any checked radio input in the original metabox would become unchecked, when its clone "helper" was inserted into the DOM
(since only one radio within a set of radios of the same name can be checked).

Continued use of the clone helper is important so that the element being dragged isn't subject to the click and other event handlers attached to the real metabox,
so we can't just switch to dragging around the real metabox.  See, for example, comment:10:ticket:16972.

Preserve the radios' state via some name attribute trickery.

Fixes #16972


git-svn-id: https://develop.svn.wordpress.org/trunk@35809 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 22:22:44 +00:00
Helen Hou-Sandi 093707c534 Plugins: Provide a link to searching the plugin directory when no search results are found.
Many new users do not know the difference between managing installed plugins and those found in the plugin directory. This helps with discoverability. The link is not provided in multisite installs because we assume that somebody with that kind of power in a network is experienced enough not to need it. This can always be reconsidered later.

props mordauk for the initial patch.
fixes #29865.


git-svn-id: https://develop.svn.wordpress.org/trunk@35808 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 22:22:11 +00:00
Mel Choyce c2dc14c159 Twenty Eleven/Docs: Remove duplicate "can" from footer template.
See #34885.


git-svn-id: https://develop.svn.wordpress.org/trunk@35807 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 22:11:53 +00:00