Commit Graph

28765 Commits

Author SHA1 Message Date
John Blackbourn 28f8566630 Improve the `doing_it_wrong()` text for `title-tag` theme support.
Props ocean90
Fixes #18548


git-svn-id: https://develop.svn.wordpress.org/trunk@30787 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-08 16:05:34 +00:00
Jeremy Felt 0ae462657d Clean up factory arguments in ms-sites group.
* Arguments for user, path, and title are only necessary when we need to do something with those arguments later. Most cases in the ms-sites group do not require them.
* In `test_get_blog_id_from_url_is_case_insensitive()`, we should pass a lowercase domain argument.
* A user factory in `test_switch_restore_blog()` is not necessary.

See #30080


git-svn-id: https://develop.svn.wordpress.org/trunk@30786 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-08 02:32:53 +00:00
Jeremy Felt a4c7261823 Split current tests for `update_blog_status()`
The current tests for `update_blog_status()` mirrored the tests for `update_blog_details()` in many ways and can be split in the same way. A noticeable difference is that the the matching actions fire even when no change is made to a field.

See #30080


git-svn-id: https://develop.svn.wordpress.org/trunk@30785 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-08 02:14:21 +00:00
Jeremy Felt 7a8bceabaa Split current tests for `update_blog_details()`
The current tests for `upload_blog_details()` were focused on the actions fired whenever a site is marked as spam, archived, deleted, or matured. This breaks those into individual sections with fewer assertions per test.

See #30080


git-svn-id: https://develop.svn.wordpress.org/trunk@30784 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-08 01:43:31 +00:00
Scott Taylor 0b157bf069 Incorporate https://github.com/johndyer/mediaelement/pull/1385 into our custom build of MediaElement 2.16.2.
Props bradyvercher.
Fixes #30281.


git-svn-id: https://develop.svn.wordpress.org/trunk@30783 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 23:58:46 +00:00
Andrew Ozz c8e8281a05 Plugins: move the recommender results to a separate tab. Any outstanding quality issues will be fixed on the API side without needing core changes. Props tellyworth, fixes #30337.
git-svn-id: https://develop.svn.wordpress.org/trunk@30782 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 23:39:54 +00:00
Andrew Ozz 51272ff656 Twenty Fifteen: add spaces after screen reader text strings to make them readable. Props nvwd, pavelevap, afercia. Fixes #30606.
git-svn-id: https://develop.svn.wordpress.org/trunk@30781 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 23:27:42 +00:00
Andrew Ozz 8719a8a8b0 Media: ensure the toolbar is shown after leaving iframe-based content. Props mcsf, fixes #30608.
git-svn-id: https://develop.svn.wordpress.org/trunk@30780 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 21:11:23 +00:00
Drew Jaynes (DrewAPicture) 3913b26b24 Fix formatting in the DocBlock for `wp_get_sidebars_widgets()`.
See #30315.


git-svn-id: https://develop.svn.wordpress.org/trunk@30779 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 20:14:10 +00:00
Drew Jaynes (DrewAPicture) 02f8434c28 Flesh out and fix formatting in the DocBlock for `wp_register_widget_control()`.
Includes:
* Added todos for documenting `$options` in the hash notation style
* Backtick-escaping and general formatting

See #30315.


git-svn-id: https://develop.svn.wordpress.org/trunk@30778 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 20:12:50 +00:00
Scott Taylor a0c600a121 When using the spacebar to select something in "bulk select" mode, don't scroll the page.
Props avryl.
Fixes #30622.


git-svn-id: https://develop.svn.wordpress.org/trunk@30777 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 20:10:56 +00:00
Drew Jaynes (DrewAPicture) 292a65f737 Flesh out information in the DocBlock for `wp_register_sidebar_widget()`.
Includes:
* Documenting the `$options` parameter in hash notation style
* Converting `@uses` tags to `@global`
* Various backtick-escaping.

See #30315.


git-svn-id: https://develop.svn.wordpress.org/trunk@30776 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 20:10:37 +00:00
Andrew Ozz 1a8c0b9254 TinyMCE: return focus to the editor after closing the image toolbar. Props afercia, see #27642.
git-svn-id: https://develop.svn.wordpress.org/trunk@30775 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 20:07:22 +00:00
Drew Jaynes (DrewAPicture) 3e0e0f453e Introduce documentation for three methods in `WP_Widget_Factory`: `register()`, `unregister()`, `_register_widgets()`.
See #30315.


git-svn-id: https://develop.svn.wordpress.org/trunk@30774 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 20:07:05 +00:00
Drew Jaynes (DrewAPicture) 3c1a8e1407 Introduce documentation for the `$id_base`, `$name`, `$widget_options`, `$control_options`, `$number`, `$id`, and `$updated` properties in `WP_Widget'.
See #30315.


git-svn-id: https://develop.svn.wordpress.org/trunk@30773 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 20:04:43 +00:00
Drew Jaynes (DrewAPicture) ac47dd2cd0 Tweak formatting in the DocBlock for the `install_themes_tabs` hook.
Props kpdesign.
See #28578.


git-svn-id: https://develop.svn.wordpress.org/trunk@30772 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 18:40:03 +00:00
Boone Gorges 98d17497d2 In `WP_Query::get_queried_object()`, use the new format for referencing tax query clauses.
`queried_terms`, rather than `queries`, is the tax_query property where a flat
index of terms is stored.

See [29901] for a similar fix in `redirect_canonical()`. See #29738.

Props dd32.
Fixes #30623.

git-svn-id: https://develop.svn.wordpress.org/trunk@30771 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 14:57:53 +00:00
Drew Jaynes (DrewAPicture) 2f25ec0773 Document the default arguments for `the_widget()` in the hash notation style.
Props coffee2code.
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@30770 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 11:03:51 +00:00
Drew Jaynes (DrewAPicture) bf507bd3d0 Document the default arguments for `register_sidebars()` in the hash notation style.
Props coffee2code.
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@30769 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 11:00:57 +00:00
Drew Jaynes (DrewAPicture) a82a0df5f9 Improve inline documentation for `wpdb::has_cap()`.
Adds a changelog entry for the addition of the 'utf8mb4' feature, accepted values for `$db_cap`, and a return description.

Props kpdesign.
See #21212.


git-svn-id: https://develop.svn.wordpress.org/trunk@30768 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 05:22:42 +00:00
Drew Jaynes (DrewAPicture) 2b8a662873 Fix a typo in the DocBlock for `WP_Http_Curl::$bytes_written_total` introduced in [29968].
Props kpdesign.
See #26726.


git-svn-id: https://develop.svn.wordpress.org/trunk@30767 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 05:15:50 +00:00
Dion Hulse 8a5ea24f61 In the `links_add_base()` callback, use a HTTP-aware URL joining function, rather than a filesystem joining function to avoid PHP warnings on certain systems.
Fixes #29950


git-svn-id: https://develop.svn.wordpress.org/trunk@30766 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 03:18:06 +00:00
Dion Hulse 1a43dda77b WP_HTTP: Revert r30491 which updated the bundled root certificates. There's a report that this is breaking under certain PHP/OpenSSL versions (which we've encountered before), and we're safer with a slighty out of date CA bundle than breaking HTTPS communication on affected sites.
See #30434


git-svn-id: https://develop.svn.wordpress.org/trunk@30765 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 03:12:14 +00:00
Andrew Ozz 549006887b Admin toolbar: remove unneeded overrides of `z-index` and `left` on screens narrower than 782px. Props avryl, babbardel. Fixes #29867.
git-svn-id: https://develop.svn.wordpress.org/trunk@30764 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 03:00:35 +00:00
Andrew Ozz 958fa3180d Twenty Fifteen: clean up of `twentyfifteen_color_scheme_css_template()` in customizer.php. Props iamtakashi. Fixes #30601.
git-svn-id: https://develop.svn.wordpress.org/trunk@30763 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 02:39:22 +00:00
Andrew Ozz fce20e9784 Better docs for `Plugin_Upgrader::deactivate_plugin_before_upgrade()`. Props DrewAPicture. Fixes #29088.
git-svn-id: https://develop.svn.wordpress.org/trunk@30762 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 01:18:21 +00:00
Andrew Ozz d948f0bf32 Always return a value in `Plugin_Upgrader::deactivate_plugin_before_upgrade()`. Props jdgrimes. Fixes #29088.
git-svn-id: https://develop.svn.wordpress.org/trunk@30761 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 00:52:06 +00:00
Andrew Ozz af5c93a432 Customizer - Widgets: add feedback for screen readers when moving up or down. Props adamsilverstein, afercia. Fixes #28892.
git-svn-id: https://develop.svn.wordpress.org/trunk@30760 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 00:44:49 +00:00
Drew Jaynes (DrewAPicture) ae45b7462b Restore missing line in DocBlock for `WP_Tax_Query::get_sql_for_clause()`.
Props kpdesign.
See [30622], #30469.


git-svn-id: https://develop.svn.wordpress.org/trunk@30759 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 00:38:48 +00:00
Drew Jaynes (DrewAPicture) 3cdbc730d3 Add missing DocBlocks and parameter descriptions for a wide variety of properties and methods in `WP_Upgrader`, `Plugin_Upgrader`, `Theme_Upgrader`, `Language_Pack_Upgrader`, `Core_Upgrader`, and `File_upload_Upgrader`.
Props jdgrimes, DrewAPicture.

See #29086.


git-svn-id: https://develop.svn.wordpress.org/trunk@30758 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-07 00:25:44 +00:00
Andrew Ozz 08021593f3 TinyMCE, improve accessibility:
- Return focus to the editor on pressing Escape while the image toolbar is focused.
- Add a Close button to the Help modal and close it on Escape.
- Override the title on the editor iframe (read by screen reader apps), replace with the Alt+Shift+H shortcut.
- Add focus shortcuts descriptions to the Help modal.
Fixes #27642.

git-svn-id: https://develop.svn.wordpress.org/trunk@30757 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 23:52:25 +00:00
Drew Jaynes (DrewAPicture) 716984e94d Add a blank line preceding a Markdown-formatted ordered list in the DocBlock for the `admin_body_class` filter.
Props kpdesign.
See #30558.


git-svn-id: https://develop.svn.wordpress.org/trunk@30756 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 23:20:12 +00:00
Drew Jaynes (DrewAPicture) fffbee4ac7 Fix a typo in the return description for `get_sample_permalink()`.
Props TobiasBg.
Fixes #30591.


git-svn-id: https://develop.svn.wordpress.org/trunk@30755 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 21:45:12 +00:00
John Blackbourn 7082b703b2 Improve various hook and filter docs so they are correctly parsed for the code reference.
Fixes #30558
Props DrewAPicture


git-svn-id: https://develop.svn.wordpress.org/trunk@30754 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 21:31:41 +00:00
Drew Jaynes (DrewAPicture) 7187da0b32 Convert various uses of `(optional)` in core parameter descriptions to use the style prescribed in the inline documentation standards for PHP.
The style for marking parameters optional in inline PHP docs is: `@param type $var Optional. Description. Accepts. Default.`, where Accepts can be omitted on a case-by-case basis.

Props coffee2code.
Fixes #30591.


git-svn-id: https://develop.svn.wordpress.org/trunk@30753 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 21:23:52 +00:00
Mark Jaquith 71bb091cc3 Revert [28719] and no longer math-process multiplication of negative numbers
see #19308
fixes #30445
props rmccue

git-svn-id: https://develop.svn.wordpress.org/trunk@30752 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 21:23:12 +00:00
Boone Gorges 5d259386be Remove `<code>` tags from translatable string in `WP_Date_Query`.
This was missed in [30300]. See #25834.

Props ramiy.
Fixes #30612.

git-svn-id: https://develop.svn.wordpress.org/trunk@30751 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 02:37:49 +00:00
Boone Gorges 5b6c00274d Use `wp_checkdate()` when checking date validity in `WP_Date_Query`.
See #25834.

git-svn-id: https://develop.svn.wordpress.org/trunk@30750 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 02:28:41 +00:00
Andrew Ozz 578a50acca Editor DFW v2: fade out the Screen Options/Help tabs when open. Props avryl, fixes #30593.
git-svn-id: https://develop.svn.wordpress.org/trunk@30749 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 00:49:21 +00:00
Andrew Ozz 6f43327574 TinyMCE: manually fire `ExecCommand` when aligning images as we do `preventDefault()` on `BeforeExecCommand` for them. Props avryl, fixes #30565.
git-svn-id: https://develop.svn.wordpress.org/trunk@30748 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 00:32:18 +00:00
Andrew Ozz a3367bcee3 Themes screen: fix the position of the search field. Props jesin, fixes #29556.
git-svn-id: https://develop.svn.wordpress.org/trunk@30747 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 00:12:25 +00:00
Andrew Ozz 501206feef Twenty Twelve: menu on touch devices: fix jQuery selector for menu items with submenus. props babbardel, fixes #24767.
git-svn-id: https://develop.svn.wordpress.org/trunk@30746 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-05 22:58:12 +00:00
Drew Jaynes (DrewAPicture) 4315ce7f9d Document the default arguments for `register_sidebar()` in the hash notation style.
Props coffee2code.
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@30745 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-05 03:37:48 +00:00
Drew Jaynes (DrewAPicture) 46bbcf649a Add missing documentation for the `xmlrpc_element_limit` hook in wp-includes/class-IXR.php.
Props ankitgadertcampcom, kpdesign.
Fixes #29977.


git-svn-id: https://develop.svn.wordpress.org/trunk@30744 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-05 03:27:02 +00:00
Andrew Ozz 492b8db722 Editor: fix initial state for editor-expand when TinyMCE is disabled or not supported. Props avryl, fixes #30592.
git-svn-id: https://develop.svn.wordpress.org/trunk@30743 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-05 01:52:46 +00:00
Andrew Nacin 96dee2af62 Adjust [29806] and revert [29807] to restore placeholder and email copy order.
Avoids unnecessarily changing a (large, carefully formatted) translated string from 4.0.

fixes #21089.


git-svn-id: https://develop.svn.wordpress.org/trunk@30742 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-05 01:14:03 +00:00
Ian Stewart 04029d8ce2 Twenty Fifteen: updating customizer label text for more clarity.
Props iamtakashi, fixes #30545.



git-svn-id: https://develop.svn.wordpress.org/trunk@30741 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-04 22:56:31 +00:00
Helen Hou-Sandi 10d40a7801 Filter bar: Better field display on smaller screens.
props TacoVerdo, jesin.
fixes #29556 and #29495.


git-svn-id: https://develop.svn.wordpress.org/trunk@30740 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-04 22:22:26 +00:00
John Blackbourn 99c61f2201 Correct the default value of the `show_split_view` argument for revisions so they are correctly displayed side by side ins
tead of inline.

Fixes #24908


git-svn-id: https://develop.svn.wordpress.org/trunk@30739 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-04 14:35:02 +00:00
Scott Taylor 23a0766a6d Add some inline JS docs for Customizer.
See #30469.


git-svn-id: https://develop.svn.wordpress.org/trunk@30738 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-04 02:03:30 +00:00