Commit Graph

307 Commits

Author SHA1 Message Date
Andrew Nacin d0d07cf614 Updates: Saner stats and rollback handling. WP.org now collects basic stats on non-auto updates as they have been hugely informative.
props dd32 for initial patch.
fixes #25657.


git-svn-id: https://develop.svn.wordpress.org/trunk@25863 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 09:48:36 +00:00
Andrew Nacin bce2656e6d Move upgrader_process_complete for core to its proper place in Core_Upgrader.
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.

props dd32.
fixes #25659.


git-svn-id: https://develop.svn.wordpress.org/trunk@25861 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 04:36:54 +00:00
Andrew Nacin 597e82e94c Rename the automatic_updates_send_email filter to auto_core_update_send_email. (Final name change.)
fixes #25653. Also:
 * Fully document all new hooks, methods, and classes in the upgrader.
 * Rename 'language' to 'translation' inside the upgrader.
 * Improve the readability of the crazy do-while loop in the is_vcs_checkout() method.


git-svn-id: https://develop.svn.wordpress.org/trunk@25859 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-21 22:28:07 +00:00
Drew Jaynes a6d9b5e57a Improve inline documentation for hooks in wp-admin/customize.php.
Props kpdesign.
Fixes #25444.


git-svn-id: https://develop.svn.wordpress.org/trunk@25858 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-21 21:17:00 +00:00
Andrew Nacin d96b64c116 Commit [25823] should not have renamed AUTOMATIC_UPDATER_DISABLED to AUTOMATIC_UPDATES_DISABLED.
The proper constant is AUTOMATIC_UPDATER_DISABLED. Keep the filter in line with that too.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25851 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 21:23:43 +00:00
Dominik Schilling (ocean90) 5d7ee6ce93 Vendor-prefixes for [25845]. props jorbin. see #25603.
git-svn-id: https://develop.svn.wordpress.org/trunk@25849 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 19:24:18 +00:00
Andrew Nacin 278b180b2f About page: Prevent the meter from briefly sticking on 'Strong' when the animation resets.
props jorbin.
see #25603.


git-svn-id: https://develop.svn.wordpress.org/trunk@25848 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 18:49:47 +00:00
Andrew Nacin c85914b57e Since we're dealing with a huge password meter, don't bold half of the result strings unnecessarily. see #25603.
git-svn-id: https://develop.svn.wordpress.org/trunk@25847 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 18:36:01 +00:00
Dominik Schilling (ocean90) 476e4a4778 IE7: Fix width of the password input field on the about page. see #25603.
git-svn-id: https://develop.svn.wordpress.org/trunk@25846 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 17:57:08 +00:00
Andrew Nacin f4bf16102d About page: Use box-sizing: border-box on the password meter so pixels line up.
Also eliminates a duplicate width: 100% property.

fixes #25603.


git-svn-id: https://develop.svn.wordpress.org/trunk@25845 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 17:46:54 +00:00
Dominik Schilling (ocean90) 3b56df670e CSS cleanup for the about page.
Also fixes for IE and support for RTL.

see #25603.

git-svn-id: https://develop.svn.wordpress.org/trunk@25844 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 17:35:39 +00:00
Andrew Nacin fda5b39db2 Use correct variable. fixes #10787.
git-svn-id: https://develop.svn.wordpress.org/trunk@25843 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 17:15:36 +00:00
Andrew Nacin a028b8f2dc Use full paths to images so they work on wp-admin/network/about.php and user/about.php. see #25603.
git-svn-id: https://develop.svn.wordpress.org/trunk@25842 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 16:50:00 +00:00
Andrew Nacin 0b22aae62d Notify administrators of successful, failed, and pending core updates.
Blocks future background updates after critical failures, but allow retries in certain situations. More in the ticket.

fixes #10787.


git-svn-id: https://develop.svn.wordpress.org/trunk@25841 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 16:29:16 +00:00
Andrew Nacin 77730d6377 Remove rarr from about page text. Use a subtle background instead.
props markjaquith.
see #25603.


git-svn-id: https://develop.svn.wordpress.org/trunk@25840 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 08:41:40 +00:00
Andrew Nacin 6810bc9069 Awesome about page design for WordPress 3.7.
The page includes a giant password meter that serves as both an animated example and a working demo. How cool is that?

props jorbin, melchoyce.
see #25603.


git-svn-id: https://develop.svn.wordpress.org/trunk@25839 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 08:10:43 +00:00
Andrew Nacin 142d8c3d30 Delete expired transients on database upgrades.
Reverts [25416], which had all transients being cleared. This leaves much to be desired, but we don't want a core update to be blamed for breaking a site that incorrectly assumes transients aren't transient.

props dartiss, pento.
fixes #20316.


git-svn-id: https://develop.svn.wordpress.org/trunk@25838 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 07:47:44 +00:00
Andrew Nacin 92c2bc7797 Introduce email templates for automatic background updates.
The four templates are:
 1. We successfully updated their site. If any of their themes or plugins are out of date, it also mentions that. ('success')
 2. We are not configured to update their site, so we notify them of the new release. ('notify')
 3. We tried but failed to update their site. The error was early in the process, so no harm, no foul. This is the same as template #2, plus one sentence. ('fail')
 4. We tried to update their site, and failed while copying files. ('critical')

With assistance from markjaquith.

see #10787.


git-svn-id: https://develop.svn.wordpress.org/trunk@25837 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-18 06:32:27 +00:00
Andrew Nacin aa4635548d set_current_screen() is now unnecessary in Automatic_Upgrader_Skin, which is good because it breaks things in the network admin.
fixes #25622.


git-svn-id: https://develop.svn.wordpress.org/trunk@25836 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 23:23:42 +00:00
Andrew Nacin 8cb344e237 In automatic background updates, standardize on 'update'.
New, final filter names:
 * auto_update_{$type} (plugin, theme, core, language)
 * automatic_updates_is_vcs_checkout
 * automatic_updates_disabled

New class name is WP_Automatic_Updater. Method names include update() and should_update().

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25835 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 23:20:56 +00:00
Andrew Nacin ba10ec2cba Remove redundant code. see #25603, #22704, [25833].
git-svn-id: https://develop.svn.wordpress.org/trunk@25834 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 20:29:12 +00:00
Andrew Nacin ab77984329 Check if background core updates are supported on about.php.
see #25603, #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25833 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 20:28:38 +00:00
Andrew Nacin f555490bee Update the text for the about page, so translators can get started. Design is in flux.
props nacin, markjaquith, jorbin, jenmylo.
see #25603.


git-svn-id: https://develop.svn.wordpress.org/trunk@25832 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 20:16:36 +00:00
Dion Hulse 3ce626a96b Silence PHP warnings from disk_free_space(). disk_free_space() will produce a warning in error conditions in addition to returning false, this includes a case where the bytes free is greater than PHP_INT_MAX (which is a error condition we don't need to check).
See #25576, #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25831 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 18:39:04 +00:00
Drew Jaynes 8166a14066 Inline documentation for hooks in wp-admin/options-general.php.
Props siobhyb for the initial patch.
Fixes #25454.


git-svn-id: https://develop.svn.wordpress.org/trunk@25830 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 06:17:20 +00:00
Drew Jaynes eb3d658b7e Inline documentation for hooks in wp-admin/options-discussion.php.
Props siobhyb, ericlewis.
Fixes #25453.


git-svn-id: https://develop.svn.wordpress.org/trunk@25829 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 05:59:54 +00:00
Dion Hulse d2d9b963a2 For Background updates, ensure that only one update process runs at the same time by using the options table as a lock.
This prevents multiple cron spawns and/or long-running updates from causing multiple update processes to spin up.
This also fixes a case where the upgrader might kick in for ( ! is_main_network() || ! is_main_site() ) in mulisite installs.
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25828 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 05:23:35 +00:00
Drew Jaynes 5de9864891 Inline documentation for hooks in wp-admin/customize.php.
Props andg, rzen.
Fixes #25444.


git-svn-id: https://develop.svn.wordpress.org/trunk@25826 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 04:52:38 +00:00
Andrew Nacin 4644bb87f6 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25825 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 04:01:06 +00:00
Andrew Nacin c39143fd2e Make WP_Automatic_Upgrader a proper object that gets instantiated. Renames nearly all of its methods.
Also renames wp_auto_updates_maybe_update() to wp_maybe_auto_update().

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25823 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 00:54:15 +00:00
Dion Hulse d0bd68cf5f Remove a duplicate semicolon that snuck in. Props JustinSainton. See #18200
git-svn-id: https://develop.svn.wordpress.org/trunk@25822 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-17 00:11:25 +00:00
Drew Jaynes 0edc7a4087 Inline documentation for hooks in wp-admin/custom-header.php.
Props gizburdt for the initial patch.
Fixes #25443.


git-svn-id: https://develop.svn.wordpress.org/trunk@25821 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-16 23:25:30 +00:00
Andrew Nacin c471399eee "Future security updates will be applied automatically." see #22704.
git-svn-id: https://develop.svn.wordpress.org/trunk@25820 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-16 23:05:23 +00:00
Drew Jaynes ff4c82bd7b Inline documentation for hooks in wp-admin/edit-form-advanced.php.
Props ericlewis.
Fixes #25434.


git-svn-id: https://develop.svn.wordpress.org/trunk@25819 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-16 22:58:21 +00:00
Dion Hulse d5aba84213 Allow the WordPress.org Language update API to disallow automated background updates for a specific language pack. See #18200
git-svn-id: https://develop.svn.wordpress.org/trunk@25818 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-16 22:26:47 +00:00
Dion Hulse 853c9a50bd When a plugin enables Background Plugin updates, don't deactivate the plugin during update as we require a browser to reactivate it afterwards. See #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25817 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-16 19:47:21 +00:00
Andrew Nacin 4bcad55280 Update the banner for update-core.php that tells users they are set up for security updates to happen in the background.
"This site is set up to install security updates of WordPress automatically. Cool!"

Checkmark is a placeholder; we'll tinker with this further today.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25816 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-16 19:40:02 +00:00
Andrew Nacin 977ca48a58 Merge the should_auto_update() and can_auto_update() methods. see #22704.
git-svn-id: https://develop.svn.wordpress.org/trunk@25815 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-16 19:34:05 +00:00
Dion Hulse aa5c907e40 Fix a issue where the translation name isn't showing up in the Background Update emails, caused by a PHP Warning/missing variable in [25806]. See #18200
git-svn-id: https://develop.svn.wordpress.org/trunk@25812 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-16 17:06:58 +00:00
Dion Hulse 549029393f Avoid a few PHP Warnings when files don't exist and use a better method to locate the local filepath.
See #18201


git-svn-id: https://develop.svn.wordpress.org/trunk@25811 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-16 15:19:59 +00:00
Andrew Nacin e192eb396e Include translations in the update bubbles (as +1 if there are any). see #18200.
git-svn-id: https://develop.svn.wordpress.org/trunk@25810 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-16 14:33:21 +00:00
Dion Hulse 96aa66a924 Remove the no longer used Headerless_Upgrader_Skin class, it's been replaced by Language_Pack_Upgrader_Skin.
See #18200, [25806]


git-svn-id: https://develop.svn.wordpress.org/trunk@25807 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-16 04:18:12 +00:00
Dion Hulse ddaaa6d88a Language Packs: Many many fixes such as:
- Add a "Update Translations" stand-alone button to the updates page
- Shift Language feedback to before update process completion action links & limit the verbosity of output (name + success/errors)
- Simplify/combine the language update descriptive string to only include a plugin/theme name
- Properly handle cache clearing after language updates to prevent langs being repeditively updated
- Display a "All items up to date" string when there's nothing to do
- Reduce the 'Connection Information' from a <h2> to a <h3> to remove duplicate h2's and screen icons from update screens
- Fix the Direct filesystem method not being used for Language updates because WP_LANG_DIR doesn't exist (check it's parent for writable instead)
See #18200, #22704



git-svn-id: https://develop.svn.wordpress.org/trunk@25806 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-16 04:14:29 +00:00
Andrew Nacin 4f7112000f Avoid numerous potential PHP warnings when dealing with the pre-r25801 get_core_checksums() return value.
Warnings included current(), filestat(), and md5_file().

see #18201. see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25805 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-16 04:01:12 +00:00
Andrew Nacin 867f084ca0 Significantly simplify get_core_checksums(), as the caching and chunking was causing too much grief.
Make sure we only do our pre-flight is_writable check when the file exists.

see #18201. see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25801 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-15 23:02:28 +00:00
Andrew Nacin 14b83f44f1 Use correct variable. see #22704.
git-svn-id: https://develop.svn.wordpress.org/trunk@25800 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-15 22:06:08 +00:00
Andrew Nacin 3b724d5082 Remove accidental debug cruft in [25780]. see #22704.
git-svn-id: https://develop.svn.wordpress.org/trunk@25799 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-15 21:24:01 +00:00
Andrew Nacin 1e8729b5c1 Avoid our pre-flight writable checks if get_core_checksums() doesn't exist yet.
Thus, it will not work for 3.6 => 3.7, only 3.7+.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25798 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-15 20:34:02 +00:00
Andrew Nacin 0a284a4d5c Only add error data to the files_not_writable WP_Error if the install already has [25775] and [25796] applied.
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25797 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-15 20:00:01 +00:00
Andrew Nacin 55d176020b In show_message(), only print error data if it is a string.
see #25576, [25775].


git-svn-id: https://develop.svn.wordpress.org/trunk@25796 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-15 19:50:48 +00:00